* [2024-11-09 15:43] Ihor Radchenko:
Phil Estival <p...@7d.nz> writes:
Have you considered integrating it into ob-sql itself?
If not, what are the obstacles?
Hello Ihor,
yes I have. It grows ob-sql by approximately 300 lines.
There are rooms for improvements.
https://github.com/flintforge/ob-sql-session/blob/main/ob-sql.el
Thanks for the update!
I will be looking towards your improvements to be merged upstream.
Feel free to ask me anything if you need any help.
I will keep running ob-sql with :session in the next days.
This work configuration should help to detect if there is an anomaly.
Shall I submit a patch?
Since many lines are changed due to proper indentation, docstrings,
untabification and a few lateral improvements, I was wondering if
such a patch has to be gradual and minimize sudden changes.
Also I'm trying to run the tests with
: make BTEST_RE='ob-sql.*' test-dirty
but they get skipped due to a missing dependency,
and I don't know in which direction to look for from there.
Below is what the command returns. Any idea ?
27 files scanned, 13 files contains IDs, and 54 IDs found.
0 source block added to Library of Babel
Local variables list is not properly terminated
selected tests: ob-sql.*
Running 2 tests (2024-11-11 11:17:40+0100, selector ‘"ob-sql.*"’)
skipped 1/2 *org-missing-dependency*/test-ob-sql (0.000139 sec)
skipped 2/2 *org-missing-dependency*/test-ob-sqlite (0.000098 sec)
Ran 2 tests, 0 results as expected, 0 unexpected, 2 skipped (2024-11-11
11:17:40+0100, 0.000470 sec) ?
--
Phil Estival
