On Tue, Oct 20, 2020 at 07:44:04PM +0100, Matthew Wilcox wrote:
> On Tue, Oct 20, 2020 at 11:24:39AM -0700, Elena Afanasova wrote:
> > Reported by checkpatch.pl
>
> Checkpatch is wrong.
>
> > +++ b/drivers/staging/rtl8712/rtl871x_recv.h
> > @@ -8,7 +8,7 @@
> > #define NR_RECVFRAME 256
> >
> >
On Mon, Oct 26, 2020 at 04:16:52AM +, Matthew Wilcox wrote:
> On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote:
> > > - dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p
> > > (acd = %p)\n", cur, cur->acd);
> > > + dev_dbg(&eng->pldev->dev, "Handling com
On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote:
> > - dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p
> > (acd = %p)\n", cur, cur->acd);
> > + dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p
> > (acd = %p)\n",
> > + cur
On Sun, 25 Oct 2020, Elena Afanasova wrote:
> Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too.
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova
> ---
> Changes in v3:
> - use array_size()
> Changes in v2:
> - correct the subject line
>
In the subject line, there should not a space before the colon.
Thanks for improving the subjects and messages otherwise.
julia
On Fri, 23 Oct 2020, Elena Afanasova wrote:
> The coding style (!bar) is more common than (bar == NULL). Reported by
> checkpatch.pl.
>
> Signed-off-by: Elena Afanaso
On Fri, Oct 23, 2020 at 03:03:17AM -0700, Elena Afanasova wrote:
> - txb = kmalloc(sizeof(struct rtllib_txb) + (sizeof(u8 *) * nr_frags),
> - gfp_mask);
> + txb = kzalloc(sizeof(*txb) + (sizeof(u8 *) * nr_frags), gfp_mask);
This would be a good opportunity to use struct_s
On Fri, 23 Oct 2020, Elena Afanasova wrote:
> Correct the code style for comparison to NULL. Reported by checkpatch.pl.
I have the impression that the subject line is too detailed, and the log
message is not detailed enough. The subject line should just orient the
reader, so they can decide w
The above is not the right subject line for this file (ie the part to the
left of the colon). You should use git log --oneline on this file to see
what others have done.
julia
On Fri, 23 Oct 2020, Elena Afanasova wrote:
> kmalloc() and memset() calls can be replaced with kzalloc().
> Found with
On Fri, 23 Oct 2020, Elena Afanasova wrote:
> kmalloc() and memset() calls can be replaced with kzalloc().
It would be nice to say why the change is correct.
julia
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova
> ---
> drivers/staging/rtl8192e/rtllib_tx.c | 4 +---
> 1 file ch
On Thu, 22 Oct 2020, izabela.bakoll...@gmail.com wrote:
> From: Izabela Bakollari
>
> Fix code alignment. Issue reported by checkpatch.pl
Try to find something other than "Fix" to describe what you have done.
What kind of change have you made and why is it a good idea?
>
> Signed-off-by: Izab
On Thu, 22 Oct 2020, izabela.bakoll...@gmail.com wrote:
> From: Izabela Bakollari
>
> Rearrange comment that exceeds 100 columns length. Issue reported
> by checkpatch.pl
>
> Signed-off-by: Izabela Bakollari
> ---
> drivers/staging/wlan-ng/cfg80211.c | 3 ++-
> 1 file changed, 2 insertions(+
On Thu, Oct 22, 2020 at 07:29:31AM +0200, Greg KH wrote:
> On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> > Hello,
> > I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> > and have found that there are several gb_audio_module_*_show functions
> > that accep
On Thu, Oct 22, 2020 at 07:29:31AM +0200, Greg KH wrote:
> On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> > Hello,
> > I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> > and have found that there are several gb_audio_module_*_show functions
> > that accep
On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> Hello,
> I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> and have found that there are several gb_audio_module_*_show functions
> that accept "struct gb_audio_manager_module_attribute * " as a function
> par
On Wed, 21 Oct 2020, Deepak R Varma wrote:
> Replace bit masking by BIT macro. This resolves checkpatch issue
Replace bit masking by the BIT macro. This resolves the checkpatch issue
> "CHECK: Prefer using the BIT macro"
>
> Signed-off-by: Deepak R Varma
> ---
> drivers/staging/kpc2000/kpc2
On Wed, Oct 21, 2020 at 10:11:52AM +0530, Vaishali Thakkar wrote:
> On Wed, Oct 21, 2020 at 8:33 AM Deepak R Varma wrote:
> >
> > Multiple issues reported by checkpatch script around lines exceeding 100
> > columns, indentation of function parameters, extra blank lines. These
> > code formatting c
On Wed, Oct 21, 2020 at 8:33 AM Deepak R Varma wrote:
>
> Multiple issues reported by checkpatch script around lines exceeding 100
> columns, indentation of function parameters, extra blank lines. These
> code formatting changes improves the code readability.
Please send separate patches while fi
On Wed, Oct 21, 2020 at 12:01 AM Elena Afanasova wrote:
>
> Reported by checkpatch.pl
>
> Signed-off-by: Elena Afanasova
This patch is fixing 2 different checkpatch warnings. They
should be sent as separate patches. One for removing extra
blank lines, another one for fixing the code alignment.
On Tue, Oct 20, 2020 at 8:56 PM Elena Afanasova wrote:
>
> Reported by checkpatch.pl
Hi Elena,
Thanks for your patches. Your commit log should mention
why are you doing certain changes. Above commit log
doesn't give reviewer/maintainer an idea about what are
you fixing and why that change is nec
On Tue, Oct 20, 2020 at 11:24:39AM -0700, Elena Afanasova wrote:
> Reported by checkpatch.pl
Checkpatch is wrong.
> +++ b/drivers/staging/rtl8712/rtl871x_recv.h
> @@ -8,7 +8,7 @@
> #define NR_RECVFRAME 256
>
> #define RXFRAME_ALIGN8
> -#define RXFRAME_ALIGN_SZ (1 << RXFRAME_ALIGN)
On 19/10/2020 12:49, Deepak R Varma wrote:
On Mon, Oct 19, 2020 at 12:34:15PM +0100, Ian Abbott wrote:
On 19/10/2020 11:57, Deepak R Varma wrote:
On Mon, Oct 19, 2020 at 12:41:14PM +0200, Julia Lawall wrote:
On Mon, 19 Oct 2020, Ian Abbott wrote:
On 18/10/2020 20:49, Deepak R Varma wrote:
On Mon, Oct 19, 2020 at 12:34:15PM +0100, Ian Abbott wrote:
> On 19/10/2020 11:57, Deepak R Varma wrote:
> > On Mon, Oct 19, 2020 at 12:41:14PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Mon, 19 Oct 2020, Ian Abbott wrote:
> > >
> > > > On 18/10/2020 20:49, Deepak R Varma wrote:
> > > > > I
On 19/10/2020 11:57, Deepak R Varma wrote:
On Mon, Oct 19, 2020 at 12:41:14PM +0200, Julia Lawall wrote:
On Mon, 19 Oct 2020, Ian Abbott wrote:
On 18/10/2020 20:49, Deepak R Varma wrote:
Instructions split on multiple lines can be combined on a single line
for improved readability of the co
On Mon, Oct 19, 2020 at 12:41:14PM +0200, Julia Lawall wrote:
>
>
> On Mon, 19 Oct 2020, Ian Abbott wrote:
>
> > On 18/10/2020 20:49, Deepak R Varma wrote:
> > > Instructions split on multiple lines can be combined on a single line
> > > for improved readability of the code.
> > >
> > > Signed-o
On Mon, 19 Oct 2020, Ian Abbott wrote:
> On 18/10/2020 20:49, Deepak R Varma wrote:
> > Instructions split on multiple lines can be combined on a single line
> > for improved readability of the code.
> >
> > Signed-off-by: Deepak R Varma
> > ---
> > .../staging/comedi/drivers/tests/ni_routes
On Thu, 2020-04-02 at 18:42 -0700, John B. Wyatt IV wrote:
> DEBUG is not actually used as far as I can tell (I am still new to
> kernel debugging systems to please correct me).
DEBUG is used by the _debug and _dbg macros
(pr_debug, dev_dbg)
___
devel
On Fri, 2020-04-03 at 01:50 +0200, Stefano Brivio wrote:
> On Wed, 1 Apr 2020 19:17:06 -0700
> "John B. Wyatt IV" wrote:
>
> > Remove unused code surrounded by an #if 0 block.
> >
> > Code has not been altered since 2014 as reported by git blame.
> >
> > Reported by checkpatch.
> >
> > Signed
On Wed, 1 Apr 2020 19:17:06 -0700
"John B. Wyatt IV" wrote:
> Remove unused code surrounded by an #if 0 block.
>
> Code has not been altered since 2014 as reported by git blame.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 6 -
On Wed, 1 Apr 2020, John B. Wyatt IV wrote:
> Fix 2 parenthesis alignment issues.
Please try to find a way to describe what you have done that doesn't
involve the word "Fix". What have you done and why?
julia
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
> ---
> drivers
On Wed, 1 Apr 2020 18:25:15 -0700
"John B. Wyatt IV" wrote:
> Fix 2 parenthesis alignment issues.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
Reviewed-by: Stefano Brivio
--
Stefano
___
devel mailing list
de...@linuxdriverpro
On Mon, 30 Mar 2020 15:03:55 -0700
"John B. Wyatt IV" wrote:
> On Mon, 2020-03-30 at 19:40 +0200, Stefano Brivio wrote:
> > On Sun, 29 Mar 2020 12:37:18 +0200 (CEST)
> > Julia Lawall wrote:
> >
> > > On Sun, 29 Mar 2020, Soumyajit Deb wrote:
> > >
> > > > I had the same doubt the other day
On Mon, 2020-03-30 at 19:40 +0200, Stefano Brivio wrote:
> On Sun, 29 Mar 2020 12:37:18 +0200 (CEST)
> Julia Lawall wrote:
>
> > On Sun, 29 Mar 2020, Soumyajit Deb wrote:
> >
> > > I had the same doubt the other day about the replacement of
> > > udelay() with
> > > usleep_range(). The correspon
On Mon, 2020-03-30 at 23:06 +0200, Stefano Brivio wrote:
> On Mon, 30 Mar 2020 11:45:17 -0700
> "John B. Wyatt IV" wrote:
>
> > Add error code handling to unused 'ret' variable that was never
> > used.
> > Return an error code from functions called within
> > vnt_radio_power_on.
> >
> > Issue re
On Mon, 30 Mar 2020 11:45:17 -0700
"John B. Wyatt IV" wrote:
> Add error code handling to unused 'ret' variable that was never used.
> Return an error code from functions called within vnt_radio_power_on.
>
> Issue reported by coccinelle (coccicheck).
>
> Suggested-by: Quentin Deslandes
> Sugg
On 30/03/2020 18:14, Stefano Brivio wrote:
On Mon, 30 Mar 2020 09:45:30 -0700
"John B. Wyatt IV" wrote:
Add error code handling to unused 'ret' variable that was never used.
Return an error code from functions called within vnt_radio_power_on.
Issue reported by coccinelle (coccicheck).
Sugge
On Sun, 29 Mar 2020 12:37:18 +0200 (CEST)
Julia Lawall wrote:
> On Sun, 29 Mar 2020, Soumyajit Deb wrote:
>
> > I had the same doubt the other day about the replacement of udelay() with
> > usleep_range(). The corresponding range for the single argument value of
> > udelay() is quite confusing a
On Mon, 30 Mar 2020 09:45:30 -0700
"John B. Wyatt IV" wrote:
> Add error code handling to unused 'ret' variable that was never used.
> Return an error code from functions called within vnt_radio_power_on.
>
> Issue reported by coccinelle (coccicheck).
>
> Suggested-by: Quentin Deslandes
> Sugg
On Thu, 26 Mar 2020 02:52:53 +0530
Simran Singhal wrote:
> Compress two lines into a single line if immediate return statement is found.
> It also removes variable cmd_obj as it is no longer needed.
>
> It is done using script Coccinelle.
This should be consistent. What does "it" refer to, now?
On Thu, 26 Mar 2020 02:24:18 +0530
Simran Singhal wrote:
> Compress two lines into a single line if immediate return statement is found.
Same as your patches for issues reported by checkpatch, I think you
should post these ones as a patchset.
--
Stefano
___
On Wed, 25 Mar 2020 21:31:42 +0530
Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
> Reported by checkpatch.pl
>
> git diff -w shows no difference.
> diff of the .o files before and after the changes shows no difference.
>
> Signed-off-by: Shreeya Patel
Hi Simran,
On Wed, 25 Mar 2020 22:14:52 +0530
Simran Singhal wrote:
> Add whiteline after variable declarations to remove the checkpatch.pl
> warning:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Simran Singhal
Sorry for the late review. This patch introduces similar
On Wed, 25 Mar 2020 19:32:45 +0530
Simran Singhal wrote:
> Clean up unnecessary braces around single statement blocks.
> Issues reported by checkpatch.pl as:
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Simran Singhal
> ---
> drivers/staging/rtl8723bs/c
On Wed, 25 Mar 2020 19:52:26 +0530
Simran Singhal wrote:
> Remove multiple assignments by factorizing them.
> Problem found using checkpatch.pl:-
> CHECK: multiple assignments should be avoided
>
> Signed-off-by: Simran Singhal
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 7 +--
> 1
On Sun, Mar 29, 2020 at 2:23 PM Sam Muhammed wrote:
> On Sun, 2020-03-29 at 12:37 +0200, Julia Lawall wrote:
> > On Sun, 29 Mar 2020, Soumyajit Deb wrote:
> >
First of all, let's stop topposting.
> > > I had the same doubt the other day about the replacement of udelay() with
> > > usleep_range()
On Sun, 2020-03-29 at 12:37 +0200, Julia Lawall wrote:
>
> On Sun, 29 Mar 2020, Soumyajit Deb wrote:
>
> > I had the same doubt the other day about the replacement of udelay() with
> > usleep_range(). The corresponding range for the single argument value of
> > udelay() is quite confusing as I co
On Sun, 29 Mar 2020, Soumyajit Deb wrote:
> I had the same doubt the other day about the replacement of udelay() with
> usleep_range(). The corresponding range for the single argument value of
> udelay() is quite confusing as I couldn't decide the range. But as much as I
> noticed checkpatch.pl
On Sun, 29 Mar 2020, John Wyatt wrote:
> On Sun, 2020-03-29 at 11:28 +0200, Julia Lawall wrote:
> >
> > On Sun, 29 Mar 2020, John B. Wyatt IV wrote:
> >
> > > Fix style issue with usleep_range being reported as preferred over
> > > udelay.
> > >
> > > Issue reported by checkpatch.
> > >
> > > P
On Sun, 2020-03-29 at 11:28 +0200, Julia Lawall wrote:
>
> On Sun, 29 Mar 2020, John B. Wyatt IV wrote:
>
> > Fix style issue with usleep_range being reported as preferred over
> > udelay.
> >
> > Issue reported by checkpatch.
> >
> > Please review.
> >
> > As written in Documentation/timers/t
On Sun, 29 Mar 2020, John B. Wyatt IV wrote:
> Fix style issue with usleep_range being reported as preferred over
> udelay.
>
> Issue reported by checkpatch.
>
> Please review.
>
> As written in Documentation/timers/timers-howto.rst udelay is the
> generally preferred API. hrtimers, as noted in
On 3/25/20 2:43 PM, Simran Singhal wrote:
Simplify function returns by merging assignment and return into
one command line.
"Simplify function returns by merging assignment and return into one line".
You could change the subject also to "Simplify function return logic".
thanks,
-lakshmi
___
On Thu, 26 Mar 2020, Simran Singhal wrote:
> Some functions like kmalloc/kzalloc return NULL on failure.
> When NULL represents failure, !x is commonly used.
Try for a shorter subject line. "Simplify NULL tests" would do. Then the
log message should be in the imperative.
julia
>
> This wa
On Wed, 25 Mar 2020, Simran Singhal wrote:
> This patch fixes the checkpatch warning by removing a blank
> line.
> CHECK: Please don't use multiple blank lines
The subject line and the log message should be written in the imperative.
So that would be Remove, rather than Removing for the subject l
On Mon, 2020-03-23 at 02:04 +0100, Stefano Brivio wrote:
> Hi Shreeya,
>
> On Mon, 23 Mar 2020 04:48:08 +0530
> Shreeya Patel wrote:
>
> > On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote:
> > > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
> >
> > Hi Greg and Joe,
> >
> > > > On Sun
Hi Shreeya,
On Mon, 23 Mar 2020 04:48:08 +0530
Shreeya Patel wrote:
> On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote:
> > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
>
> Hi Greg and Joe,
>
> > > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:
> > > > Add space ar
On Sat, 21 Mar 2020 19:34:31 +0530
Simran Singhal wrote:
> This patch fixes the checkpatch warning by removing multiple blank
> lines.
Actually, you're removing just one. Can you please re-post fixing the
description? Mind that it's going to be a "v2", that is, the second
version of this patch.
On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote:
> On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
Hi Greg and Joe,
> > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:
> > > Add space around operators for improving the code
> > > readability.
> > > Reported by checkpatch.pl
On Mon, 23 Mar 2020, Simran Singhal wrote:
> Remove comparisons to NULL in conditionals in
> drivers/staging/rtl8723bs/core/rtw_ap.c
> Issues reported by checkpatch.pl as:
> CHECK: Comparison to NULL could be written
The patch also drops some parentheses that are completely unrelated to the
ch
On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
> On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:
> > Add space around operators for improving the code
> > readability.
> > Reported by checkpatch.pl
> >
> > git diff -w shows no difference.
> > diff of the .o files before and after
On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
> Reported by checkpatch.pl
>
> git diff -w shows no difference.
> diff of the .o files before and after the changes shows no difference.
There is no need to have thes
On Fri, 13 Mar 2020 16:54:51 +0530
Shreeya Patel wrote:
> Replace calls to kmalloc followed by a memcpy with a direct call to
> kmemdup.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression from,to,size,flag;
> statement S;
> @@
>
> - to = \(kmalloc\|kzal
On Fri, 13 Mar 2020 15:59:12 +0530
Shreeya Patel wrote:
> Remove unnecessary if and else conditions since both are leading to the
> initialization of "phtpriv->ampdu_enable" with the same value.
> Also, remove the unnecessary else-if condition since it does nothing.
>
> Signed-off-by: Shreeya Pa
On Sat, 2020-03-14 at 16:58 +0530, Shreeya Patel wrote:
> This could be:
> > if ((!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable ==
> > 1)) ||
> > pregistrypriv->ampdu_enable == 2)
> > phtpriv->ampdu_enable = true;
> >
> > Though it is probably more sensible to jus
On Fri, 2020-03-13 at 14:21 -0700, Joe Perches wrote:
Hi Joe,
> On Fri, 2020-03-13 at 15:59 +0530, Shreeya Patel wrote:
> > Remove unnecessary if and else conditions since both are leading to
> > the
> > initialization of "phtpriv->ampdu_enable" with the same value.
> > Also, remove the unnecessa
On Fri, 2020-03-13 at 15:59 +0530, Shreeya Patel wrote:
> Remove unnecessary if and else conditions since both are leading to the
> initialization of "phtpriv->ampdu_enable" with the same value.
> Also, remove the unnecessary else-if condition since it does nothing.
[]
> diff --git a/drivers/stagin
Ignore this one. There was a typo in Greg's email address.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Thanks!
You sent the same patch twice. Next time put a note under the ---
"Resending because I had a typo in Greg's email address".
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverde
The original patch description was basically fine. Outreachy reviews
tend to be more pedantic about this sort of stuff than most maintainers.
There are a couple who have very strict rules, but try to avoid those
maintainers and your life will be happier.
regards,
dan carpenter
__
On Wed, Mar 11, 2020 at 07:28:59PM +0530, Shreeya Patel wrote:
> Remove unnecessary if and else conditions since both are leading to the
> initialization of "phtpriv->ampdu_enable" with the same value.
>
> Signed-off-by: Shreeya Patel
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 +++---
On Fri, 2020-03-13 at 10:20 +0300, Dan Carpenter wrote:
> On Wed, Mar 11, 2020 at 07:08:11PM +0530, Shreeya Patel wrote:
> > diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > index e813382e78a6..643592b0bd38 100644
> > --- a/drivers/sta
On Wed, Mar 11, 2020 at 07:08:11PM +0530, Shreeya Patel wrote:
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index e813382e78a6..643592b0bd38 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723
On Thu, 2020-03-12 at 03:58 +0530, Shreeya Patel wrote:
> Hey Joe,
>
> On March 11, 2020 10:56:29 PM GMT+05:30, Joe Perches wrote:
> > On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
> > > Remove if and else conditions since both are leading to the
> > > initialization of "valueDMATimeout
On 3/12/2020 3:49 AM, Julia Lawall wrote:
Thanks for your input Julia and Stefano.
That's my general preference as well, but I can't find any point in the
"Describe your changes" section of submitting-patches.rst actually
defining the order. I wouldn't imply that from the sequence the steps
are
On Thu, 12 Mar 2020, Stefano Brivio wrote:
> Hi Lakshmi,
>
> On Wed, 11 Mar 2020 19:42:06 -0700
> Lakshmi Ramasubramanian wrote:
>
> > On 3/11/2020 6:58 AM, Shreeya Patel wrote:
> >
> > > Remove unnecessary if and else conditions since both are leading to the
> > > initialization of "phtpriv->
Hi Lakshmi,
On Wed, 11 Mar 2020 19:42:06 -0700
Lakshmi Ramasubramanian wrote:
> On 3/11/2020 6:58 AM, Shreeya Patel wrote:
>
> > Remove unnecessary if and else conditions since both are leading to the
> > initialization of "phtpriv->ampdu_enable" with the same value.
> >
> > Signed-off-by: Shr
On 3/11/2020 6:58 AM, Shreeya Patel wrote:
Remove unnecessary if and else conditions since both are leading to the
initialization of "phtpriv->ampdu_enable" with the same value.
Signed-off-by: Shreeya Patel
Stating this based on the patch descriptions I have seen.
Others, please advise\corre
On March 11, 2020 10:34:28 PM GMT+05:30, Stefano Brivio
wrote:
Hey Stefano,
>On Wed, 11 Mar 2020 18:47:42 +0530
>Shreeya Patel wrote:
>
>> Add space around operators for improving the code
>> readability.
>> Reported by checkpatch.pl
>>
>> git diff -w shows no difference.
>> diff of the .o
Hey Joe,
On March 11, 2020 10:56:29 PM GMT+05:30, Joe Perches wrote:
>On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
>> Remove if and else conditions since both are leading to the
>> initialization of "valueDMATimeout" and "valueDMAPageCount" with
>> the same value.
>
>You might consider
On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
> Remove if and else conditions since both are leading to the
> initialization of "valueDMATimeout" and "valueDMAPageCount" with
> the same value.
You might consider removing the
/* Timeout value is calculated by 34 / (2^n) */
comment
On Wed, 11 Mar 2020 19:08:11 +0530
Shreeya Patel wrote:
> Remove if and else conditions since both are leading to the
> initialization of "valueDMATimeout" and "valueDMAPageCount" with
> the same value.
>
> Found using coccinelle script.
>
> Signed-off-by: Shreeya Patel
Reviewed-by: Stefano B
On Wed, 11 Mar 2020 18:47:42 +0530
Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
> Reported by checkpatch.pl
>
> git diff -w shows no difference.
> diff of the .o files before and after the changes shows no difference.
>
> Signed-off-by: Shreeya Patel
On Wed, 11 Mar 2020, Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
>
> Reported by checkpatch.pl
>
> Signed-off-by: Shreeya Patel
> ---
>
> shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
> drivers/staging/rtl8188eu/core/
> shreeya@Shreeya-Pat
On Tue, 2020-03-10 at 15:57 +0100, Julia Lawall wrote:
> On Tue, 10 Mar 2020, Shreeya Patel wrote:
>
> > Add space around operators for improving the code
> > readability.
> >
> > Reported by checkpatch.pl
> >
> > Signed-off-by: Shreeya Patel
> > ---
> >
> > rtw_mlme_old.o - Previously produce
On Tue, 10 Mar 2020, Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
>
> Reported by checkpatch.pl
>
> Signed-off-by: Shreeya Patel
> ---
>
> rtw_mlme_old.o - Previously produced object file before making any
> changes to the source code.
> rtw_mlme.o -
On Mon, 2020-03-09 at 08:35 +0100, Julia Lawall wrote:
> On Mon, 9 Mar 2020, Shreeya Patel wrote:
>
> > On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote:
> > > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> > > > Add space around operators for improving the code
> > > > readability.
On Mon, 9 Mar 2020, Shreeya Patel wrote:
> On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote:
> > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> > > Add space around operators for improving the code
> > > readability.
> >
> > Hello again Shreeya.
> >
> I have some questions here...
>
On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote:
> On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> > Add space around operators for improving the code
> > readability.
>
> Hello again Shreeya.
>
I have some questions here...
> The subject isn't really quite appropriate as you
> ar
On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote:
> On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> > Add space around operators for improving the code
> > readability.
>
> Hello again Shreeya.
>
> The subject isn't really quite appropriate as you
> are not doing this space around o
On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote:
> On Mon, 9 Mar 2020, Shreeya Patel wrote:
>
> > Add space around & operator for improving the code
> > readability.
> I guess you found this with checkpatch. If so, it could be nice to add
> "Reported by checkpatch." to the log message. OK
On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
Hello again Shreeya.
The subject isn't really quite appropriate as you
are not doing this space around operator addition
for the entire subsystem.
IMO, the subject should be
On Sun, 2020-03-08 at 21:17 +0100, Julia Lawall wrote:
>
> On Mon, 9 Mar 2020, Shreeya Patel wrote:
>
> > On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
> >
> > Hi Joe,
> >
> > > On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote:
> > > > On Mon, 9 Mar 2020, Shreeya Patel wrote:
> > >
On Sun, 2020-03-08 at 13:19 -0700, Joe Perches wrote:
> On Mon, 2020-03-09 at 01:40 +0530, Shreeya Patel wrote:
> > On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
> > Hi Joe,
>
> Hello.
> []
> > > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > > > > b/drivers/staging/rtl8188
On Mon, 2020-03-09 at 01:40 +0530, Shreeya Patel wrote:
> On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
> Hi Joe,
Hello.
[]
> > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > > > b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > []
> > > > @@ -924,7 +924,7 @@ static void rtw_
On Mon, 9 Mar 2020, Shreeya Patel wrote:
> On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
>
> Hi Joe,
>
> > On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote:
> > > On Mon, 9 Mar 2020, Shreeya Patel wrote:
> > >
> > > > Add space around & operator for improving the code
> > > > reada
On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
Hi Joe,
> On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote:
> > On Mon, 9 Mar 2020, Shreeya Patel wrote:
> >
> > > Add space around & operator for improving the code
> > > readability.
> > I guess you found this with checkpatch. If so,
On Mon, 9 Mar 2020, Shreeya Patel wrote:
> Add space around & operator for improving the code
> readability.
I guess you found this with checkpatch. If so, it could be nice to add
"Reported by checkpatch." to the log message. OK otherwise.
Acked-by: Julia Lawall
>
> Signed-off-by: Shreeya Pa
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in files ms.{h,c}
I think that these should be converted to all upper case rather than all
lower case.
julia
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rts5208/ms.c | 86 ++
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in files xd.{h,c}
>
> Signed-off-by: Gabriela Bittencourt
Acked-by: Julia Lawall
> ---
> drivers/staging/rts5208/xd.c | 8
> drivers/staging/rts5208/xd.h | 6 +++---
> 2 files changed, 7 inse
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in file sd.h
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rts5208/sd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/sd.h b/drivers/st
On Tue, 29 Oct 2019, Gabriela Bittencourt wrote:
> Fixing typo in word 'and'.
>
> Signed-off-by: Gabriela Bittencourt
Acked-by: Julia Lawall
> ---
> drivers/staging/sm750fb/sm750_accel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750
On Mon, 28 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in file xd.c
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rts5208/xd.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rts5208/xd.c b/dr
1 - 100 of 588 matches
Mail list logo
