On Fri, 23 Oct 2020, Elena Afanasova wrote:
> kmalloc() and memset() calls can be replaced with kzalloc().
It would be nice to say why the change is correct.
julia
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova <eafanas...@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_tx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
> b/drivers/staging/rtl8192e/rtllib_tx.c
> index e0d79daca24a..c9959bb4ab63 100644
> --- a/drivers/staging/rtl8192e/rtllib_tx.c
> +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> @@ -205,12 +205,10 @@ static struct rtllib_txb *rtllib_alloc_txb(int
> nr_frags, int txb_size,
> struct rtllib_txb *txb;
> int i;
>
> - txb = kmalloc(sizeof(struct rtllib_txb) + (sizeof(u8 *) * nr_frags),
> - gfp_mask);
> + txb = kzalloc(sizeof(*txb) + (sizeof(u8 *) * nr_frags), gfp_mask);
> if (!txb)
> return NULL;
>
> - memset(txb, 0, sizeof(struct rtllib_txb));
> txb->nr_frags = nr_frags;
> txb->frag_size = cpu_to_le16(txb_size);
>
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20201023100317.4473-1-eafanasova%40gmail.com.
>
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
