On Fri, 2020-03-13 at 15:59 +0530, Shreeya Patel wrote:
> Remove unnecessary if and else conditions since both are leading to the
> initialization of "phtpriv->ampdu_enable" with the same value.
> Also, remove the unnecessary else-if condition since it does nothing.
[]
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c 
> b/drivers/staging/rtl8723bs/core/rtw_mlme.c
[]
> @@ -2772,16 +2772,7 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 
> *pie, uint ie_len, u8 channe
>  
>       /* maybe needs check if ap supports rx ampdu. */
>       if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1) {
> -             if (pregistrypriv->wifi_spec == 1) {
> -                     /* remove this part because testbed AP should disable 
> RX AMPDU */
> -                     /* phtpriv->ampdu_enable = false; */
> -                     phtpriv->ampdu_enable = true;
> -             } else {
> -                     phtpriv->ampdu_enable = true;
> -             }
> -     } else if (pregistrypriv->ampdu_enable == 2) {
> -             /* remove this part because testbed AP should disable RX AMPDU 
> */
> -             /* phtpriv->ampdu_enable = true; */
> +             phtpriv->ampdu_enable = true;

This isn't the same test.

This could be:
        if ((!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1)) ||
            pregistrypriv->ampdu_enable == 2)
                phtpriv->ampdu_enable = true;

Though it is probably more sensible to just set
phtpriv->ampdu_enable without testing whether or
not it's already set:

        if (pregistrypriv->ampdu_enable == 1 ||
            pregistrypriv->ampdu_enable == 2)
                phtpriv->ampdu_enable = true;


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to