On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
> Remove if and else conditions since both are leading to the
> initialization of "valueDMATimeout" and "valueDMAPageCount" with
> the same value.
You might consider removing the
/* Timeout value is calculated by 34 / (2^n) */
comment entirely as it doesn't make much sense.
For what N is "(34 / (2 ^ N))" = 6 ?
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
[]
> @@ -551,18 +551,11 @@ static void HalRxAggr8723BSdio(struct adapter *padapter)
>
> pregistrypriv = &padapter->registrypriv;
>
> - if (pregistrypriv->wifi_spec) {
> - /* 2010.04.27 hpfan */
> - /* Adjust RxAggrTimeout to close to zero disable RxAggr,
> suggested by designer */
> - /* Timeout value is calculated by 34 / (2^n) */
> - valueDMATimeout = 0x06;
> - valueDMAPageCount = 0x06;
> - } else {
> - /* 20130530, Isaac@SD1 suggest 3 kinds of parameter */
> - /* TX/RX Balance */
> - valueDMATimeout = 0x06;
> - valueDMAPageCount = 0x06;
> - }
> + /* 2010.04.27 hpfan */
> + /* Adjust RxAggrTimeout to close to zero disable RxAggr, suggested by
> designer */
> + /* Timeout value is calculated by 34 / (2^n) */
> + valueDMATimeout = 0x06;
> + valueDMAPageCount = 0x06;
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
