On Tue, Oct 20, 2020 at 07:44:04PM +0100, Matthew Wilcox wrote:
> On Tue, Oct 20, 2020 at 11:24:39AM -0700, Elena Afanasova wrote:
> > Reported by checkpatch.pl
>
> Checkpatch is wrong.
>
> > +++ b/drivers/staging/rtl8712/rtl871x_recv.h
> > @@ -8,7 +8,7 @@
> > #define NR_RECVFRAME 256
> >
> >
On Mon, Oct 26, 2020 at 04:16:52AM +, Matthew Wilcox wrote:
> On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote:
> > > - dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p
> > > (acd = %p)\n", cur, cur->acd);
> > > + dev_dbg(&eng->pldev->dev, "Handling com
On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote:
> > - dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p
> > (acd = %p)\n", cur, cur->acd);
> > + dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p
> > (acd = %p)\n",
> > + cur
eed to exceed 80 characters here.
julia
> if (!txb)
> return NULL;
>
> - memset(txb, 0, sizeof(struct ieee80211_txb));
> txb->nr_frags = nr_frags;
> txb->frag_size = __cpu_to_le16(txb_size);
>
> --
> 2.25.1
>
>
> --
&g
NULL)
> + if (!precvframe)
> return NULL;
> precvframe->u.hdr.rx_tail -= sz;
> if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) {
> --
> 2.25.1
>
>
> --
> You received this message because you are subscribed to the Go
On Fri, Oct 23, 2020 at 03:03:17AM -0700, Elena Afanasova wrote:
> - txb = kmalloc(sizeof(struct rtllib_txb) + (sizeof(u8 *) * nr_frags),
> - gfp_mask);
> + txb = kzalloc(sizeof(*txb) + (sizeof(u8 *) * nr_frags), gfp_mask);
This would be a good opportunity to use struct_s
e)
> return NULL;
> precvframe->u.hdr.rx_tail -= sz;
> if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) {
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outrea
)
> return NULL;
>
> - memset(txb, 0, sizeof(struct ieee80211_txb));
> txb->nr_frags = nr_frags;
> txb->frag_size = __cpu_to_le16(txb_size);
>
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Gro
xb = kzalloc(sizeof(*txb) + (sizeof(u8 *) * nr_frags), gfp_mask);
> if (!txb)
> return NULL;
>
> - memset(txb, 0, sizeof(struct rtllib_txb));
> txb->nr_frags = nr_frags;
> txb->frag_size = cpu_to_le16(txb_size);
>
> --
> 2.25.1
>
&g
netdev_dbg
> (wlandev->netdev,
> --
> 2.18.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails
4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To
On Thu, Oct 22, 2020 at 07:29:31AM +0200, Greg KH wrote:
> On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> > Hello,
> > I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> > and have found that there are several gb_audio_module_*_show functions
> > that accep
On Thu, Oct 22, 2020 at 07:29:31AM +0200, Greg KH wrote:
> On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> > Hello,
> > I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> > and have found that there are several gb_audio_module_*_show functions
> > that accep
On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> Hello,
> I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> and have found that there are several gb_audio_module_*_show functions
> that accept "struct gb_audio_manager_module_attribute * " as a function
> par
AYLOAD_SIZE_MASK 0x0700
> #define KPC_DMA_CARD_MAX_READ_REQUEST_SIZE_MASK 0x7000
> #define KPC_DMA_CARD_S2C_INTERRUPT_STATUS_MASK 0x00FF
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" gr
ng/kpc2000/kpc2000/core.c
> > @@ -124,6 +124,7 @@ static ssize_t cpld_reconfigure(struct device *dev,
> > writeq(wr_val, pcard->sysinfo_regs_base + REG_CPLD_CONFIG);
> > return count;
> > }
> > +
> > static DEVICE_ATTR(cpld_reconfigure, 0220, NUL
ask_reg_show(struct device *dev,
> @@ -367,7 +368,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev,
> dma_bar_phys_len = pci_resource_len(pcard->pdev, DMA_BAR);
>
> pcard->dma_bar_base = ioremap(dma_bar_phys_addr,
> - dma_
r *padapter, void *pcontext);
>
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kerne
/
> + /* Remove sta node when there are no pending
> packets.
> +* must be done after get_next and before
> break
> +*/
> + if (list_empty(&pframe_queue->queue))
>
(1 << RXFRAME_ALIGN)
> +#define RXFRAME_ALIGN_SZ BIT(RXFRAME_ALIGN)
>
> #define MAX_SUBFRAME_COUNT 64
>
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To
On 19/10/2020 12:49, Deepak R Varma wrote:
On Mon, Oct 19, 2020 at 12:34:15PM +0100, Ian Abbott wrote:
On 19/10/2020 11:57, Deepak R Varma wrote:
On Mon, Oct 19, 2020 at 12:41:14PM +0200, Julia Lawall wrote:
On Mon, 19 Oct 2020, Ian Abbott wrote:
On 18/10/2020 20:49, Deepak R Varma wrote:
On Mon, Oct 19, 2020 at 12:34:15PM +0100, Ian Abbott wrote:
> On 19/10/2020 11:57, Deepak R Varma wrote:
> > On Mon, Oct 19, 2020 at 12:41:14PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Mon, 19 Oct 2020, Ian Abbott wrote:
> > >
> > > > On 18/10/2020 20:49, Deepak R Varma wrote:
> > > > > I
On 19/10/2020 11:57, Deepak R Varma wrote:
On Mon, Oct 19, 2020 at 12:41:14PM +0200, Julia Lawall wrote:
On Mon, 19 Oct 2020, Ian Abbott wrote:
On 18/10/2020 20:49, Deepak R Varma wrote:
Instructions split on multiple lines can be combined on a single line
for improved readability of the co
and by themselves.
>
> julia
>
Hi Julia and Ian,
I wanted to take advantage of the relaxation of 80 column limit to 100
columns and hence proposed combining the lines. Are you saying this is
allowed only in certain cases?
Please confirm and I will handle it accordingly.
Thank you,
De
acter limit.
But function argument stand by themselves.
julia
>
> --
> -=( Ian Abbott || MEV Ltd. is a company )=-
> -=( registered in England & Wales. Regd. number: 02862268. )=-
> -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
> -=( Bird Hall Lane, STOCKPORT
On Thu, 2020-04-02 at 18:42 -0700, John B. Wyatt IV wrote:
> DEBUG is not actually used as far as I can tell (I am still new to
> kernel debugging systems to please correct me).
DEBUG is used by the _debug and _dbg macros
(pr_debug, dev_dbg)
___
devel
On Fri, 2020-04-03 at 01:50 +0200, Stefano Brivio wrote:
> On Wed, 1 Apr 2020 19:17:06 -0700
> "John B. Wyatt IV" wrote:
>
> > Remove unused code surrounded by an #if 0 block.
> >
> > Code has not been altered since 2014 as reported by git blame.
> >
> > Reported by checkpatch.
> >
> > Signed
On Wed, 1 Apr 2020 19:17:06 -0700
"John B. Wyatt IV" wrote:
> Remove unused code surrounded by an #if 0 block.
>
> Code has not been altered since 2014 as reported by git blame.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 6 -
ruct
> ion_page_pool *pool, bool high)
>
> list_del(&page->lru);
> mod_node_page_state(page_pgdat(page), NR_KERNEL_MISC_RECLAIMABLE,
> - -(1 << pool->order));
> + -(1 << pool->order));
On Wed, 1 Apr 2020 18:25:15 -0700
"John B. Wyatt IV" wrote:
> Fix 2 parenthesis alignment issues.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
Reviewed-by: Stefano Brivio
--
Stefano
___
devel mailing list
de...@linuxdriverpro
On Mon, 30 Mar 2020 15:03:55 -0700
"John B. Wyatt IV" wrote:
> On Mon, 2020-03-30 at 19:40 +0200, Stefano Brivio wrote:
> > On Sun, 29 Mar 2020 12:37:18 +0200 (CEST)
> > Julia Lawall wrote:
> >
> > > On Sun, 29 Mar 2020, Soumyajit Deb wrote:
> > >
> > > > I had the same doubt the other day
On Mon, 2020-03-30 at 19:40 +0200, Stefano Brivio wrote:
> On Sun, 29 Mar 2020 12:37:18 +0200 (CEST)
> Julia Lawall wrote:
>
> > On Sun, 29 Mar 2020, Soumyajit Deb wrote:
> >
> > > I had the same doubt the other day about the replacement of
> > > udelay() with
> > > usleep_range(). The correspon
On Mon, 2020-03-30 at 23:06 +0200, Stefano Brivio wrote:
> On Mon, 30 Mar 2020 11:45:17 -0700
> "John B. Wyatt IV" wrote:
>
> > Add error code handling to unused 'ret' variable that was never
> > used.
> > Return an error code from functions called within
> > vnt_radio_power_on.
> >
> > Issue re
On Mon, 30 Mar 2020 11:45:17 -0700
"John B. Wyatt IV" wrote:
> Add error code handling to unused 'ret' variable that was never used.
> Return an error code from functions called within vnt_radio_power_on.
>
> Issue reported by coccinelle (coccicheck).
>
> Suggested-by: Quentin Deslandes
> Sugg
On 30/03/2020 18:14, Stefano Brivio wrote:
On Mon, 30 Mar 2020 09:45:30 -0700
"John B. Wyatt IV" wrote:
Add error code handling to unused 'ret' variable that was never used.
Return an error code from functions called within vnt_radio_power_on.
Issue reported by coccinelle (coccicheck).
Sugge
On Sun, 29 Mar 2020 12:37:18 +0200 (CEST)
Julia Lawall wrote:
> On Sun, 29 Mar 2020, Soumyajit Deb wrote:
>
> > I had the same doubt the other day about the replacement of udelay() with
> > usleep_range(). The corresponding range for the single argument value of
> > udelay() is quite confusing a
On Mon, 30 Mar 2020 09:45:30 -0700
"John B. Wyatt IV" wrote:
> Add error code handling to unused 'ret' variable that was never used.
> Return an error code from functions called within vnt_radio_power_on.
>
> Issue reported by coccinelle (coccicheck).
>
> Suggested-by: Quentin Deslandes
> Sugg
On Thu, 26 Mar 2020 02:52:53 +0530
Simran Singhal wrote:
> Compress two lines into a single line if immediate return statement is found.
> It also removes variable cmd_obj as it is no longer needed.
>
> It is done using script Coccinelle.
This should be consistent. What does "it" refer to, now?
On Thu, 26 Mar 2020 02:24:18 +0530
Simran Singhal wrote:
> Compress two lines into a single line if immediate return statement is found.
Same as your patches for issues reported by checkpatch, I think you
should post these ones as a patchset.
--
Stefano
___
On Wed, 25 Mar 2020 21:31:42 +0530
Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
> Reported by checkpatch.pl
>
> git diff -w shows no difference.
> diff of the .o files before and after the changes shows no difference.
>
> Signed-off-by: Shreeya Patel
Hi Simran,
On Wed, 25 Mar 2020 22:14:52 +0530
Simran Singhal wrote:
> Add whiteline after variable declarations to remove the checkpatch.pl
> warning:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Simran Singhal
Sorry for the late review. This patch introduces similar
On Wed, 25 Mar 2020 19:32:45 +0530
Simran Singhal wrote:
> Clean up unnecessary braces around single statement blocks.
> Issues reported by checkpatch.pl as:
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Simran Singhal
> ---
> drivers/staging/rtl8723bs/c
On Wed, 25 Mar 2020 19:52:26 +0530
Simran Singhal wrote:
> Remove multiple assignments by factorizing them.
> Problem found using checkpatch.pl:-
> CHECK: multiple assignments should be avoided
>
> Signed-off-by: Simran Singhal
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 7 +--
> 1
On Sun, Mar 29, 2020 at 2:23 PM Sam Muhammed wrote:
> On Sun, 2020-03-29 at 12:37 +0200, Julia Lawall wrote:
> > On Sun, 29 Mar 2020, Soumyajit Deb wrote:
> >
First of all, let's stop topposting.
> > > I had the same doubt the other day about the replacement of udelay() with
> > > usleep_range()
this operation?
> > >
> > > Why does checkpatch favor usleep_range while the docs favor
> > udelay?
> >
> > I don't know the answer in detail, but it is quite possible that
> > checkpatch doesn't pay any attention to the delay argument.
&
script that highlights things that may be of concern. It
> is not a
> precise static analsis tool.
>
> As a matter of form, all of your Please review comments should
> have been
> put below the ---. Currently, if someone had wanted to apply
>
rl script that highlights things that may be of concern. It is not a
precise static analsis tool.
As a matter of form, all of your Please review comments should have been
put below the ---. Currently, if someone had wanted to apply the patch,
you would make them do extra work to remove this information.
ju
this a checkpatch issue?"
Is usleep_range too expensive for this operation?
Why does checkpatch favor usleep_range while the docs favor udelay?
>
> julia
>
> > gpiod_set_value(par->gpio.reset, 1);
> > mdelay(120);
> > }
> > --
> > 2.25.1
&g
hard to know a priori what the range should be. So it is probably better
to leave the code alone.
julia
> gpiod_set_value(par->gpio.reset, 1);
> mdelay(120);
> }
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups
> &qu
On 3/25/20 2:43 PM, Simran Singhal wrote:
Simplify function returns by merging assignment and return into
one command line.
"Simplify function returns by merging assignment and return into one line".
You could change the subject also to "Simplify function return logic".
thanks,
-lakshmi
___
ep == NULL) {
> + if (!pwep) {
> DBG_871X(" r871x_set_encryption: pwep allocate
> fail !!!\n");
> goto exit;
> }
> --
> 2.17.1
>
> --
> You received this message because y
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~staging$ git diff -w drivers/staging/rtl8188eu
ter Map (BAR 1, Start Addr 0)
> *
> * BAR Size:
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> e
On Mon, 2020-03-23 at 02:04 +0100, Stefano Brivio wrote:
> Hi Shreeya,
>
> On Mon, 23 Mar 2020 04:48:08 +0530
> Shreeya Patel wrote:
>
> > On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote:
> > > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
> >
> > Hi Greg and Joe,
> >
> > > > On Sun
Hi Shreeya,
On Mon, 23 Mar 2020 04:48:08 +0530
Shreeya Patel wrote:
> On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote:
> > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
>
> Hi Greg and Joe,
>
> > > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:
> > > > Add space ar
On Sat, 21 Mar 2020 19:34:31 +0530
Simran Singhal wrote:
> This patch fixes the checkpatch warning by removing multiple blank
> lines.
Actually, you're removing just one. Can you please re-post fixing the
description? Mind that it's going to be a "v2", that is, the second
version of this patch.
On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote:
> On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
Hi Greg and Joe,
> > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:
> > > Add space around operators for improving the code
> > > readability.
> > > Reported by checkpatch.pl
t = (uint)(pwps_ie - ie);
> @@ -2322,7 +2322,7 @@ void rtw_ap_restore_network(struct adapter *padapter)
> for (i = 0; i < chk_alive_num; i++) {
> psta = rtw_get_stainfo_by_offset(pstapriv, chk_alive_list[i]);
>
> - if (psta == NULL) {
> + if
On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
> On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:
> > Add space around operators for improving the code
> > readability.
> > Reported by checkpatch.pl
> >
> > git diff -w shows no difference.
> > diff of the .o files before and after
On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
> Reported by checkpatch.pl
>
> git diff -w shows no difference.
> diff of the .o files before and after the changes shows no difference.
There is no need to have thes
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
This patchset adds space around operators and removes
all the checkpatch warnings for the same from the files
present under drivers/staging/rtl8188eu/hal/ directory.
Shreeya Patel (11):
Staging: rtl8188eu: hal_com: Add space around operators
Staging: rtl8188eu: odm: Add space around operators
On Fri, 13 Mar 2020 16:54:51 +0530
Shreeya Patel wrote:
> Replace calls to kmalloc followed by a memcpy with a direct call to
> kmemdup.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression from,to,size,flag;
> statement S;
> @@
>
> - to = \(kmalloc\|kzal
On Fri, 13 Mar 2020 15:59:12 +0530
Shreeya Patel wrote:
> Remove unnecessary if and else conditions since both are leading to the
> initialization of "phtpriv->ampdu_enable" with the same value.
> Also, remove the unnecessary else-if condition since it does nothing.
>
> Signed-off-by: Shreeya Pa
On Sat, 2020-03-14 at 16:58 +0530, Shreeya Patel wrote:
> This could be:
> > if ((!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable ==
> > 1)) ||
> > pregistrypriv->ampdu_enable == 2)
> > phtpriv->ampdu_enable = true;
> >
> > Though it is probably more sensible to jus
On Fri, 2020-03-13 at 14:21 -0700, Joe Perches wrote:
Hi Joe,
> On Fri, 2020-03-13 at 15:59 +0530, Shreeya Patel wrote:
> > Remove unnecessary if and else conditions since both are leading to
> > the
> > initialization of "phtpriv->ampdu_enable" with the same value.
> > Also, remove the unnecessa
On Fri, 2020-03-13 at 15:59 +0530, Shreeya Patel wrote:
> Remove unnecessary if and else conditions since both are leading to the
> initialization of "phtpriv->ampdu_enable" with the same value.
> Also, remove the unnecessary else-if condition since it does nothing.
[]
> diff --git a/drivers/stagin
Replace calls to kmalloc followed by a memcpy with a direct call to
kmemdup.
The Coccinelle semantic patch used to make this change is as follows:
@@
expression from,to,size,flag;
statement S;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
-
Ignore this one. There was a typo in Greg's email address.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Thanks!
You sent the same patch twice. Next time put a note under the ---
"Resending because I had a typo in Greg's email address".
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverde
Remove if and else conditions since both are leading to the
initialization of "valueDMATimeout" and "valueDMAPageCount" with
the same value.
Found using coccinelle script.
Signed-off-by: Shreeya Patel
---
Changes in v2
- Remove unnecessary comments.
drivers/staging/rtl8723bs/hal/sdio_halini
Remove if and else conditions since both are leading to the
initialization of "valueDMATimeout" and "valueDMAPageCount" with
the same value.
Found using coccinelle script.
Signed-off-by: Shreeya Patel
---
Changes in v2
- Remove unnecessary comments.
drivers/staging/rtl8723bs/hal/sdio_halini
Remove unnecessary if and else conditions since both are leading to the
initialization of "phtpriv->ampdu_enable" with the same value.
Also, remove the unnecessary else-if condition since it does nothing.
Signed-off-by: Shreeya Patel
---
Changes in v2
- Remove unnecessary comments
- Remove u
The original patch description was basically fine. Outreachy reviews
tend to be more pedantic about this sort of stuff than most maintainers.
There are a couple who have very strict rules, but try to avoid those
maintainers and your life will be happier.
regards,
dan carpenter
__
On Wed, Mar 11, 2020 at 07:28:59PM +0530, Shreeya Patel wrote:
> Remove unnecessary if and else conditions since both are leading to the
> initialization of "phtpriv->ampdu_enable" with the same value.
>
> Signed-off-by: Shreeya Patel
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 +++---
On Fri, 2020-03-13 at 10:20 +0300, Dan Carpenter wrote:
> On Wed, Mar 11, 2020 at 07:08:11PM +0530, Shreeya Patel wrote:
> > diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > index e813382e78a6..643592b0bd38 100644
> > --- a/drivers/sta
On Wed, Mar 11, 2020 at 07:08:11PM +0530, Shreeya Patel wrote:
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index e813382e78a6..643592b0bd38 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723
On Thu, 2020-03-12 at 03:58 +0530, Shreeya Patel wrote:
> Hey Joe,
>
> On March 11, 2020 10:56:29 PM GMT+05:30, Joe Perches wrote:
> > On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
> > > Remove if and else conditions since both are leading to the
> > > initialization of "valueDMATimeout
On 3/12/2020 3:49 AM, Julia Lawall wrote:
Thanks for your input Julia and Stefano.
That's my general preference as well, but I can't find any point in the
"Describe your changes" section of submitting-patches.rst actually
defining the order. I wouldn't imply that from the sequence the steps
are
x27;t
think that order is ever suggested explicitly. On the other hand it
avoids "This patch...", which would add some clutter, in my opinion.
julia
>
> --
> Stefano
>
> --
> You received this message because you are subscribed to the Google Groups
> "o
Hi Lakshmi,
On Wed, 11 Mar 2020 19:42:06 -0700
Lakshmi Ramasubramanian wrote:
> On 3/11/2020 6:58 AM, Shreeya Patel wrote:
>
> > Remove unnecessary if and else conditions since both are leading to the
> > initialization of "phtpriv->ampdu_enable" with the same value.
> >
> > Signed-off-by: Shr
On 3/11/2020 6:58 AM, Shreeya Patel wrote:
Remove unnecessary if and else conditions since both are leading to the
initialization of "phtpriv->ampdu_enable" with the same value.
Signed-off-by: Shreeya Patel
Stating this based on the patch descriptions I have seen.
Others, please advise\corre
On March 11, 2020 10:34:28 PM GMT+05:30, Stefano Brivio
wrote:
Hey Stefano,
>On Wed, 11 Mar 2020 18:47:42 +0530
>Shreeya Patel wrote:
>
>> Add space around operators for improving the code
>> readability.
>> Reported by checkpatch.pl
>>
>> git diff -w shows no difference.
>> diff of the .o
Hey Joe,
On March 11, 2020 10:56:29 PM GMT+05:30, Joe Perches wrote:
>On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
>> Remove if and else conditions since both are leading to the
>> initialization of "valueDMATimeout" and "valueDMAPageCount" with
>> the same value.
>
>You might consider
On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
> Remove if and else conditions since both are leading to the
> initialization of "valueDMATimeout" and "valueDMAPageCount" with
> the same value.
You might consider removing the
/* Timeout value is calculated by 34 / (2^n) */
comment
On Wed, 11 Mar 2020 19:08:11 +0530
Shreeya Patel wrote:
> Remove if and else conditions since both are leading to the
> initialization of "valueDMATimeout" and "valueDMAPageCount" with
> the same value.
>
> Found using coccinelle script.
>
> Signed-off-by: Shreeya Patel
Reviewed-by: Stefano B
On Wed, 11 Mar 2020 18:47:42 +0530
Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
> Reported by checkpatch.pl
>
> git diff -w shows no difference.
> diff of the .o files before and after the changes shows no difference.
>
> Signed-off-by: Shreeya Patel
Remove unnecessary if and else conditions since both are leading to the
initialization of "phtpriv->ampdu_enable" with the same value.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers
Remove if and else conditions since both are leading to the
initialization of "valueDMATimeout" and "valueDMAPageCount" with
the same value.
Found using coccinelle script.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 +
1 file changed, 5 ins
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
1 - 100 of 601 matches
Mail list logo
