Re: [PATCH 1/4] soc: qcom: Expose DDR data from SMEM

2025-04-09 Thread Bjorn Andersson
On Wed, Apr 09, 2025 at 04:47:29PM +0200, Konrad Dybcio wrote: > From: Konrad Dybcio > > Most modern Qualcomm platforms (>= SM8150) expose information about the > DDR memory present on the system via SMEM. > > Details from this information is used in various scenarios, such as > multimedia drive

Re: [PATCH 1/2] drm/dp: Add smooth brightness register bit definition

2025-04-09 Thread Murthy, Arun R
On 08-04-2025 10:31, Suraj Kandpal wrote: Add DP_EDP_SMOOTH_BRIGHTNESS register bit definition for EDP_GENERAL_CAPABILITY 2 register. Signed-off-by: Suraj Kandpal --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy include/drm/display/drm_dp.h | 1 + 1

Re: [PATCH v2 2/4] drm/xe: Update xe_ttm_access_memory to use GPU for non-visible access

2025-04-09 Thread Matthew Brost
On Thu, Apr 03, 2025 at 03:28:48PM -0600, Cavitt, Jonathan wrote: > -Original Message- > From: Intel-xe On Behalf Of Matthew > Brost > Sent: Thursday, April 3, 2025 1:27 PM > To: intel...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Subject: [PATCH v2 2/4] drm/xe: Update

Re: [PATCH 2/2] drm/i915/backlight: Modify condition to use panel luminance

2025-04-09 Thread Murthy, Arun R
On 08-04-2025 10:31, Suraj Kandpal wrote: According to our internal spec we need to now check if both panel luminance and smooth brightness are available in panel for us to be able to change brightness using luminance value. Signed-off-by: Suraj Kandpal --- Reviewed-by: Arun R Murthy Thanks

Re: [PATCH 2/2] drm/i915/backlight: Modify condition to use panel luminance

2025-04-09 Thread Nautiyal, Ankit K
On 4/10/2025 11:11 AM, Nautiyal, Ankit K wrote: On 4/8/2025 10:31 AM, Suraj Kandpal wrote: According to our internal spec we need to now check if both panel luminance and smooth brightness are available in panel for us to be able to change brightness using luminance value. Since DP_EDP_SMOO

Re: [PATCH] drm/v3d: Fix Indirect Dispatch configuration for V3D 7.1.6 and later

2025-04-09 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga El mié, 09-04-2025 a las 17:50 -0300, Maíra Canal escribió: > This commit is a resubmission of commit 1fe1c66274fb ("drm/v3d: Fix > Indirect Dispatch configuration for V3D 7.1.6 and later"), which was > accidentally reverted by commit 91dae758bdb8 ("Merge tag > 'dr

[PATCH V1] accel/amdxdna: Fix incorrect size of ERT_START_NPU commands

2025-04-09 Thread Lizhi Hou
When multiple ERT_START_NPU commands are combined in one buffer, the buffer size calculation is incorrect. Also, the condition to make sure the buffer size is not beyond 4K is also fixed. Fixes: aac243092b70 ("accel/amdxdna: Add command execution") Signed-off-by: Lizhi Hou --- drivers/accel/amdx

Re: [PATCH v4 00/13] Introduce parity_odd() and refactor redundant parity code

2025-04-09 Thread H. Peter Anvin
On 4/9/25 11:33, Yury Norov wrote: I don't have a strong preference for the name, but if I had to guess the return value from the function prototype, I would intuitively expect an int to return "0 for even and 1 for odd," and a bool to return "true for even, false for odd." I recall Jiri and Ja

Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Arend Van Spriel
On April 10, 2025 12:06:52 AM Johannes Berg wrote: On Wed, 2025-04-09 at 20:43 +0200, Arend van Spriel wrote: This is orthogonal to the change to parity_odd() though. More specific to the new parity_odd() you can now do following as parity_odd() argument is u64: err = !parity_odd(*(u16 *)p);

Re: [PATCH 1/2] drm/dp: Add smooth brightness register bit definition

2025-04-09 Thread Nautiyal, Ankit K
On 4/8/2025 10:31 AM, Suraj Kandpal wrote: Add DP_EDP_SMOOTH_BRIGHTNESS register bit definition for EDP_GENERAL_CAPABILITY 2 register. Signed-off-by: Suraj Kandpal --- include/drm/display/drm_dp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/display/drm_dp.h b/include/dr

Re: [PATCH v8 00/10] Improve gpu_scheduler trace events + UAPI

2025-04-09 Thread Pierre-Eric Pelloux-Prayer
Hi, I've rebased the series on top of drm-next, applied the minor tweaks suggested by Tvrtko on v8 and the R-b tags. The result can be found on gitlab.fdo: https://gitlab.freedesktop.org/pepp/linux/-/commits/improve_gpu_scheduler_trace_v9 I believe it's ready to be merged, unless I've missed

Reminder: Seeking nominations for the 2025 X.Org Board of Directors Elections

2025-04-09 Thread Mark Filion
Hello! The nomination period is currently open for the upcoming election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2025 election are now open and will remain open until 23:59 UTC on 16 April 2025. The Boar

[PATCH] drm/meson: fix resource cleanup in meson_drv_bind_master() on error

2025-04-09 Thread Martin Blumenstingl
meson_drv_bind_master() does not free resources in the order they are allocated. This can lead to crashes such as: Unable to handle kernel NULL pointer dereference at virtual address 00c8 [...] Hardware name: Beelink GT-King Pro (DT) pstate: 6005 (nZCv daif -PAN -UA

RE: [RFC] PCI: add CONFIG_MMU dependency

2025-04-09 Thread Deucher, Alexander
[Public] > -Original Message- > From: Arnd Bergmann > Sent: Monday, April 7, 2025 6:38 AM > To: Bjorn Helgaas > Cc: Arnd Bergmann ; Jeff Hugo > ; Carl Vanderlip ; Oded > Gabbay ; Takashi Sakamoto ; > Maarten Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; David > Airlie ; Simona Vetter

[PULL] drm-intel-fixes

2025-04-09 Thread Jani Nikula
Hi Dave & Sima - Fixes for v6.15-rc2. drm-intel-fixes-2025-04-09: drm/i915 fixes for v6.15-rc2: - Fix scanline offset for LNL+ and BMG+ - Fix GVT unterminated-string-initialization build warning - Fix DP rate limit when sink doesn't support TPS4 - Handle GDDR + ECC memory type detection - Fix

Re: [PATCH v4 01/13] bitops: Change parity8() to parity_odd() with u64 input and bool return type

2025-04-09 Thread Kuan-Wei Chiu
On Wed, Apr 09, 2025 at 11:39:22AM -0700, Guenter Roeck wrote: > On 4/9/25 11:25, Kuan-Wei Chiu wrote: > > On Wed, Apr 09, 2025 at 12:59:14PM -0400, Yury Norov wrote: > > > On Wed, Apr 09, 2025 at 11:43:44PM +0800, Kuan-Wei Chiu wrote: > > > > Redesign the parity8() helper as parity_odd(), changing

Re: [PATCH 04/10] panel/auo-a030jtn01: Use refcounted allocation in place of devm_kzalloc()

2025-04-09 Thread Dixit, Ashutosh
On Mon, 07 Apr 2025 08:49:23 -0700, Imre Deak wrote: > > Hi, > > On Tue, Apr 01, 2025 at 12:03:47PM -0400, Anusha Srivatsa wrote: > > Move to using the new API devm_drm_panel_alloc() to allocate the > > panel. > > > > Signed-off-by: Anusha Srivatsa > > --- > > drivers/gpu/drm/panel/panel-auo-a030

Re: [PATCH v5 2/4] drm/panthor: Add driver IOCTL for setting BO labels

2025-04-09 Thread Boris Brezillon
On Tue, 8 Apr 2025 23:24:22 +0100 Adrián Larumbe wrote: > Allow UM to label a BO for which it possesses a DRM handle. > > Signed-off-by: Adrián Larumbe > Reviewed-by: Liviu Dudau Just one minor doc issue below, but with this fixed, it's Reviewed-by: Boris Brezillon > --- > drivers/gpu/dr

Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Johannes Berg
On Wed, 2025-04-09 at 20:43 +0200, Arend van Spriel wrote: > > This is orthogonal to the change to parity_odd() though. More specific > to the new parity_odd() you can now do following as parity_odd() > argument is u64: > > err = !parity_odd(*(u16 *)p); > Can it though? Need to

[PATCH v8 05/23] drm/mediatek: mtk_hdmi: Convert to module_platform_driver macro

2025-04-09 Thread AngeloGioacchino Del Regno
Now that all of the mtk_hdmi subdrivers are a platform driver on their own it is possible to remove the custom init/exit functions in this driver and just use the module_platform_driver() macro. While at it, also compress struct of_device_id entries and remove stray commas in mtk_hdmi_driver assig

Re: [PATCH v3 11/15] drm/tests: hdmi: Drop unused drm_kunit_helper_connector_hdmi_init_funcs()

2025-04-09 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:20:00PM +0200, Cristian Ciocaltea wrote: > After updating the code to make use of the new EDID setup helpers, > drm_kunit_helper_connector_hdmi_init_funcs() became unused, hence drop > it. > > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm/tests/drm_hdmi_sta

[pull] amdgpu, amdkfd drm-fixes-6.15

2025-04-09 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.15. The following changes since commit dce8bd9137b88735dd0efc4e2693213d98c15913: drm/amdgpu/gfx12: fix num_mec (2025-03-26 17:47:18 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.15-2025-04-09

Re: [PATCH v3 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-09 Thread Marcus Folkesson
Hello Javier, On Wed, Apr 09, 2025 at 11:43:54AM +0200, Javier Martinez Canillas wrote: > Marcus Folkesson writes: > > Hello Marcus, > > [...] > > >> > >> That's a god question, I don't really know... > >> > >> But fbdev does support XRGB, which may be another good reason to add > >> it

Re: [PATCH 1/2] drm/sched: add drm_sched_prealloc_dependency_slots v2

2025-04-09 Thread Philipp Stanner
+Cc Matthew On Wed, 2025-04-09 at 15:55 +0200, Christian König wrote: > Am 09.04.25 um 12:28 schrieb Philipp Stanner: > > On Fri, 2025-03-21 at 16:58 +0100, Christian König wrote: > > > Sometimes drivers need to be able to submit multiple jobs which > > > depend on > > > each other to different sc

Re: [PATCH v4 01/13] bitops: Change parity8() to parity_odd() with u64 input and bool return type

2025-04-09 Thread Yury Norov
On Wed, Apr 09, 2025 at 11:43:44PM +0800, Kuan-Wei Chiu wrote: > Redesign the parity8() helper as parity_odd(), changing its input type > from u8 to u64 to support broader use cases and its return type from > int to bool to clearly reflect the function's binary output. The > function now returns tr

[PATCH] drm/v3d: Fix Indirect Dispatch configuration for V3D 7.1.6 and later

2025-04-09 Thread Maíra Canal
This commit is a resubmission of commit 1fe1c66274fb ("drm/v3d: Fix Indirect Dispatch configuration for V3D 7.1.6 and later"), which was accidentally reverted by commit 91dae758bdb8 ("Merge tag 'drm-misc-next-2024-08-01' of https://gitlab.freedesktop.org/drm/misc/kernel into drm-next"), likely due

[PATCH v4 11/13] mtd: ssfdc: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/mtd/ssfdc.c | 20 1 file changed, 4 insertions(+), 16 de

Re: [PATCH v4 00/13] Introduce parity_odd() and refactor redundant parity code

2025-04-09 Thread Kuan-Wei Chiu
On Wed, Apr 09, 2025 at 12:54:35PM -0400, Yury Norov wrote: > On Wed, Apr 09, 2025 at 11:43:43PM +0800, Kuan-Wei Chiu wrote: > > Several parts of the kernel contain open-coded and redundant > > implementations of parity calculation. This patch series introduces > > a unified helper, parity_odd(), t

Re: [PATCH 2/2] dma-fence: Improve docu for dma_fence_check_and_signal()

2025-04-09 Thread Li, Yunxiang (Teddy)
[AMD Official Use Only - AMD Internal Distribution Only] Hi Philipp, I feel like the problem has two parts. The documentation does not make explicit that DMA_FENCE_FLAG_SIGNALED_BIT is "caching" the hardware state when a fence is backed by hardware, so what dma_fence_is_signaled here is doing i

Re: [PATCH v4 02/13] media: media/test_drivers: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
On Wed, Apr 09, 2025 at 01:03:42PM -0400, Yury Norov wrote: > On Wed, Apr 09, 2025 at 11:43:45PM +0800, Kuan-Wei Chiu wrote: > > Refactor parity calculations to use the standard parity_odd() helper. > > This change eliminates redundant implementations. > > > > Co-developed-by: Yu-Chun Lin > > Sig

Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

2025-04-09 Thread Helen Koike
Hi Vignesh, Thank you for your patch. On 09/04/2025 03:15, Vignesh Raman wrote: Add jobs to validate devicetrees and run KUnit tests. Pipeline link, https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550 I see the checks are in the same stage as build, does it make sense to c

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Philipp Stanner
On Wed, 2025-04-09 at 15:14 +0200, Christian König wrote: > Am 09.04.25 um 14:56 schrieb Philipp Stanner: > > On Wed, 2025-04-09 at 14:51 +0200, Philipp Stanner wrote: > > > On Wed, 2025-04-09 at 14:39 +0200, Boris Brezillon wrote: > > > > Hi Philipp, > > > > > > > > On Wed,  9 Apr 2025 14:06:37 +

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Christian König
Am 09.04.25 um 16:01 schrieb Philipp Stanner: > On Wed, 2025-04-09 at 15:14 +0200, Christian König wrote: >> Am 09.04.25 um 14:56 schrieb Philipp Stanner: >>> On Wed, 2025-04-09 at 14:51 +0200, Philipp Stanner wrote: On Wed, 2025-04-09 at 14:39 +0200, Boris Brezillon wrote: > Hi Philipp, >

Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
On Wed, Apr 09, 2025 at 08:43:09PM +0200, Arend van Spriel wrote: > On 4/9/2025 5:43 PM, Kuan-Wei Chiu wrote: > > Refactor parity calculations to use the standard parity_odd() helper. > > This change eliminates redundant implementations. > > > > Co-developed-by: Yu-Chun Lin > > Signed-off-by: Yu-

[PATCH v8 3/6] rust: enable `clippy::as_ptr_cast_mut` lint

2025-04-09 Thread Tamir Duberstein
In Rust 1.66.0, Clippy introduced the `as_ptr_cast_mut` lint [1]: > Since `as_ptr` takes a `&self`, the pointer won’t have write > permissions unless interior mutability is used, making it unlikely > that having it as a mutable pointer is correct. There is only one affected callsite, and the chan

[PATCH v6 2/4] drm/panthor: Add driver IOCTL for setting BO labels

2025-04-09 Thread Adrián Larumbe
Allow UM to label a BO for which it possesses a DRM handle. Signed-off-by: Adrián Larumbe Reviewed-by: Liviu Dudau Reviewed-by: Boris Brezillon --- drivers/gpu/drm/panthor/panthor_drv.c | 42 ++- drivers/gpu/drm/panthor/panthor_gem.h | 2 ++ include/uapi/drm/panthor_dr

Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Arend van Spriel
On 4/9/2025 5:43 PM, Kuan-Wei Chiu wrote: Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/pci/cx18/cx18-av-vbi.c | 1

Re: [PATCH 3/4] drm/msm/a6xx: Get HBB dynamically, if available

2025-04-09 Thread Konrad Dybcio
On 4/9/25 5:30 PM, Connor Abbott wrote: > On Wed, Apr 9, 2025 at 11:22 AM Konrad Dybcio > wrote: >> >> On 4/9/25 5:12 PM, Connor Abbott wrote: >>> On Wed, Apr 9, 2025 at 10:48 AM Konrad Dybcio >>> wrote: From: Konrad Dybcio The Highest Bank address Bit value can change based

Re: [PATCH v2 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P

2025-04-09 Thread Dmitry Baryshkov
On 09/04/2025 09:07, Krzysztof Kozlowski wrote: On 08/04/2025 22:26, Dmitry Baryshkov wrote: + - const: qcom,sa8775p-dsi-ctrl + - const: qcom,mdss-dsi-ctrl Drop fallback Hi Krzysztof, I couldn't understand the meaning of "Drop fallback", could please elaborate it ? L

[PATCH v4 07/13] Input: joystick - Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/input/joystick/grip_mp.c| 17 ++--- drivers/input/joystick/si

[PATCH v4 05/13] serial: max3100: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/tty/serial/max3100.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH v4 06/13] lib/bch: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- lib/bch.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff

[PATCH v4 01/13] bitops: Change parity8() to parity_odd() with u64 input and bool return type

2025-04-09 Thread Kuan-Wei Chiu
Redesign the parity8() helper as parity_odd(), changing its input type from u8 to u64 to support broader use cases and its return type from int to bool to clearly reflect the function's binary output. The function now returns true for odd parity and false for even parity, making its behavior more i

[PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/pci/cx18/cx18-av-vbi.c | 12 ++-- 1 file changed, 2 insertions(

Re: [PATCH 0/4] Retrieve information about DDR from SMEM

2025-04-09 Thread Dmitry Baryshkov
soc/qcom/smem.h | 4 + 8 files changed, 371 insertions(+), 16 deletions(-) --- base-commit: 46086739de22d72319e37c37a134d32db52e1c5c change-id: 20250409-topic-smem_dramc-6467187ac865 Best regards, -- With best wishes Dmitry

[PATCH v4 02/13] media: media/test_drivers: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/test-drivers/vivid/vivid-vbi-gen.c | 8 ++-- 1 file changed, 2 inse

[PATCH v4 13/13] nfp: bpf: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/net/ethernet/netronome/nfp/nfp_asm.c | 7 +-- 1 file changed, 1 insertion

[PATCH v4 12/13] fsi: i2cr: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/fsi/fsi-master-i2cr.c | 20 +++- 1 file changed, 3 insertions

[PATCH v4 09/13] wifi: brcm80211: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu Acked-by: Arend van Spriel --- .../wireless/broadcom/brcm80211/brcmsmac/dma.c | 18 ++---

[PATCH v4 10/13] drm/bridge: dw-hdmi: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 8 ++-- 1 file changed, 2 i

Re: [PATCH 0/4] Retrieve information about DDR from SMEM

2025-04-09 Thread Konrad Dybcio
On 4/9/25 5:44 PM, Dmitry Baryshkov wrote: > On 09/04/2025 17:47, Konrad Dybcio wrote: >> SMEM allows the OS to retrieve information about the DDR memory. >> Among that information, is a semi-magic value called 'HBB', or Highest >> Bank address Bit, which multimedia drivers (for hardware like Adren

Re: [PATCH 3/4] drm/msm/a6xx: Get HBB dynamically, if available

2025-04-09 Thread Connor Abbott
On Wed, Apr 9, 2025 at 11:40 AM Konrad Dybcio wrote: > > On 4/9/25 5:30 PM, Connor Abbott wrote: > > On Wed, Apr 9, 2025 at 11:22 AM Konrad Dybcio > > wrote: > >> > >> On 4/9/25 5:12 PM, Connor Abbott wrote: > >>> On Wed, Apr 9, 2025 at 10:48 AM Konrad Dybcio > >>> wrote: > > From: Ko

Re: [PATCH 3/4] drm/msm/a6xx: Get HBB dynamically, if available

2025-04-09 Thread Konrad Dybcio
On 4/9/25 5:44 PM, Connor Abbott wrote: > On Wed, Apr 9, 2025 at 11:40 AM Konrad Dybcio > wrote: >> >> On 4/9/25 5:30 PM, Connor Abbott wrote: >>> On Wed, Apr 9, 2025 at 11:22 AM Konrad Dybcio >>> wrote: On 4/9/25 5:12 PM, Connor Abbott wrote: > On Wed, Apr 9, 2025 at 10:48 AM Konra

Re: [PATCH v2 10/15] drm: renesas: rz-du: mipi_dsi: Use mHz for D-PHY frequency calculations

2025-04-09 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Wed, Apr 9, 2025 at 9:16 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Tue, 8 Apr 2025 at 22:09, Prabhakar wrote: > > From: Lad Prabhakar > > > > Pass the HSFREQ in milli-Hz to the `dphy_init()` callback to improve > > precision, especially for th

[PATCH v4 04/13] media: saa7115: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/i2c/saa7115.c | 12 ++-- 1 file changed, 2 insertions(+), 10 de

[PATCH v8 03/23] drm/mediatek: mtk_cec: Switch to register as module_platform_driver

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for adding a driver for the new HDMIv2 IP, and before splitting out the common bits from the HDMI driver, change the mtk_cec driver from being registered from the mtk_hdmi driver itself to be a module_platform_driver of its own. Besides being a cleanup, this also allows build flexib

[PATCH v1 3/5] drm/mediatek: mtk_dpi: Add support for additional output formats

2025-04-09 Thread AngeloGioacchino Del Regno
Add support for configuring the Display Parallel Interface block to output YUV444 8/10 bits, YUV422 10/12 bits (8 bits support is already present), BGR 8-bits, and RGB 10-bits. The enablement of the various additional output formats in SoCs platform data will be done in a different change. Signed

[PATCH v8 02/23] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2

2025-04-09 Thread AngeloGioacchino Del Regno
Add a binding for the HDMI TX v2 Encoder found in MediaTek MT8195 and MT8188 SoCs. This fully supports the HDMI Specification 2.0b, hence it provides support for 3D-HDMI, Polarity inversion, up to 16 bits Deep Color, color spaces including RGB444, YCBCR420/422/444 (ITU601/ITU709) and xvYCC, with o

[PATCH v8 04/23] drm/mediatek: mtk_hdmi_ddc: Switch to register as module_platform_driver

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for adding a driver for the new HDMIv2 IP, and before splitting out the common bits from the HDMI driver, change the mtk_hdmi_ddc driver from being registered from the HDMI driver itself to be a module_platform_driver of its own. With this change, there are no more users of the mtk_

[PATCH v8 10/23] drm/mediatek: mtk_hdmi: Move N/CTS setting to new function

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for splitting common bits of this driver, moving the hdmi_rec_n_table struct array, and the hdmi_recommended_n(), hdmi_mode_clock_to_hz(), hdmi_expected_cts() functions, add one function called mtk_hdmi_get_ncts() that sets both N and CTS in a single call. Reviewed-by: CK Hu Signed

[PATCH v8 16/23] drm/mediatek: mtk_hdmi: Split driver and add common probe function

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for adding a new driver for the HDMI TX v2 IP, split out the functions that will be common between the already present mtk_hdmi (v1) driver and the new one. Since the probe flow for both drivers is 90% similar, add a common probe function that will be called from each driver's .prob

[PATCH v1 1/5] drm/mediatek: mtk_dpi: Use switch in mtk_dpi_config_color_format()

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for adding support for an additional color format, convert the format conditional in mtk_dpi_config_color_format() to a switch. This also makes the concept of RGB being the default color format a little more human readable. This commit brings no functional differences. Signed-off-b

[PATCH v8 12/23] drm/mediatek: mtk_hdmi: Move CEC device parsing in new function

2025-04-09 Thread AngeloGioacchino Del Regno
Move the CEC device parsing logic to a new function called mtk_hdmi_get_cec_dev(), and move the parsing action to the end of mtk_hdmi_dt_parse_pdata(), allowing to remove gotos in this function, reducing code size and improving readability. Reviewed-by: CK Hu Signed-off-by: AngeloGioacchino Del R

[PATCH v1 4/5] drm/mediatek: mtk_dpi: Allow additional output formats on MT8195/88

2025-04-09 Thread AngeloGioacchino Del Regno
Allow additional output formats in both DPI and DP_INTF blocks of the MT8195 and MT8188 SoCs (as the latter is fully compatible with, hence reuses, the former's platform data for both blocks) by adding: 1. New formats to the `mt8195_output_fmts` array for dp_intf, lacking YUV422 12-bits support

[PATCH v8 13/23] drm/mediatek: mtk_hdmi: Move output init to mtk_hdmi_register_audio_driver()

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for moving the common bits of this driver, merge the contents of mtk_hdmi_output_init in mtk_hdmi_register_audio_driver function to aggregate all of the initial audio setup together in the same function and to make it clear that all of the setup that is performed in mtk_hdmi_output_i

[PATCH v1 0/5] MediaTek DPI: Cleanups and add support for more formats

2025-04-09 Thread AngeloGioacchino Del Regno
This series adds support to configure the MediaTek DPI IP to output more formats, such as YUV422 8/10/12 bits, YUV444 8/10 bits, BGR 8bits, and RGB 10 bits, and also performs some cleanups that improve the code readability when those are added. Even though some of those formats are also supported

[PATCH v8 22/23] drm/mediatek: mtk_hdmi_v2: Add debugfs ops and implement ABIST

2025-04-09 Thread AngeloGioacchino Del Regno
Implement the Automated Built-In Self-Test ABIST functionality provided by the HDMIv2 IP and expose it through the "hdmi_abist" debugfs file. Write "1" to this file to activate ABIST, or "0" to deactivate. The ABIST functionality can be used to validate that the HDMI Transmitter itself works and

[PATCH v8 07/23] drm/mediatek: mtk_hdmi: Disgregate function mtk_hdmi_audio_set_param()

2025-04-09 Thread AngeloGioacchino Del Regno
As a cleanup, and in preparation for splitting common bits of this driver, disgregate the code in function mtk_hdmi_audio_set_param() to the beginning and end of function mtk_hdmi_audio_hw_params(). In a later commit, the hw_params callback function will also be disgregated so that the code will g

[PATCH v1 5/5] drm/mediatek: mtk_dpi: Rename output fmts array for MT8195 DP_INTF

2025-04-09 Thread AngeloGioacchino Del Regno
For the sake of increasing human readability and avoid possible confusion between DPI and DP_INTF output formats (as the two are ever so slightly different), rename the mt8195_output_fmts array to mt8195_dp_intf_output_fmts. This commit brings no functional changes. Signed-off-by: AngeloGioacchin

[PATCH v8 18/23] drm/mediatek: mtk_hdmi_common: Assign DDC adapter pointer to bridge

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for adding the new HDMI TX v2 IP driver, assign the pointer to the DDC adapter to struct drm_bridge during probe. This commit brings no functional changes. Reviewed-by: CK Hu Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 1 + 1 file

[PATCH v8 09/23] drm/mediatek: mtk_hdmi: Move plugged_cb/codec_dev setting to new function

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for splitting common bits of this driver, move the mutex-protected cable plugged callback and codec device setting to a new function called mtk_hdmi_audio_set_plugged_cb(). Reviewed-by: CK Hu Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 13

[PATCH v8 19/23] drm/mediatek: mtk_hdmi_common: Add OP_HDMI if helper funcs assigned

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for adding the HDMI TX v2 driver, and to allow a future modernization of the HDMI v1 one, perform changes that enable the usage of the HDMI Helpers provided by DRM. Check if the HDMI driver provides the function pointers to hdmi_{clear,write}_infoframe used by the HDMI Helper API an

[PATCH v8 15/23] drm/mediatek: mtk_hdmi: Add HDMI IP version configuration to pdata

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for adding a driver for the HDMIv2 IP and before moving the common bits out of this driver, add a new structure `mtk_hdmi_ver_conf`, holding pointers to HDMI IP version specific drm_bridge_funcs, hdmi_codec_ops and clock array used for probe, and nest it into the mtk_hdmi_conf platfo

[PATCH v8 08/23] drm/mediatek: mtk_hdmi: Move audio params selection to new function

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for splitting common bits of this driver, move the audio params (codec, sample rate/size, input type, i2s format, etc) selection to a new function called mtk_hdmi_audio_params(). While at it, also rename "hdmi_params" to "aud_params" both to match the mtk_hdmi struct member name and

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Christian König
Am 09.04.25 um 14:56 schrieb Philipp Stanner: > On Wed, 2025-04-09 at 14:51 +0200, Philipp Stanner wrote: >> On Wed, 2025-04-09 at 14:39 +0200, Boris Brezillon wrote: >>> Hi Philipp, >>> >>> On Wed,  9 Apr 2025 14:06:37 +0200 >>> Philipp Stanner wrote: >>> dma_fence_is_signaled()'s name stron

[PATCH v8 17/23] drm/mediatek: mtk_hdmi_common: Make CEC support optional

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for adding a new driver for HDMIv2, for which CEC is not strictly required, change the of_get_compatible_child() failure error to -ENOTSUPP to be able to differentiate between error conditions in mtk_hdmi_dt_parse_pdata(). In that case, if -ENOTSUPP is returned, this driver will pri

Re: [PATCH v5 3/4] drm/panthor: Label all kernel BO's

2025-04-09 Thread Boris Brezillon
On Tue, 8 Apr 2025 23:24:23 +0100 Adrián Larumbe wrote: > Kernel BO's aren't exposed to UM, so labelling them is the responsibility > of the driver itself. This kind of tagging will prove useful in further > commits when want to expose these objects through DebugFS. > > Expand panthor_kernel_bo

Re: [PATCH v2 1/9] drm/panthor: Add 64-bit and poll register accessors

2025-04-09 Thread Karunika Choo
On 21/03/2025 07:48, Boris Brezillon wrote: > On Thu, 20 Mar 2025 11:17:33 + > Karunika Choo wrote: > >> This patch adds 64-bit register accessors to simplify register access in >> Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. >> >> Signed-off-by: Karunika Choo >> --

Re: [PATCH v4 02/13] media: media/test_drivers: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Yury Norov
On Thu, Apr 10, 2025 at 02:23:09AM +0800, Kuan-Wei Chiu wrote: > On Wed, Apr 09, 2025 at 01:03:42PM -0400, Yury Norov wrote: > > On Wed, Apr 09, 2025 at 11:43:45PM +0800, Kuan-Wei Chiu wrote: > > > Refactor parity calculations to use the standard parity_odd() helper. > > > This change eliminates re

[PATCH v4 08/13] net: ethernet: oa_tc6: Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/net/ethernet/oa_tc6.c | 19 +++ 1 file changed, 3 insertions(

Re: [PATCH v4 07/13] Input: joystick - Replace open-coded parity calculation with parity_odd()

2025-04-09 Thread Dmitry Torokhov
On Wed, Apr 09, 2025 at 11:43:50PM +0800, Kuan-Wei Chiu wrote: > Refactor parity calculations to use the standard parity_odd() helper. > This change eliminates redundant implementations. > > Co-developed-by: Yu-Chun Lin > Signed-off-by: Yu-Chun Lin > Signed-off-by: Kuan-Wei Chiu Acked-by: Dmit

Re: [PATCH 3/4] drm/msm/a6xx: Get HBB dynamically, if available

2025-04-09 Thread Connor Abbott
On Wed, Apr 9, 2025 at 10:48 AM Konrad Dybcio wrote: > > From: Konrad Dybcio > > The Highest Bank address Bit value can change based on memory type used. > > Attempt to retrieve it dynamically, and fall back to a reasonable > default (the one used prior to this change) on error. > > Signed-off-by

Re: [PATCH v3 10/15] drm/tests: hdmi: Replace open coded EDID setup

2025-04-09 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:19:59PM +0200, Cristian Ciocaltea wrote: > Make use of the recently introduced macros to reduce boilerplate code > around EDID setup. This also helps dropping the redundant calls to > set_connector_edid(). > > No functional changes intended. > > Signed-off-by: Cristian

Re: [PATCH 3/4] drm/msm/a6xx: Get HBB dynamically, if available

2025-04-09 Thread Konrad Dybcio
On 4/9/25 5:12 PM, Connor Abbott wrote: > On Wed, Apr 9, 2025 at 10:48 AM Konrad Dybcio wrote: >> >> From: Konrad Dybcio >> >> The Highest Bank address Bit value can change based on memory type used. >> >> Attempt to retrieve it dynamically, and fall back to a reasonable >> default (the one used

Re: [PATCH v2] drm/amd/display: Add error check for avi and vendor infoframe setup function

2025-04-09 Thread Alex Hung
On 4/7/25 20:20, Wentao Liang wrote: The function fill_stream_properties_from_drm_display_mode() calls the function drm_hdmi_avi_infoframe_from_display_mode() and the function drm_hdmi_vendor_infoframe_from_display_mode(), but does not check its return value. Log the error messages to prevent

Re: [PATCH v4 0/3] Use proper printk format in appletbdrm

2025-04-09 Thread Petr Mladek
On Tue 2025-04-08 12:38:50, Andy Shevchenko wrote: > On Tue, Apr 08, 2025 at 08:52:10AM +, Aditya Garg wrote: > > > On 8 Apr 2025, at 2:11 PM, Andy Shevchenko > > > wrote: > > > On Tue, Apr 08, 2025 at 12:17:13PM +0530, Aditya Garg wrote: > > >> The vsprint patch was originally being sent as

Re: [PATCH v3 09/15] drm/tests: hdmi: Fixup CamelCase warning

2025-04-09 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:19:58PM +0200, Cristian Ciocaltea wrote: > Rename the reject_100_MHz_connector_hdmi_funcs variable to make > checkpatch.pl happy: > > CHECK: Avoid CamelCase: > > While at it, also rename reject_100MHz_connector_tmds_char_rate_valid() > for consistency. > > Signed-of

[PATCH 1/2] drm/v3d: fix client obtained from axi_ids on V3D 4.1

2025-04-09 Thread Jose Maria Casanova Crespo
The client that causes an MMU error is expected to be reported. But in the case of MMU TFU errors, a non existing client was being reported. This happened because because the client calculation was taking into account more than the bits 0-7 from the axi_id that were representing the client. This

[PATCH 2/2] drm/v3d: client ranges from axi_ids are different with V3D 7.1

2025-04-09 Thread Jose Maria Casanova Crespo
The client mask has been reduced from 8 bits on V3D 4.1 to 7 bits on V3d 7.1, so the ranges for each client are not compatible. A new CSD client can now report MMU errors on 7.1 Signed-off-by: Jose Maria Casanova Crespo --- drivers/gpu/drm/v3d/v3d_irq.c | 21 - 1 file change

[PATCH 0/1] drm/amd/display: Add quirk to force backlight type on some TUXEDO devices

2025-04-09 Thread Werner Sembach
This is a quirk we currently manually apply via our installer, but we don't have this exact device + panel configuration in our archive anymore so I could only test the qurik moking in other ids. Werner Sembach (1): drm/amd/display: Add quirk to force backlight type on some TUXEDO devices

[PATCH v8 00/23] Add support for MT8195/88 HDMIv2 and DDCv2

2025-04-09 Thread AngeloGioacchino Del Regno
Changes in v8: - Dropped DPI patches as those have been applied in the previous merge window - Changed description in mediatek,mt8195-hdmi.yaml as requested by CK - Refactored function mtk_hdmi_v2_hw_gcp_avmute() to include contents of, and delete, mtk_hdmi_v2_hw_reset_av_mute_regs() as reque

[PATCH v8 14/23] drm/mediatek: mtk_hdmi: Improve mtk_hdmi_get_all_clk() flexibility

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for splitting common bits of this driver and for introducing a new version of the MediaTek HDMI Encoder IP, improve the flexibility of function mtk_hdmi_get_all_clk() by adding a pointer to the clock names array and size of it to its parameters. Also change the array of struct clock

[PATCH v1 2/5] drm/mediatek: mtk_dpi: Add local helpers for bus format parameters

2025-04-09 Thread AngeloGioacchino Del Regno
In preparation for adding support for additional color formats, add local helpers to map media bus format parameters to this driver's bit_num, channel_swap and color_format. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dpi

[PATCH v7 1/2] drm/bridge: documentat bridge allocation and lifecycle

2025-04-09 Thread Luca Ceresoli
Document in detail the DRM bridge allocation and refcounting process based on the recently introduced devm_drm_bridge_alloc(). Signed-off-by: Luca Ceresoli --- Changes in v7: - remove mention of "legacy mode", we now support only refcounted bridges - rename patch title from "drm/bridge: ad

[PATCH v8 1/6] rust: enable `clippy::ptr_as_ptr` lint

2025-04-09 Thread Tamir Duberstein
In Rust 1.51.0, Clippy introduced the `ptr_as_ptr` lint [1]: > Though `as` casts between raw pointers are not terrible, > `pointer::cast` is safer because it cannot accidentally change the > pointer's mutability, nor cast the pointer to other types like `usize`. There are a few classes of changes

[PATCH v8 4/6] rust: enable `clippy::as_underscore` lint

2025-04-09 Thread Tamir Duberstein
In Rust 1.63.0, Clippy introduced the `as_underscore` lint [1]: > The conversion might include lossy conversion or a dangerous cast that > might go undetected due to the type being inferred. > > The lint is allowed by default as using `_` is less wordy than always > specifying the type. Always sp

[PATCH v8 5/6] rust: enable `clippy::cast_lossless` lint

2025-04-09 Thread Tamir Duberstein
Before Rust 1.29.0, Clippy introduced the `cast_lossless` lint [1]: > Rust’s `as` keyword will perform many kinds of conversions, including > silently lossy conversions. Conversion functions such as `i32::from` > will only perform lossless conversions. Using the conversion functions > prevents con

Re: [PATCH v3 06/15] drm/connector: hdmi: Factor out bpc and format computation logic

2025-04-09 Thread Maxime Ripard
Hi, On Wed, Mar 26, 2025 at 12:19:55PM +0200, Cristian Ciocaltea wrote: > In preparation to support fallback to an alternative output format, e.g. > YUV420, when RGB cannot be used for any of the available color depths, > move the bpc try loop out of hdmi_compute_config() and, instead, make it > p

[PATCH v8 0/6] rust: reduce `as` casts, enable related lints

2025-04-09 Thread Tamir Duberstein
--- base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8 change-id: 20250307-ptr-as-ptr-21b1867fc4d4 prerequisite-change-id: 20250409-container-of-mutness-b153dab4388d:v1 prerequisite-patch-id: 53d5889db599267f87642bb0ae3063c29bc24863 Best regards, -- Tamir Duberstein

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Philipp Stanner
On Wed, 2025-04-09 at 16:10 +0200, Christian König wrote: > Am 09.04.25 um 16:01 schrieb Philipp Stanner: > > On Wed, 2025-04-09 at 15:14 +0200, Christian König wrote: > > > Am 09.04.25 um 14:56 schrieb Philipp Stanner: > > > > On Wed, 2025-04-09 at 14:51 +0200, Philipp Stanner wrote: > > > > > On

  1   2   >