Re: [PATCH V8 03/43] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2025-03-31 Thread Alex Hung
On 3/29/25 09:26, Simon Ser wrote: I would also highlight that we need to seamlessly switch between HW fixed-function blocks and shaders/CPU with no visible difference. Depending on the content being displayed we might need to fallback to shaders/CPU at any time. (A classic example would be a

Re: [PATCH v2 1/2] drm/msm/dp: Fix support of LTTPR handling

2025-03-31 Thread Dmitry Baryshkov
On Wed, Mar 12, 2025 at 12:38:03AM +0100, Aleksandrs Vinarskis wrote: > Take into account LTTPR capabilities when selecting maximum allowed > link rate, number of data lines. Initialize LTTPR before > msm_dp_panel_read_sink_caps, as > a) Link params computation need to take into account LTTPR's cap

Re: [PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

2025-03-31 Thread Alex Hung
On 3/31/25 19:04, Shengyu Qu wrote: My understanding is that currently the driver would just report no colorop support on cursor plane and actually implement the background plane's colorop on cursor? No. Again it is up to compositors or apps to determine how color pipeline and color

Re: [PATCH V8 43/43] drm/colorop: Add destroy functions for color pipeline

2025-03-31 Thread Alex Hung
On 3/29/25 09:48, Simon Ser wrote: I would prefer these functions to be introduced together with the patches adding functions to create objects and adding the new fields. That way it's easier to check the symmetry and at no point in the series there are memory leaks. The object creation and

[PATCH v3] backlight: pm8941: Add NULL check in wled_configure()

2025-03-31 Thread Henry Martin
Thanks for your review. No further improvements needed for this implementation - it already handles all error cases appropriately. Best regards, Henry

Re: [PATCH v2] backlight: pm8941: Add NULL check in wled_configure()

2025-03-31 Thread Markus Elfring
> devm_kasprintf() return NULL if memory allocation fails. Currently, call? failed? > wled_configure() does not check for this case, leading to a possible NULL > pointer dereference. You may omit the word “possible” in such a change description. (W

Re: [PATCH v1 2/3] drm/ci: Add jobs to validate devicetrees

2025-03-31 Thread Vignesh Raman
Hi Dmitry, On 30/03/25 22:36, Dmitry Baryshkov wrote: On Thu, Mar 27, 2025 at 09:31:11PM +0530, Vignesh Raman wrote: Add jobs to run dt_binding_check and dtbs_check. If warnings are seen, exit with a non-zero error code while configuring them as warning in the GitLab CI pipeline. Can it reall

Re: [PATCH v2] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi wrapped functions

2025-03-31 Thread Dmitry Baryshkov
On Tue, Apr 01, 2025 at 04:01:03AM +0300, Dmitry Baryshkov wrote: > On Mon, Mar 31, 2025 at 03:40:27PM -0700, Doug Anderson wrote: > > Hi, > > > > On Mon, Mar 31, 2025 at 1:28 PM Dmitry Baryshkov > > wrote: > > > > > > On Mon, Mar 31, 2025 at 08:06:36AM -0700, Doug Anderson wrote: > > > > Hi, > >

[PATCH] backlight: qcom-wled: Add NULL check in the wled_configure

2025-03-31 Thread Henry Martin
When devm_kasprintf() fails, it returns a NULL pointer. However, this return value is not properly checked in the function wled_configure. A NULL check should be added after the devm_kasprintf call to prevent potential NULL pointer dereference error. Fixes: f86b77583d88c ("backlight: pm8941: Co

Re: [PATCH 12/12] drm/i915/display: Expose sharpness strength property

2025-03-31 Thread Nautiyal, Ankit K
On 3/21/2025 9:36 PM, Nemesa Garg wrote: Expose the drm crtc sharpness strength property which will enable or disable the sharpness/casf based on user input. With this user can set/update the strength of the sharpness or casf filter. v2: Update subject[Ankit] Signed-off-by: Nemesa Garg Rev

[PATCH v2 16/18] drm/sysfb: Add vesadrm for VESA displays

2025-03-31 Thread Thomas Zimmermann
Add support for screen_info setups with VIDEO_TYPE_VLFB. Provide the minimum functionality of reading modes, updating and clearing the display. There is existing support for these displays provided by simpledrm with CONFIG_SYSFB_SIMPLEFB=y. Using vesadrm over simpledrm will allow for the use of ad

Re: [PATCH 1/1] fbdev: atyfb: Fix buffer overflow

2025-03-31 Thread Ville Syrjälä
On Thu, Mar 27, 2025 at 12:14:26PM +0200, Jani Nikula wrote: > On Thu, 27 Mar 2025, Denis Arefev wrote: > > The value LCD_MISC_CNTL is used in the 'aty_st_lcd()' function to > > calculate an index for accessing an array element of size 9. > > This may cause a buffer overflow. > > The fix is to fi

[PATCH 7/7] drm/panel: make prepare/enable and disable/unprepare calls return void

2025-03-31 Thread Dmitry Baryshkov
Now there are no users of the return value of the drm_panel_prepare(), drm_panel_unprepare(), drm_panel_enable() and drm_panel_disable() calls. Usually these calls are performed from the atomic callbacks, where it is impossible to return an error. Stop returning error codes and return void instead.

[PATCH 3/7] drm/bridge: analogic_dp: drop panel_is_modeset

2025-03-31 Thread Dmitry Baryshkov
The dp->panel_is_modeset is now a write-only field. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +-- drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 1 - 2 files changed, 1 insertion(+), 11 deletions(-) diff --git

[PATCH 6/7] drm/bridge: analogix_dp: ignore return values of drm_panel_* calls

2025-03-31 Thread Dmitry Baryshkov
Follow the example of other drivers and ignore return values of the drm_panel_prepare() / unprepare() / enable() / disable() calls. There is no possible error recovery, so the driver just logs a message. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 39

[PATCH 5/7] drm/bridge: analogix_dp: inline analogix_dp_prepare_panel()

2025-03-31 Thread Dmitry Baryshkov
The analogix_dp_prepare_panel() is now only calling a corresponding drm_panel function. Inline it to simplify the code. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 43 +- 1 file changed, 10 insertions(+), 33 deletions(-) diff --gi

Re: [PATCH 02/12] drm/i915/display: Introduce HAS_CASF for sharpness support

2025-03-31 Thread Nautiyal, Ankit K
On 3/21/2025 9:36 PM, Nemesa Garg wrote: HAS_CASF macro will be used to check whether platform support the content adaptive sharpness capability or not. Perhaps reworded to maintain imperative mood: Add HAS_CASF macro to check.. Otherwise LGTM. Reviewed-by: Ankit Nautiyal v2: Update co

Re: [PATCH 03/12] drm/i915/display: Add sharpness strength and winsize

2025-03-31 Thread Nautiyal, Ankit K
On 3/21/2025 9:36 PM, Nemesa Garg wrote: register I think this is part of the subject, need to fix this. The strength value for sharpness is based on user input and the winsize is based on resolution. Set the casf_enable flag if there is a platform support and uapi strength is not zero. O

Re: [PATCH 05/12] drm/i915/display: Compute the scaler filter

2025-03-31 Thread Nautiyal, Ankit K
On 3/21/2025 9:36 PM, Nemesa Garg wrote: coefficients This is part of the subject, need to fix. Regards, Ankit The sharpness property requires the use of one of the scaler so need to set the sharpness scaler coefficient values. These values are based on experiments and vary for different

Re: [PATCH 07/12] drm/i915/display: Configure the second scaler for

2025-03-31 Thread Nautiyal, Ankit K
On 3/21/2025 9:36 PM, Nemesa Garg wrote: sharpness This again is part of subject. As only second scaler can be used for sharpness check if it is available and also check if panel fitting is not enabled, then set the sharpness as both uses pipe scaler so only one can be enabled at a time.

[RFC v3 04/14] drm/sched: Clarify locked section in drm_sched_rq_select_entity_fifo

2025-03-31 Thread Tvrtko Ursulin
Rq->lock only protects the tree walk so lets move the rest out. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 31 ++ 1 file changed, 17 insertions(+), 14 deleti

Re: [PATCH v3 1/2] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to eDP panel

2025-03-31 Thread Dmitry Baryshkov
On Tue, 1 Apr 2025 at 00:38, Christopher Obbard wrote: > > Hi Dmitry, > > On Mon, 31 Mar 2025 at 17:49, Dmitry Baryshkov > wrote: > > > > On 31/03/2025 18:39, Christopher Obbard wrote: > > > Hi Johan, > > > > > > On Mon, 31 Mar 2025 at 09:50, Johan Hovold wrote: > > >> > > >> On Thu, Mar 27, 202

Re: [PATCH 08/12] drm/i915/display: Compare the sharpness state

2025-03-31 Thread Nautiyal, Ankit K
On 3/21/2025 9:36 PM, Nemesa Garg wrote: Compare the sharpness win_size, strength and enable bits Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/d

Re: [PATCH 10/12] drm/i915/display: Write and read back the casf registers

2025-03-31 Thread Nautiyal, Ankit K
On 3/21/2025 9:36 PM, Nemesa Garg wrote: Write the casf registers bits to enable the sharpness Hmm, there is no write here. We are setting the configuration for CASF and capturing it in crtc_state, and we are getting the configuration after a read back. Also, as mentioned, in previous pat

[PATCH 1/7] drm/bridge: analogix_dp: drop extra calls to analogix_dp_prepare_panel()

2025-03-31 Thread Dmitry Baryshkov
The analogix_dp_prepare_panel() returns immediately if there is no attached panel. Drop several calls to this function which are performed when dp->plat_data->panel is NULL. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 22 +- 1 file

RE: [PATCH 09/12] drm/i915/display: Set a scaler mode

2025-03-31 Thread Garg, Nemesa
> -Original Message- > From: Nautiyal, Ankit K > Sent: Tuesday, April 1, 2025 11:07 AM > To: Garg, Nemesa ; intel-...@lists.freedesktop.org; > intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH 09/12] drm/i915/display: Set a scaler mode > > > On 3/21/

Re: [PATCH 11/12] drm/i915/display: Enable/disable casf

2025-03-31 Thread Nautiyal, Ankit K
On 3/21/2025 9:36 PM, Nemesa Garg wrote: To enable or disable the sharpness check the casf_enable flag. While enabling the sharpness write the programmable coefficients, sharpness register bits and also enable the scaler. Load the filter lut value which needs to be done one time while enabling

[PATCH 6.6 3/3] drm/amd/display: Don't write DP_MSTM_CTRL after LT

2025-03-31 Thread Thadeu Lima de Souza Cascardo
From: Wayne Lin [ Upstream commit bc068194f548ef1f230d96c4398046bf59165992 ] [Why] Observe after suspend/resme, we can't light up mst monitors under specific mst hub. The reason is that driver still writes DPCD DP_MSTM_CTRL after LT. It's forbidden even we write the same value for that dpcd regi

[RFC v3 07/14] drm/sched: Consolidate entity run queue management

2025-03-31 Thread Tvrtko Ursulin
Move the code dealing with entities entering and exiting run queues to helpers to logically separate it from jobs entering and exiting entities. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_en

[RFC v3 06/14] drm/sched: Implement RR via FIFO

2025-03-31 Thread Tvrtko Ursulin
Round-robin being the non-default policy and unclear how much it is used, we can notice that it can be implemented using the FIFO data structures if we only invent a fake submit timestamp which is monotonically increasing inside drm_sched_rq instances. So instead of remembering which was the last

[RFC v3 05/14] drm/sched: Consolidate drm_sched_rq_select_entity_rr

2025-03-31 Thread Tvrtko Ursulin
Extract out two copies of the identical code to function epilogue to make it smaller and more readable. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 48 +++--- 1 f

[RFC v3 12/14] drm/sched: Embed run queue singleton into the scheduler

2025-03-31 Thread Tvrtko Ursulin
Now that the run queue to scheduler relationship is always 1:1 we can embed it (the run queue) directly in the scheduler struct and save on some allocation error handling code and such. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner

[RFC v3 13/14] drm/sched: De-clutter drm_sched_init

2025-03-31 Thread Tvrtko Ursulin
Move work queue allocation into a helper for a more streamlined function body. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 28 +- 1 file changed, 14 insertion

Re: [PATCH v2] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi wrapped functions

2025-03-31 Thread Doug Anderson
Hi, On Mon, Mar 31, 2025 at 1:28 PM Dmitry Baryshkov wrote: > > On Mon, Mar 31, 2025 at 08:06:36AM -0700, Doug Anderson wrote: > > Hi, > > > > On Sun, Mar 30, 2025 at 11:18 PM Tejas Vipin wrote: > > > > > > @@ -157,7 +137,6 @@ static int boe_bf060y8m_aj0_prepare(struct drm_panel > > > *panel) >

Re: [PATCH] drm/amd/display: replace use of msleep(<20) with usleep_range for better accuracy

2025-03-31 Thread James
On Mon, Mar 31, 2025, at 11:20 AM, Harry Wentland wrote: > Agreed. Little timing changes often have unintended effects. > I have no desire to change working code unless it's required > to fix a real-life issue. > > Harry Thanks for your explanation, and for taking the time to review. Best regar

Re: [PATCH v2 4/4] arm64: dts: rockchip: Enable HDMI1 on rock-5b

2025-03-31 Thread Sebastian Reichel
Hi, On Mon, Mar 31, 2025 at 08:01:34PM +0100, Mark Brown wrote: > On Wed, Dec 11, 2024 at 01:06:17AM +0200, Cristian Ciocaltea wrote: > > Add the necessary DT changes to enable the second HDMI output port on > > Radxa ROCK 5B. > > > > While at it, switch the position of &vop_mmu and @vop to maint

Re: [PATCH v3 1/2] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to eDP panel

2025-03-31 Thread Christopher Obbard
Hi Dmitry, On Mon, 31 Mar 2025 at 17:49, Dmitry Baryshkov wrote: > > On 31/03/2025 18:39, Christopher Obbard wrote: > > Hi Johan, > > > > On Mon, 31 Mar 2025 at 09:50, Johan Hovold wrote: > >> > >> On Thu, Mar 27, 2025 at 04:56:53PM +, Christopher Obbard wrote: > >>> The eDP panel has an HPD

Re: [PATCH v2] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi wrapped functions

2025-03-31 Thread Dmitry Baryshkov
On Mon, Mar 31, 2025 at 08:06:36AM -0700, Doug Anderson wrote: > Hi, > > On Sun, Mar 30, 2025 at 11:18 PM Tejas Vipin wrote: > > > > @@ -157,7 +137,6 @@ static int boe_bf060y8m_aj0_prepare(struct drm_panel > > *panel) > > > > ret = boe_bf060y8m_aj0_on(boe); > > if (ret < 0) { > >

Re: [PATCH v2] drm/amdkfd: Change svm_range_get_info return type

2025-03-31 Thread Felix Kuehling
On 2025-03-31 09:18, Ваторопин Андрей wrote: From: Andrey Vatoropin Static analysis shows that pointer "svms" cannot be NULL because it points to the object "struct svm_range_list". Remove the extra NULL check. It is meaningless and harms the readability of the code. In the function svm_range_

Re: [PATCH RFC 00/12] dma: Enable dmem cgroup tracking

2025-03-31 Thread Dave Airlie
On Tue, 11 Mar 2025 at 00:26, Maxime Ripard wrote: > > Hi, > > On Mon, Mar 10, 2025 at 03:16:53PM +0100, Christian König wrote: > > [Adding Ben since we are currently in the middle of a discussion > > regarding exactly that problem] > > > > Just for my understanding before I deep dive into the cod

Re: [PATCH v2] backlight: pm8941: Add NULL check in wled_configure()

2025-03-31 Thread Dmitry Baryshkov
On Mon, Mar 31, 2025 at 10:16:54PM +0800, Henry Martin wrote: > devm_kasprintf() return NULL if memory allocation fails. Currently, > wled_configure() does not check for this case, leading to a possible NULL > pointer dereference. > > Add NULL check after devm_kasprintf() to prevent this issue. >

[RFC v3 01/14] drm/sched: Add some scheduling quality unit tests

2025-03-31 Thread Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Cc: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/scheduler/tests/Makefile | 3 +- .../gpu/drm/scheduler/tests/tests_scheduler.c | 548 ++ 2 files changed, 550

[RFC v3 08/14] drm/sched: Move run queue related code into a separate file

2025-03-31 Thread Tvrtko Ursulin
Lets move all the code dealing with struct drm_sched_rq into a separate compilation unit. Advantage being sched_main.c is left with a clearer set of responsibilities. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/

[RFC v3 00/14] Deadline DRM scheduler

2025-03-31 Thread Tvrtko Ursulin
This is similar to v2 but I dropped some patches (for now) and added some new ones. Most notably deadline scaling based on queue depth appears to be able to add a little bit of fairness with spammy clients (deep submission queue). As such, on the high level main advantages of the series: 1. Code

[PATCH v3] backlight: pm8941: Add NULL check in wled_configure()

2025-03-31 Thread Henry Martin
devm_kasprintf() returns NULL when memory allocation fails. Currently, wled_configure() does not check for this case, which results in a NULL pointer dereference. Add NULL check after devm_kasprintf() to prevent this issue. Fixes: f86b77583d88 ("backlight: pm8941: Convert to using %pOFn instead o

Re: [PATCH v2 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-31 Thread Dmitry Baryshkov
On Wed, Mar 12, 2025 at 12:38:04AM +0100, Aleksandrs Vinarskis wrote: > DisplayPort requires per-segment link training when LTTPR are switched > to non-transparent mode, starting with LTTPR closest to the source. > Only when each segment is trained individually, source can link train > to sink. >

Re: [PATCH v2] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi wrapped functions

2025-03-31 Thread Dmitry Baryshkov
On Mon, Mar 31, 2025 at 03:40:27PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Mar 31, 2025 at 1:28 PM Dmitry Baryshkov > wrote: > > > > On Mon, Mar 31, 2025 at 08:06:36AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Sun, Mar 30, 2025 at 11:18 PM Tejas Vipin > > > wrote: > > > > > > >

[PATCH v5] drm/syncobj: Extend EXPORT_SYNC_FILE for timeline syncobjs

2025-03-31 Thread Rob Clark
From: Rob Clark Add support for exporting a dma_fence fd for a specific point on a timeline. This is needed for vtest/vpipe[1][2] to implement timeline syncobj support, as it needs a way to turn a point on a timeline back into a dma_fence fd. It also closes an odd omission from the syncobj UAPI

[RFC v3 09/14] drm/sched: Add deadline policy

2025-03-31 Thread Tvrtko Ursulin
Deadline scheduling policy should be a fairer flavour of FIFO with two main advantages being that it can naturally connect with the dma-fence deadlines, and secondly that it can get away with multiple run queues per scheduler. >From the latter comes the fairness advantage. Where the current FIFO p

[PATCH v2 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()

2025-03-31 Thread Lyude Paul
A negative resolution doesn't really make any sense, so let's make these parameters unsigned. In C this doesn't make much of a difference, but Rust is stricter about signed/unsigned casts and additionally can check for arithmetic over/underflows if CONFIG_RUST_OVERFLOW_CHECKS is enabled. Signed-of

[PATCH v2 2/2] drm/mode_config: Make drm_mode_config.(max|min)_(width|height) unsigned

2025-03-31 Thread Lyude Paul
It doesn't make much sense to allow devices to specify their min/max resolution as signed integers, and in Rust with CONFIG_RUST_OVERFLOW_CHECKS enabled this provides us actual over/underflow checks. Similarly, it doesn't really make much sense for us to allow devices to specify their minimum/maxim

[PATCH v2 0/2] drm: Make some resolution info unsigned

2025-03-31 Thread Lyude Paul
During the review of some of my patches for KMS bindings in Rust, it was pointed out we have some areas of DRM that are storing resolutions as signed integers when it doesn't really make sense. Since Rust has arithematic overflow checking by default in the kernel, let's change these to unsigned so

Re: [PATCH V8 11/43] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE

2025-03-31 Thread Shengyu Qu
在 2025/3/27 7:46, Alex Hung 写道: From: Harry Wentland With the introduction of the pre-blending color pipeline we can no longer have color operations that don't have a clear position in the color pipeline. We deprecate all existing plane properties. For upstream drivers those are: - COLOR_EN

Re: [RFC PATCH v2 5/6] drm/shmem: Add a helper to check object's page backing status

2025-03-31 Thread Thomas Zimmermann
Hi Am 26.03.25 um 03:14 schrieb Adrián Larumbe: Provide a helper function that lets shmem API users know whether a given object is backed by physical pages, or else in the case of a sparse shmem object, at least one of them is populated. The obvious user is fdinfo, which needs to know an object

Re: [PATCH v8 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-31 Thread Yongbang Shi
dp->aux.name = kasprintf(GFP_KERNEL, "HIBMC DRM dp aux"); As being discussed in the feedback for v7, this is a memory leak. Can you simply assign the string here? Alright!

Re: [PATCH v2] drm/bridge:anx7625: Enable DSC feature

2025-03-31 Thread Dmitry Baryshkov
On Mon, Mar 31, 2025 at 05:44:58AM +, Xin Ji wrote: > > > 4K30(3840x2160 30Hz) timing pixel clock around 297M, for 24bits RGB > > > pixel data format, total transport bandwidth need 297M*24(at least > > > 7.2Gbps) more than anx7625 mipi rx lane bandwidth(maximum 6Gbps, > > > 4lanes, each lane 1

Re: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-03-31 Thread Dmitry Baryshkov
On Mon, Mar 31, 2025 at 03:04:07AM +, Xin Ji wrote: > > > > > > > > > > > > > > > > > From: Dmitry Baryshkov > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Sent: Thursday, February 13, 2025 9:04 PM > > > > > > > > > > > > > > > > > To: Xin Ji > > > > > > > > > > > > > > >

Re: [git pull] drm for 6.15-rc1

2025-03-31 Thread Jani Nikula
On Fri, 28 Mar 2025, Linus Torvalds wrote: > If you want to do that hdrtest thing, do it as part of your *own* > checks. Don't make everybody else see that disgusting thing and have > those turds in their trees. > > I'll just disable it by marking it BROKEN for now. You guys can figure > out what

Re: [PATCH 1/2] drm/panfrost: Add PM runtime flags

2025-03-31 Thread Philippe Simons
On 3/31/25 12:32, Steven Price wrote: On 27/03/2025 12:36, Andre Przywara wrote: On Thu, 13 Mar 2025 00:23:18 +0100 Philippe Simons wrote: Hi Rob, Boris, Steven, When the GPU is the only device attached to a single power domain, core genpd disable and enable it when gpu enter and leave run

Re: [PATCH 1/4] drm: adp: Replace custom compare_dev with component_compare_of

2025-03-31 Thread Janne Grunau
On Mon, Mar 31, 2025 at 05:28:45PM +0800, shao.ming...@zte.com.cn wrote: > From: Tang Dongxing > > Remove the custom device comparison function compare_dev and replace it > with the existing kernel helper component_compare_of > > Signed-off-by: Tang Dongxing > Signed-off-by: Shao Mingyin > ---

Re: [PATCH 2/2] drm/panfrost: add h616 compatible string

2025-03-31 Thread Andre Przywara
On Mon, 31 Mar 2025 11:32:58 +0100 Steven Price wrote: Hi Steven, thanks for having a look! > On 12/03/2025 23:23, Philippe Simons wrote: > > Tie the Allwinner compatible string to the two features bits that will > > toggle the clocks and the reset line whenever the power domain is changing > >

Re: [PATCH 09/15] drm/panthor: Test for imported buffers with drm_gem_is_imported()

2025-03-31 Thread Steven Price
On 17/03/2025 13:06, Thomas Zimmermann wrote: > Instead of testing import_attach for imported GEM buffers, invoke > drm_gem_is_imported() to do the test. The helper tests the dma_buf > itself while import_attach is just an artifact of the import. Prepares > to make import_attach optional. > > Sign

Re: [PATCH] dma-buf/sw_sync: Decrement refcount on error in sw_sync_ioctl_get_deadline()

2025-03-31 Thread Christian König
Am 31.03.25 um 11:45 schrieb Dan Carpenter: > Call dma_fence_put(fence) before returning an error on this error path. > > Fixes: 70e67aaec2f4 ("dma-buf/sw_sync: Add fence deadline support") > Signed-off-by: Dan Carpenter > --- > drivers/dma-buf/sw_sync.c | 4 +++- > 1 file changed, 3 insertions(+

[PATCH 1/4] drm: adp: Replace custom compare_dev with component_compare_of

2025-03-31 Thread shao.mingyin
From: Tang Dongxing Remove the custom device comparison function compare_dev and replace it with the existing kernel helper component_compare_of Signed-off-by: Tang Dongxing Signed-off-by: Shao Mingyin --- drivers/gpu/drm/adp/adp_drv.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(

Re: [PATCH] drm/i915/gem: Convert SPDX headers to single-line format

2025-03-31 Thread Andi Shyti
Hi, On Fri, Mar 28, 2025 at 12:26:29AM +0100, Andi Shyti wrote: > Replace multi-line SPDX license headers with single-line > equivalents (// SPDX-License-Identifier: MIT or /* ... */ for > headers), as preferred by current kernel coding style. > > Signed-off-by: Andi Shyti merged to drm-intel-g

[PATCH v2] drm/amdkfd: Change svm_range_get_info return type

2025-03-31 Thread Ваторопин Андрей
From: Andrey Vatoropin Static analysis shows that pointer "svms" cannot be NULL because it points to the object "struct svm_range_list". Remove the extra NULL check. It is meaningless and harms the readability of the code. In the function svm_range_get_info() there is no possibility of failure.

Re: [PATCH 00/18] drm: Provide helpers for system framebuffers and add efidrm/vesadrm

2025-03-31 Thread Thomas Zimmermann
Hi Am 19.03.25 um 13:50 schrieb nerdopolis: [...] FYI When this gets merged, https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/common/xf86platformBus.c?ref_type=heads#L589 might need to be updated to add exceptions for vesadrm and efidrm like there is for simpledrm. I am willi

Re: [PATCH v3 1/4] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-31 Thread Maxime Ripard
On Sun, Mar 30, 2025 at 10:24:12PM -0400, Anusha Srivatsa wrote: > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index > a9c042c8dea1a82ef979c7a68204e0b55483fc28..97a5457b64fbbe9c91c6a4f41b8e1fbfe4fa604e > 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h >

Re: [PATCH v6] drm/dp: clamp PWM bit count to advertised MIN and MAX capabilities

2025-03-31 Thread Johan Hovold
On Sun, Mar 30, 2025 at 08:31:07PM +0100, Christopher Obbard wrote: > According to the eDP specification (VESA Embedded DisplayPort Standard > v1.4b, Section 3.3.10.2), if the value of DP_EDP_PWMGEN_BIT_COUNT is > less than DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN, the sink is required to use > the MIN valu

RE: [PATCH v15 0/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-31 Thread Cavitt, Jonathan
-Original Message- From: Landwerlin, Lionel G Sent: Monday, March 31, 2025 1:18 AM To: Cavitt, Jonathan ; intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; Zhang, Jianxun ; Lin, Shuicheng ; dri-devel@lists.freedesktop.org

Re: [PATCH 17/18] drm/sysfb: vesadrm: Add EDID support

2025-03-31 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Enable the connector's EDID property if edid_info contains valid > data. Exports the EDID via sysfs for user-space compositors. > > EDID information is not always available. Depending on the system > and kernel configuration, it is either provided by the boot loader >

Re: [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-03-31 Thread Pekka Paalanen
On Thu, 27 Mar 2025 17:35:39 +0100 Geert Uytterhoeven wrote: > Hi Pekka, > > On Thu, 27 Mar 2025 at 16:59, Pekka Paalanen > wrote: > > On Thu, 27 Mar 2025 16:21:16 +0200 > > Tomi Valkeinen wrote: > > > On 27/03/2025 11:20, Pekka Paalanen wrote: > > > > On Wed, 26 Mar 2025 15:55:18 +0200 >

[PATCH v9 drm-dp 9/9] drm/hisilicon/hibmc: Add vga connector detect functions

2025-03-31 Thread Yongbang Shi
From: Baihan Li Because the connected VGA connector would make driver can't get the userspace call, adding detect_ctx in vga connector to make HPD active userspace. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/hisilicon/hibmc/hibmc_dr

Re: [PATCH v15 0/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-31 Thread Lionel Landwerlin
Hi Jonathan, Are the pagefault reported for any unit in the GPU (including command streamer?) or is it limited to execution units? Thanks, -Lionel On 28/03/2025 22:40, Jonathan Cavitt wrote: Add additional information to each VM so they can report up to the first 50 seen faults. Only pagef

Re: [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-03-31 Thread Laurent Pinchart
On Mon, Mar 31, 2025 at 10:54:46AM +0300, Pekka Paalanen wrote: > On Thu, 27 Mar 2025 17:35:39 +0100 > Geert Uytterhoeven wrote: > > > Hi Pekka, > > > > On Thu, 27 Mar 2025 at 16:59, Pekka Paalanen > > wrote: > > > On Thu, 27 Mar 2025 16:21:16 +0200 > > > Tomi Valkeinen wrote: > > > > On 27/

[PATCH v9 drm-dp 6/9] drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-03-31 Thread Yongbang Shi
From: Baihan Li DP controller can support generating a color bar signal over the DisplayPort interface. This can be useful to check for possible DDR or GPU problems, as the signal generator resides completely in the DP block. Add debugfs file that controls colorbar generator. echo: config the co

[PATCH v9 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-31 Thread Yongbang Shi
From: Baihan Li Add registering drm_aux and use it to get connector edid with drm functions. Add ddc channel in connector initialization to put drm_aux in drm_connector. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v8 -> v9: - fix the lea

Re: [PATCH v3 1/2] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to eDP panel

2025-03-31 Thread Johan Hovold
On Thu, Mar 27, 2025 at 04:56:53PM +, Christopher Obbard wrote: > The eDP panel has an HPD GPIO. Describe it in the device tree > for the generic T14s model, as the HPD GPIO property is used in > both the OLED and LCD models which inherit this device tree. AFAICT, this patch is not correct as

[PATCH v9 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-31 Thread Yongbang Shi
From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v8 -> v9: - modify the adaptation of hibmc_dp_link_reduce_rate(). - fix the leak problem in hibmc_dp_aux_init(), suggested by Jani Nikula. v8: https://lore.kern

[PATCH v9 drm-dp 1/9] drm/hisilicon/hibmc: Restructuring the header dp_reg.h

2025-03-31 Thread Yongbang Shi
From: Baihan Li Move the macros below their corresponding registers to make them more obvious. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v2 -> v3: - restructuring the header dp_reg.h, suggested by Dmitry Baryshkov. --- drivers/gpu/drm

[PATCH v9 drm-dp 3/9] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-03-31 Thread Yongbang Shi
From: Baihan Li Add dp serdes cfg in link training process, and related adapting and modificating. Change some init values about training, because we want completely to negotiation process, so we start with the maximum rate and the electrical characteristic level is 0. Because serdes default cfgs

[PATCH v9 drm-dp 8/9] drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD

2025-03-31 Thread Yongbang Shi
From: Baihan Li To realize HPD feature, request irq for HPD , add its handler function. We use pci_alloc_irq_vectors() to get our msi irq, because we have two interrupts now. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v4 -> v5: - remove

[PATCH v9 drm-dp 7/9] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-31 Thread Yongbang Shi
From: Baihan Li Add HPD interrupt enable functions in drm framework, and also add detect_ctx functions. Because of the debouncing when HPD pulled out, add 200 ms delay in detect. Add link reset process to reset link status when a new connector pulgged in. Signed-off-by: Baihan Li Signed-off-by:

[PATCH v9 drm-dp 2/9] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-03-31 Thread Yongbang Shi
From: Baihan Li This dp controller need features of digital-to-analog conversion and high-speed transmission in chip by its extern serdes controller. Our serdes cfg is relatively simple, just need two register configurations. Don't need too much functions, like: power on/off, initialize, and some

[PATCH v9 drm-dp 4/9] drm/hisilicon/hibmc: Refactor the member of drm_aux in struct hibmc_dp

2025-03-31 Thread Yongbang Shi
From: Baihan Li Because the drm_aux of struct hibmc_dp_dev's member is not easy to get in hibmc_drm_dp.c, move the drm_aux to struct hibmc_dp. Then there are some adaptations and modifications to make this patch compile. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry

Re: [PATCH v2] drm/bridge:anx7625: Enable DSC feature

2025-03-31 Thread Dmitry Baryshkov
On Mon, Mar 31, 2025 at 10:28:00AM +0300, Dmitry Baryshkov wrote: > On Mon, Mar 31, 2025 at 05:44:58AM +, Xin Ji wrote: > > > > 4K30(3840x2160 30Hz) timing pixel clock around 297M, for 24bits RGB > > > > pixel data format, total transport bandwidth need 297M*24(at least > > > > 7.2Gbps) more th

Re: [PATCH] kunit: fixes backtrace suppression test module description

2025-03-31 Thread Dan Carpenter
On Sun, Mar 30, 2025 at 01:11:59PM +0800, David Gow wrote: > On Sat, 29 Mar 2025 at 23:06, Alessandro Carminati > wrote: > > > > Adds module description to the backtrace suppression test > > > > Fixes: ("19f3496") kunit: add test cases for backtrace warning suppression > > > > Signed-off-by: Ale

Re: [PATCH v9 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2025-03-31 Thread AngeloGioacchino Del Regno
Il 28/03/25 10:40, Jianeng Ceng ha scritto: Ponyta is a custom label Chromebook based on MT8186. It is a self-developed project of Huaqin and has no fixed OEM. Signed-off-by: Jianeng Ceng --- Chage in V9: - No change. Changes in v8: - PATCH 1/2: Remove custom label. - Link to v7:https://lore.

Re: [PATCH 10/18] drm/sysfb: Merge CRTC functions

2025-03-31 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Merge the CRTC functions of ofdrm and simpledrm. Replace the code > in each driver with the shared helpers. Set up callbacks with > initializer macros. > > Ofdrm supports a gamma LUT, while simpledrm does not. So far ofdrm's > LUT size has been hard-coded in the driver

[PATCH 3/4] drm: malidp: Replace custom compare_dev with component_compare_of

2025-03-31 Thread shao.mingyin
From: Tang Dongxing Remove the custom device comparison function compare_dev and replace it with the existing kernel helper component_compare_of Signed-off-by: Tang Dongxing Signed-off-by: Shao Mingyin --- drivers/gpu/drm/arm/malidp_drv.c | 9 + 1 file changed, 1 insertion(+), 8 delet

Re: [PATCH 12/18] drm/sysfb: ofdrm: Add EDID support

2025-03-31 Thread Thomas Zimmermann
Hi Am 31.03.25 um 11:26 schrieb Maxime Ripard: On Thu, Mar 20, 2025 at 02:08:56PM +0100, Thomas Zimmermann wrote: Despite the nitpicks, overall LGTM. Thanks for reviewing. Since I have your attention and you're knowledgeable wrt EDID: byte 20 of the EDID header indicates the type of output (a

Re: [PATCH] kunit: fixes Compilation error on s390

2025-03-31 Thread Heiko Carstens
On Sat, Mar 29, 2025 at 03:03:20PM +, Alessandro Carminati wrote: > The current implementation of suppressing warning backtraces uses __func__, > which is a compile-time constant only for non -fPIC compilation. > GCC's support for this situation in position-independent code varies across > vers

Re: [PATCH 14/18] drm/sysfb: Add efidrm for EFI displays

2025-03-31 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Add support for screen_info setups with VIDEO_TYPE_EFI. Provide the > minimum functionality of reading modes, updating and clearing the display. > > There is existing support for these displays provided by simpledrm with > CONFIG_SYSFB_SIMPLEFB=y. Using efidrm over sim

[PATCH] dma-buf/sw_sync: Decrement refcount on error in sw_sync_ioctl_get_deadline()

2025-03-31 Thread Dan Carpenter
Call dma_fence_put(fence) before returning an error on this error path. Fixes: 70e67aaec2f4 ("dma-buf/sw_sync: Add fence deadline support") Signed-off-by: Dan Carpenter --- drivers/dma-buf/sw_sync.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/sw_sync.c

Re: [PATCH 15/18] drm/sysfb: efidrm: Add EDID support

2025-03-31 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Enable the connector's EDID property if edid_info contains valid > data. Exports the EDID via sysfs for user-space compositors. > > EDID information is not always available. Depending on the system > and kernel configuration, it is either provided by the boot loader >

Re: [PATCH 13/18] firmware: sysfb: Move bpp-depth calculation into screen_info helper

2025-03-31 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Move the calculation of the bits per pixels for screen_info into a > helper function. This will make it available to other callers besides > the firmware code. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javie

[PATCH 0/4] Replace custom compare_dev with component_compare_of in drm

2025-03-31 Thread shao.mingyin
From: Tang Dongxing Remove the custom device comparison function compare_dev and replace it with the existing kernel helper component_compare_of, as suggested in the review feedback. This simplifies the code by eliminating redundant logic and aligns with the pattern used in other DRM drivers like

Re: [PATCH 12/18] drm/sysfb: ofdrm: Add EDID support

2025-03-31 Thread Maxime Ripard
On Thu, Mar 20, 2025 at 02:08:56PM +0100, Thomas Zimmermann wrote: > > Despite the nitpicks, overall LGTM. > > Thanks for reviewing. > > Since I have your attention and you're knowledgeable wrt EDID: byte 20 of > the EDID header indicates the type of output (analog, HDMI, DP, etc). I > intent to

Re: [PATCH 16/18] drm/sysfb: Add vesadrm for VESA displays

2025-03-31 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Add support for screen_info setups with VIDEO_TYPE_VLFB. Provide the > minimum functionality of reading modes, updating and clearing the display. > > There is existing support for these displays provided by simpledrm with > CONFIG_SYSFB_SIMPLEFB=y. Using vesadrm over s

Re: [PATCH 18/18] drm/sysfb: vesadrm: Add gamma correction

2025-03-31 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Add palette support and export GAMMA properties via sysfs. User-space > compositors can use this interface for programming gamma ramps or night > mode. > > Vesadrm supports palette updates via VGA DAC registers or VESA palette > calls. Up to 256 palette entries are ava

  1   2   >