Re: [PATCH] drm/rockchip: Add GEM create ioctl support

2020-01-23 Thread Heiko Stuebner
Hi Ezquiel, Am Mittwoch, 22. Januar 2020, 20:08:55 CET schrieb Ezequiel Garcia: > From: Mark Yao > > Add driver-specific GEM create/offset ioctls, to allow users > to create objects of arbitrary size. > > These are required to allocate buffers to be shared with > video decoder block, with hardw

Re: [PATCH v7 06/12] drm/bridge: Add the necessary bits to support bus format negotiation

2020-01-23 Thread Boris Brezillon
On Thu, 23 Jan 2020 07:52:59 + (UTC) Jonas Karlman wrote: > On 2020-01-23 08:39, Boris Brezillon wrote: > > On Wed, 22 Jan 2020 23:44:28 + (UTC) > > Jonas Karlman wrote: > > > >>> +static int > >>> +drm_atomic_bridge_chain_select_bus_fmts(struct drm_bridge *bridge, > >>> +

Re: [REPOST PATCH] drm/msm: Set dma maximum segment size for mdss

2020-01-23 Thread Sai Prakash Ranjan
Hi, On 2020-01-22 00:56, Rob Clark wrote: On Tue, Jan 21, 2020 at 11:19 AM Douglas Anderson wrote: From: Sean Paul Turning on CONFIG_DMA_API_DEBUG_SG results in the following error: [ 12.078665] msm ae0.mdss: DMA-API: mapping sg segment longer than device claims to support [len=3526

[PATCH V4 2/3] arch: mips: brcm: Add 7425 flash-edu support

2020-01-23 Thread Kamal Dasu
Nand controller v5.0 and v6.0 have nand edu blocks that enable dma nand flash transfers. This allows for faster read and write access. Signed-off-by: Kamal Dasu Acked-by: Paul Burton Reviewed-by: Florian Fainelli --- arch/mips/boot/dts/brcm/bcm7425.dtsi | 4 ++-- 1 file changed, 2 insertions(+

[PATCH] drm/i915/gvt: fix high-order allocation failure on late load

2020-01-23 Thread Igor Druzhinin
If the module happens to be loaded later at runtime there is a chance memory is already fragmented enough to fail allocation of firmware blob storage and consequently GVT init. Since it doesn't seem to be necessary to have the blob contiguous, use vmalloc() instead to avoid the issue. Signed-off-b

[PATCH 1/4] drm/msm/dpu: fix comparing pointer to 0 in dpu_encoder_phys_cmd.c

2020-01-23 Thread Zheng Bin
Fixes coccicheck warning: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:414:52-53: WARNING comparing pointer to 0 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:443:56-57: WARNING comparing pointer to 0 Reported-by: Hulk Robot Signed-off-by: Zheng Bin --- drivers/gpu/drm/msm/dis

Re: [PATCH V2 3/3] mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers

2020-01-23 Thread Kamal Dasu
On Wed, Jan 22, 2020 at 3:50 AM Miquel Raynal wrote: > > Hi Kamal, > > I'm fine with the patch, nitpicking below :) > > Kamal Dasu wrote on Tue, 21 Jan 2020 15:00:08 > -0500: > > > Legacy mips soc platforms that have controller v5.0 and 6.0 use > > flash-edu block for dma transfers. This change a

[PATCH V4 1/3] dt: bindings: brcmnand: Add support for flash-edu

2020-01-23 Thread Kamal Dasu
Adding support for EBI DMA unit (EDU). Signed-off-by: Kamal Dasu Reviewed-by: Rob Herring --- .../devicetree/bindings/mtd/brcm,brcmnand.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Document

[PATCH 4/4] drm/msm/dpu: fix comparing pointer to 0 in dpu_encoder.c

2020-01-23 Thread Zheng Bin
Fixes coccicheck warning: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:464:56-57: WARNING comparing pointer to 0 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:571:15-16: WARNING comparing pointer to 0 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:571:32-33: WARNING comparing pointer to 0 drivers/gpu

[PATCH V4 3/3] mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers

2020-01-23 Thread Kamal Dasu
Legacy mips soc platforms that have controller v5.0 and 6.0 use flash-edu block for dma transfers. This change adds support for nand dma transfers using the EDU block. Signed-off-by: Kamal Dasu --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 293 ++- 1 file changed, 287 insert

[PATCH V4 0/3] mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers

2020-01-23 Thread Kamal Dasu
V2 Changes: Refactored drivers/mtd/nand/raw/brcmnand/brcmnand.c based on initial review comments V3 Changes : No change ignore this patch set V4 changes : - Included cover letter to resend the patch set .../devicetree/bindings/mtd/brcm,brcmnand.txt - Added Reviewed-by tag arch/mips/boot/dt

[PATCH] drm/rockchip: Add GEM create ioctl support

2020-01-23 Thread Ezequiel Garcia
From: Mark Yao Add driver-specific GEM create/offset ioctls, to allow users to create objects of arbitrary size. These are required to allocate buffers to be shared with video decoder block, with hardware-specific needs such as macroblock alignment and extra room for motion vectors. Signed-off-

[PATCH 2/4] drm/msm/dpu: fix comparing pointer to 0 in dpu_encoder_phys_vid.c

2020-01-23 Thread Zheng Bin
Fixes coccicheck warning: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c:242:48-49: WARNING comparing pointer to 0 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c:562:25-26: WARNING comparing pointer to 0 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c:562:48-49: WARNING compari

Re: [PATCH -next v2] backlight: qcom-wled: fix unsigned comparison to zero

2020-01-23 Thread kgunda
On 2020-01-22 16:25, Daniel Thompson wrote: On Wed, Jan 22, 2020 at 09:32:40AM +0800, Chen Zhou wrote: Fixes coccicheck warning: ./drivers/video/backlight/qcom-wled.c:1104:5-15: WARNING: Unsigned expression compared with zero: string_len > 0 The unsigned variable string_len is assigned

Re: [RFC PATCH v3 5/7] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

2020-01-23 Thread Georgi Djakov
Hi Artur, On 12/20/19 13:56, Artur Świgoń wrote: > This patch adds interconnect functionality to the exynos-bus devfreq > driver. > > The SoC topology is a graph (or, more specifically, a tree) and its > edges are specified using the 'exynos,interconnect-parent-node' in the > DT. Due to unspecifi

[PATCH 3/4] drm/msm/dpu: fix comparing pointer to 0 in dpu_vbif.c

2020-01-23 Thread Zheng Bin
Fixes coccicheck warning: drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c:27:51-52: WARNING comparing pointer to 0 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c:109:51-52: WARNING comparing pointer to 0 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c:167:12-13: WARNING comparing pointer to 0 drivers/gpu/drm/msm/di

[PATCH] drm/omap: use true,false for bool variable

2020-01-23 Thread Zheng Bin
Fixes coccicheck warning: drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:681:1-15: WARNING: Assignment of 0/1 to bool variable drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:732:1-15: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot Signed-off-by: Zheng Bin --- drivers/g

[PATCH V3 3/3] mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers

2020-01-23 Thread Kamal Dasu
Legacy mips soc platforms that have controller v5.0 and 6.0 use flash-edu block for dma transfers. This change adds support for nand dma transfers using the EDU block. Signed-off-by: Kamal Dasu --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 296 ++- 1 file changed, 290 insert

Re: [RFC PATCH v3 4/7] arm: dts: exynos: Add interconnect bindings for Exynos4412

2020-01-23 Thread Georgi Djakov
Hi Artur, Thank you for your continuous work on this. On 12/20/19 13:56, Artur Świgoń wrote: > This patch adds the following properties to the Exynos4412 DT: > - exynos,interconnect-parent-node: to declare connections between > nodes in order to guarantee PM QoS requirements between nodes;

[PATCH 0/4] drm/msm/dpu: fix comparing pointer to 0

2020-01-23 Thread Zheng Bin
Zheng Bin (4): drm/msm/dpu: fix comparing pointer to 0 in dpu_encoder_phys_cmd.c drm/msm/dpu: fix comparing pointer to 0 in dpu_encoder_phys_vid.c drm/msm/dpu: fix comparing pointer to 0 in dpu_vbif.c drm/msm/dpu: fix comparing pointer to 0 in dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/d

Re: [PATCH v3 0/4] Use no_vblank property for drivers without VBLANK

2020-01-23 Thread Thomas Zimmermann
Hi Am 21.01.20 um 10:36 schrieb Gerd Hoffmann: > On Mon, Jan 20, 2020 at 01:20:47PM +0100, Thomas Zimmermann wrote: >> Instead of faking VBLANK events by themselves, drivers without VBLANK >> support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. >> The patchset makes this official

Re: [PATCH v7 06/12] drm/bridge: Add the necessary bits to support bus format negotiation

2020-01-23 Thread Neil Armstrong
On 23/01/2020 08:52, Jonas Karlman wrote: > On 2020-01-23 08:39, Boris Brezillon wrote: >> On Wed, 22 Jan 2020 23:44:28 + (UTC) >> Jonas Karlman wrote: >> +static int +drm_atomic_bridge_chain_select_bus_fmts(struct drm_bridge *bridge, + struct dr

[Bug 206231] R9 280X low performance with all games

2020-01-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206231 --- Comment #31 from Jacques Belosoukinski (kentos...@whiteninjastudio.com) --- Is there a reason to have such poor performance with Dirt Rally compared to the Windows version which should run at an average of 70fps during the benchmark? I noticed

Re: [[Intel-gfx] [PATCH v2 00/10] drm: Introduce struct drm_device based WARN* and use them in i915

2020-01-23 Thread Bharadiya,Pankaj
On Wed, Jan 22, 2020 at 06:22:17PM +0200, Jani Nikula wrote: > On Wed, 15 Jan 2020, Pankaj Bharadiya > wrote: > > Device specific dev_WARN and dev_WARN_ONCE macros available in kernel > > include device information in the backtrace, so we know what device > > the warnings originate from. > > > >

Re: [PATCH RFC v2 2/6] drm/sprd: add Unisoc's drm kms master

2020-01-23 Thread Thomas Zimmermann
Hi, thank you for replacing for GEM code with the generic CMA implementation. Once it's needed, we can add specialized memory management to you driver. I've looked throught your submission and think you may want to reconsider the current design. AFAICT, you have some a driver with generic code an

[PATCH v4 04/15] drm/bochs: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 9

[PATCH v4 14/15] drm/virtio: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_display

[PATCH v4 11/15] drm/st7586: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/tiny/st7586.c | 9

[PATCH v4 10/15] drm/repaper: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/tiny/repaper.c | 9 ---

[PATCH v4 15/15] drm/xen: Explicitly disable automatic sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. This would apply to xen, but xen has its own vblank logic. To avoid interfering with the atomic helpers, disable automatic vblank events explictly. v4: * separate commit from core vblank chan

[PATCH v4 02/15] drm/arc: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/arc/arcpgu_crtc.c | 16

[PATCH v4 13/15] drm/vboxvideo: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/vboxvideo/vbox_mode.c

[PATCH v4 01/15] drm: Initialize struct drm_crtc_state.no_vblank from device settings

2020-01-23 Thread Thomas Zimmermann
At the end of a commit, atomic helpers can generate a VBLANK event automatically. Originally implemented for writeback connectors, the functionality can be used by any driver and/or hardware without proper VBLANK interrupt. The patch updates the documentation to make this behaviour official: setti

[PATCH v4 06/15] drm/gm12u320: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/tiny/gm12u320.c | 9 --

[PATCH v4 12/15] drm/udl: Don't set struct drm_crtc_state.no_vblank explictly

2020-01-23 Thread Thomas Zimmermann
As udl does not initialize vblanking, atomic helpers initialize the value of struct drm_crtc_state.no_vblank to be true. No need to set it from within the driver. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/udl/udl_modeset.c | 11 --- 1 file changed, 11

[PATCH v4 05/15] drm/cirrus: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/cirrus/cirrus.c | 8 --

[PATCH v4 00/15] Use no_vblank property for drivers without VBLANK

2020-01-23 Thread Thomas Zimmermann
Instead of faking VBLANK events by themselves, drivers without VBLANK support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. The patchset makes this official and converts over drivers. The current implementation looks at state of a device wrt vblanking. If vblanking has been initial

[PATCH v4 03/15] drm/ast: Don't set struct drm_crtc_state.no_vblank explictly

2020-01-23 Thread Thomas Zimmermann
As ast does not initialize vblanking, atomic helpers initialize the value of struct drm_crtc_state.no_vblank to be true. No need to set it from within the driver. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/ast/ast_mode.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH v4 07/15] drm/ili9225: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/tiny/ili9225.c | 9 ---

[PATCH v4 08/15] drm/mipi-dbi: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/drm_mipi_dbi.c | 9 ---

[PATCH v4 09/15] drm/qxl: Remove sending of vblank event

2020-01-23 Thread Thomas Zimmermann
The atomic helpers automatically send out fake VBLANK events if no vblanking has been initialized. Remove the sending code from the driver. v4: * separate commit from core vblank changes Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 14

Re: [[Intel-gfx] [PATCH v2 00/10] drm: Introduce struct drm_device based WARN* and use them in i915

2020-01-23 Thread Jani Nikula
On Thu, 23 Jan 2020, "Bharadiya,Pankaj" wrote: > Will rebase remaining patches and submit. Please also add a patch to convert MISSING_CASE(), and another to remove the WARN_ON/WARN_ON_ONCE "overrides" that we have in i915_utils.h. Thanks, Jani. -- Jani Nikula, Intel Open Source Graphics Cente

[PATCH v8 02/12] drm/bridge: Patch atomic hooks to take a drm_bridge_state

2020-01-23 Thread Boris Brezillon
This way the drm_bridge_funcs interface is consistent with the rest of the subsystem. The only driver implementing those hooks (analogix DP) is patched too. Signed-off-by: Boris Brezillon Reviewed-by: Laurent Pinchart Signed-off-by: Neil Armstrong [narmstrong: renamed state as old_bridge_state

[PATCH v8 03/12] drm/rcar-du: Plug atomic state hooks to the default implementation

2020-01-23 Thread Boris Brezillon
This is needed to pass a bridge state to all atomic hooks, if we don't do that, the core can't duplicate/create bridge states. Signed-off-by: Boris Brezillon --- Changes in v7: * New patch --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/

[PATCH v8 10/12] drm/bridge: panel: Propage bus format/flags

2020-01-23 Thread Boris Brezillon
So that the previous bridge element in the chain knows which input format the panel bridge expects. Signed-off-by: Boris Brezillon --- Changes in v7: * Set atomic state hooks explicitly Changes in v3: * Adjust things to match the new bus-format negotiation approach * Use drm_atomic_helper_bridge

[PATCH v8 00/12] drm: Add support for bus-format negotiation

2020-01-23 Thread Boris Brezillon
Hello, This patch series aims at adding support for runtime bus-format negotiation between all elements of the 'encoder -> bridges -> connector/display' section of the pipeline. In order to support that, we need drm bridges to fully take part in the atomic state validation process, which requires

[PATCH v8 06/12] drm/bridge: Add the necessary bits to support bus format negotiation

2020-01-23 Thread Boris Brezillon
drm_bridge_state is extended to describe the input and output bus configurations. These bus configurations are exposed through the drm_bus_cfg struct which encodes the configuration of a physical bus between two components in an output pipeline, usually between two bridges, an encoder and a bridge,

[PATCH v8 09/12] dt-bindings: display: bridge: lvds-codec: Add new bus-width prop

2020-01-23 Thread Boris Brezillon
Add the bus-width property to describe the input bus format. Signed-off-by: Boris Brezillon --- Changes in v7: * Rebase on top of lvds-codec changes * Drop the data-mapping property Changes in v3: * New patch --- .../devicetree/bindings/display/bridge/lvds-codec.yaml| 8 1 file cha

[PATCH v8 07/12] drm/imx: pd: Use bus format/flags provided by the bridge when available

2020-01-23 Thread Boris Brezillon
Now that bridges can expose the bus format/flags they expect, we can use those instead of the relying on the display_info provided by the connector (which is only valid if the encoder is directly connected to bridge element driving the panel/display). We also explicitly expose the bus formats supp

[PATCH v8 05/12] drm/bridge: Add an ->atomic_check() hook

2020-01-23 Thread Boris Brezillon
So that bridge drivers have a way to check/reject an atomic operation. The drm_atomic_bridge_chain_check() (which is just a wrapper around the ->atomic_check() hook) is called in place of drm_bridge_chain_mode_fixup() (when ->atomic_check() is not implemented, the core falls back on ->mode_fixup(),

[PATCH v8 12/12] ARM: dts: imx: imx51-zii-rdu1: Fix the display pipeline definition

2020-01-23 Thread Boris Brezillon
The current definition does not represent the exact display pipeline we have on the board: the LVDS panel is actually connected through a parallel -> LVDS bridge. Let's fix that so the driver can select the proper bus format on the CRTC end. Signed-off-by: Boris Brezillon --- Changes in v7: * Non

[PATCH v8 01/12] drm/bridge: Add a drm_bridge_state object

2020-01-23 Thread Boris Brezillon
One of the last remaining objects to not have its atomic state. This is being motivated by our attempt to support runtime bus-format negotiation between elements of the bridge chain. This patch just paves the road for such a feature by adding a new drm_bridge_state object inheriting from drm_priva

[PATCH v8 08/12] drm/bridge: lvds-codec: Implement basic bus format negotiation

2020-01-23 Thread Boris Brezillon
Some DPI -> LVDS encoders might support several input bus width. Add a DT property to describe the bus width used on a specific design. Signed-off-by: Boris Brezillon --- Changes in v7: * Fix a use-after-release problem * Get rid of the data-mapping parsing * Use kmalloc instead of kcalloc. Chan

[PATCH v8 11/12] drm/panel: simple: Fix the lt089ac29000 bus_format

2020-01-23 Thread Boris Brezillon
The lt089ac29000 panel is an LVDS panel, not a DPI one. Fix the definition to reflect this fact. Signed-off-by: Boris Brezillon Suggested-by: Laurent Pinchart --- Changes in v7: * New patch --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH v8 04/12] drm/bridge: analogix: Plug atomic state hooks to the default implementation

2020-01-23 Thread Boris Brezillon
This is needed to pass a bridge state to all atomic hooks, if we don't do that, the core can't duplicate/create bridge states. Signed-off-by: Boris Brezillon --- Changes in v7: * New patch --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] drm/stm: dsi: stm mipi dsi doesn't print error on probe deferral

2020-01-23 Thread Philippe CORNU
Dears Yannick & Etienne, Thank you for your patch, Reviewed-by: Philippe Cornu Philippe :-) On 1/21/20 11:24 AM, Yannick Fertre wrote: > From: Etienne Carriere > > Change DSI driver to not print an error trace when probe > is deferred for a clock resource. > > Signed-off-by: Etienne Carriere

Re: [PATCH] drm/bridge/synopsys: dsi: missing post disable

2020-01-23 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Reviewed-by: Philippe Cornu Philippe :-) On 1/21/20 11:24 AM, Yannick Fertre wrote: > From: Yannick Fertré > > Sometime the post_disable function is missing (not registered). > > Signed-off-by: Yannick Fertré > --- > drivers/gpu/drm/bridge/synopsys/

Re: [PATCH] drm/stm: ltdc: check crtc state before enabling LIE

2020-01-23 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 1/21/20 11:14 AM, Yannick Fertre wrote: > Following investigations of a hardware bug, the LIE interrupt > can occur while the display controller is not activated. > LIE interrupt (vblank) don't have to be set if th

Re: [PATCH] drm/stm: ltdc: check number of endpoints

2020-01-23 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 1/21/20 11:14 AM, Yannick Fertre wrote: > Number of endpoints could exceed the fix value MAX_ENDPOINTS(2). > Instead of increase simply this value, the number of endpoint > could be read from device tree. Load sequ

Re: [PATCH] drm/stm: ltdc: enable/disable depends on encoder

2020-01-23 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 1/20/20 2:46 PM, Yannick Fertre wrote: > From: Yannick Fertré > > When connected to a dsi host, the ltdc display controller > must send frames only after the end of the dsi panel > initialization to avoid errors

Re: [PATCH] drm/stm: ltdc: add number of interrupts

2020-01-23 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 1/21/20 11:13 AM, Yannick Fertre wrote: > The number of interrupts depends on the ltdc version. > Don't try to get interrupt which not exist, avoiding > kernel warning messages. > > Signed-off-by: Yannick Fertre

Re: [PULL] topic/drm-warn for drm-misc-next

2020-01-23 Thread Maxime Ripard
On Wed, Jan 22, 2020 at 05:25:40PM +0200, Jani Nikula wrote: > > Hi Maarten/Maxime, > > Please pull the drm_device based drm_WARN* macros from the topic > branch. I'll pull the same to drm-intel-next-queued. > > I like to use the topic branch here, because due to timing it'll take > forever for the

[Intel-gfx] [PATCH v3 1/4] drm/i915/display: Make WARN* drm specific where drm_device ptr is available

2020-01-23 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done automatica

[Intel-gfx] [PATCH v3 0/4] drm: Introduce struct drm_device based WARN* and use them in i915

2020-01-23 Thread Pankaj Bharadiya
Device specific dev_WARN and dev_WARN_ONCE macros available in kernel include device information in the backtrace, so we know what device the warnings originate from. Similar to this, add new struct drm_device based drm_WARN* macros. These macros include device information in the backtrace, so we

[Intel-gfx] [PATCH v3 4/4] drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available

2020-01-23 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done automatica

[Intel-gfx] [PATCH v3 3/4] drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available

2020-01-23 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done automati

[Intel-gfx] [PATCH v3 2/4] drm/i915/display: Make WARN* drm specific where drm_priv ptr is available

2020-01-23 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done automati

[PATCH v4 2/2] drm/debugfs: also take per device driver features into account

2020-01-23 Thread Jani Nikula
Use drm_core_check_all_features() to ensure both the driver features and the per-device driver features are taken into account when registering debugfs files. v3: - files[i].driver_features == 0 actually means "don't care" v2: - use drm_core_check_all_features() Cc: Ville Syrjälä Cc: Thomas Zim

[PATCH v4 1/2] drm: add drm_core_check_all_features() to check for a mask of features

2020-01-23 Thread Jani Nikula
Add new drm_core_check_all_features() function to check for a mask of features. All features in the mask are required. Redefine existing drm_core_check_feature() in terms of this function, using the drm_driver_feature enum for the parameter. v3: - add drm_core_check_all_features() (Thomas) v2: -

Re: [Intel-gfx] [PATCH v3 2/2] drm/debugfs: also take per device driver features into account

2020-01-23 Thread Jani Nikula
On Wed, 22 Jan 2020, Thomas Zimmermann wrote: > Hi > > Am 22.01.20 um 16:50 schrieb Jani Nikula: >> Use drm_core_check_all_features() to ensure both the driver features and >> the per-device driver features are taken into account when registering >> debugfs files. >> >> v2: >> - use drm_core_chec

Re: [PATCH v3 2/7] uaccess: Tell user_access_begin() if it's for a write or not

2020-01-23 Thread Jani Nikula
On Thu, 23 Jan 2020, Christophe Leroy wrote: > On 32 bits powerPC (book3s/32), only write accesses to user are > protected and there is no point spending time on unlocking for reads. > > On 64 bits powerpc (book3s/64 at least), access can be granted > read only, write only or read/write. > > Add a

Re: [PATCH v2 0/5] drm/i915: conversion to new drm logging macros.

2020-01-23 Thread Jani Nikula
On Tue, 21 Jan 2020, Wambui Karuga wrote: > This series continues the conversion to the new struct drm_device based > logging macros in various files in drm/i915. These patches were > achieved both using coccinelle and manually. > > v2: rebase patches onto drm-tip to fix merge conflict in v1 serie

[PULL] drm-intel-fixes

2020-01-23 Thread Joonas Lahtinen
Hi Dave & Daniel, Last pull request for 5.5. Then it's Jani's turn to handle 5.6. A fix for huge userptr objects and a fix that is also cc stable, to correctly handle negative values in engine->uabi_class/instance. Regards, Joonas *** drm-intel-fixes-2020-01-23: - Avoid overflow with huge use

[PATCH v4 05/22] drm/amdgpu: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert amdgpu over. v2: * don't wrap existing functions; change signature instead Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++---

[PATCH v4 04/22] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-23 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert amdgpu over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 12 drivers/gpu/drm/amd/amdgpu/amdgpu_dr

[PATCH v4 01/22] drm: Remove internal setup of struct drm_device.vblank_disable_immediate

2020-01-23 Thread Thomas Zimmermann
VBLANK interrupts can be disabled immediately or with a delay, where the latter is the default. The former option can be selected by setting get_vblank_timestamp and enabling vblank_disable_immediate in struct drm_device. Simplify the code in preparation of the removal of struct drm_device.get_vbla

[PATCH v4 08/22] drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-23 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert nouveau over. v4: * add argument names in function declaration Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1

[PATCH v4 03/22] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs

2020-01-23 Thread Thomas Zimmermann
The callback get_vblank_timestamp() is currently located in struct drm_driver, but really belongs into struct drm_crtc_funcs. Add an equivalent there. Driver will be converted in separate patches. The default implementation is drm_calc_vbltimestamp_from_scanoutpos(). The patch adds drm_crtc_vblank

[PATCH v4 09/22] drm/nouveau: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert nouvean over. v4: * add argument names in function declaration Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 3 +++ drivers/gpu/drm/no

[PATCH v4 13/22] drm/msm: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert msm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 2 ++ dri

[PATCH v4 06/22] drm/gma500: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert gma500 over. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 3 +++ drivers/gpu/drm/gma500/psb_drv.c | 4

[PATCH v4 16/22] drm/sti: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert sti over. v2: * remove unnecessary include of sti_crtc.h from sti_drv.c Signed-off-by: Thomas Zimmermann Acked-by: Benjamin Gaignard --- drivers/gpu/drm/sti/sti_crtc.c |

[PATCH v4 21/22] drm: Clean-up VBLANK-related callbacks in struct drm_driver

2020-01-23 Thread Thomas Zimmermann
All non-legacy users of VBLANK functions in struct drm_driver have been converted to use the respective interfaces in struct drm_crtc_funcs. The remaining users of VBLANK callbacks in struct drm_driver are legacy drivers with userspace modesetting. All users of struct drm_driver.get_scanout_positi

[PATCH v4 17/22] drm/vc4: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-23 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 12 +++- drivers/gpu/drm/vc4/vc4_drv.c | 1 - drivers/gpu/drm/vc4

[PATCH v4 12/22] drm/msm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-23 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert mem over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 67 +++ drivers/gpu/drm/msm/disp/mdp5/mdp5_k

[PATCH v4 00/22] drm: Clean up VBLANK callbacks in struct drm_driver

2020-01-23 Thread Thomas Zimmermann
VBLANK handlers in struct drm_driver are deprecated. Only legacy, non-KMS drivers are supposed to used them. DRM drivers with kernel modesetting are supposed to use VBLANK callbacks of the CRTC infrastructure. This patchset converts all DRM drivers to CRTC VBLANK callbacks and cleans up struct drm

[PATCH v4 07/22] drm/i915: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert i915 over. The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). i915 doesn't use CRTC helpers. Instea

[PATCH v4 18/22] drm/vc4: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 1 + drivers/gpu/drm/vc4/vc4_drv.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff -

[PATCH v4 20/22] drm/vmwgfx: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vmwgfx over. v2: * remove accidental whitespace fixes Signed-off-by: Thomas Zimmermann Acked-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 --- drive

[PATCH v4 02/22] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs

2020-01-23 Thread Thomas Zimmermann
The new callback get_scanout_position() reads the current location of the scanout process. The operation is currently located in struct drm_driver, but really belongs to the CRTC. Drivers will be converted in separate patches. To help with the conversion, the timestamp calculation has been moved f

[PATCH v4 14/22] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-23 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert stm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/stm/drv.c | 1 - drivers/gpu/drm/stm/ltdc.c | 65 ++

[PATCH v4 19/22] drm/vkms: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vkms over. Signed-off-by: Thomas Zimmermann Reviewed-by: Rodrigo Siqueira Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/vkms/vkms_crtc.c | 9 ++--- drivers/gpu/drm/vkms/vk

[PATCH v4 22/22] drm: Remove legacy version of get_scanout_position()

2020-01-23 Thread Thomas Zimmermann
The legacy version of get_scanout_position() was only useful while drivers still used drm_driver.get_scanout_position(). With no such drivers left, the related typedef and code can be removed Signed-off-by: Thomas Zimmermann Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_vblank.c| 27 ++

[PATCH v4 11/22] drm/radeon: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert radeon over. Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_display.c | 12 -- drivers/gpu/drm/radeon/radeon_drv.c | 7

[PATCH v4 10/22] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-23 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert radeon over. v4: * 80-character line fixes Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/atombios_crtc.c | 1 + drivers/gpu/dr

[PATCH v4 15/22] drm/stm: Convert to CRTC VBLANK callbacks

2020-01-23 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert stm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/stm/drv.c | 1 - drivers/gpu/drm/stm/ltdc.c | 1 + 2 files changed, 1 insertion(+), 1 de

Re: [PATCH v4 2/2] drm/debugfs: also take per device driver features into account

2020-01-23 Thread Thomas Zimmermann
Am 23.01.20 um 13:48 schrieb Jani Nikula: > Use drm_core_check_all_features() to ensure both the driver features and > the per-device driver features are taken into account when registering > debugfs files. > > v3: > - files[i].driver_features == 0 actually means "don't care" > > v2: > - use dr

Re: [PATCH AUTOSEL 5.4 003/205] drm/v3d: don't leak bin job if v3d_job_init fails.

2020-01-23 Thread Sasha Levin
On Fri, Jan 17, 2020 at 08:25:30AM +0100, Iago Toral wrote: Hi Sasha, please notice that there were two separate patches that addressed the same issue and applying both simultaneously leads to a double free (which is what I see is happening with this patch: see the second call to kfree(bin) rig

Re: [PATCH] dt-bindings: restrict properties for sitronix,st7735r

2020-01-23 Thread Rob Herring
On Mon, Jan 20, 2020 at 08:02:49PM +0100, Sam Ravnborg wrote: > Hi David. > > > > +allOf: > > > + - $ref: panel/panel-common.yaml# > > > > not all of these properties are applicable. > > > > > > +required: > > > + - compatible > > > + - reg > > > + - dc-gpios > > > + - reset-gpios > > > >

[PATCH][next] drm/i915/gem: fix null pointer dereference on vm

2020-01-23 Thread Colin King
From: Colin Ian King Currently if the call to function context_get_vm_rcu returns a null pointer for vm then the error exit path via label err_put will call i915_vm_put on the null vm, causing a null pointer dereference. Fix this by adding a null check on vm and returning without calling the i91

  1   2   >