On Mon, Jan 20, 2020 at 08:02:49PM +0100, Sam Ravnborg wrote:
> Hi David.
>
> > > +allOf:
> > > + - $ref: panel/panel-common.yaml#
> >
> > not all of these properties are applicable.
> >
>
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - dc-gpios
> > > + - reset-gpios
> >
> > Missing optional rotation and backlight properties.
>
> Thanks for catching this. I have written a little .yaml files
> since I applied this - and learned a little more of the syntax.
>
> See attached patch for my attempt to fix this.
> Please review.
>
> Sam
>
> From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <s...@ravnborg.org>
> Date: Mon, 20 Jan 2020 19:55:04 +0100
> Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r
>
> David Lechner noticed (paraphrased):
> - not all properties from panel-common are applicable.
> - missing optional rotation and backlight properties
>
> Fix this by listing all allowed properties, and do not allow other properties.
>
> Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT
> schema")
> Reported-by: David Lechner <da...@lechnology.com>
> Signed-off-by: Sam Ravnborg <s...@ravnborg.org>
> Cc: Geert Uytterhoeven <geert+rene...@glider.be>
> Cc: David Lechner <da...@lechnology.com>
> Cc: Rob Herring <r...@kernel.org>
> Cc: dri-devel@lists.freedesktop.org
> ---
> .../devicetree/bindings/display/sitronix,st7735r.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
Acked-by: Rob Herring <r...@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
