[PATCH 4/4] drm/msm/dpu: fix comparing pointer to 0 in dpu_encoder.c

[Zheng Bin]

Fixes coccicheck warning:

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:464:56-57: WARNING comparing 
pointer to 0
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:571:15-16: WARNING comparing 
pointer to 0
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:571:32-33: WARNING comparing 
pointer to 0
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:571:49-50: WARNING comparing 
pointer to 0
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1968:17-18: WARNING comparing 
pointer to 0
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1981:17-18: WARNING comparing 
pointer to 0
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:2012:51-52: WARNING comparing 
pointer to 0

Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Zheng Bin <zhengbi...@huawei.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index f8ac3bf..26d3b8f 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -461,7 +461,7 @@ void dpu_encoder_helper_split_config(
        struct msm_display_info *disp_info;

        if (!phys_enc->hw_mdptop || !phys_enc->parent) {
-               DPU_ERROR("invalid arg(s), encoder %d\n", phys_enc != 0);
+               DPU_ERROR("invalid arg(s), encoder %d\n", phys_enc != NULL);
                return;
        }

@@ -568,7 +568,7 @@ static int dpu_encoder_virt_atomic_check(

        if (!drm_enc || !crtc_state || !conn_state) {
                DPU_ERROR("invalid arg(s), drm_enc %d, crtc/conn state %d/%d\n",
-                               drm_enc != 0, crtc_state != 0, conn_state != 0);
+                               drm_enc != NULL, crtc_state != NULL, conn_state 
!= NULL);
                return -EINVAL;
        }

@@ -1965,7 +1965,7 @@ static int dpu_encoder_virt_add_phys_encs(
                if (IS_ERR_OR_NULL(enc)) {
                        DPU_ERROR_ENC(dpu_enc, "failed to init vid enc: %ld\n",
                                PTR_ERR(enc));
-                       return enc == 0 ? -EINVAL : PTR_ERR(enc);
+                       return enc == NULL ? -EINVAL : PTR_ERR(enc);
                }

                dpu_enc->phys_encs[dpu_enc->num_phys_encs] = enc;
@@ -1978,7 +1978,7 @@ static int dpu_encoder_virt_add_phys_encs(
                if (IS_ERR_OR_NULL(enc)) {
                        DPU_ERROR_ENC(dpu_enc, "failed to init cmd enc: %ld\n",
                                PTR_ERR(enc));
-                       return enc == 0 ? -EINVAL : PTR_ERR(enc);
+                       return enc == NULL ? -EINVAL : PTR_ERR(enc);
                }

                dpu_enc->phys_encs[dpu_enc->num_phys_encs] = enc;
@@ -2009,7 +2009,7 @@ static int dpu_encoder_setup_display(struct 
dpu_encoder_virt *dpu_enc,
        struct dpu_enc_phys_init_params phys_params;

        if (!dpu_enc) {
-               DPU_ERROR("invalid arg(s), enc %d\n", dpu_enc != 0);
+               DPU_ERROR("invalid arg(s), enc %d\n", dpu_enc != NULL);
                return -EINVAL;
        }

--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel