Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-20 Thread Jean-Francois Moine
On Sun, 19 May 2013 10:30:00 +0200 Sebastian Hesselbarth wrote: > > /* --- test (not cubox) * > > &dcon { status = "okay"; }; > > > > &lcd1 { > > status = "okay"; > > clocks =<&core_clk 3>,<0>,<&lcdclk>,<0>; > > marvell,port-type =<1>; > > display-timings { > > mo

[RFC 4/4] DRM: tda998x: add missing include

2013-05-19 Thread Jean-Francois Moine
On Sun, 19 May 2013 10:30:00 +0200 Sebastian Hesselbarth wrote: > > /* --- test (not cubox) * > > &dcon { status = "okay"; }; > > > > &lcd1 { > > status = "okay"; > > clocks =<&core_clk 3>,<0>,<&lcdclk>,<0>; > > marvell,port-type =<1>; > > display-timings { > > mo

[RFC 4/4] DRM: tda998x: add missing include

2013-05-19 Thread Sebastian Hesselbarth
On 05/19/2013 08:01 AM, Jean-Francois Moine wrote: > On Sat, 18 May 2013 21:30:09 +0200 > Sebastian Hesselbarth wrote: >> So in the end, we will have a DT node for the HW controllers found >> in Dove SoCs, a node for TDA998x, and a node for the video card, i.e. >> _how_ lcd controllers, external e

Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-19 Thread Sebastian Hesselbarth
On 05/19/2013 08:01 AM, Jean-Francois Moine wrote: On Sat, 18 May 2013 21:30:09 +0200 Sebastian Hesselbarth wrote: So in the end, we will have a DT node for the HW controllers found in Dove SoCs, a node for TDA998x, and a node for the video card, i.e. _how_ lcd controllers, external encoders, c

Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-19 Thread Jean-Francois Moine
On Sat, 18 May 2013 21:30:09 +0200 Sebastian Hesselbarth wrote: > So in the end, we will have a DT node for the HW controllers found > in Dove SoCs, a node for TDA998x, and a node for the video card, i.e. > _how_ lcd controllers, external encoders, clocks, maybe audio, ... > are hooked up on that

[RFC 4/4] DRM: tda998x: add missing include

2013-05-19 Thread Jean-Francois Moine
On Sat, 18 May 2013 21:30:09 +0200 Sebastian Hesselbarth wrote: > So in the end, we will have a DT node for the HW controllers found > in Dove SoCs, a node for TDA998x, and a node for the video card, i.e. > _how_ lcd controllers, external encoders, clocks, maybe audio, ... > are hooked up on that

[RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Sebastian Hesselbarth
On 05/18/2013 10:26 PM, Russell King - ARM Linux wrote: > On Sat, May 18, 2013 at 09:30:09PM +0200, Sebastian Hesselbarth wrote: >> The device for tda998x yes, but not the driver. Anyway, Russel decided >> to have tda998x probed by his drm_driver. > > For the simple reason that _that_ is how DRM sl

[RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Sebastian Hesselbarth
On 05/18/2013 08:58 PM, Jean-Francois Moine wrote: > On Sat, 18 May 2013 14:23:19 -0400 > Rob Clark wrote: > >>> These parameters should not be there. It seems to me that the DT is the >>> right place. >> >> You might not want to directly have a hard DT dependency in tda998x, >> as the encoder cou

[RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Russell King - ARM Linux
On Sat, May 18, 2013 at 09:30:09PM +0200, Sebastian Hesselbarth wrote: > The device for tda998x yes, but not the driver. Anyway, Russel decided > to have tda998x probed by his drm_driver. For the simple reason that _that_ is how DRM slave encoders work. Sometimes, reading the code of the subsystem

[RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Jean-Francois Moine
On Sat, 18 May 2013 14:23:19 -0400 Rob Clark wrote: > > These parameters should not be there. It seems to me that the DT is the > > right place. > > You might not want to directly have a hard DT dependency in tda998x, > as the encoder could be used on non-DT platforms. Although a DT to > enco

[RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Sebastian Hesselbarth
On 05/18/2013 07:46 PM, Jean-Francois Moine wrote: > On Sat, 18 May 2013 19:12:19 +0200 > Sebastian Hesselbarth wrote: > >> The RFC sent by Russell King was missing an include for tda998x. This >> is just a compatible clone to remember Russell to add that later. >> >> Signed-off-by: Sebastian Hess

[RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Jean-Francois Moine
On Sat, 18 May 2013 19:12:19 +0200 Sebastian Hesselbarth wrote: > The RFC sent by Russell King was missing an include for tda998x. This > is just a compatible clone to remember Russell to add that later. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: linux-arm-kernel a

[RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Sebastian Hesselbarth
The RFC sent by Russell King was missing an include for tda998x. This is just a compatible clone to remember Russell to add that later. Signed-off-by: Sebastian Hesselbarth --- Cc: Russell King Cc: linux-arm-kernel at lists.infradead.org Cc: dri-devel at lists.freedesktop.org Cc: Jason Cooper C

Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Sebastian Hesselbarth
On 05/18/2013 10:26 PM, Russell King - ARM Linux wrote: On Sat, May 18, 2013 at 09:30:09PM +0200, Sebastian Hesselbarth wrote: The device for tda998x yes, but not the driver. Anyway, Russel decided to have tda998x probed by his drm_driver. For the simple reason that _that_ is how DRM slave enc

Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Russell King - ARM Linux
On Sat, May 18, 2013 at 09:30:09PM +0200, Sebastian Hesselbarth wrote: > The device for tda998x yes, but not the driver. Anyway, Russel decided > to have tda998x probed by his drm_driver. For the simple reason that _that_ is how DRM slave encoders work. Sometimes, reading the code of the subsystem

Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Sebastian Hesselbarth
On 05/18/2013 08:58 PM, Jean-Francois Moine wrote: On Sat, 18 May 2013 14:23:19 -0400 Rob Clark wrote: These parameters should not be there. It seems to me that the DT is the right place. You might not want to directly have a hard DT dependency in tda998x, as the encoder could be used on non

Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Jean-Francois Moine
On Sat, 18 May 2013 14:23:19 -0400 Rob Clark wrote: > > These parameters should not be there. It seems to me that the DT is the > > right place. > > You might not want to directly have a hard DT dependency in tda998x, > as the encoder could be used on non-DT platforms. Although a DT to > enco

Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Sebastian Hesselbarth
On 05/18/2013 07:46 PM, Jean-Francois Moine wrote: On Sat, 18 May 2013 19:12:19 +0200 Sebastian Hesselbarth wrote: The RFC sent by Russell King was missing an include for tda998x. This is just a compatible clone to remember Russell to add that later. Signed-off-by: Sebastian Hesselbarth ...

Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Jean-Francois Moine
On Sat, 18 May 2013 19:12:19 +0200 Sebastian Hesselbarth wrote: > The RFC sent by Russell King was missing an include for tda998x. This > is just a compatible clone to remember Russell to add that later. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: linux-arm-ker...@l

[RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Rob Clark
On Sat, May 18, 2013 at 2:58 PM, Jean-Francois Moine wrote: > On Sat, 18 May 2013 14:23:19 -0400 > Rob Clark wrote: > >> > These parameters should not be there. It seems to me that the DT is the >> > right place. >> >> You might not want to directly have a hard DT dependency in tda998x, >> as the

[RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Sebastian Hesselbarth
The RFC sent by Russell King was missing an include for tda998x. This is just a compatible clone to remember Russell to add that later. Signed-off-by: Sebastian Hesselbarth --- Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org Cc: dri-devel@lists.freedesktop.org Cc: Jason Cooper Cc: Jea

[RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Rob Clark
On Sat, May 18, 2013 at 1:46 PM, Jean-Francois Moine wrote: > On Sat, 18 May 2013 19:12:19 +0200 > Sebastian Hesselbarth wrote: > >> The RFC sent by Russell King was missing an include for tda998x. This >> is just a compatible clone to remember Russell to add that later. >> >> Signed-off-by: Seba

Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Rob Clark
On Sat, May 18, 2013 at 2:58 PM, Jean-Francois Moine wrote: > On Sat, 18 May 2013 14:23:19 -0400 > Rob Clark wrote: > >> > These parameters should not be there. It seems to me that the DT is the >> > right place. >> >> You might not want to directly have a hard DT dependency in tda998x, >> as the

Re: [RFC 4/4] DRM: tda998x: add missing include

2013-05-18 Thread Rob Clark
On Sat, May 18, 2013 at 1:46 PM, Jean-Francois Moine wrote: > On Sat, 18 May 2013 19:12:19 +0200 > Sebastian Hesselbarth wrote: > >> The RFC sent by Russell King was missing an include for tda998x. This >> is just a compatible clone to remember Russell to add that later. >> >> Signed-off-by: Seba