On Sat, May 18, 2013 at 1:46 PM, Jean-Francois Moine <moin...@free.fr> wrote:
> On Sat, 18 May 2013 19:12:19 +0200
> Sebastian Hesselbarth <sebastian.hesselba...@gmail.com> wrote:
>
>> The RFC sent by Russell King was missing an include for tda998x. This
>> is just a compatible clone to remember Russell to add that later.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselba...@gmail.com>
>> ---
>> Cc: Russell King <li...@arm.linux.org.uk>
>> Cc: linux-arm-ker...@lists.infradead.org
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: Jason Cooper <ja...@lakedaemon.net>
>> Cc: Jean-Francois Moine <moin...@free.fr>
>> ---
>> include/drm/i2c/tda998x.h | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>> create mode 100644 include/drm/i2c/tda998x.h
>>
>> diff --git a/include/drm/i2c/tda998x.h b/include/drm/i2c/tda998x.h
>> new file mode 100644
>> index 0000000..41f799f
>> --- /dev/null
>> +++ b/include/drm/i2c/tda998x.h
>> @@ -0,0 +1,23 @@
>> +#ifndef __TDA998X_H__
>> +#define __TDA998X_H__
>> +
>> +enum tda998x_audio_format {
>> + AFMT_I2S,
>> + AFMT_SPDIF,
>> +};
>> +
>> +struct tda998x_encoder_params {
>> + int audio_cfg;
>> + int audio_clk_cfg;
>> + enum tda998x_audio_format audio_format;
>> + int audio_sample_rate;
>> + char audio_frame[6];
>> + int swap_a, mirr_a;
>> + int swap_b, mirr_b;
>> + int swap_c, mirr_c;
>> + int swap_d, mirr_d;
>> + int swap_e, mirr_e;
>> + int swap_f, mirr_f;
>> +};
>> +
>> +#endif
>
> These parameters should not be there. It seems to me that the DT is the
> right place.
You might not want to directly have a hard DT dependency in tda998x,
as the encoder could be used on non-DT platforms. Although a DT to
encoder-params helper might be a nice idea for platforms which do have
DT.
BR,
-R
> --
> Ken ar c'hentañ | ** Breizh ha Linux atav! **
> Jef | http://moinejf.free.fr/
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
