[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Sharma, Shashank
I guess Daniel has already reverted the patches. Now many I know who is going to define on what should be the right way to handle aspect ratios ? Regards Shashank On 11/15/2016 7:48 PM, Ville Syrjälä wrote: > On Tue, Nov 15, 2016 at 01:48:04PM +, Jose Abreu wrote: >> Hi, >> >> >> >> On 15-

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Sharma, Shashank
Regards Shashank On 11/15/2016 7:48 PM, Ville Syrjälä wrote: > On Tue, Nov 15, 2016 at 01:48:04PM +, Jose Abreu wrote: >> Hi, >> >> >> >> On 15-11-2016 10:52, Daniel Vetter wrote: >>> On Tue, Nov 15, 2016 at 03:36:02PM +0530, Sharma, Shashank wrote: On 11/15/2016 3:30 PM, Daniel Vetter w

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Ville Syrjälä
On Tue, Nov 15, 2016 at 08:40:01PM +0530, Sharma, Shashank wrote: > Regards > Shashank > On 11/15/2016 7:48 PM, Ville Syrjälä wrote: > > On Tue, Nov 15, 2016 at 01:48:04PM +, Jose Abreu wrote: > >> Hi, > >> > >> > >> > >> On 15-11-2016 10:52, Daniel Vetter wrote: > >>> On Tue, Nov 15, 2016 at

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Ville Syrjälä
On Tue, Nov 15, 2016 at 09:18:03AM -0500, Alex Deucher wrote: > On Tue, Nov 15, 2016 at 9:03 AM, Daniel Vetter wrote: > > On Tue, Nov 15, 2016 at 03:54:42PM +0200, Ville Syrjälä wrote: > >> On Tue, Nov 15, 2016 at 11:00:04AM +0100, Daniel Vetter wrote: > >> > On Tue, Nov 15, 2016 at 02:30:47PM +

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Ville Syrjälä
On Tue, Nov 15, 2016 at 01:48:04PM +, Jose Abreu wrote: > Hi, > > > > On 15-11-2016 10:52, Daniel Vetter wrote: > > On Tue, Nov 15, 2016 at 03:36:02PM +0530, Sharma, Shashank wrote: > >> On 11/15/2016 3:30 PM, Daniel Vetter wrote: > >>> On Tue, Nov 15, 2016 at 02:30:47PM +0530, Sharma, Shash

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Ville Syrjälä
On Tue, Nov 15, 2016 at 11:00:04AM +0100, Daniel Vetter wrote: > On Tue, Nov 15, 2016 at 02:30:47PM +0530, Sharma, Shashank wrote: > > On 11/15/2016 2:21 PM, Daniel Vetter wrote: > > > On Mon, Nov 14, 2016 at 10:26:08PM +0530, Sharma, Shashank wrote: > > > > In any case, I guess addition of a cap f

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Sharma, Shashank
Regards Shashank On 11/15/2016 3:30 PM, Daniel Vetter wrote: > On Tue, Nov 15, 2016 at 02:30:47PM +0530, Sharma, Shashank wrote: >> On 11/15/2016 2:21 PM, Daniel Vetter wrote: >>> On Mon, Nov 14, 2016 at 10:26:08PM +0530, Sharma, Shashank wrote: In any case, I guess addition of a cap for as

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Daniel Vetter
On Tue, Nov 15, 2016 at 09:18:03AM -0500, Alex Deucher wrote: > On Tue, Nov 15, 2016 at 9:03 AM, Daniel Vetter wrote: > > On Tue, Nov 15, 2016 at 03:54:42PM +0200, Ville Syrjälä wrote: > >> On Tue, Nov 15, 2016 at 11:00:04AM +0100, Daniel Vetter wrote: > >> > On Tue, Nov 15, 2016 at 02:30:47PM +

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Daniel Vetter
On Tue, Nov 15, 2016 at 03:54:42PM +0200, Ville Syrjälä wrote: > On Tue, Nov 15, 2016 at 11:00:04AM +0100, Daniel Vetter wrote: > > On Tue, Nov 15, 2016 at 02:30:47PM +0530, Sharma, Shashank wrote: > > > On 11/15/2016 2:21 PM, Daniel Vetter wrote: > > > > On Mon, Nov 14, 2016 at 10:26:08PM +0530,

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Sharma, Shashank
Regards Shashank On 11/15/2016 2:21 PM, Daniel Vetter wrote: > On Mon, Nov 14, 2016 at 10:26:08PM +0530, Sharma, Shashank wrote: >> On 11/14/2016 10:15 PM, Ville Syrjälä wrote: >>> On Mon, Nov 14, 2016 at 10:12:04PM +0530, Sharma, Shashank wrote: Regards Shashank

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Jose Abreu
Hi, On 15-11-2016 10:52, Daniel Vetter wrote: > On Tue, Nov 15, 2016 at 03:36:02PM +0530, Sharma, Shashank wrote: >> On 11/15/2016 3:30 PM, Daniel Vetter wrote: >>> On Tue, Nov 15, 2016 at 02:30:47PM +0530, Sharma, Shashank wrote: On 11/15/2016 2:21 PM, Daniel Vetter wrote: > On Mon, No

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Daniel Vetter
On Tue, Nov 15, 2016 at 03:36:02PM +0530, Sharma, Shashank wrote: > On 11/15/2016 3:30 PM, Daniel Vetter wrote: > > On Tue, Nov 15, 2016 at 02:30:47PM +0530, Sharma, Shashank wrote: > > > On 11/15/2016 2:21 PM, Daniel Vetter wrote: > > > > On Mon, Nov 14, 2016 at 10:26:08PM +0530, Sharma, Shashank

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Daniel Vetter
On Tue, Nov 15, 2016 at 02:30:47PM +0530, Sharma, Shashank wrote: > On 11/15/2016 2:21 PM, Daniel Vetter wrote: > > On Mon, Nov 14, 2016 at 10:26:08PM +0530, Sharma, Shashank wrote: > > > In any case, I guess addition of a cap for aspect ratio should fix the > > > current objections for this implem

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Alex Deucher
On Tue, Nov 15, 2016 at 9:26 AM, Daniel Vetter wrote: > On Tue, Nov 15, 2016 at 09:18:03AM -0500, Alex Deucher wrote: >> On Tue, Nov 15, 2016 at 9:03 AM, Daniel Vetter wrote: >> > On Tue, Nov 15, 2016 at 03:54:42PM +0200, Ville Syrjälä wrote: >> >> On Tue, Nov 15, 2016 at 11:00:04AM +0100, Dani

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Daniel Vetter
On Mon, Nov 14, 2016 at 10:26:08PM +0530, Sharma, Shashank wrote: > On 11/14/2016 10:15 PM, Ville Syrjälä wrote: > > On Mon, Nov 14, 2016 at 10:12:04PM +0530, Sharma, Shashank wrote: > > > Regards > > > > > > Shashank > > > > > > > > > On 11/14/2016 9:50 PM, Ville Syrjälä wrote: > > > > On M

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Alex Deucher
On Tue, Nov 15, 2016 at 9:03 AM, Daniel Vetter wrote: > On Tue, Nov 15, 2016 at 03:54:42PM +0200, Ville Syrjälä wrote: >> On Tue, Nov 15, 2016 at 11:00:04AM +0100, Daniel Vetter wrote: >> > On Tue, Nov 15, 2016 at 02:30:47PM +0530, Sharma, Shashank wrote: >> > > On 11/15/2016 2:21 PM, Daniel Vet

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-14 Thread Sharma, Shashank
On 11/14/2016 10:15 PM, Ville Syrjälä wrote: > On Mon, Nov 14, 2016 at 10:12:04PM +0530, Sharma, Shashank wrote: >> Regards >> >> Shashank >> >> >> On 11/14/2016 9:50 PM, Ville Syrjälä wrote: >>> On Mon, Nov 14, 2016 at 09:37:18PM +0530, Sharma, Shashank wrote: Regards Shashank >

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-14 Thread Sharma, Shashank
Regards Shashank On 11/14/2016 9:50 PM, Ville Syrjälä wrote: > On Mon, Nov 14, 2016 at 09:37:18PM +0530, Sharma, Shashank wrote: >> Regards >> >> Shashank >> >> >> On 11/14/2016 9:19 PM, Ville Syrjälä wrote: >>> On Mon, Nov 14, 2016 at 08:14:34PM +0530, Sharma, Shashank wrote: Regards >

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-14 Thread Sharma, Shashank
Regards Shashank On 11/14/2016 9:19 PM, Ville Syrjälä wrote: > On Mon, Nov 14, 2016 at 08:14:34PM +0530, Sharma, Shashank wrote: >> Regards >> Shashank >>> the revert: >>> >>>HDMI2 connected 1920x1080+0+0 (normal left inverted right x axis y axis) >>> 700mm x 390mm >>> - 1920x1080 6

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-14 Thread Sharma, Shashank
Regards Shashank > the revert: > > HDMI2 connected 1920x1080+0+0 (normal left inverted right x axis y axis) > 700mm x 390mm > - 1920x1080 60.00*+ > - 1920x1080i60.0050.00 > + 1920x1080 60.00*+ 50.0059.9430.0025.0024.0029.97 >23.98 > + 1920x1080i

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-14 Thread Ville Syrjälä
On Mon, Nov 14, 2016 at 10:12:04PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/14/2016 9:50 PM, Ville Syrjälä wrote: > > On Mon, Nov 14, 2016 at 09:37:18PM +0530, Sharma, Shashank wrote: > >> Regards > >> > >> Shashank > >> > >> > >> On 11/14/2016 9:19 PM, Ville Syrjälä

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-14 Thread Ville Syrjälä
On Mon, Nov 14, 2016 at 09:37:18PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/14/2016 9:19 PM, Ville Syrjälä wrote: > > On Mon, Nov 14, 2016 at 08:14:34PM +0530, Sharma, Shashank wrote: > >> Regards > >> Shashank > >>> the revert: > >>> > >>>HDMI2 connected 1920x1080

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-14 Thread Ville Syrjälä
On Mon, Nov 14, 2016 at 08:14:34PM +0530, Sharma, Shashank wrote: > Regards > Shashank > > the revert: > > > > HDMI2 connected 1920x1080+0+0 (normal left inverted right x axis y axis) > > 700mm x 390mm > > - 1920x1080 60.00*+ > > - 1920x1080i60.0050.00 > > + 1920x1080 60.00

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-11 Thread Ville Syrjälä
On Fri, Nov 11, 2016 at 12:07:29PM -0500, Alex Deucher wrote: > On Fri, Nov 11, 2016 at 12:00 PM, Ville Syrjälä > wrote: > > On Thu, Nov 03, 2016 at 02:31:43PM +0200, ville.syrjala at linux.intel.com > > wrote: > >> From: Ville Syrjälä > >> > >> This reverts commit a68362fe3e84fcbedd49939aa2

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-11 Thread Ville Syrjälä
On Fri, Nov 11, 2016 at 07:00:17PM +0200, Ville Syrjälä wrote: > On Thu, Nov 03, 2016 at 02:31:43PM +0200, ville.syrjala at linux.intel.com > wrote: > > From: Ville Syrjälä > > > > This reverts commit a68362fe3e84fcbedd49939aa200519aa5410135. > > > > Adding new mode flags willy nilly breaks

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-11 Thread Ville Syrjälä
On Thu, Nov 03, 2016 at 02:31:43PM +0200, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > This reverts commit a68362fe3e84fcbedd49939aa200519aa5410135. > > Adding new mode flags willy nilly breaks existing userspace. We need to > coordinate this better, potentially with a ne

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-11 Thread Daniel Vetter
On Fri, Nov 11, 2016 at 6:07 PM, Alex Deucher wrote: >> This was with sna, which does this: >> #define KNOWN_MODE_FLAGS ((1<<14)-1) >> if (mode->status == MODE_OK && kmode->flags & ~KNOWN_MODE_FLAGS) >> mode->status = MODE_BAD; /* unknown flags => unhandled */ >> so all the modes with an

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-11 Thread Alex Deucher
On Fri, Nov 11, 2016 at 12:00 PM, Ville Syrjälä wrote: > On Thu, Nov 03, 2016 at 02:31:43PM +0200, ville.syrjala at linux.intel.com > wrote: >> From: Ville Syrjälä >> >> This reverts commit a68362fe3e84fcbedd49939aa200519aa5410135. >> >> Adding new mode flags willy nilly breaks existing user

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-07 Thread Sharma, Shashank
Regards Shashank On 11/7/2016 8:56 PM, Emil Velikov wrote: > On 7 November 2016 at 07:43, Sharma, Shashank > wrote: >> If I was not very clear for the first time, every time we send a patch to >> drm-intel/dri-devel, we do basic testing on Gnome-desktop too (Not only >> Android). >> >> So even

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-07 Thread Emil Velikov
On 7 November 2016 at 15:48, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/7/2016 8:56 PM, Emil Velikov wrote: >> >> On 7 November 2016 at 07:43, Sharma, Shashank >> wrote: >>> >>> If I was not very clear for the first time, every time we send a patch to >>> drm-intel/dri-devel, we

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-07 Thread Emil Velikov
On 7 November 2016 at 07:43, Sharma, Shashank wrote: > If I was not very clear for the first time, every time we send a patch to > drm-intel/dri-devel, we do basic testing on Gnome-desktop too (Not only > Android). > > So even these aspect ratio patches were tested with full gnome-desktop, and >

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-07 Thread Sharma, Shashank
If I was not very clear for the first time, every time we send a patch to drm-intel/dri-devel, we do basic testing on Gnome-desktop too (Not only Android). So even these aspect ratio patches were tested with full gnome-desktop, and it worked well. Regards Shashank On 11/3/2016 9:49 PM, Sharma

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-03 Thread Sharma, Shashank
On 11/3/2016 9:33 PM, Daniel Vetter wrote: > On Thu, Nov 3, 2016 at 2:49 PM, Ville Syrjälä > wrote: >>> If you still think you should send this revert, I am removing my NACK. >>> Pls Go ahead. >> The other option is to not revert and instead slap a fix on top. But >> that would have to be done

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-03 Thread Sharma, Shashank
t test with normal userspace as well. That has a long > history and so any ABI/behaviour change is actually a big deal. > >>>> >>>> NACK until we get to the right reason. >>>> >>>> Regards >>>> Shashank >>>> -----Origina

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-03 Thread Sharma, Shashank
t reason. My nack continues. >>>> >>>> Regards >>>> Shashank >>>> -Original Message- >>>> From: ville.syrjala at linux.intel.com [mailto:ville.syrjala at >>>> linux.intel.com] >>>> Sent: Thursday, November

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-03 Thread Daniel Vetter
On Thu, Nov 3, 2016 at 2:49 PM, Ville Syrjälä wrote: >> If you still think you should send this revert, I am removing my NACK. >> Pls Go ahead. > > The other option is to not revert and instead slap a fix on top. But > that would have to be done reasonably quickly so that the thing is > ready in

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-03 Thread Daniel Vetter
com] > Sent: Thursday, November 3, 2016 6:02 PM > To: dri-devel at lists.freedesktop.org > Cc: Sharma, Shashank ; Lin; Jia, Lin A > ; Sharma, Akashdeep ; > Jim Bride ; Jose Abreu synopsys.com>; Daniel Vetter ; Emil Velikov > > Subject: [PATCH 1/2] Revert "drm: Add and h

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-03 Thread Ville Syrjälä
rspace as well. That has a long > > history and so any ABI/behaviour change is actually a big deal. > > > >>>> > >>>> NACK until we get to the right reason. > >>>> > >>>> Regards > >>>> Shashank > >>>&g

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-03 Thread Ville Syrjälä
essage- > >> From: ville.syrjala at linux.intel.com [mailto:ville.syrjala at > >> linux.intel.com] > >> Sent: Thursday, November 3, 2016 6:02 PM > >> To: dri-devel at lists.freedesktop.org > >> Cc: Sharma, Shashank ; Lin; Jia, Lin A > >> ; Sharma

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-03 Thread Ville Syrjälä
t; > > linux.intel.com] > > > Sent: Thursday, November 3, 2016 6:02 PM > > > To: dri-devel at lists.freedesktop.org > > > Cc: Sharma, Shashank ; Lin; Jia, Lin A > > > ; Sharma, Akashdeep > > intel.com>; Jim Bride ; Jose Abreu > >

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-03 Thread Ville Syrjälä
6:02 PM > > To: dri-devel at lists.freedesktop.org > > Cc: Sharma, Shashank ; Lin; Jia, Lin A > > ; Sharma, Akashdeep > intel.com>; Jim Bride ; Jose Abreu > > ; Daniel Vetter ; > > Emil Velikov > > Subject: [PATCH 1/2] Revert "drm: Add and handle ne

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-03 Thread ville.syrj...@linux.intel.com
From: Ville Syrjälä This reverts commit a68362fe3e84fcbedd49939aa200519aa5410135. Adding new mode flags willy nilly breaks existing userspace. We need to coordinate this better, potentially with a new client cap that only exposes the aspect ratio flags when userspace is prepared for them (simi