On 04/09/2025 01:08, Adrián Larumbe wrote:
> From: Boris Brezillon
>
> Minor revision of the driver must be bumped because this expands the
> uAPI. On top of that, let user know the available priorities so that
> they can create contexts with legal priority values.
>
> Signed-off-by: Boris Brezi
On 19/09/2025 09:07, Steven Price wrote:
> Commit a017f7b86051 ("drm/panfrost: Expose JM context IOCTLs to UM")
> added new ioctls to the driver and was meant to bump the version number.
> However it actually only added a comment and didn't change the exposed
> version
On 04/09/2025 01:08, Adrián Larumbe wrote:
> From: Boris Brezillon
>
> A JM context describes GPU HW resourdce allocation for the jobs bound to
> it. At the time of writing this, it only holds the JS and queue
> scheduler priorities.
>
> When a context is created, all the scheduler entities crea
comment.
Fixes: a017f7b86051 ("drm/panfrost: Expose JM context IOCTLs to UM")
Reviewed-by: Boris Brezillon
Signed-off-by: Steven Price
---
drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c
b
On 28/08/2025 21:04, Chia-I Wu wrote:
> It is unclear why fence errors were set only for CS_INHERIT_FAULT.
> Downstream driver also does not treat CS_INHERIT_FAULT specially.
> Remove the check.
>
> Signed-off-by: Chia-I Wu
> Reviewed-by: Boris Brezillon
Reviewed-by: Steven
On 17/09/2025 20:18, Adrián Larumbe wrote:
> This patch series brings the notion of JM contexts into Panfrost.
> UM will be able to create contexts, get a handle for them and attach
> it to a job submission. Contexts describe basic HW resource assignment
> to jobs, but at the moment that includes p
> Until context creation and destruction are exposed to UM, all issued
> jobs shall be bound to the default Panfrost file context, which has
> medium priority.
>
> Signed-off-by: Boris Brezillon
> Signed-off-by: Adrián Larumbe
Reviewed-by: Steven Price
> ---
>
Signed-off-by: Boris Brezillon
> Signed-off-by: Adrián Larumbe
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 36 ++---
> 1 file changed, 33 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfr
>
> For every context, show the DRM scheduler priority value of all of its
> scheduling entities.
>
> Signed-off-by: Boris Brezillon
> Signed-off-by: Adrián Larumbe
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 96 +++
On 12/09/2025 14:19, Adrián Larumbe wrote:
> From: Boris Brezillon
>
> A JM context describes user-requested priorities for the JM queues.
>
> Context creation leads to the initialization of scheduling entities of
> the same priority for all the device's job slots.
>
> Until context creation an
he driver in the cover letter and patch 1.
> - Improved the commit message for patch 1.
> Link to v1:
> https://lore.kernel.org/dri-devel/20250828130402.2549948-1-daniel.alme...@collabora.com/
Looks good to me, and all the tests now pass (using Panthor) on my Rock5B.
Tested-by: Steven Pr
On 02/09/2025 21:06, Chia-I Wu wrote:
> Userspace relies on the ring field of gpu_scheduler tracepoints to
> identify a drm_gpu_scheduler. The value of the ring field is taken from
> sched->name.
>
> Because we typically have multiple schedulers running in parallel in
> each process, assign uniqu
On 05/09/2025 11:23, Nicolas Frattaroli wrote:
> The only device-specific part of panthor's get_dev_status devfreq
> callback is getting the clock frequency. All the other logic surrounding
> what it does may be useful for other devfreq implementations however.
>
> Expose it in the panthor_devfreq
On 10/09/2025 17:50, Boris Brezillon wrote:
> On Wed, 10 Sep 2025 16:56:43 +0100
> Steven Price wrote:
>
>> On 10/09/2025 16:52, Boris Brezillon wrote:
>>> On Wed, 10 Sep 2025 16:42:32 +0100
>>> Steven Price wrote:
>>>
>>>&
On 10/09/2025 16:52, Boris Brezillon wrote:
> On Wed, 10 Sep 2025 16:42:32 +0100
> Steven Price wrote:
>
>>> +int panfrost_jm_ctx_create(struct drm_file *file,
>>> + struct drm_panfrost_jm_ctx_create *args)
>>> +{
>>> + struct
On 04/09/2025 01:08, Adrián Larumbe wrote:
> From: Boris Brezillon
>
> For DebugFS builds, create a filesystem knob that, for every single open
> file of the Panfrost DRM device, shows its command name information and
> PID (when applicable), and all of its existing JM contexts.
>
> For every co
d
> destruction ioctls.
>
> Signed-off-by: Boris Brezillon
> Signed-off-by: Adrián Larumbe
Reviewed-by: Steven Price
> ---
> include/uapi/drm/panfrost_drm.h | 50 +
> 1 file changed, 50 insertions(+)
>
> diff --git a/include/
t_cur_freq operation, and expose it through a
> helper function to the rest of panthor.
>
> Signed-off-by: Nicolas Frattaroli
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_devfreq.c | 33
> +++
> drivers/gpu/drm/panthor/pantho
On 05/09/2025 11:23, Nicolas Frattaroli wrote:
> On some devices, devfreq is not controlled directly by DT OPPs and the
> common clock framework, but through an external devfreq driver. To
> permit this type of usage, add the concept of devfreq providers.
>
> Devfreq providers for panthor register
coming MediaTek
> MFG devfreq can use it as well.
>
> Signed-off-by: Nicolas Frattaroli
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_devfreq.c | 32 ---
> drivers/gpu/drm/panthor/panthor_devfreq.h | 36
> ++
On 03/09/2025 20:21, Chia-I Wu wrote:
> A panthor group can have at most MAX_CS_PER_CSG panthor queues.
>
> Fixes: 4bdca11507928 ("drm/panthor: Add the driver frontend block")
> Signed-off-by: Chia-I Wu
> Reviewed-by: Boris Brezillon # v1
> Reviewed-by: Steven Pric
each process, assign unique names to schedulers such that userspace can
> distinguish them.
>
> Signed-off-by: Chia-I Wu
Reviewed-by: Steven Price
>
> ---
>
> v2:
> - include drm_client_id in the name to be truly unique
> - remove unnecessary NULL in drm_sched_init_a
up_args->queues.count > MAX_CS_PER_CSG)
> + return -EINVAL;
> +
I think this check would be better moved up to
panthor_ioctl_group_create() (where we already have a zero check). But
either way:
Reviewed-by: Steven Price
Thanks,
Steve
> group = kzalloc(sizeof(*group), GFP_KERNEL);
> if (!group)
> return -ENOMEM;
On 28/08/2025 21:01, Chia-I Wu wrote:
> Fail early from panthor_vm_bind_prepare_op_ctx instead of late from
> ops->map_pages.
>
> Signed-off-by: Chia-I Wu
> Reviewed-by: Boris Brezillon
Reviewed-by: Steven Price
I'll push this to drm-misc-next.
Thanks,
Steve
&
Hi Boris,
On 01/09/2025 13:14, Boris Brezillon wrote:
> Hi Steve,
>
> On Mon, 1 Sep 2025 11:52:02 +0100
> Steven Price wrote:
>
>> On 28/08/2025 03:34, Adrián Larumbe wrote:
>>> From: Boris Brezillon
>>>
>>> The new uAPI lets user space query
On 01/09/2025 13:08, Adrián Larumbe wrote:
> Hi Steven,
>
> On 01.09.2025 11:52, Steven Price wrote:
>>
>> On 28/08/2025 03:34, Adrián Larumbe wrote:
>>> From: Boris Brezillon
>>>
>>> The new uAPI lets user space query the KM driver for the avail
On 28/08/2025 03:34, Adrián Larumbe wrote:
> From: Boris Brezillon
>
> The new uAPI lets user space query the KM driver for the available
> priorities a job can be given at submit time. These are managed through
> the notion of a context, which besides a priority, codifies the list
> of L2 caches
On 28/08/2025 21:18, Chia-I Wu wrote:
> Some socs such as mt8196 require custom ASN hash.
I don't know the full details of this, but I'm puzzled by the "require"
here.
AIUI the "custom ASN hash support" (or L2C_SLICE_HASH as it was renamed)
affects the efficiency of the L2 caches in the GPU. It b
On 28/08/2025 21:18, Chia-I Wu wrote:
> Parse asn-hash and enable custom ASN hash when the property exists.
> This is required on some socs such as mt8196.
>
> Signed-off-by: Chia-I Wu
This mostly looks fine, although there is a question of naming. This was
renamed in a later version of the arch
each process, assign unique names to schedulers such that userspace can
> distinguish them.
>
> Signed-off-by: Chia-I Wu
One nit below, but otherwise:
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 32 ++---
> 1 file changed, 23
Hi Daniel,
A couple of errors that I hit when I tested this are below.
On 28/08/2025 14:04, Daniel Almeida wrote:
> Add an initial test suit covering query device properties, allocating
> memory, binding and unbinding VA ranges through VM_BIND and submitting a
> simple piece of work through GROUP
On 28/08/2025 14:03, Daniel Almeida wrote:
> We will be adding tests for Panthor in a subsequent patch, so first add
> the ability to open the device.
>
> Signed-off-by: Daniel Almeida
There's also chipset_to_str() which should be updated to return the
correct name. Although I think that only ma
On 15/08/2025 14:42, Steven Price wrote:
> The only callers to mmu_hw_do_operation_locked() pass an 'op' of either
> AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. This means the code paths
> after that are dead. Removing those paths means the
> mmu_hw_do_flush_on_gpu_ctrl() f
On 21/08/2025 12:51, Boris Brezillon wrote:
> On Wed, 16 Jul 2025 16:43:24 +0100
> Steven Price wrote:
[...]
>> Although in general I'm a bit wary of relying on the whole lock region
>> feature - previous GPUs have an errata. But maybe I'm being over
>> cautious
On 04/07/2025 10:18, Steven Price wrote:
> On 04/07/2025 08:54, Sakari Ailus wrote:
>> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
>> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
>> to pm_runtime_mark_last_busy(). Remove the n
On 15/08/2025 15:01, Karunika Choo wrote:
> On 15/08/2025 14:42, Steven Price wrote:
>> The only callers to mmu_hw_do_operation_locked() pass an 'op' of either
>> AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. This means the code paths
>> after that are dead.
y having a switch statement for the type of 'op'
(warning if we get an unexpected value) and removing the dead cases.
Suggested-by: Daniel Stone
Signed-off-by: Steven Price
---
Changes from v1:
* As well as removing dead code, inline mmu_hw_do_flush_on_gpu_ctrl
drivers/gpu/drm/pantho
On 15/08/2025 12:17, Daniel Stone wrote:
> Hi Steven,
>
> On Fri, 15 Aug 2025 at 11:25, Steven Price wrote:
>> The only callers to mmu_hw_do_operation_locked() pass an 'op' of either
>> AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. So remove the code paths
>> t
ned-off-by: Steven Price
---
drivers/gpu/drm/panthor/panthor_mmu.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c
b/drivers/gpu/drm/panthor/panthor_mmu.c
index 367c89aca558..b16f44aec725 100644
--- a/drivers/gpu/drm/panthor/pan
On 14/08/2025 23:58, Liviu Dudau wrote:
> On Fri, Aug 08, 2025 at 11:50:27AM +0100, Daniel Stone wrote:
>> Hi Karunika,
>>
>>
>> On Thu, 7 Aug 2025 at 17:27, Karunika Choo wrote:
>>> @@ -585,6 +615,9 @@ static int mmu_hw_do_operation_locked(struct
>>> panthor_device *ptdev, int as_nr,
>>>
flushes are completed instead of dropped.
>
> Reviewed-by: Liviu Dudau
> Co-developed-by: Dennis Tsiang
> Signed-off-by: Dennis Tsiang
> Signed-off-by: Karunika Choo
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_gpu.c | 7 +++
> 1 file change
On 31/07/2025 13:48, Karunika Choo wrote:
> On 31/07/2025 11:57, Steven Price wrote:
>> On 30/07/2025 18:43, Karunika Choo wrote:
>>> In certain scenarios, it is possible for multiple cache flushes to be
>>> requested before the previous one completes
On 30/07/2025 18:43, Karunika Choo wrote:
> In certain scenarios, it is possible for multiple cache flushes to be
> requested before the previous one completes. This patch introduces the
> cache_flush_lock mutex to serialize these operations and ensure that
> any requested cache flushes are complet
On 29/07/2025 14:47, Alexandre Courbot wrote:
> On Mon Jul 28, 2025 at 10:25 PM JST, Steven Price wrote:
>> On 28/07/2025 12:43, Alexandre Courbot wrote:
>>> On Mon Jul 28, 2025 at 4:51 PM JST, Steven Price wrote:
>>>> On 28/07/2025 05:59, Alexandre Courbot wrote:
&
On 28/07/2025 12:43, Alexandre Courbot wrote:
> On Mon Jul 28, 2025 at 4:51 PM JST, Steven Price wrote:
>> On 28/07/2025 05:59, Alexandre Courbot wrote:
>>> Hi Daniel, thanks for the review!
>>>
>>> On Sat Jul 26, 2025 at 1:14 AM JST, Daniel Almeida wrote:
On 20/07/2025 01:01, Chia-I Wu wrote:
> Create a devcoredump on any faulty or fatal event. The coredump data is
> in YAML format for readability and flexibility.
>
> Only panthor_group state is captured for now.
>
> Signed-off-by: Chia-I Wu
> ---
> drivers/gpu/drm/panthor/Makefile |
this module provides an intuitive and
>>> readable syntax for defining a
>>> +//! dedicated type for each register. Each such type comes with its own
>>> field accessors that can
>>> +//! return an error if a field's value is invalid.
>>>
>&
On 18/07/2025 07:38, Chia-I Wu wrote:
> This series saves task pid and comm in panthor_group and prints task pid and
> comm on gpu errors.
>
> v3: fix new kerneldoc warnings
> v2: save the task info in panthor_group on panthor_group_create, rather than
> in panthor_file on panthor_open, becaus
On 24/07/2025 13:42, Karunika Choo wrote:
> This patch adds firmware binary and GPU model naming support for
> Mali-Gx20 and Mali-Gx25 GPUs.
>
> Signed-off-by: Karunika Choo
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 2 ++
> drivers/gpu/drm
On 24/07/2025 10:26, Karunika Choo wrote:
> This patch adds firmware binary and GPU model naming support for
> Mali-Gx20 and Mali-Gx25 GPUs.
>
> The GPU_COHERENCY_FEATURES macros are slightly reworked as the
> assumption that FEATURE = BIT(PROTOCOL) no longer holds with the
> introduction of the S
s.
>
> Mali-Gx10 and Mali-Gx15 GPUs also has support for the FLUSH_CACHES
> command and will also use this by default going forward.
>
> Reviewed-by: Chia-I Wu
> Reviewed-by: Liviu Dudau
> Signed-off-by: Karunika Choo
Reviewed-by: Steven Price
> ---
> dri
ewed-by: Liviu Dudau
> Signed-off-by: Karunika Choo
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 1 +
> drivers/gpu/drm/panthor/panthor_hw.c | 15 +++
> drivers/gpu/drm/panthor/panthor_regs.h | 3 +++
> include/uapi/drm/panthor_drm.h
ng of the function to
> accommodate naming differences based on supported GPU features.
>
> Reviewed-by: Chia-I Wu
> Reviewed-by: Liviu Dudau
> Signed-off-by: Karunika Choo
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_hw.c | 61 --
; case GPU_PROD_ID_MAKE(10, 7):
> return "Mali-G610";
> + case GPU_PROD_ID_MAKE(10, 3):
> + return "Mali-G510";
> + case GPU_PROD_ID_MAKE(10, 4):
> + return "Mali-G310";
Chia-I Wu pointed out these don't appear to have any logical ordering.
I'd suggest ordering by arch major/product major.
With that fixed:
Reviewed-by: Steven Price
> }
>
> return "(Unknown Mali GPU)";
-I Wu
> Reviewed-by: Liviu Dudau
> Signed-off-by: Karunika Choo
One minor nit (see below), but otherwise:
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/Makefile | 1 +
> drivers/gpu/drm/panthor/panthor_device.c | 5 +
> drivers/gpu/drm/panthor/pantho
On 13/11/2024 21:03, Jann Horn wrote:
> When bailing out due to group_priority_permit() failure, the queue_args
> need to be freed. Fix it by rearranging the function to use the
> goto-on-error pattern, such that the success case flows straight without
> indentation while error cases jump forward t
On 13/07/2025 04:08, Chia-I Wu wrote:
> It is useful to know which tasks cause gpu errors.
>
> Signed-off-by: Chia-I Wu
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 24 +++-
> 1 file changed, 19 insertions(+), 5 deletions(
f-by: Chia-I Wu
One nit below, but with that fixed:
Reviewed-by: Steven Price
>
> ---
> v2: save to panthor_group on panthor_group_create rather than to
> panthor_file on panthor_open
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 19 +++
> 1 file c
On 10/07/2025 04:05, lihongtao wrote:
> obj->mappings.lock should be destroyed when free
> panfrost gem object in panfrost_gem_free_object.
mutex_destroy() doesn't actually release any resources. It is purely a
debugging feature (if CONFIG_DEBUG_MUTEXES is disabled then it is
compiled away complet
On 15/07/2025 16:17, Caterina Shablia wrote:
> El viernes, 11 de julio de 2025 16:03:26 (hora de verano de Europa central),
> Steven Price escribió:
>> On 07/07/2025 18:04, Caterina Shablia wrote:
>>> From: Boris Brezillon
>>>
>>> This allows us to
On 15/07/2025 17:09, Caterina Shablia wrote:
> El martes, 15 de julio de 2025 17:08:09 (hora de verano de Europa central),
> Caterina Shablia escribió:
>> El viernes, 11 de julio de 2025 15:30:21 (hora de verano de Europa central),
>> Steven Price escribió:
>>> On
On 15/07/2025 16:33, Caterina Shablia wrote:
> El martes, 15 de julio de 2025 17:08:09 (hora de verano de Europa central),
> Caterina Shablia escribió:
>> El viernes, 11 de julio de 2025 15:30:21 (hora de verano de Europa central),
>> Steven Price escribió:
>>> On
On 11/07/2025 16:45, Adrián Larumbe wrote:
> Commit ec62d37d2c0d("drm/panthor: Fix the fast-reset logic") did away
> with the only reference to panthor_vm_flush_all(), so let's get rid
> of the orphaned definition.
>
> Signed-off-by: Adrián Larumbe
Reviewed-by: St
On 07/07/2025 18:04, Caterina Shablia wrote:
> From: Boris Brezillon
>
> This allows us to optimize mapping of a relatively small
> portion of a BO over and over in a large VA range, which
> is useful to support Vulkan sparse bindings in an efficient
> way.
>
> Signed-off-by: Boris Brezillon
>
On 07/07/2025 18:04, Caterina Shablia wrote:
> From: Boris Brezillon
>
> drm_gpuva_init() only has one internal user, and given we are about to
> add new optional fields, it only add maintenance burden for no real
> benefit, so let's kill the thing now.
Commit 111fdd2198e6 ("drm/msm: drm_gpuvm c
On 07/07/2025 18:04, Caterina Shablia wrote:
> From: Boris Brezillon
>
> Move the lock/flush_mem operations around the gpuvm_sm_map() calls so
> we can implement true atomic page updates, where any access in the
> locked range done by the GPU has to wait for the page table updates
> to land befor
On 10/07/2025 09:53, Simona Vetter wrote:
> On Wed, Jul 09, 2025 at 04:48:21PM +0100, Steven Price wrote:
>> On 09/07/2025 14:52, Simona Vetter wrote:
>>> The object is potentially already gone after the drm_gem_object_put().
>>> In general the object should be fully
of DRM GEM objects
> over DebugFS")
> Cc: Adrián Larumbe
> Cc: Boris Brezillon
> Cc: Steven Price
> Cc: Liviu Dudau
> Reviewed-by: Liviu Dudau
> Signed-off-by: Simona Vetter
> Signed-off-by: Simona Vetter
Reviewed-by: Steven Price
Although a nit on the email
hed_init() params")
> Reported-by: Tvrtko Ursulin
> Closes:
> https://lore.kernel.org/dri-devel/b5d0921c-7cbf-4d55-aa47-c35cd7861...@igalia.com/
> Signed-off-by: Philipp Stanner
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 2 +-
> 1 file chang
el-simple.c | 2 --
> drivers/gpu/drm/panthor/panthor_sched.c| 2 --
Panthor changes are:
Reviewed-by: Steven Price
Thanks,
Steve
> drivers/gpu/drm/tegra/submit.c | 1 -
> drivers/gpu/drm/tidss/tidss_drv.c | 2 --
> driv
rk_last_busy().
>
> Signed-off-by: Sakari Ailus
Reviewed-by: Steven Price
But this can't be merged via drm-misc until the PM changes have hit
Linus' tree and been backmerged to drm-misc-next.
Thanks,
Steve
> ---
> The cover letter of the set can be found here
> https://lore.kerne
On 30/06/2025 15:07, Steven Price wrote:
> panthor_gpu_block_power_on() takes a register offset (rdy_reg) for the
> purpose of waiting for the power transition to complete. However, a
> copy/paste error converting to use the new 64 register functions
> switched it to using the
Hi Daniel,
On 30/06/2025 15:56, Daniel Almeida wrote:
> Hi Steven,
>
>> On 30 Jun 2025, at 07:11, Steven Price wrote:
>>
>> Hi Daniel,
>>
>> My Rust is still quite weak, so I'll just review the GPU-specific parts.
>> Please CC me on future posts.
register.
Fixes: 4d230aa209ed ("drm/panthor: Add 64-bit and poll register accessors")
Signed-off-by: Steven Price
---
drivers/gpu/drm/panthor/panthor_gpu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c
b/drivers/gpu/d
Hi Daniel,
My Rust is still quite weak, so I'll just review the GPU-specific parts.
Please CC me on future posts.
On 27/06/2025 23:34, Daniel Almeida wrote:
> Add a Rust driver for ARM Mali CSF-based GPUs. It is a port of Panthor
> and therefore exposes Panthor's uAPI and name to userspace, and t
Hi Karunika,
On 02/06/2025 15:32, Karunika Choo wrote:
> This patch series introduces a GPU HW abstraction to Panthor, to enable
> support for new Mali GPUs.
>
> Key changes:
> - Addition of GPU-specific initialization framework to standardize and
> streamline support new GPUs.
> - Support for
On 02/06/2025 15:32, Karunika Choo wrote:
> As the FLUSH_MEM and FLUSH_PT commands are deprecated in GPUs from
> Mali-Gx20 onwards, this patch adds support for performing cache
> maintenance via the FLUSH_CACHES command in GPU_CONTROL, in place of
NIT: s/GPU_CONTROL/GPU_COMMAND/ (also in the subje
On 21/06/2025 00:50, Chia-I Wu wrote:
> It allows us to get rid of manual try_module_get / module_put.
>
> Signed-off-by: Chia-I Wu
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 14 +++---
> 1 file changed, 3 insertions(+), 11 deletions(
Hi Lukas,
I was going to try testing this out, but it doesn't look functional. See
below.
On 16/05/2025 16:49, Lukas Zapolskas wrote:
[...]
> diff --git a/drivers/gpu/drm/panthor/panthor_perf.c
> b/drivers/gpu/drm/panthor/panthor_perf.c
> index 9365ce9fed04..15fa533731f3 100644
> --- a/drivers/g
All 5 patches push to drm-misc-next.
Thanks,
Steve
On 09/05/2025 11:12, Louis-Alexis Eyraud wrote:
> This patchset adds the support of the ARM Mali G57 MC2 GPU (Valhall-JM,
> dual core), integrated in the Mediatek MT8370 SoC, to the panfrost
> driver and to the mt8370.dtsi include file.
>
> Sinc
thor: Add the scheduler logical block")
> ---
> Signed-off-by: Ashley Smith
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 233 +---
> 1 file changed, 167 insertions(+), 66 deletions(-)
>
> diff --git a/drivers/gpu/drm/pa
t terminated correctly.
>
> Signed-off-by: Ashley Smith
> Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
&
ugh a new ioctl().
>
> Signed-off-by: Adrián Larumbe
> Reviewed-by: Steven Price
All 5 patches pushed to drm-misc.
Thanks,
Steve
conventions.
>
> Signed-off-by: Adrián Larumbe
> Fixes: 64111a0e22a9 ("drm/panfrost: Fix incorrect updating of current device
> frequency")
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 4 ++--
> 1 file changed, 2 inserti
gs, since Panfrost has no kernel-only BO's.
>
> Two additional GEM state flags which are displayed but aren't relevant
> to Panthor are 'Purged' and 'Purgeable', since Panfrost implements an
> explicit shrinker and a madvise ioctl to flag objects as re
creation, they might remain
> unlabelled for their entire lifetime, so a generic tag was deemed
> preferable. The tag is assigned before a UM handle is created so it
> doesn't contradict the logic about labelling internal BOs.
>
> Signed-off-by: Adrián Larumbe
Reviewed-by: Stev
t terminated correctly.
>
> Signed-off-by: Ashley Smith
Reviewed-by: Steven Price
> ---
> Changes in v2:
> - Fixed syntax error
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/dr
On 15/05/2025 19:04, Daniel Stone wrote:
> Hi Steven,
>
> On Thu, 8 May 2025 at 11:42, Steven Price wrote:
>> I'm also seeing a splat when running this, see below. I haven't got my
>> head around how this is happening, but I see it when glmark quits at the
>>
On 15/05/2025 11:33, Ashley Smith wrote:
> This fixes a bug where if we timeout after a suspend and the termination
> fails, due to waiting on a fence that will never be signalled for
> example, we do not resume the group correctly. The fix forces a reset
> for groups that are not terminated correc
latform data).
>
> So drop these duplicated definitions and use default_supplies instead.
> Also, rename mediatek_mt8183_supplies to a more generic name too
> (legacy_supplies).
>
> Signed-off-by: Louis-Alexis Eyraud
Thanks for doing this.
Reviewed-by: Steven Price
>
ries, if the num_pm_domains field of the platform data is also
> set to the matching core number.
>
> So, create a generic power domain array (mediatek_pm_domains) and use
> it in the mt8183(b), mt8186, mt8188 and mt8192 platform data instead.
>
> Signed-off-by: Louis-Alexis Eyraud
avoid such leaks, use the DRM_GPU_SCHED_STAT_RUNNING status to skip the
> reset and rearm the timer.
>
> Signed-off-by: Maíra Canal
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> dif
On 07/05/2025 17:07, Adrián Larumbe wrote:
> This change is essentially a Panfrost port of commit a3707f53eb3f
> ("drm/panthor: show device-wide list of DRM GEM objects over DebugFS").
>
> The DebugFS file is almost the same as in Panthor, minus the GEM object
> usage flags, since Panfrost has no
ut modifying MT8186
> configuration and behaviour.
>
> Signed-off-by: Louis-Alexis Eyraud
With one minor comment fixed below:
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git
On 24/04/2025 03:21, Adrián Larumbe wrote:
> Allow UM to label a BO for which it possesses a DRM handle.
>
> Signed-off-by: Adrián Larumbe
Minor comments below, but otherwise:
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 44 +
that will allow
> UM to set BO labels through a new ioctl().
>
> Signed-off-by: Adrián Larumbe
Reviewed-by: Steven Price
But one comment below
> ---
> drivers/gpu/drm/panfrost/panfrost_gem.c | 19 +++
> drivers/gpu/drm/panfrost/panfrost_gem.h | 16
On 28/04/2025 07:10, Philippe Simons wrote:
> Hi, is there any issue with this serie
Hi,
Sorry, no nothing wrong - it's just slipped through. Thanks for the
reminder. I've applied it to drm-misc-next.
Thanks,
Steve
> Thanks,
>
> Philippe
>
> On 4/3/25 07:52, Philippe Simons wrote:
>> Allwinne
ags() into panthor_gem.c and
> declare it static.
>
> Fixes: a3707f53eb3f ("drm/panthor: show device-wide list of DRM GEM objects
> over DebugFS")
> Reported-by: Arnd Bergmann
> Closes:
> https://lore.kernel.org/dri-devel/20250424142419.47b9d...@collabora.com/T/#t
>
On 24/04/2025 07:08, Gregory Greenman wrote:
> Hello,
>
> I'm new to DRM developmentand ran into something in the Panfrost (but
> also Panthor) driver I'm curious about.
>
> In drivers/gpu/drm/panfrost/panfrost_gem.c, there's this line: obj-
>>base.map_wc = !pfdev->coherent;
>
> From what I can
On 25/04/2025 15:30, Boris Brezillon wrote:
> On Fri, 25 Apr 2025 14:34:53 +0100
> Steven Price wrote:
>
>> On 17/03/2025 13:06, Thomas Zimmermann wrote:
>>> Instead of testing import_attach for imported GEM buffers, invoke
>>> drm_gem_is_imported() to do the t
1 - 100 of 1013 matches
Mail list logo
