We start to have support many Sitronix displays in the tiny directory,
and we expect more to come.
Move them to their own subdirectory.
Reviewed-by: Javier Martinez Canillas
Suggested-by: Javier Martinez Canillas
Signed-off-by: Marcus Folkesson
---
Changes in v2:
- Rebase on drm-misc-next
1 1 = White
1 0 = Light gray
0 1 = Dark gray
0 0 = Black
instead.
So I will probably add support for D1 and D2 formats and invert the
pixels for the R1, R2 and XRGB formats.
Could that work or are there any side effects that I should be aware of?
Best regards,
Marcus Folkesson
signature.asc
Description: PGP signature
9): undefined reference to `drm_client_setup'
>
> Select the appropriate Kconfig symbol.
>
> Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD
> controller")
> Signed-off-by: Arnd Bergmann
Reviewed-by: Marcus Folkesson
signature.asc
Description: PGP signature
Hello Javier,
On Mon, Apr 28, 2025 at 09:16:32AM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> > We start to have support many Sitronix displays in the tiny directory,
> > and we expect more to come.
> >
> >
' ')
> /* [7:0] D0:D1:D2:D3 2:2:2:2 four pixels/byte */
>
> So the driver actually supports D1 and D2, and XRGB should be
> inverted while converting to monochrome (and grayscale, which is not
> yet implemented).
Hrm, that seems right.
I'm up to some rework of the driver, so I will put it into my pipeline.
Thank you for noticing this!
Best regards,
Marcus Folkesson
signature.asc
Description: PGP signature
We start to have support many Sitronix displays in the tiny directory,
and we expect more to come.
Move them to their own subdirectory.
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 6 ++--
drivers/gpu/drm/Kconfig | 2
Hello Javier,
On Tue, Apr 08, 2025 at 12:44:46PM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
> > The controller has a SPI, I2C and 8bit parallel interface, th
common parts could
easily be put into a common file to be used with other interfaces.
I only have I2C to test with.
The device is a little defiant, it tends to NAK some commands, but all
commands takes effect, hence the I2C_M_IGNORE_NAK flag.
Signed-off-by: Marcus Folkesson
---
Changes in v6
Add MAINTAINERS entry for the Sitronix ST7571 dot matrix LCD
controller.
Reviewed-by: Thomas Zimmermann
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
The controller has a SPI, I2C and 8bit parallel interface, this
driver is for the I2C interface only.
Reviewed-by: Thomas Zimmermann
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Marcus Folkesson
---
drivers/gpu/drm/tiny
Sitronix ST7571 is a dot matrix LCD controller supporting
both 4bit grayscale and monochrome LCDs.
Reviewed-by: Conor Dooley
Reviewed-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Marcus Folkesson
---
.../bindings/display/sitronix,st7571.yaml | 73
Add MAINTAINERS entry for the Sitronix ST7571 dot matrix LCD
controller.
Reviewed-by: Thomas Zimmermann
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
common parts could
easily be put into a common file to be used with other interfaces.
I only have I2C to test with.
The device is a little defiant, it tends to NAK some commands, but all
commands takes effect, hence the I2C_M_IGNORE_NAK flag.
Signed-off-by: Marcus Folkesson
---
Changes in v5
Sitronix ST7571 is a dot matrix LCD controller supporting
both 4bit grayscale and monochrome LCDs.
Reviewed-by: Conor Dooley
Reviewed-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Marcus Folkesson
---
.../bindings/display/sitronix,st7571.yaml | 73
Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
The controller has a SPI, I2C and 8bit parallel interface, this
driver is for the I2C interface only.
Reviewed-by: Thomas Zimmermann
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Marcus Folkesson
---
drivers/gpu/drm/tiny
Hello Javier,
On Wed, Apr 23, 2025 at 01:08:11AM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
> > The controller has a SPI, I2C and 8bit parallel interface, th
Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
The controller has a SPI, I2C and 8bit parallel interface, this
driver is for the I2C interface only.
Reviewed-by: Thomas Zimmermann
Signed-off-by: Marcus Folkesson
---
drivers/gpu/drm/tiny/Kconfig | 11 +
drivers/gpu/drm
Hi Krzysztof,
On Tue, Apr 15, 2025 at 09:22:30AM +0200, Krzysztof Kozlowski wrote:
> On 15/04/2025 07:58, Marcus Folkesson wrote:
> > +title: Sitronix ST7571 Display Controller
> > +
> > +maintainers:
> > + - Marcus Folkesson
> > +
> > +description:
Add MAINTAINERS entry for the Sitronix ST7571 dot matrix LCD
controller.
Reviewed-by: Thomas Zimmermann
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
889bd4a59551c9bc125f94944a6e1c7e3ef2de83
common parts could
easily be put into a common file to be used with other interfaces.
I only have I2C to test with.
The device is a little defiant, it tends to NAK some commands, but all
commands takes effect, hence the I2C_M_IGNORE_NAK flag.
Signed-off-by: Marcus Folkesson
---
Changes in v4
Sitronix ST7571 is a dot matrix LCD controller supporting
both 4bit grayscale and monochrome LCDs.
Signed-off-by: Marcus Folkesson
---
.../bindings/display/sitronix,st7571.yaml | 73 ++
1 file changed, 73 insertions(+)
diff --git a/Documentation/devicetree/bindings
On Fri, Apr 11, 2025 at 10:26:47AM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> [...]
>
> >> static const struct of_device_id st7571_of_match[] = {
> >>/* monochrome displays */
> >>{
> >>
Hello,
On Wed, Apr 09, 2025 at 11:43:54AM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> [...]
>
> >>
> >> That's a god question, I don't really know...
> >>
> >> But fbdev does suppo
Hi Thomas,
Thank you for your review and feedback!
On Mon, Apr 07, 2025 at 10:30:28AM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 04.04.25 um 15:50 schrieb Marcus Folkesson:
> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
> > The controller has a SPI,
Hello Javier,
On Wed, Apr 09, 2025 at 11:43:54AM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> [...]
>
> >>
> >> That's a god question, I don't really know...
> >>
> >> But fbdev does s
t the I2C transport is so slow anyways that compute is
> not the bottleneck when using these small displays.
Hrm, I now realised that I have another issue.
Not all LCDs that will be attached to the ST7571 controller will be
grayscale.
The display I've attached to the ST7571 is a monochrom
Hi,
On Tue, Apr 08, 2025 at 03:57:22PM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 08.04.25 um 15:20 schrieb Marcus Folkesson:
> [...]
> > >
> > > > +static int st7571_set_pixel_format(struct st7571_device *st7571,
> > > > +
Hello Javier,
Thank you for your review and suggestions.
On Tue, Apr 08, 2025 at 12:44:46PM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
> > The controller
Add MAINTAINERS entry for the Sitronix ST7571 dot matrix LCD
controller.
Reviewed-by: Thomas Zimmermann
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
889bd4a59551c9bc125f94944a6e1c7e3ef2de83
with other interfaces.
I only have I2C to test with.
The device is a little defiant, it tends to NAK some commands, but all
commands takes effect, hence the I2C_M_IGNORE_NAK flag.
Signed-off-by: Marcus Folkesson
---
Changes in v3:
- (dt-binding) Use 'Controller' rather than 'Panel&
Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
Signed-off-by: Marcus Folkesson
---
.../bindings/display/sitronix,st7571.yaml | 70 ++
1 file changed, 70 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/sitronix,st7571.yaml
b
Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
The controller has a SPI, I2C and 8bit parallel interface, this
driver is for the I2C interface only.
Reviewed-by: Thomas Zimmermann
Signed-off-by: Marcus Folkesson
---
drivers/gpu/drm/tiny/Kconfig | 11 +
drivers/gpu/drm
with other interfaces.
I only have I2C to test with.
The device is a little defiant, it tends to NAK some commands, but all
commands takes effect, hence the I2C_M_IGNORE_NAK flag.
Signed-off-by: Marcus Folkesson
---
Marcus Folkesson (3):
dt-bindings: st7571-i2c: Add Sitronix ST7571 panel
Thank you Krzysztof,
I will fix the issues you pointed out, just a few comments below.
On Wed, Apr 02, 2025 at 10:27:53AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Apr 02, 2025 at 08:12:10AM +0200, Marcus Folkesson wrote:
> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD c
ion of the patch:
description:
Sitronix ST7571 is a driver and controller for up to 4-level gray
scale dot-matrix LCD panels.
It drives 128 segment outputs and 128+1 common outputs.
It provides several system interfaces like SPI, I2C and 8-bit parallel bus.
But still, it is not obvious if I should move it to panel or not.
>
> Best regards,
> Krzysztof
Best regards,
Marcus Folkesson
signature.asc
Description: PGP signature
Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
The controller has a SPI, I2C and 8bit parallel interface, this
driver is for the I2C interface only.
Signed-off-by: Marcus Folkesson
---
drivers/gpu/drm/tiny/Kconfig | 12 +
drivers/gpu/drm/tiny/Makefile | 1 +
drivers
Add MAINTAINERS entry for the Sitronix ST7571 dot matrix LCD
controller.
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
889bd4a59551c9bc125f94944a6e1c7e3ef2de83..eeae24fda846b9f63400ebb08c3fa7f02f3f4b19
Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
Signed-off-by: Marcus Folkesson
---
.../bindings/display/sitronix,st7571.yaml | 73 ++
1 file changed, 73 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/sitronix,st7571.yaml
b
Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
The controller has a SPI, I2C and 8bit parallel interface, this
driver is for the I2C interface only.
Signed-off-by: Marcus Folkesson
---
drivers/gpu/drm/tiny/Kconfig | 11 +
drivers/gpu/drm/tiny/Makefile | 1 +
drivers
with other interfaces.
I only have I2C to test with.
The device is a little defiant, it tends to NAK some commands, but all
commands takes effect, hence the I2C_M_IGNORE_NAK flag.
Signed-off-by: Marcus Folkesson
---
Changes in v2:
- Reworked pretty much the whole driver to not use obsolete code
On Thu, Apr 03, 2025 at 04:28:22PM +0200, Krzysztof Kozlowski wrote:
> On 03/04/2025 12:31, Marcus Folkesson wrote:
> >>> +i2c {
> >>> +#address-cells = <1>;
> >>> +#size-cells = <0>;
> >>> +
> >>> +
Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
The controller has a SPI, I2C and 8bit parallel interface, this is for
the I2C interface only.
Signed-off-by: Marcus Folkesson
---
.../bindings/display/sitronix,st7571-i2c.yaml | 71 ++
1 file changed, 71
Add MAINTAINERS entry for the Sitronix ST7571 dot matrix LCD
controller.
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
889bd4a59551c9bc125f94944a6e1c7e3ef2de83..00d19d45679f6d18a7e9c9e619b7642176b7ef95
43 matches
Mail list logo
