Thank you Krzysztof, I will fix the issues you pointed out, just a few comments below.
On Wed, Apr 02, 2025 at 10:27:53AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Apr 02, 2025 at 08:12:10AM +0200, Marcus Folkesson wrote:
> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
> > The controller has a SPI, I2C and 8bit parallel interface, this is for
> > the I2C interface only.
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkes...@gmail.com>
> > ---
> > .../bindings/display/sitronix,st7571-i2c.yaml | 71
> > ++++++++++++++++++++++
> > 1 file changed, 71 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/sitronix,st7571-i2c.yaml
> > b/Documentation/devicetree/bindings/display/sitronix,st7571-i2c.yaml
> > new file mode 100644
> > index
> > 0000000000000000000000000000000000000000..6e5e0994a98db646a37bb17c4289332546c9266e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/sitronix,st7571-i2c.yaml
>
[...]
>
> > + maxItems: 1
> > +
> > + sitronix,panel-width-mm:
> > + description: physical panel width [mm]
> > +
> > + sitronix,panel-height-mm:
> > + description: physical panel height [mm]
>
> No, use standard properties.
I will use width-mm and height-mm from panels.yaml from
panel-common.yaml instead
>
> > +
> > + sitronix,panel-nlines:
> > + description: Number of lines in the panel
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 1
> > + maximum: 128
> > + default: 128
>
> Ditto
I will use vactive in panel-timing instead.
Do I need to specify those properties or should I just list them as
required?
Some bindings set e.g.
reg: true
reset-gpios: true
and others just list them as required.
>
> > +
> > + sitronix,panel-start-line:
> > + description: Start line of the panel
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 0
> > + maximum: 127
> > + default: 0
>
> Ditto
I will use vfront-porch in panel-timing instead.
[...]
>
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + display@3f {
>
> Look how this is called in other bindings... The binding and example are
> not following existing code. Why? Why doing something entirely
> different?
Sorry, I'm not sure what you mean here.
>
> Best regards,
> Krzysztof
Best regards,
Marcus Folkesson
signature.asc
Description: PGP signature
