Hi Krzysztof,
On Fri, Apr 04, 2025 at 07:36:12PM +0200, Krzysztof Kozlowski wrote:
> On 04/04/2025 19:30, Krzysztof Kozlowski wrote:
> >> +
> >> +examples:
> >> + - |
> >> + #include <dt-bindings/gpio/gpio.h>
> >> +
> >> + i2c {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + display@3f {
> >
> > Not much improved. How is this called in every other binding? panel.
>
> Hmmm, unless this is not a panel, but it looks like a panel and
> description partially suggests it. Other sitronix devices are split
> between these two, but OTOH your driver is more complex than just simple
> panel.I've counted this as a display, but the border is not crystal clear, and, as you say, other Sitronix devices are split between the two. It is a controller/driver for a LCD panel. > > Your commit msg is one sentence and binding description is basically > non-existing, so not sure how to help. You need to describe the hardware > so people understand what this device is. I've prepared this description for the next version of the patch: description: Sitronix ST7571 is a driver and controller for up to 4-level gray scale dot-matrix LCD panels. It drives 128 segment outputs and 128+1 common outputs. It provides several system interfaces like SPI, I2C and 8-bit parallel bus. But still, it is not obvious if I should move it to panel or not. > > Best regards, > Krzysztof Best regards, Marcus Folkesson
signature.asc
Description: PGP signature
