edksetup.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran via
groups.io
Sent: Friday, November 10, 2023 7:08 PM
To: devel@edk2.groups.io; G Edhaya Chandran ; Barton
Gao ; Carolyn Gjertsen ; Samer
El-Haj-Mahmoud ; Supreeth Venkatesh
Cc
Looks good to me.
Better to add
https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C#user-content-CamelCase
in commit message for reference.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran via
groups.io
Sent: Friday
This is good. Thanks, Rebecca!
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran via
groups.io
Sent: Friday, November 10, 2023 7:02 PM
To: devel@edk2.groups.io; G Edhaya Chandran ; Barton
Gao ; Carolyn Gjertsen ; Samer
El-Haj-Mahmoud
Good catch. Looks good to me. Thanks, Rebecca!
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran via
groups.io
Sent: Friday, November 10, 2023 7:08 PM
To: devel@edk2.groups.io; G Edhaya Chandran ; Barton
Gao ; Carolyn Gjertsen ; Samer
El
Good fix and cleanup, Abdul. EFIAPI is needed for
https://uefi.org/specs/UEFI/2.9_A/02_Overview.html#calling-conventions.
Looks good to me as long as we can also successfully build AARCH64 and other
architectures with this change.
Reviewed-by: Sunny Wang
-Original Message-
From: devel
Looks good to me.
For others' reference, the change has been already verified by running
SystemReady SIE (Security Interface extension) tests on multiple SystemReady
certified Arm systems.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Stuart
Looks good to me.
For others' reference, the change has been already verified by running
SystemReady SIE (Security Interface extension) tests on multiple SystemReady
certified Arm systems.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Stuart
Looks good to me.
For others' reference, the change has been already verified by running
SystemReady SIE (Security Interface extension) tests on multiple SystemReady
certified Arm systems.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Stuart
Looks good to me.
For others' reference, the change has been already verified by running
SystemReady SIE (Security Interface extension) tests on multiple SystemReady
certified Arm systems.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Stuart
Looks good to me.
For others' reference, the change has been already verified by running
SystemReady SIE (Security Interface extension) tests on multiple SystemReady
certified Arm systems.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Stuart
Looks good to me.
For others' reference, the change has been already verified by running
SystemReady SIE (Security Interface extension) tests on multiple SystemReady
certified Arm systems.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Stuart
new patch.
Please go ahead to upstream the patch for the release.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abhimanyu Singh
via groups.io
Sent: Tuesday, March 5, 2024 5:36 PM
To: devel@edk2.groups.io
Cc: Abhi Singh ; G Edhaya Chandran
; Barton
Thanks for addressing my comments, Abhi.
https://github.com/tianocore/edk2-test/pull/90
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abhimanyu Singh
via groups.io
Sent: Monday, April 8, 2024 11:45 PM
To: devel@edk2.groups.io
Cc: Abhi Singh
Reviewed the changes on https://github.com/PrachotanReddy/edk2-test/pull/1 and
https://github.com/PrachotanReddy/edk2-test/pull/2. Looks good to me.
Thanks for addressing my online and offline comments, Prachotan.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io
Hi Liming, Hao, and all
Now we're checking the SCT runtime variable service test case.
https://github.com/tianocore/edk2-test/blob/92a0343c1553342c53fae9d9d646b763add232c0/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestConformance.c#L3401
an
PL011 is not a valid ACPI identifier so don't expose it as a _CID.
Since _CID (Comptable ID) is optional, let's just drop it.
Cc: Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Pierre Gondois
Cc: Ard Biesheuvel
Signed-off-by: Sunny Wang
---
Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1
PL011 is not a valid ACPI identifier so don't expose it as a _CID.
Since _CID (Compatible ID) is optional, let's just drop it.
Cc: Samer El-Haj-Mahmoud
Cc: Pierre Gondois
Signed-off-by: Sunny Wang
Reviewed-by: Sami Mujawar
Reviewed-by: Ard Biesheuvel
---
Platform/ARM/JunoPkg/
Good catch, Ard. Thanks.
Since this was not on EDKII emailing list (thanks to Sami for offline pointing
this out to me), I resend this patch for testing my email address and fixing
this typo.
Best Regards,
Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ard
: Sunny Wang
---
Platform/RaspberryPi/AcpiTables/Uart.asl | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/AcpiTables/Uart.asl
b/Platform/RaspberryPi/AcpiTables/Uart.asl
index 8ce297078d..e3165911a6 100644
--- a/Platform/RaspberryPi/AcpiTables/Uart.asl
changed as expected.
Cc: Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Pete Batard
Cc: Ard Biesheuvel
Signed-off-by: Sunny Wang
---
.../RaspberryPi/AcpiTables/AcpiTables.inf | 9 +-
.../RaspberryPi/AcpiTables/Dbg2MiniUart.aslc | 82
.../AcpiTables/{Dbg2.aslc
Somehow my first patch got messed up. Please ignore this.
I will check the problem and send the patches again.
Best Regards,
Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunny Wang via
groups.io
Sent: Wednesday, March 24, 2021 5:45 PM
To: devel@edk2.groups.io
Looks good to me.
Reviewed-by: Sunny Wang
Hi Patrick,
This patch is to address your comment below. Could you give this patch a try on
your side?
https://edk2.groups.io/g/devel/message/79766?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2CSecurityPkg%3A+Create+library+for+enrolling
invalid combination -- FAILURE
For details, please check the threads below:
- https://edk2.groups.io/g/devel/topic/86486174
- https://edk2.groups.io/g/devel/message/82466
Cc: Liming Gao
Cc: Heinrich Schuchardt
Cc: G Edhaya Chandran
Cc: Samer El-Haj-Mahmoud
Signed-off-by: Sunny Wang
length of 0x5c
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Marcin Wojtas
Cc: Samer El-Haj-Mahmoud
Signed-off-by: Sunny Wang
---
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
b
e the test cases to fix this issue.
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Heinrich Schuchardt
Cc: Samer El-Haj-Mahmoud
Signed-off-by: Sunny Wang
---
.../SimpleTextOutBBTestConformance_efi.c | 13 +-
.../SimpleTextOutBBTestConformance_uefi.c
: Sunny Wang ; edk2-devel-groups-io
; Leif Lindholm ; Ard Biesheuvel
; Samer El-Haj-Mahmoud
Subject: Re: [edk2-platform PATCH v1] Silicon/Marvell/Armada7k8k: Fix wrong
SMBIOS version issue
On Wed, 12 Jan 2022 at 00:00, Marcin Wojtas wrote:
>
> wt., 11 sty 2022 o 22:46 Sunny Wang nap
Thanks, Liming.
-Original Message-
From: gaoliming
Sent: 18 January 2022 05:25
To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Sunny Wang
Cc: 'Heinrich Schuchardt' ; G Edhaya
Chandran ; Samer El-Haj-Mahmoud
Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/Variable:
s for Edhaya's offline reminder!
https://github.com/sunnywang-arm/edk2-test/pull/1/files?diff=unified&w=1
Best Regards,
Sunny
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunny Wang via
groups.io
Sent: 11 January 2022 21:53
To: devel@edk2.groups.io
Cc: Sunny W
Sorry for the late review.
The change looks fine. However, I'm confused about the comment " Log the error
here and return key states are not supported when high order bit of
KeyToggleState is 0 or KeyState not touched". It looks like returning
EFI_UNSUPPORTED won't log any error/failure in the
I tested this patch as well and confirmed this patch fixed the FWTS failure
below. Thanks, Sami.
- dbg2: DBG2 Device 'COM0' not found in ACPI object name space.
Tested-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jagadeesh Ujja
via groups.i
Looks good. Thanks much, Marcin.
This will be helpful as http://wiki.macchiatobin.net/tiki-index.php has been
not accessible for quite a while.
Reviewed-by: Sunny Wang
Best Regards,
Sunny
-Original Message-
From: Marcin Wojtas
Sent: 14 March 2022 12:06
To: devel@edk2.groups.io
Cc
Looks good to me. This only affects RISCV. Therefore, as long as you build and
run SCT on the RISCV platform, this change should be fine.
Reviewed-by: Sunny Wang
Best Regards,
Sunny Wang
-Original Message-
From: Schaefer, Daniel
Sent: Thursday, March 4, 2021 11:21 AM
To: devel@edk2
Looks good to me.
Same comment as patch 1/5. This only affects RISCV. Therefore, as long as you
build and run SCT on the RISCV platform, this change should be fine.
Reviewed-by: Sunny Wang
-Original Message-
From: Schaefer, Daniel
Sent: Thursday, March 4, 2021 11:21 AM
To: devel@edk2
riginal places and have only one option "-Wno-error " in GCC:*_*_*_CC_FLAGS.
Also, good catch on meaningless compiler options -Wno-error=xxx.
Moreover, I also built SCT with this patch series and run it on my Rasberry Pi
4, and don't see any obvious issue.
Best Regards,
Sunn
Looks good to me. Same comment as the patches 1/5 and 2/5.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Daniel Schaefer
Sent: Thursday, March 4, 2021 11:21 AM
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao
; Samer El-Haj-Mahmoud
Samer El-Haj-Mahmoud
Cc: Jeremy Linton
Cc: Pete Batard
Cc: Ard Biesheuvel
Signed-off-by: Sunny Wang
---
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c| 11 ++-
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf | 3 ++-
.../Drivers/ConfigDxe/ConfigDxeHii.uni
Samer El-Haj-Mahmoud
Cc: Jeremy Linton
Cc: Sami Mujawar
Cc: Pete Batard
Cc: Ard Biesheuvel
Signed-off-by: Sunny Wang
---
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c| 11 ++-
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf | 3 ++-
.../Drivers/ConfigDxe/ConfigDxeHii.uni
PL before connect is 4
- ESC (setup), F1 (shell), ENTER (boot)Boot Policy is Full Discovery. Connect
all devices
Best Regards,
Sunny Wang
-Original Message-
From: Pete Batard
Sent: Monday, April 12, 2021 9:04 PM
To: Sunny Wang ; devel@edk2.groups.io
Cc: Samer El-Haj-Mahmoud ; Jeremy Lint
ng
to "base64". Now the issue seems to be resolved.
Best Regards,
Sunny Wang
-Original Message-
From: Ard Biesheuvel
Sent: Tuesday, April 13, 2021 1:27 AM
To: Pete Batard
Cc: Sunny Wang ; edk2-devel-groups-io
; Samer El-Haj-Mahmoud ;
Jeremy Linton ; Ard Biesheuvel
Sub
Samer El-Haj-Mahmoud
Cc: Jeremy Linton
Cc: Sami Mujawar
Cc: Pete Batard
Cc: Ard Biesheuvel
Signed-off-by: Sunny Wang
---
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c| 11 ++-
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf | 3 ++-
.../Drivers/ConfigDxe/ConfigDxeHii.uni
It looks like "base64" would cause a display issue with
https://edk2.groups.io/g/devel/message/74011, so I re-sent v2 with the default
"8bit" setting. So far, "8bit" seems working fine.
Best Regards,
Sunny Wang
-Original Message-
From: devel@edk2.groups.i
Oops, I already sent v2. Sorry for missing your request (checking and
confirming other issues and adding them to the commit message), Samer.
I will check this later and send v3 or re-send v2.
Please not push this until I address this comment. Thanks!
Best Regards,
Sunny Wang
-Original
out to fix three issues below. I also added comments/updates
to these four issues and closed the following three.
https://github.com/pftf/RPi4/issues/144
https://github.com/pftf/RPi4/issues/114
https://github.com/pftf/RPi4/issues/117
Best Regards,
Sunny Wang
-Original Message-
From: Samer
ete Batard
Cc: Ard Biesheuvel
Signed-off-by: Sunny Wang
---
Platform/RaspberryPi/AcpiTables/Dsdt.asl| 3 ++-
Platform/RaspberryPi/AcpiTables/Emmc.asl| 4 ++--
Platform/RaspberryPi/AcpiTables/SsdtThermal.asl | 4 ++--
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git
xTest\SimpleTextOutBBTestFunction_efi.c
-
uefi-sct\SctPkg\TestCase\UEFI\IHV\Protocol\SimpleTextOut\BlackBoxTest\SimpleTextOutBBTestConformance_uefi.c
Reviewed-by: Sunny Wang
Best Regards,
Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Heinrich
Schuchardt via groups.io
Sent: Tu
issue. I agree that it is not worth further checking
and making change for EFI_SIMPLE_TEXT_OUTPUT_MODE data structure, so you change
is good enough!
Best Regards,
Sunny Wang
-Original Message-
From: Heinrich Schuchardt
Sent: Monday, May 10, 2021 6:30 PM
To: Sunny Wang ; devel@edk2
Looks good to me. I'm just curious if we would run into a similar problem with
using Print() in MdePkg\Library\UefiLib\UefiLibPrint.c or ShellPrintEx() in
ShellPkg\Library\UefiShellLib\UefiShellLib.c. If not, we may need to improve
SctPrint().
Reviewed-by: Sunny Wang
-Original Me
Looks good to me. I'm just curious if we would run into a similar problem with
using Print() in MdePkg\Library\UefiLib\UefiLibPrint.c or ShellPrintEx() in
ShellPkg\Library\UefiShellLib\UefiShellLib.c. If not, we may need to improve
SctPrint().
Reviewed-by: Sunny Wang
-Original Me
https://uefi.org/acpi
Reviewed-by: Sunny Wang mailto:sunny.w...@arm.com>>
From: devel@edk2.groups.io On Behalf Of gaoliming via
groups.io
Sent: Friday, May 21, 2021 1:20 PM
To: devel@edk2.groups.io; ashishsin...@nvidia.com; Samer El-Haj-Mahmoud
; michael.d.kin...@intel.com;
zhiguang@intel
.
Best Regards,
Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Marcin Wojtas
via groups.io
Sent: Sunday, May 23, 2021 5:15 PM
To: devel@edk2.groups.io
Cc: liming@intel.com; michael.d.kin...@intel.com; l...@nuviainc.com;
ardb+tianoc...@kernel.org; Samer El-Haj
PCR+header+with+NVIDIA+16550+Subtype,20,2,0,82919032.
Of course, if this won't cause any issue with pushing the patch, I'm totally
fine with this.
Reviewed-by: Sunny Wang
Best Regards,
Sunny Wang
-Original Message-
From: Marcin Wojtas
Sent: Monday, May 24, 2021 10
Looks good to me. Good catch!
Reviewed-by: Sunny Wang
By the way, just FYI, I still run into the same problem (line-ending problem)
with Windows Outlook and EDK2 email archive
https://edk2.groups.io/g/devel/topic/patch/83043513?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,83043513
Looks good to me as well.
Reviewed-by: Sunny Wang
-Original Message-
From: Samer El-Haj-Mahmoud
Sent: Monday, May 24, 2021 7:00 PM
To: Marcin Wojtas ; devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Sunny Wang
; g...@semihalf.com; upstr...@semihalf.com; Samer
El
Looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Marcin Wojtas
Sent: Monday, May 24, 2021 1:29 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
g...@semihalf.com; upstr...@semihalf.com; Marcin Wojtas
Looks good to me as well. By the way, this fixed Windows PE blue screen issue.
Reviewed-by: Sunny Wang
-Original Message-
From: Samer El-Haj-Mahmoud
Sent: Monday, May 24, 2021 7:00 PM
To: Marcin Wojtas ; devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Sunny Wang
Already internally reviewed this. Looks good! Thanks for working on this, Greg!
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Wednesday, May 26, 2021 5:42 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
Looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Thursday, July 1, 2021 5:21 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr...@semihalf.com; jiewen
Looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Thursday, July 1, 2021 5:18 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr...@semihalf.com; jiewen
Looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Thursday, July 1, 2021 5:18 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr...@semihalf.com; jiewen
Looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Thursday, July 1, 2021 5:18 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr...@semihalf.com; jiewen
Looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Thursday, July 1, 2021 5:18 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr...@semihalf.com; jiewen
Looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Thursday, July 1, 2021 5:18 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr...@semihalf.com; jiewen
Looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Thursday, July 1, 2021 5:18 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr...@semihalf.com; jiewen
Looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Thursday, July 1, 2021 5:18 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr...@semihalf.com; jiewen
Reviewed whole series.
Reviewed-by: Sunny Wang
We still need matintainers to review the patches below:
[PATCH v5 03/10] OvmfPkg: add SecureBootVariableLib class resolution
[PATCH v5 04/10] EmulatorPkg: add SecureBootVariableLib class resolution
[PATCH v5 05/10] SecurityPkg: Remove duplicated
Reviewed whole series.
Reviewed-by: Sunny Wang
We still need Intel platforms' maintainers to review the patch below. All other
patches (for ARM, RISC-V, and QEMU platforms) were already reviewed by
maintainers.
- [edk2-platforms PATCH v5 1/4] Intel Platforms: add SecureBootVariab
NXP guys.
Hi Leif and Meenakshi,
Can we just push the latest LSDK to the Tiano edk2-platform in one patch set?
Then, If there is anything that needs to be cleaned up like the Coding style
issue, we can create an issue in Bugzilla for it. What do you guys think?
Best Regards,
Sunny Wang
-O
Looks good.
Just have some comments mentioned Patch 0/4 about moving/renaming file/folder
for synchronizing with NXP LSDK opensource
https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms.
Best Regards,
Sunny Wang
-Original Message-
From: Vikas Singh
Sent: Friday
Looks good.
Just have some comments mentioned Patch 0/4 about moving/renaming file/folder
for synchronizing with NXP LSDK opensource
https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms.
Best Regards,
Sunny Wang
-Original Message-
From: Vikas Singh
Sent: Friday
". In our offline discussion,
this would cause some build problems with the current CM implementation
(Multiple NXP platforms share One CM folder).
Best Regards,
Sunny Wang
-Original Message-
From: Vikas Singh
Sent: Friday, June 18, 2021 11:28 PM
To: devel@edk2.groups.io
Cc: Sami M
mer El-Haj-Mahmoud
Cc: G Edhaya Chandran
Cc: Barton Gao
Signed-off-by: Sunny Wang
---
.../MemoryAllocationServicesBBTestFunction.c | 110 +++---
1 file changed, 66 insertions(+), 44 deletions(-)
diff --git
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocati
ommits. The first
commit number is wrong (incomplete). The complete number is
6469702898789e555c6947e50216a3f79e0ddeb9.
I also tested this patch by running ACS 3.0 (FWTS V20.07.00) on my RPi4, and no
longer see the MethodCIDInvalidString failures.
Reviewed-by: Sunny Wang
Tested-by: Sunny Wan
://edk2.groups.io/g/devel/message/77781
Therefore, I think this series already got all the necessary Reviewed-By and
Acked-By of all parts and is ready to be pushed now.
Best Regards,
Sunny Wang
-Original Message-
From: Samer El-Haj-Mahmoud
Sent: Friday, July 16, 2021 8:00 PM
To: devel@edk2
nceInterfaceVer|L"TCG2_VERSION"|gTcg2ConfigFormSetGuid|0x0|"1.3"|NV,BS
Best Regards,
Sunny Wang
-Original Message-
From: Gao, Zhichao
Sent: Wednesday, July 21, 2021 1:14 PM
To: Grzegorz Bernacki
Cc: devel@edk2.groups.io; l...@nuviainc.com; ardb+tianoc...@kernel.org;
Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Ard Biesheuvel
Cc: Pete Batard
Cc: Leif Lindholm
Signed-off-by: Sunny Wang
---
.../VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/EmbeddedPkg
Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Ard Biesheuvel
Cc: Pete Batard
Cc: Leif Lindholm
Signed-off-by: Sunny Wang
---
.../VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/EmbeddedPkg
evel/topic/patch_1_1/84397263
Best Regards,
Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunny Wang via
groups.io
Sent: Friday, July 23, 2021 5:01 PM
To: devel@edk2.groups.io
Cc: Sunny Wang ; Samer El-Haj-Mahmoud
; Sami Mujawar ; Jeremy
Linton ; Ard Biesheuvel ;
P
ahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Ard Biesheuvel
Cc: Pete Batard
Cc: Leif Lindholm
Signed-off-by: Sunny Wang
---
.../Drivers/VarBlockServiceDxe/VarBlockService.c | 12
1 file changed, 12 insertions(+)
diff --git a/Platform/RaspberryPi/Drivers/VarBlockServ
allation failure.
Best Regards,
Sunny Wang
-Original Message-
From: Ard Biesheuvel
Sent: Friday, July 23, 2021 11:10 PM
To: Sunny Wang
Cc: edk2-devel-groups-io ; Samer El-Haj-Mahmoud
; Sami Mujawar ; Jeremy
Linton ; Ard Biesheuvel ;
Pete Batard ; Leif Lindholm
Subject: Re: [edk
o get merged first, and will have more patches based on this to be sent
out to solve some deployment and testing problems caused by Fast boot on ARM
platforms.
- https://edk2.groups.io/g/devel/message/78072
Best Regards,
Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Thu
Ditto. v5 looks good to me as well, so keep my 'R-b' for v5.
Thanks for helping on this, Hao. :)
Best Regards,
Sunny Wang
-Original Message-
From: Gao, Zhichao
Sent: Tuesday, August 3, 2021 10:25 AM
To: Wu, Hao A ; devel@edk2.groups.io; g...@semihalf.com;
Sunny W
, and 4/4) first?
Best Regards,
Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Wednesday, July 14, 2021 8:31 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr...@semihalf.com; j
27;re done with
synchronizing edk2-platform with NXP-LSDK.
2. OK, I just thought that you would like to use the same way (build flag) as
what we used in NXP LSDK. I'm also fine with the current approach. We can
co-work with NXP to update NXP-LSDK later.
Reviewed-by: Sunny Wang mailt
\Library\SocFixupLib\ from NXP LSDK later and
adding it now can avoid confusion caused by the mismatch between edk2 and NXP
LSDK. Why don't we add it now?
Best Regards,
Sunny Wang
From: Vikas Singh
Sent: Monday, July 26, 2021 9:04 PM
To: Sunny Wang ; devel@edk2.groups.io; Meenakshi Aggarwal
(
Looks good. Thanks, Greg.
Reviewed-by: Sunny Wang
For others' reference, this patch is similar to the one below for Rasberry Pi
that just got merged.
- https://edk2.groups.io/g/devel/message/78514
After merging this change, we should be able to easily enable "boot discovery
policy
rPolicyProtocol, BootDiscoveryPolicyHandler() would just return
with only printing a message to remind users/developers that Boot Discovery
Policy doesn't work (driver connect will be skipped).
Best Regards,
Sunny Wang
-Original Message-
From: Ard Biesheuvel
Sent: Friday, August 6, 2021 9:45 PM
T
Just aware that the patch series hasn't been sent out by devel@edk2.groups.io.
I will review other related patches once the patch series gets sent out by
devel@edk2.groups.io.
Best Regards,
Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunny Wang via
grou
In v3: Address comments given by Jeremy and Matio on v2.
In v2: Address comments given by Pete on v1.
Dynamically build UARTs info in ACPI so that it can match the UART
related settings defined in config.txt
Sunny Wang (2):
Platform/RaspberryPi: Dynamically build UARTs info in ACPI
Platform
changed as expected.
Cc: Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Pete Batard
Cc: Ard Biesheuvel
Cc: Mario Bălănică
Signed-off-by: Sunny Wang
---
.../RaspberryPi/AcpiTables/AcpiTables.inf | 8 +-
.../RaspberryPi/AcpiTables/Dbg2MiniUart.aslc | 81
UART) can
work fine.
- Successfully booted VMware ESXi-Arm Fling v1.3 with only serial
console connection (PL011 UART).
Cc: Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Pete Batard
Cc: Ard Biesheuvel
Cc: Mario Bălănică
Signed-off-by: Sunny Wang
---
Platform/R
change you wanted here for my reference?
Moreover, for the changes you want, could you also paste the code change?
Best Regards,
Sunny Wang
From: devel@edk2.groups.io On Behalf Of Mario Balanica
via groups.io
Sent: Monday, May 31, 2021 8:41 PM
To: Sunny Wang
Cc: devel@edk2.groups.io; Sa
e instance in
edk2\MdeModulePkg\Library\PlatformVarCleanupLib\PlatVarCleanupLib.c. If not,
feel free to add other instances, Bret.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Tuesday, June 1, 2021 9:12 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; a
Internally reviewed this patch before sending the edk2 mailing list and It
looks good to me. Please also address Min M's good catch/comment.
Reviewed-by: Sunny Wang
Hi Laszlo,
if you have time, I think you can still review this patch because this patch is
a simple one and is based on
Internally reviewed this patch before sending the edk2 mailing list and It
looks good to me. Please also address Pete's good catches/comments.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Tuesday, June 1, 2021 9:12 PM
To: devel@edk2.groups.io
Internally reviewed this patch before sending the edk2 mailing list and Greg
already addressed all my comments, so It looks good to me.
Reviewed-by: Sunny Wang
As for Bret's comment, the "#define FAIL(fmt...).. " was added for addressing
my internal review comment for better
Internally reviewed this patch before sending the edk2 mailing list and It
looks good to me. Please also address Pete's good catches/comments.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Tuesday, June 1, 2021 9:12 PM
To: devel@edk2.groups.io
Internally reviewed this patch before sending the edk2 mailing list and Greg
already addressed all my comments, so It looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Tuesday, June 1, 2021 9:12 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com
Internally reviewed this patch before sending the edk2 mailing list and it
looks good to me.
Reviewed-by: Sunny Wang
Sent: Tuesday, June 1, 2021 9:12 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr
Mujawar
Cc: Jeremy Linton
Cc: Pete Batard
Cc: Ard Biesheuvel
Cc: Mario Balanica
Sunny Wang (3):
Platform/RaspberryPi: Dynamically build UARTs info in ACPI
Silicon/Broadcom/Bcm283x: Clean up GpioPinSet function
Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS
changed as expected.
Cc: Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Pete Batard
Cc: Ard Biesheuvel
Cc: Mario Bălănică
Signed-off-by: Sunny Wang
---
.../RaspberryPi/AcpiTables/AcpiTables.inf | 8 +-
.../RaspberryPi/AcpiTables/Dbg2MiniUart.aslc | 81
1 - 100 of 137 matches
Mail list logo
