.
With that addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/10/2023 06:15 pm, Rohit Mathew wrote:
As of now, the field-validator implemented by FNPTR_FIELD_VALIDATOR
function pointer takes two parameters, the pointer to the field and a
context pointer. For cases where the
Hi Rohit,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/10/2023, 18:16, "Rohit Mathew" mailto:rohit.mat...@arm.com>> wrote:
As of now, the print-formatter implemented by the FNPTR_PRINT_FORMATTER
function p
Hi Rohit,
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
With that addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/10/2023 06:17 pm, Rohit Mathew wrote:
Most of the ACPI tables have fields that are marked reserved. Implement
Hi Rohit,
Thank you for this patch.
Please see my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 02/10/2023 06:17 pm, Rohit Mathew wrote:
Add a parser for the MPAM (Memory system resource partitioning and
monitoring) ACPI table. This parser would parse all MPAM related
structures
Hi Sahil,
Thank you for this patch.
I think this patch can be split into 3 or 4 patches. Can you look into
that, please?
I also have other feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 23/08/2023 12:03 pm, sahil wrote:
NT_FW_CONFIG DTB contains platform information passed by
Hi Laszlo,
I will look into this and provide a fix shortly.
Regards,
Sami Mujawar
On 11/12/2023, 17:21, "Laszlo Ersek" mailto:ler...@redhat.com>> wrote:
Hi Jianyong,
On 12/11/23 17:31, Laszlo Ersek wrote:
> On 11/23/23 04:22, Jianyong Wu wrote:
>> Add the lo
From: Jianyong Wu
Add the long lost CI for CloudHv on AArch64.
As CloudHv CI works nearly the same way with other VMMs like KvmTool,
thus we can easily create its CI configuration based on KvmTool.
Reviewed-by: Laszlo Ersek
Signed-off-by: Jianyong Wu
Signed-off-by: Sami Mujawar
---
The
Hi Laszlo,
I have posted a v3 patch to fix the issue at
https://edk2.groups.io/g/devel/message/112485
I have done a draft pull request to check the v3 patch passes CI and this can
be seen at https://github.com/tianocore/edk2/pull/5145
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
Hi Himanshu,
Thank you for this patch.
Please see my feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 06/12/2023 10:11 am, Himanshu Sharma wrote:
Add interrupt node to the AML description of the serial-port only if the
IRQ ID from the Configuration Manager is a valid SPI (shared
Hi Himanshu,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 06/12/2023 10:11 am, Himanshu Sharma wrote:
Taking reference from Table 2-1 of the Arm
Hi Laszlo,
On 14/12/2023, 12:28, "Laszlo Ersek" mailto:ler...@redhat.com>> wrote:
On 12/13/23 16:13, Sami Mujawar wrote:
> From: Jianyong Wu mailto:jianyong...@arm.com>>
>
> Add the long lost CI for CloudHv on AArch64.
> As CloudHv CI works nearly the sam
Hi Leif, Ard,
On 14/12/2023, 14:46, "Leif Lindholm" mailto:quic_llind...@quicinc.com>> wrote:
+Sami (who I know once, a very long time ago, used cygwin)
[SAMI] Now that we have WSL, I have stopped using Cygwin.
Also, this patch looks good to me.
Reviewed-by: Sami Mujawar
Merged as b8a3eec88cc7..59a952d9ab00
Thanks.
Regards,
Sami Mujawar
On 14/12/2023, 13:54, "Sami Mujawar" mailto:sami.muja...@arm.com>> wrote:
Hi Laszlo,
On 14/12/2023, 12:28, "Laszlo Ersek" mailto:ler...@redhat.com> <mailto:ler...@redhat.com
<mailto:le
Hi Sahil,
Please find my feedback marked inline as [SAMI].
With those fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Add NOR flash library, this library provides APIs for getting the list
of NOR flash devices on the platform.
Signed-off-by
Hi Sahil,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil via groups.io wrote:
Enable SCP QSPI flash region access by adding it in the PlatformLibMem
Signed-off-by: sahil
---
Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h
/P30NorFlashDeviceLib/P30NorFlashDeviceLib.inf
NorFlashDeviceLib|Platform/Arm/Library/CadenceQspiNorFlashDeviceLib/CadenceQspiNorFlashDeviceLib.inf
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Add NOR flash DXE driver, this brings up NV storage on
QSPI's flash device using FVB pro
Hi Sahil,
Please see my response for Patch 3/5.
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Enable persistent storage on QSPI flash device.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 20 ++--
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 4
Hi Sahil,
As such these changes look good to me. But, we would need to revisit
this based on my response for Patch 3/5.
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 +
Platform/ARM/N1Sdp
Hi Abdul,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Add helper functions to generate AML resource data
for word I/O.
Cc: Pierre Gondois
Cc: Sami
Hi Abdul,
Thank you for this fix. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Corrects the parameters of AmlCodeGenRdWordBusNumber() to
UINT16 to generate word bus number.
Cc
/DynamicTablesPkg/Include/AcpiTableGenerator.h#L217
Maybe we need to find and fix those issues as well.
In either case, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Corrects the function pointer
the
changes and get this patch merged.
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Adds API to generate AML code to invoke/call another
method. Also provides ability to pass arguments of
type integer, string, ArgObj or LocalObj.
Cc: Pierre
d with argument.
V1:
Code changes to
Add API to generate word I/O ranges.
Correct the parameter to generate word bus number.
Corrects the function pointer typedef
Cc: Pierre Gondois
Cc: Sami Mujawar
Cc: Abdul Lateef Attar
Abdul Lateef Attar (4):
DynamicTablesPkg: AML Code generation
Hi Abdul,
Can you check if the patch 4/4 at
https://github.com/samimujawar/edk2/tree/REVIEW_2923_dynamictables_word_io_method_invocation_v5
looks ok to you, please?
If you confim, I will apply the push label.
Regards,
Sami Mujawar
On 21/12/2023 01:56 pm, Sami Mujawar via groups.io wrote
Series merged as 5d533bbc2773..d01defe06b35
Thanks.
Regards,
Sami Mujawar
On 22/12/2023, 03:59, "Attar, AbdulLateef (Abdul Lateef)"
mailto:abdullateef.at...@amd.com>> wrote:
[AMD Official Use Only - General]
Hi Sami,
Below mentioned patch looks good;
https://github.com/
Hi Pierre,
Thank you for this patch.
I just have one comment marked inline as [SAMI].
Otherwise this patch looks good to me.
With that addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 30/11/2023 11:09 am, Pierre Gondois wrote:
Add definitions for:
- _PSD version: added in
Hi Abdul,
Thank you for this patch.
I have some minor suggestions that I will fix before merging. Otherwise
this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 03/01/2024 09:52 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Add the support for X64
Hi Abdul,
Thank you for this patch.
I have some minor suggestions that I will fix before merging. Otherwise
this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 03/01/2024 09:52 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Add the support for X64
IA32?
Regards,
Sami Mujawar
On 03/01/2024 09:52 am, Abdul Lateef Attar via groups.io wrote:
From: Abdul Lateef Attar
PR: https://github.com/tianocore/edk2/pull/5209
v2: Fix the IA32 compilation errors.
v1: Fix the X64 compilation errors.
Cc: Pierre Gondois pierre.gond...@arm.com
Cc: Sami
Hi Rebecca,
Thank you for this patch.
I have some minor suggestions marked inline as [SAMI].
Regards,
Sami Mujawar
On 03/01/2024, 20:44, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
The generic watchdog offset register is 48 bits wide, and can be set by
p
Hi Rebecca,
Thank you for this patch.
I have some minor suggestions marked inline as [SAMI].
Regards,
Sami Mujawar
On 03/01/2024, 20:44, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
Update GenericWatchdogDxe to disable watchdog interaction after exiti
Hi Abdul,
Thanks for confirming.
I think the matrix at https://github.com/tianocore/edk2/tree/master/.pytool
needs updating.
Can you send a patch to update that, please?
Regards,
Sami Mujawar
On 04/01/2024, 04:05, "Attar, AbdulLateef (Abdul Lateef)"
mailto:abdullateef.at...@amd.c
Hi Abdul,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/01/2024, 13:43, "Abdul Lateef Attar" mailto:abdat...@amd.com>> wrote:
From: Abdul Lateef Attar mailto:abdullateef.at...@amd.com>>
Update the "Basic Status" matrix
Hi Himanshu,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/01/2024 08:02 am, Himanshu Sharma wrote:
Taking reference from Table 2-1 of the Arm Generic Interrupt Controller
Architecture Specification, Issue H, January 2022
Hi Himanshu,
There are some minor comments marked inline as [SAMI], otherwise this
patch looks good to me.
I can fix those up before merging the patch.
With that,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/01/2024 08:02 am, Himanshu Sharma wrote:
Add interrupt node to the
,
Sami Mujawar
On 04/01/2024, 18:49, "Prabin CA" mailto:prabin...@arm.com>> wrote:
This patch series introduces support for two reference design platforms-
RD-N2-Cfg3 and RD-V2. The RD-N2-Cfg3 FVP platform is a variant of RD-N2
platform with a different mesh size and GIC
Hi Rebecca,
Thank you for the updated patch.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 05/01/2024, 05:15, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
The generic watchdog offset register is 48 bits wide, and can be set by
perfo
Hi Rebecca,
I have a minor suggestion marked inline as [SAMI], otherwise this patch looks
good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/01/2024, 05:15, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
The calculation of the timer p
Hi Rebecca,
Thank you for this patch.
Please see my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 05/01/2024, 05:15, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
Update GenericWatchdogDxe to disable watchdog interaction after exiting
boot services
Hi Gua,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 11/01/2024, 09:15, "gua@intel.com <mailto:gua@intel.com>"
mailto:gua@intel.com>> wrote:
From: Gua Guo mailto:gua@intel.com>>
REF: ht
Hi Gua,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 11/01/2024, 14:19, "Guo, Gua" mailto:gua@intel.com>> wrote:
You mean we need to add below error handle after all callers ?
Hob = CreateHob (...)
ASSERT (Hob != NULL); < Her
Hi Gua,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 11/01/2024, 15:19, "Guo, Gua" mailto:gua@intel.com>> wrote:
Maybe I can add error handle but they will have several case need to do if it's
fine.
It maybe increasing some BIOS size.
Hi Liming,
If there are no further comments on this patch, can you let me know if I can
merge this, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113740): https://edk2.groups.io/g/devel/message/113740
-L490
I believe such cases are at other places as well.
I think it may be better to introduce a Panic() hander to fix this properly.
Regards,
Sami Mujawar
On 12/01/2024, 02:25, "gua@intel.com <mailto:gua@intel.com>"
mailto:gua@intel.com>> wrote:
Fr
th the links to the previous
discussion, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114042): https://edk2.groups.io/g/devel/message/114042
Mute This Topic: https://groups.io/mt/103521642/21656
Group Own
fter point 11 above to edk2 &
edk2-platforms master branch.
c. Similarly, the RISCV support can be merged after point 13.
I will send out a request for creating the staging branch shortly.
Regards,
Sami Mujawar
On 10/01/2024, 21:56, "Jeshua Smith" mailto:jesh...@nvidia.com>&g
Hi Rebecca,
Thank you for this patch.
Please find my feedback inline marked as [SAMI].
Regards,
Sami Mujawar
On 19/01/2024, 15:46, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
The generic watchdog offset register is 48 bits wide, and can be set by
perfo
Hi Rebecca,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/01/2024, 15:46, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
The calculation of the timer period was broken. Introduce a global
mTi
Hi Rebecca,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
Otherwise, this patch looks good to me.
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/01/2024, 15:46, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>>
Hi All,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 24/01/2024, 12:41, "Gerd Hoffmann" mailto:kra...@redhat.com>> wrote:
On Fri, Jan 12, 2024 at 08:56:02AM +, Ni, Ray wrote:
> It's strange to me that ARM's MM env still allows
Hi Pierre,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/12/2023, 09:29, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different
versions of t
Hi Pierre,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/12/2023, 09:29, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
The PERFORMANCE_DESCRIBE_FASTCHANNEL Scmi command is available
since SCMI v2
Hi Pierre,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/12/2023, 09:29, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Make use of the newly added CPC revision macro.
Signed-off-by
Hi Pierre,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/12/2023, 09:29, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
The DynamicTables framework uses the AmlLib to generate some
Aml objects. It
Hi Pierre,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 12/12/2023, 09:29, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Add an object describing _PSD information, cf. ACPI 6.5,
s8.4.5.5 _PSD (P-State Dependenc
Hi Pierre,
Thank you for this patch.
I have a minor suggestion that I will fix before merging.
Otherwise, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/12/2023, 09:30, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
The _PSD
Hi Pierre,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/12/2023, 09:30, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Make use of the newly added AmlCreatePsdNode() to generate
_PSD objects.
_P
Hi Pierre,
Please see my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 12/12/2023, 09:29, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Add AmlCreatePsdNode() to the AmlLib to generate _PSD objects.
_PSD objects allow to describe 'performance con
Hi Pierre,
I think we should not relax the checks as this may lead to a production
platform ignoring the mandatory fields.
Maybe we need to define a pre-processor e.g. DEVELOPMENT_PLATFORM_RELAXATIONS
and add additional warnings to say that the platform is not spec compliant.
Regards,
Sami
Hi Rebecca,
On 24/01/2024, 19:36, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
On 1/23/2024 7:10 AM, Sami Mujawar wrote:
> @@ -310,6 +318,7 @@ GenericWatchdogEntry (
> {
> EFI_STATUS Status;
> EFI_HANDLE Handle;
> + UINT32 WatchdogIId;
> [SA
Hi Pierre,
I have some minor feedback inline marked [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/12/2023, 09:30, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
The SCP holds some power information that could be advertised
through
Hi Pierre,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/12/2023, 09:31, "pierre.gond...@arm.com <mailto:pierre.gond...@arm.com>"
mailto:pierre.gond...@arm.com>> wrote:
From: Pierre Gondois mailto:
Hi Pierre,
Thank you for this patch.
I just have a minor suggestion marked inline as [SAMI].
Otherwise, this patch looks good to me.
With that addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/12/2023, 09:31, "pierre.gond...@arm.com <mailto:pierre.gond...
Hi Pierre,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 12/12/2023, 09:31, "pierre.gond...@arm.com <mailto:pierre.gond...@arm.com>"
mailto:pierre.gond...@arm.com>> wrote:
From: Pierre Gondois mailto:pierre.g
Hi Pierre,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 25/01/2024, 12:48, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Hello Sami,
On 1/25/24 12:31, Sami Mujawar wrote:
> Hi Pierre,
>
> Thank you for this patch.
> I just ha
Hi Laszlo,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/10/2023, 14:42, "Laszlo Ersek" mailto:ler...@redhat.com>> wrote:
Hi Sami,
On 10/12/23 14:33, Sami Mujawar wrote:
> Hi Laszlo,
>
> Thank you for this patch.
> These changes lo
Dear Basetool Maintainers,
Is it possible to provide feedback for this patch, please?
This patch fixes an issue that is blocking the patch series at
https://edk2.groups.io/g/devel/message/109178 from being merged.
Regards,
Sami Mujawar
On 13/10/2023, 08:36, "Sami Mujawar" mailto
Hi Jeshua,
Thank you for these fixes.
For this series,
Reviewed-by: Sami Mujawar
I have now queued this up for merging.
Regards,
Sami Mujawar
On 06/10/2023 05:28 pm, Jeshua Smith wrote:
While using the ConfigurationManagerObjectParser to dump objects and debug
adding new objects, I
Merged as c591395f4ab5..ec7f73436646
Thanks.
Regards,
Sami Mujawar
On 23/10/2023 05:55 pm, Sami Mujawar via groups.io wrote:
Hi Jeshua,
Thank you for these fixes.
For this series,
Reviewed-by: Sami Mujawar
I have now queued this up for merging.
Regards,
Sami Mujawar
On 06/10/2023 05
Hi Jeshua,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/10/2023 05:38 pm, Jeshua Smith wrote:
AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable
and MemoryRangeType parameters treat specific values
I had to add an entry to satisfy the CI spell checker.
With that,
Merged as ec7f73436646..309450db268c
Regards,
Sami Mujawar
On 23/10/2023 06:12 pm, Sami Mujawar via groups.io wrote:
Hi Jeshua,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards
Dear MdePkg Maintainers,
Can I have your review feedback for the first 2 patches in this series,
please?
- MdePkg: MADT: Add Online capable flag in GICC
- MdePkg: MADT: Add TRBE interrupt to GICC
I plan to merge this series by end of this week.
Regards,
Sami Mujawar
On 23/10/2023 04:30 pm
Hi Jose,
Thank you for this patch.
There was a minor numbering change that I have done before pushing the patch
for merging.
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this
Merged as 4f3ee7fbafc8..a671a14e63fd
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110318): https://edk2.groups.io/g/devel/message/110318
Mute This Topic: https://groups.io/mt/101522262/21656
Group Owner
Merged as dc8de7cc888f..1ae7cffab740
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110319): https://edk2.groups.io/g/devel/message/110319
Mute This Topic: https://groups.io/mt/101522378/21656
Group Owner
update the GICC info object parser to add an entry to parse
the ET reference token. Without this change an assert
stating that the RemainingSize != 0 will be triggered.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
| 3 +
Hi Chao,
Thank you for this patch.
I have a few suggestions marked inline as [SAMI].
Otherwise this patch looks good to me.
With those fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 06/11/2023 03:29 am, Chao Li wrote:
Moved PcdDeviceTreeInitialBaseAddress and
Hi Ashish,
Thank you for this fix.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 15/11/2023 03:19 am, Ashish Singhal wrote:
Just like CPU _UID, ETE UID also needs to be unique so
use AcpiProcessorUid instead of CpuName
Signed-off-by: Ashish Singhal
Hi Ashish,
I have created a bugzilla ticket for this at
https://bugzilla.tianocore.org/show_bug.cgi?id=4600.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111471): https://edk2.groups.io/g/devel/message/111471
Hi Laszlo, Liming, Mike,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 17/11/2023 09:20 am, Laszlo Ersek wrote:
On 11/15/23 04:19, Ashish Singhal via groups.io wrote:
Just like CPU _UID, ETE UID also needs to be unique so
use AcpiProcessorUid instead of CpuName
k you for picking this patch for the stable tag. Apparently, the
patch does not seem to have merged.
I am not sure if you have already applied the push label. Please let me know if
there are any issues that I can help with.
Regards,
Sami Mujawar
Thanks
Liming
> -----邮件原件-
> 发件人: S
Hi Liming,
Thanks a lot. I can see it in the mainline.
Regards,
Sami Mujawar
On 21/11/2023, 14:15, "gaoliming" mailto:gaolim...@byosoft.com.cn>> wrote:
Sami:
I have merged it. Please check.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io <ma
Hi Leif,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 09/11/2023, 13:12, "disc...@edk2.groups.io <mailto:disc...@edk2.groups.io>
on behalf of Leif Lindholm via groups.io" mailto:disc...@edk2.groups.io> on behalf of
quic_llindhol=quicinc@groups
Hi Ray,
On 29/11/2023, 00:56, "Ni, Ray" mailto:ray...@intel.com>>
wrote:
It's good. But I am curious why --ignore-change-id is needed?
[SAMI] This option can be useful if an internal CI uses the same script for
checking patches before they are posted on the list.
R
umably, if you have an internal gerrit instance
that runs CI before pushing, PatchCheck.py may be part of the CI
workflow; in those cases, we don't want it to error out.
So the CI would be adapted to do PatchCheck.py --ignore-change-id, and
all is well.
[SAMI] Just saw your email. You have
Hi Levi,
Apparently, you have not posted the patch to the edk2 mailing list.
Can you post a v2 series with the line ending issue fixed to the mailing list,
please?
Regards,
Sami Mujawar
On 30/11/2023, 10:30, "Sami Mujawar" mailto:sami.muja...@arm.com>> wrote:
Hi Thomas,
B
Forwarding this discussion as it unfortunately missed the mailing list.
Regards,
Sami Mujawar
On 29/11/2023 12:33 pm, Yeo Reum Yun wrote:
Thanks Pierre :)
+add Taylor Beebe
@Taylor Beebe
Hi Taylor! Thanks for your recent patch related to ImagePropertiesRecordLib!
But, after applying your
Hi Levi,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 30/11/2023, 14:29, "levi.yun" mailto:yeoreum@arm.com>> wrote:
The edk2 commit 7284c44951cffd52f1a08367d91b5c63c7bb9c16
introduces a new library ImagePropertiesRecordLib to
consolida
Merged as b95395ba400e..3220cb309390
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112043): https://edk2.groups.io/g/devel/message/112043
Mute This Topic: https://groups.io/mt/102894400/21656
Group Owner
Hi Rebecca,
Can you let me know if I can merge this patch, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114568): https://edk2.groups.io/g/devel/message/114568
Mute This Topic: https://groups.io/mt
Hi Levi,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114572): https://edk2.groups.io/g/devel/message/114572
Mute This Topic
Hi Rebecca,
I have created a pull request at
https://github.com/samimujawar/edk2/pull/new/REVIEW_2986_basetools_pcd_declare_lib_instance_v1
Regards,
Sami Mujawar
From: on behalf of "Sami Mujawar via groups.io"
Reply to: "devel@edk2.groups.io" , Sami Mujawar
Date: Fri
Hi Pierre,
Thank you for the updated patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 25/01/2024, 15:19, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Add an object describing _PSD information, cf. ACPI 6.5,
s8.4.5.5 _PSD (P-State Dependency).
Also add t
Hi Pierre,
Thank you for the updated patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 25/01/2024, 15:19, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Add AmlCreatePsdNode() to the AmlLib to generate _PSD objects.
_PSD objects allow to describe 'p
Apologies for the delay.
Merged as 74b5309da9fb..ba9c3ceaf83d
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116042): https://edk2.groups.io/g/devel/message/116042
Mute This Topic: https://groups.io/mt
Hi Ard, Leif,
This patch adds macros that can be used to validate that the SPI ranges are
valid.
These have been define here so that we do not duplicate it at multiple places.
Can you let me know if I can merge this patch, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
+Resending with email address for maintainers.
Hi Ard, Leif,
This patch adds macros that can be used to validate that the SPI ranges are
valid.
These have been define here so that we do not duplicate it at multiple places.
Can you let me know if I can merge this patch, please?
Regards,
Sami
Hi Sahil,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116161): https://edk2.groups.io/g/devel/message/116161
Mute This Topic: https://groups.io/mt
Hi Sahil,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116254): https://edk2.groups.io/g/devel/message/116254
Mute This Topic
, 0x31AD, 0x4B20, { 0x=
> 8F, 0x5F, 0xB3, 0xE8, 0x24, 0x6F, 0x80, 0x2B } }=0D
These changes should be part of patch 2/4. I am going to move this file to the
correct patch before merging.
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
1 - 100 of 1720 matches
Mail list logo
