Hi Rebecca,
On 24/01/2024, 19:36, "Rebecca Cran" <rebe...@os.amperecomputing.com
<mailto:rebe...@os.amperecomputing.com>> wrote:
On 1/23/2024 7:10 AM, Sami Mujawar wrote:
> @@ -310,6 +318,7 @@ GenericWatchdogEntry (
> {
> EFI_STATUS Status;
> EFI_HANDLE Handle;
> + UINT32 WatchdogIId;
> [SAMI] Minor, the above variable name should be WatchdogIid to comply with
> the coding standard.
I was wondering about the naming, since it's the "Watchdog Interface
ID". Since the second "I" is for another word, should it still be
lower-case?
[SAMI] I agree. If it passes the CI checks (uncrustify/ecc), I think it should
be ok.
Regards,
Sami Mujawar
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114381): https://edk2.groups.io/g/devel/message/114381
Mute This Topic: https://groups.io/mt/103832319/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
