Forwarding this discussion as it unfortunately missed the mailing list.

Regards,

Sami Mujawar

On 29/11/2023 12:33 pm, Yeo Reum Yun wrote:
Thanks Pierre :)

+add Taylor Beebe

@Taylor Beebe

Hi Taylor! Thanks for your recent patch related to ImagePropertiesRecordLib!

But, after applying your patches, some platform might experience build failure 
for the new library.

Many thanks.

________________________________________
From: Pierre Gondois <pierre.gond...@arm.com>
Sent: 29 November 2023 12:24
To: Yeo Reum Yun; ardb+tianoc...@kernel.org; Thomas Abraham; Sami Mujawar
Cc: leif.lindh...@linaro.org; Matteo Carlini; nd; Arvind Chauhan
Subject: Re: [edk2-platform] [PATCH] Platform/ARM: Fix build failure for FVP 
and Juno.

Hello Levi,

Tested-by: Pierre Gondois <pierre.gond...@arm.com>

Also it seems the following platforms (I assume this might affect others
aswell) have the same issue:
- Platform/Ampere/JadePkg/Jade.dsc
- Platform/RaspberryPi/RPi4/RPi4.dsc
- Platform/Qemu/SbsaQemu/SbsaQemu.dsc

Maybe it should be worth pinging the author of the commit at:
https://edk2.groups.io/g/devel/message/111744

On 11/29/23 12:44, levi.yun wrote:
The edk2 commit 7284c44951cffd52f1a08367d91b5c63c7bb9c16
introduces a new library ImagePropertiesRecordLib to
consolidate the logic for manipulating the image properties
used to track runtime images and to remove duplicate code.
This library is further linked with DxeCore.

Therefore, add an instance of ImagePropertiesRecordLib to
the ArmVExpress.dsc.inc file so that it is included for Arm
platforms.

Signed-off-by: Levi Yun <yeoreum....@arm.com>
---
   Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
   1 file changed, 1 insertion(+)

diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc 
b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index 
5e6886b30c8e507939a73b97366e2247a1430cef..9c9e1f79c8869639c01a0f257633dd8a8a686c3b
 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -164,6 +164,7 @@ [LibraryClasses.common]
     
CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf

     
ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
+  
ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf

   [LibraryClasses.common.SEC]
     
DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf
--
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111904): https://edk2.groups.io/g/devel/message/111904
Mute This Topic: https://groups.io/mt/102893425/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to