Hi Levi, Apparently, you have not posted the patch to the edk2 mailing list. Can you post a v2 series with the line ending issue fixed to the mailing list, please?
Regards, Sami Mujawar On 30/11/2023, 10:30, "Sami Mujawar" <sami.muja...@arm.com <mailto:sami.muja...@arm.com>> wrote: Hi Thomas, Before I go ahead and merge this patch, can you confirm that the Sgi/RD, N1sdp and Morello platforms builds work with this patch, please? Regards, Sami Mujawar On 30/11/2023, 10:24, "Sami Mujawar" <sami.muja...@arm.com <mailto:sami.muja...@arm.com> <mailto:sami.muja...@arm.com <mailto:sami.muja...@arm.com>>> wrote: Hi Levi, Thank you for this patch. There appears to be a line ending issue with your patch which I will fix locally before merging. However, can you check your git/editor configuration and also try running patchcheck.py in the future, please? Reviewed-by: Sami Mujawar <sami.muja...@arm.com <mailto:sami.muja...@arm.com> <mailto:sami.muja...@arm.com <mailto:sami.muja...@arm.com>>> Regards, Sami Mujawar On 29/11/2023 11:44 am, levi.yun wrote: > The edk2 commit 7284c44951cffd52f1a08367d91b5c63c7bb9c16 > introduces a new library ImagePropertiesRecordLib to > consolidate the logic for manipulating the image properties > used to track runtime images and to remove duplicate code. > This library is further linked with DxeCore. > > Therefore, add an instance of ImagePropertiesRecordLib to > the ArmVExpress.dsc.inc file so that it is included for Arm > platforms. > > Signed-off-by: Levi Yun <yeoreum....@arm.com <mailto:yeoreum....@arm.com> > <mailto:yeoreum....@arm.com <mailto:yeoreum....@arm.com>>> > --- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index > 5e6886b30c8e507939a73b97366e2247a1430cef..9c9e1f79c8869639c01a0f257633dd8a8a686c3b > 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -164,6 +164,7 @@ [LibraryClasses.common] > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > > > > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > + > ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf > > > > [LibraryClasses.common.SEC] > > DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf > > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111902): https://edk2.groups.io/g/devel/message/111902 Mute This Topic: https://groups.io/mt/102893425/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
