original lib mappings are preserved.
Cc: Liming Gao
Signed-off-by: Michael D Kinney
Reviewed-by: Liming Gao
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 43 +++
FmpDevicePkg/FmpDevicePkg.dsc | 6 -
2 files changed, 48 insertions(+), 1 deletion(-)
create mode 100644
From: Sean Brogan
Add YML configuration files used to run the EDK II Continuous
Integration (CI) checks on Azure Pipelines agents.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Liming Gao
Signed-off-by: Michael D Kinney
Reviewed-by: Liming Gao
---
.azurepipelines/Ubuntu-GCC5.yml
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Michael D Kinney
Acked-by: Zhichao Gao
Acked-by: Ray Ni
Reviewed-by: Liming Gao
---
ShellPkg/ShellPkg.ci.yaml | 55
original lib mappings are preserved.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Michael D Kinney
Reviewed-by: Liming Gao
Reviewed-by: Jian J Wang
---
SecurityPkg/SecurityPkg.ci.yaml | 80 +
SecurityPkg/SecurityPkg.dsc | 32 -
2
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Cc: Liming Gao
Signed-off-by: Michael D Kinney
Reviewed-by: Liming Gao
---
MdePkg/MdePkg.ci.yaml | 90 +++
1 file changed, 90 insertions(+)
create
From: Sean Brogan
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Michael D Kinney
Reviewed-by: Liming Gao
---
BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21 +++
BaseTools/Bin/gcc_arm_linux_ext_dep.yaml | 21 +++
BaseTools/Bin/iasl_ext_dep.yaml | 21 +++
BaseTools/Bin
Use BaseCryptLibNull for package CI builds to reduce package
build times. Enabled with PYTOOL_CONTINUOUS_INTEGRATION in YAML
files. By default PYTOOL_CONTINUOUS_INTEGRATION is not defined,
and the original lib mappings are preserved.
Cc: Jiewen Yao
Cc: Chao Zhang
Signed-off-by: Michael D
Update Readme.md with status badges from the most recent
EDK II Continuous Integration(CI) build.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
Acked-by: Laszlo Ersek
Reviewed-by: Liming Gao
---
Readme.md | 51
.py issues and
reopen the PR.
Cc: Liming Gao
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Michael D Kinney
Reviewed-by: Liming Gao
---
.mergify/config.yml | 97 +
1 file changed, 97 insertions(+)
create mode 100644 .mergify/config.yml
diff
* LibraryClassCheck
* SpellCheck
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Liming Gao
Signed-off-by: Michael D Kinney
Reviewed-by: Liming Gao
---
.../CharEncodingCheck/CharEncodingCheck.py| 118
.../CharEncodingCheck_plug_in.yaml| 11 +
.pytool/Plugin/CharEncodingCheck/Readme.md
From: Sean Brogan
Add main python script for EDK II Continuous Integration (CI)
builds along with a Readme.md that provides a summary of the
packages, platforms, and checks performs during a CI build.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Liming Gao
Signed-off-by: Michael D Kinney
Reviewed
> Subject: Re: [Patch v5 03/22] pip_requirements.txt: Add
> python pip requirements file
>
> Hi Mike,
>
> On 11/11/19 09:40, Michael D Kinney wrote:
> > From: Sean Brogan
> >
> > Add pip requirements file that is used to install the
> python pip
> >
results
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Liming Gao
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
Readme.md | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/Readme.md b/Readme.md
index dcd86daef1..678428bdcf
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Update Readme.md to indicate that that status badges are for
the edk2/master branch.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Liming Gao
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
Readme.md
EDK II Maintainers,
EDK II CI Phase 1 feature is now active on edk2/master.
Please use a GitHub pull request from a branch in a personal
fork of the edk2 repository with a 'push' label to request
a set of patches to be pushed to edk2/master. The GitHub PR
replaces the 'git push' operation curren
Ray,
I agree that a name that represents the symbolic debug
format makes more sense.
The term 'PE' is short for PE/COFF, and that is the
required final output format. A toolchain profile that
happens to go through other intermediate formats (e.g.
elf or macho) before finally generating a PE/CO
6 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> ; Sean Brogan
> ; Bret Barkelew
> ; Gao, Liming
>
> Subject: Re: [edk2-devel] EDK II Maintainers - EDK II
> CI is now active on edk2/master
>
> On 11/12/19 03:55, Michael D Kinney wrote:
> > EDK II Maint
From: Laszlo Ersek
> > Sent: Tuesday, November 12, 2019 12:56 AM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > ; Sean Brogan
> ;
> > Bret Barkelew ; Gao,
> Liming
> >
> > Subject: Re: [edk2-devel] EDK II Maintainers - EDK II
> C
ay
> Subject: Re: [edk2-devel] EDK II Maintainers - EDK II
> CI is now active on edk2/master
>
> Hi again,
>
> (+Ray)
>
> On 11/12/19 03:55, Michael D Kinney wrote:
> > EDK II Maintainers,
> >
> > EDK II CI Phase 1 feature is now active on
> edk
Series
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Leif Lindholm
> Sent: Wednesday, November 13, 2019 10:00 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Marcin
> Wojtas ; Kinney, Michael D
> ; W
rerequisite of removing dependency of
> TimerLib from OpensslLib.
> > RngLib will be used instead. To avoid build failure,
> add the null
> > instance of it in advance.
> >
> > Cc: Michael D Kinney
> > Cc: Kelly Steele
> > Cc: Dandan Bi
&g
r other
> software DRNG. This patch adds a C interface
> AsmRdSeed() to wrap it in BaseLib so that we can add a
> new RngLib for users to choose in their platform, if
> their processor support rdseed instruction.
>
> Ref:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1871
>
sary
>
> Cc: Ard Biesheuvel
> Cc: Bret Barkelew
> Cc: Chao Zhang
> Cc: Jiaxin Wu
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Cc: Liming Gao
> Cc: Maciej Rabeda
> Cc: Matthew Carlson
> Cc: Michael D Ki
s
> which supports rdseed instruction.
>
> Ref:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1871
> Cc: Jiewen Yao
> Cc: Chao Zhang
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Ray Ni
> Signed-off-by: Jian J Wang
> ---
> .../RngLibRdSeed/RngL
> > > > ; Kinney, Michael D
> > > > ; Gao, Liming
> ;
> > > > Ni, Ray
> > > > Subject: [edk2-devel] [PATCH 05/11]
> > > > SecurityPkg/RngLibRdSeed: add an instance of
> RngLib to make use
> > > > rdseed
> > >
PEI Phase execution environment is focused on BSP execution.
The PEI Services and most of the PPI services are not designed
to be MP safe. Since it is not safe for an AP to call PEI Services,
the IDT entry with the pointer to the PEI Service Table is
not available to an AP to prevent code from inc
That is the only reason the IDTs are different.
Earlier in this project, the same IDT was used by BSP and
APs. This meant APs could call PEI Services and we did not
know until there was a side effect. By using different IDTs,
we catch APs calling PEI Services immediately.
Mike
> -Original
Ray,
I agree that removing all UGA content makes the most sense.
Mike
From: Ni, Ray
Sent: Monday, November 18, 2019 11:59 PM
To: devel@edk2.groups.io; Gao, Zhichao ; Kinney, Michael
D
Cc: Jonathan O'Neal
Subject: RE: EDK2 bug report
+ Zhichao, Mike and mailing list.
In general, if the code
Bret Barkelew
> ; Gao, Liming
>
> Cc: Leif Lindholm (Nuvia address) ;
> Andrew Fish
> Subject: [EXTERNAL] Re: [edk2-devel] EDK II Maintainers
> - EDK II CI is now active on edk2/master
>
> On 11/12/19 03:55, Michael D Kinney wrote:
>
> > Please let us
Laszlo,
If the dev branch that is being submitted as a PR
contains the merge commit, or that developer use the
one of the github features to rebase, the merge
commit can be introduced.
When a PR is in this state, the developer need to
clean up their history locally and do a forced
push or open a
Laszlo,
My guess is the Mergify only allows commands from
GitHub users with admin roles on a repo. Which
would explain why I can submit those commands but
you and Sean got that message.
I would prefer that this condition never occur
and we never need to use these commands. It sounds
like Merg
Sean,
This is the reason that OvmfPkg was kept in the edk2 repo so only a single repo
is required for local dev testing and CI testing. Same reason for the
EmulatorPkg.
The current rule for the edk2 repo is common firmware packages and
virtual/emulated platforms.
The fact that there has not b
Laszlo,
I understand your frustration. Let's work on resolving
these issues.
What browser are you using? I would like the reproduce
that issue and report to GitHub. Do you a screen shot
where the labels button is not visibe?
Did you use the same branch name or a new branch name with
the sam
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Xu, Wei6
> Sent: Tuesday, March 17, 2020 11:12 PM
> To: devel@edk2.groups.io
> Cc: Kun Qin ; Kinney, Michael D
> ; Gao, Liming
>
> Subject: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix
> uninit
Vitaly,
The break you are seeing is because you are not using functions to eval the
PCD. This is a known restriction in how PCDs work between libs and modules and
is why the current design uses the XxxEnabled() functions.
I have not reviewed this issue in a very long time, so I do not know if
Vitaly,
It has to do with where PCDs are declared in INF files.
If you access a PCD from a macro like you have added to a library class, the
module using that library class does not know there is a macro that uses a PCD.
So the PCD declaration in the Module INF is missing. By only using the P
Abner,
Let's not add the YAML file for a new package until
the content for the new package is added or add the
YMAL file with the patch series that adds the new package.
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Abner Chang
> Sent: Monday, March 9,
Abner,
Let's not add the YAML file for a new package until
the content for the new package is added or add the
YMAL file with the patch series that adds the new package.
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Abner Chang
> Sent: Monday, March 9, 2
t; > To: devel@edk2.groups.io
> > > > > Cc: abner.ch...@hpe.com; Leif Lindholm
> ;
> > > > > Kinney, Michael D ;
> Gao, Liming
> > > > > ; Ard Biesheuvel
> > > > > ; Laszlo Ersek
> ; Bi,
> > > > > Dandan ; Daniel Sc
Liming,
I agree that spec updates would be good so the CPU arch
name RISCV64 can be reserved.
However, I believe the current specs define their EBNF
to be flexible and support new CPU archs without a spec
change. As long as BaseTools follows the EBNF, no build
tool changes should be required to
11.h.
> Since CXL uses the underlying PCIe technology for
> interconnect, it uses
> the PCIe Extended Capability DVSEC structures for its
> Flex Bus registers,
> hence the Flex Bus registers are defined to reference
> the PCIe headers.
>
> Signed-off-by: Ashraf Javeed
ter 7 of CXL Base
> Specification Rev.1.1
> > > are ported into the new Cxl11.h.
> > > Since CXL uses the underlying PCIe technology for
Hi Roman,
Thank you for the contribution to homebrew that simplifies
installing dependencies for Xcode.
I tested this with an Azure Pipelines agent.
https://dev.azure.com/mikekinney/edk2-ci/_build/results?buildId=953&view=logs&j=92151bb0-8a7b-5cbb-0979-21238daa6c94
Tested-by: Michael
53&view=logs&j=92151bb0-
> 8a7b-5cbb-0979-21238daa6c94
>
> Tested-by: Michael D Kinney
>
> Reviewed-by: Michael D Kinney
>
>
> I will push this update to the Wiki.
>
> Thanks,
>
> Mike
>
> > -Original Message-
> > From: devel@ed
, I think it will
> always have correct mfmpImageInfoBuf[] address.
>
> Of course, it is ok to use AllocateZeroPool to ensure
> zero buffer is allocated.
>
> Thanks
>
> > -Original Message-----
> > From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Jiang, Guomin
> Sent: Sunday, March 22, 2020 10:56 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> ; newexplor...@gmail.com
> Cc: Kinney, Michael D ;
> sean.bro...@microsoft.com; bret.barke...@micros
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Jiang, Guomin
> Sent: Sunday, March 22, 2020 11:08 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> ; newexplor...@gmail.com
> Cc: Kinney, Michael D ;
> Sean Brogan ; Bret Barkelew
>
> Subject:
> > Subject: [edk2-devel] [PATCH v3]
> MdePkg/UnitTestBaseLib: Add check for
> > > pointer BinData
> > >
> > > REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2531
> > >
> > > AllocatePool may fail and BinData may be invalid,
> ch
HI Bret,
You reposted the issue in BZ, so your review is very valuable to make sure the
change proposed addresses the issue reported.
Reviews by Maintainers/Reviewers documented in Maintainers.txt are required to
do the commit, but we welcome reviews from anyone in the community that wants
to
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Jiang, Guomin
> Sent: Monday, March 23, 2020 6:43 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> Gao, Liming
> Subject: [PATCH v4] MdePkg/UnitTestBaseLib: Add check
> for pointer B
he performance
> > > > > for the case when the BSP uses WaitForEvent()
> or uses CheckEvent()
> > > > > in a loop to wait for AP(s) to complete the
> task, especially when
> > > > > the task can be finished considerably fast on
> AP(s).
> >
The main issue with use of extended registers is
that the default interrupt/exception handler for
IA32/X64 does FXSAVE/FXRSTOR.
https://github.com/tianocore/edk2/blob/5f7c91f0d72efca3b53628163861265c89306f1f/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm#L244
https://gith
72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637208030668393225&sdata=TkqjqO7Fi%2BN7FPgJ0FlRcD4T59zCu7hfWQRbb%2FO5dKA%3D&reserved=0
OvmfPkg and EmulatorPkg are mostly used by the developers, so add
them to target list.
Cc: Sean Brogan mailto:sean.bro...@microsoft.com>>
Cc: Bret Barkelew
mai
08d7d1e1e394%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637208640427947736&sdata=paW9upRWw3kGWHGW7fXE1ecdQ%2FfxfXMt0s%2BYH15llW8%3D&reserved=0>
OvmfPkg and EmulatorPkg are mostly used by the developers, so add
them to target list.
Cc: Sean Brogan mailto:sean.bro...@microsoft.com>>
Cc: Br
We should not use #if statements in C code.
Also, we should not be changing the layout of the
structure based on a PCD feature flag.
I agree we need to ability to disable the use of some
Crypto services, but we need to decide what behavior
we want at build time and boot time if there is code
tha
Jiewen,
The purpose of private includes is to keep modules/lib
in *other* packages from using interfaces that are the
package with the private interface does not want other
packages to use and does not want to have to coordinate
with other packages if that package owner decides to
make changes to
Hi,
I would prefer we only extend the protocol interface and
never remove any fields from the Protocol/PPI structures
so no offsets are ever changed.
The main remaining issue is how a platform developer knows
if they are using a deprecated interface. The best method
is to know at build time wit
Hi Laszlo,
I think using the QEMU feature to map a path from the host as
a FAT formatted driver has value to provision QEMU with a set
of target tests to run. I agree there is no persistent storage
of writes to this type of drive. I believe writes are supported
if file state is needed during th
Sean,
I agree a r/w file system with simple access from host and QEMU is a much
better choice. When Laszlo gets some time, I would be interested in his
recommendations. My negative experience was from a Windows host. Perhaps that
are must better virtual disk tools from a Linux host.
Mike
F
ARM and AARCH64 have a compiler intrinsic lib that is linked against all
modules.
[LibraryClasses.ARM, LibraryClasses.AARCH64]
#
# It is not possible to prevent ARM compiler calls to generic intrinsic
functions.
# This library provides the instrinsic functions generated by a given
compile
Hi Sean,
This lib defines a global variable that is referenced when a compiler detects
use of float/double types. If the global is not referenced, then it should be
optimized away, so the size impact should be zero. That can be verified as
part of the review of this feature.
Mike
From: de
Hi Pierre,
We discussed this in the bug scrub yesterday.
We think there may be a simpler way to address this issue
without extending the INF syntax.
It is our understanding that the ASL files need to be
processed before C files when both are present in an INF.
This is similar to the requirement
Hi Ard,
I think adding a dependency in the module entry point
libs is also good way to guarantee an intrinsic lib
is available. I agree that it can provide module type
and arch specific mappings. The NULL lib instance can
do the same if the NULL instance is listed in the
module/arch specific li
It would also be good to clearly document the status of all
tool chain tags in a few places:
https://github.com/tianocore/edk2/blob/master/BaseTools/Conf/tools_def.template
https://github.com/tianocore/edk2/blob/master/Readme.md
The status I can think of are:
1) Actively used by EDK II CI. This
Rebecca,
The current use of that field is to identify previous
releases that a bug fix needs to be propagated to.
We do not know the exact release name for future releases
until we make the release.
I recommend you use the "Deadline" field to provide
the date the feature must be implemented, rev
t; Subject: Re: [edk2-devel] Need newer releases/tags added
> to TianoCore Bugzilla
>
> Okay, but the edk2-stable202002 release is also missing.
>
>
> --
> Rebecca Cran
>
>
> On 4/2/20 1:24 PM, Michael D Kinney wrote:
> > Rebecca,
> >
> > The current
The default build of the shell does not include AcpiView.
However, there is a second version of the shell built from
ShellPkg.dsc that does include the AcpiView command.
#
# Build a second version of the shell with all commands integrated
#
ShellPkg/Application/Shell/Shell.inf {
Hi Liming,
I do not see this change checking that the license is in a proper
SPDX Identifier statement?
https://spdx.org/ids-how
Only checking the for a license name is not sufficient.
A file may be covered by more than one license. What is the behavior in
this case?
The EDK II proj
Leif,
PatchCheck.py should only check added lines, not removed lines.
Are you seeing an error on a removed line?
Mike
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, April 22, 2020 8:47 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Laszlo Ersek
> ; Kinney, Michael D
>
Update the integrated UEFI Shell to include the acpiview,
ping6, and ifconfig6 commands.
Cc: Zailiang Sun
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 ++
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 ++
2 files changed
Bob,
I have verified that the shell is rebuilt correctly when
the number of NULL lib instances are changed.
Tested-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Bob Feng
> Sent: Monday, August 12,
Hi Andy,
Thanks for the contribution. Is this patch for the edk2-platform repo? The
email subject can help clarify the intended repo.
Also, we prefer the patches to be provided inline instead of an attachment.
You can use the
'git send-email' feature to do this. Here are a couple links to u
Liming,
I think a good candidate to demonstrate this
feature are the checks made in MdePkg/Include/Base.h.
The current implementation forces a divide by 0
in the C pre-processor to break the build.
STATIC_ASSERT() would be a better way to do this.
I would also remove unused externs from the build
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of vit9696 via
> Groups.Io
> Sent: Tuesday, August 13, 2019 1:17 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATC
Vitaly,
When implementing a UEFI Application, if you want maximum compatibility, you
should use UEFI Services/Protocols and minimize as many HW assumptions as
possible.
I understand, especially for accurate time and clock related services, the that
the UEFI Specification defined Services/Proto
Fix scripts to support lldb symbolic debugging when
using XCODE5 tool chain.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
---
EmulatorPkg/Unix/lldbefi.py | 8 +---
EmulatorPkg/build.sh| 17 ++---
2 files changed, 7 insertions(+), 18
environment.
The Readme.md, BAT, and sh files are also updated
to remove the use of these defines.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Reviewed-by: Hao A Wu
Reviewed-by: Jordan Justen
---
EmulatorPkg/EmulatorPkg.dsc| 26
resource section that is not supported by the
XCODE5 tool chain, and the missing HII content causes
the load of this module to ASSERT().
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
---
EmulatorPkg/EmulatorPkg.dsc | 4
EmulatorPkg/EmulatorPkg.fdf | 4
-off-by: Michael D Kinney
Michael D Kinney (10):
EmulatorPkg: Fix VS20xx IA32 boot failure
EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES
EmulatorPkg: Add support for NOOPT target
EmulatorPkg/Unix/Host: Disable inline/optimizations
Add -gdwarf to XCODE5 X64 builds to generate symbols for
source level debug using lldb.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
---
BaseTools/Conf/tools_def.template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Conf
Add NOOPT to BUILD_TARGETS in DSC file.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Reviewed-by: Hao A Wu
Reviewed-by: Jordan Justen
---
EmulatorPkg/EmulatorPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmulatorPkg
can
potentially cause a boot failure if this address specified
by the PCD is already allocated in the user process.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Reviewed-by: Hao A Wu
Reviewed-by: Jordan Justen
---
EmulatorPkg/EmulatorPkg.dec | 4 ++--
1 file
Cc: Ray Ni
Signed-off-by: Michael D Kinney
---
EmulatorPkg/Unix/Host/Host.c | 3 +++
EmulatorPkg/Unix/Host/Host.inf | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/EmulatorPkg/Unix/Host/Host.c b/EmulatorPkg/Unix/Host/Host.c
index febfb1f44c..b431a4c2ed 100644
--- a
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Reviewed-by: Hao A Wu
Acked-by: Jordan Justen
---
EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c | 9 +-
EmulatorPkg/EmulatorPkg.dsc | 6 +-
EmulatorPkg/FlashMapPei/FlashMapPei.c | 8 +-
EmulatorPkg
* Fix uninitialized Private->ReadBuffer.
* Remove old debug code that generates an exception.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
---
EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --gi
function so the storage for
this local variable is allocated for the entire
lifetime of the function.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
---
EmulatorPkg/Sec/Sec.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a
; To: Kinney, Michael D ;
> devel@edk2.groups.io
> Cc: Ni, Ray ; Andrew Fish
>
> Subject: Re: [Patch V4 06/10] EmulatorPkg: Fix XCODE5
> lldb issues
>
> On 2019-08-15 19:14:33, Michael D Kinney wrote:
> > Fix scripts to support lldb symbolic debugging when
> using XCODE5
Laszlo,
I agree that better comments/documentation of STATIC_ASSERT()
for EDK II usages is required. For example, EDK II defines
the ASSERT() macro which is based on the standard C function
assert(), but we still document it fully for EDK II usage.
/**
Macro that calls DebugAssert() if an expr
he
> combinations listed
> > above.
> >
> > https://dev.azure.com/mikekinney/edk2-
> ci/_build/results?buildId=312
> >
> > Mike
> >
> > > -Original Message-
> > > From: Justen, Jordan L
> > > Sent: Friday, August 16, 2
From: Andrew Fish
Remove old debug code that generates an exception.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
Reviewed-by: Michael D Kinney
Tested-by: Andrew Fish
---
EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 4
1 file changed, 4 deletions
is to move the declaration of PpiArray[10] to
the beginning of the function, so it is scoped correctly
for all references to this local variable and references
to its location.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
Reviewed-by: Michael D Kinney
Tested-by
VS20xx IA32 boot failure
* Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
* Add -D DISABLE_NEW_DEPRECATED_INTERFACES
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Andrew Fish (7):
EmulatorPkg/Unix/Host: Disable inline/optimizations
EmulatorPkg: Fix XCODE5 lldb issues
Add NOOPT to BUILD_TARGETS in DSC file.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Reviewed-by: Hao A Wu
Reviewed-by: Jordan Justen
Tested-by: Andrew Fish
---
EmulatorPkg/EmulatorPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
environment.
The Readme.md, BAT, and sh files are also updated
to remove the use of these defines.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Reviewed-by: Hao A Wu
Reviewed-by: Jordan Justen
Tested-by: Andrew Fish
---
EmulatorPkg/EmulatorPkg.dsc
From: Andrew Fish
Fix scripts to support lldb symbolic debugging when
using XCODE5 tool chain.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
Reviewed-by: Michael D Kinney
Tested-by: Andrew Fish
---
EmulatorPkg/Unix/lldbefi.py | 8 +---
EmulatorPkg
bitmap in
a PE/COFF resource section that is not supported by the
XCODE5 tool chain, and the missing HII content causes
the load of this module to ASSERT().
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
Reviewed-by: Michael D Kinney
Tested-by: Andrew Fish
From: Andrew Fish
Initialize Private->ReadBuffer to NULL.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
Reviewed-by: Michael D Kinney
Tested-by: Andrew Fish
---
EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 1 +
1 file changed, 1 insertion(+)
diff --gi
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Reviewed-by: Hao A Wu
Acked-by: Jordan Justen
Tested-by: Andrew Fish
---
EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c | 9 +-
EmulatorPkg/EmulatorPkg.dsc | 6 +-
EmulatorPkg/FlashMapPei/FlashMapPei.c
can
potentially cause a boot failure if this address specified
by the PCD is already allocated in the user process.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Reviewed-by: Hao A Wu
Reviewed-by: Jordan Justen
Tested-by: Andrew Fish
---
EmulatorPkg
From: Andrew Fish
Add -gdwarf to XCODE5 X64 builds to generate symbols for
source level debug using lldb.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
Reviewed-by: Michael D Kinney
Tested-by: Andrew Fish
---
BaseTools/Conf/tools_def.template | 4 ++--
1
601 - 700 of 2711 matches
Mail list logo
