Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-11-02 Thread Laszlo Ersek
ect operation. > > This is a rebased version of the patch originally written by Pete Batard. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2831 > > Cc: Pete Batard > Cc: Daniel P. Berrangé > Cc: Gerd Hoffmann > Cc: Samer El-Haj-Mahmoud > Cc

Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-11-02 Thread Laszlo Ersek
s > now. "ready-to-boot for OsRecovery" is new in UEFI 2.10 (according to the commit message), which is quite recent ("Aug 29, 2022"). I couldn't find the Mantis ticket in the Revision History (for 2.10) though. Laszlo > > >> >> Ref: https://bugzi

Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

2023-11-02 Thread Laszlo Ersek
On 11/2/23 09:49, Tan, Dun wrote: > Laszlo, > > Thanks for your thorough and detailed research on this topic. With the test > result that you reproduced, I agree with your opinion. > So this patch set will be dropped and I'll raise another new patch set. In > the new patch set, I'll only change

Re: [edk2-devel] [PATCH 1/1] BaseTools: Update PatchCheck.py to allow whitespace issues in .rtf files

2023-11-02 Thread Laszlo Ersek
if self.binary: > +if self.binary or self.filename.endswith(".rtf"): > pass > elif line.startswith('-'): > pass superficially Acked-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all me

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks

2023-11-02 Thread Laszlo Ersek
On 11/1/23 02:12, Mike Maslenkin wrote: > On Tue, Oct 31, 2023 at 7:52 PM Henz, Patrick wrote: >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4578 >> >> The implementation of XhcGetElapsedTicks did not account for >> non-zero start and stop values for the performance counter >> timer, po

Re: [edk2-devel] [PATCH v4 11/14] UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if Nonzero

2023-11-02 Thread Laszlo Ersek
On 11/1/23 21:11, Taylor Beebe wrote: > This patch is the final in this series which needs a review. Can someone > take a look? I'll try to do that. I didn't have mail delivery enabled for the list in August. Can you resend v4, rebased, and with the R-b / A-b tags given thus far picked up? Sorry

Re: [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list

2023-11-02 Thread Laszlo Ersek
ath > used by opensource.org. > - The submodule list in this file is stale and is very prone to > being forgotten. The list of submodules in the submodules setion > is replaced with a link to .gitmodules which has an active list > of submodules at any given time. > > Cc: Andrew

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks

2023-11-02 Thread Laszlo Ersek
On 11/2/23 14:06, Pedro Falcato wrote: > On Thu, Nov 2, 2023 at 11:28 AM Laszlo Ersek > wrote: >> >> On 11/1/23 02:12, Mike Maslenkin wrote: [...] >>> Just curious why this patch was broken by google groups. >>> >>> Some patches to edk2 and edk2-r

Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2

2023-11-03 Thread Laszlo Ersek
On 11/3/23 02:03, Chao Li wrote: > This patch set will enable LoongArch virtual machine in edk2, the new > LoongArch virtual machine is located in OvmfPkg/LoongArchVirt/, it is a > generic platform that dose not require any actual hardware. > > Patch1-Patch14: Submit the common library and driver

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridgeDxe: Add readback after final Cfg-Write

2023-11-03 Thread Laszlo Ersek
On 11/3/23 01:03, Joe L wrote: > From: joelopez333 > > REF:https://edk2.groups.io/g/devel/topic/102310377#110456 > > - Add a read after the final PCI Configuration space write > in RootBridgeIoPciAccess. > > - When configuration space is strongly ordered, this ensures > that program executi

Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2

2023-11-03 Thread Laszlo Ersek
On 11/3/23 08:32, Chao Li wrote: > Hi Laszlo, > > Sorry, the reason of some mail is not under cover letter is found, I > will fix it at the V2. > > I don't think the code is **duplicated** since most code is architecture > related, and maybe some code is referenced from others ARCH. As  the > cov

Re: [edk2-devel] [PATCH v4 8/8] ReadMe.rst: Add CodeQL/analyze directory under other licenses

2023-11-03 Thread Laszlo Ersek
t; complete Apache License, Version 2.0 on apache.org. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Signed-off-by: Michael Kubacki > --- > ReadMe.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ReadMe.rst b/R

Re: [edk2-devel] [PATCH v1] OvmfPkg/PlatformInitLib: Don't override user specified PciMmio64Size

2023-11-03 Thread Laszlo Ersek
op-gap. And for the long term, this patch is not good enough. We should enhance the dynamic sizing, now that Gerd has put it into place. Thanks Laszlo > > Cc: Gerd Hoffmann > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Dongwon Kim > Signed-off-by: Vivek Kasireddy

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before restoring MSR IA32_S_CET

2023-11-03 Thread Laszlo Ersek
e should improve readability, I don't mind, but then it too belongs in a separate patch. Laszlo > > Signed-off-by: Sheng Wei > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Wu Jiaxin > Cc: Tan Dun > --- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 62 +

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

2023-11-03 Thread Laszlo Ersek
On 11/3/23 13:14, Wu, Jiaxin wrote: > Shadow stack will stop update after CET disable (DisableCet in > DisableReadOnlyPageWriteProtect), but normal smi stack will be > continue updated with the function return and enter > (DisableReadOnlyPageWriteProtect & EnableReadOnlyPageWriteProtect), > thus le

Re: [edk2-devel] [PATCH v1] OvmfPkg/PlatformInitLib: Don't override user specified PciMmio64Size

2023-11-03 Thread Laszlo Ersek
On 11/3/23 14:15, Laszlo Ersek wrote: > On 11/3/23 06:15, Vivek Kasireddy wrote: >> If the user specified a size for the PCI MMIO window via the option: >> -fw_cfg name=opt/ovmf/X-PciMmio64Mb,string=32768 >> then this patch ensures that the mmio window is not resized again. &g

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

2023-11-03 Thread Laszlo Ersek
On 11/3/23 15:10, Wu, Jiaxin wrote: > Hi Laszlo, > > Thanks the feedback. > >> >> Is this somehow related to >> >> [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before >> restoring MSR IA32_S_CET >> >> at >> >> https://edk2.groups.io/g/devel/message/110605 >> >> ? >> >> I'm no

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

2023-11-03 Thread Laszlo Ersek
On 11/3/23 13:14, Wu, Jiaxin wrote: > Shadow stack will stop update after CET disable (DisableCet in > DisableReadOnlyPageWriteProtect), but normal smi stack will be > continue updated with the function return and enter > (DisableReadOnlyPageWriteProtect & EnableReadOnlyPageWriteProtect), > thus le

Re: [edk2-devel] [PATCH v4 8/8] ReadMe.rst: Add CodeQL/analyze directory under other licenses

2023-11-03 Thread Laszlo Ersek
On 11/3/23 15:16, Michael Kubacki wrote: > On 11/3/2023 9:06 AM, Laszlo Ersek wrote: >> On 11/2/23 21:03, Michael Kubacki wrote: >>> From: Michael Kubacki >>> >>> The code in this directory is licensed under Apache License, Version >>> 2.0. Theref

Re: [edk2-devel] [PATCH v4 8/8] ReadMe.rst: Add CodeQL/analyze directory under other licenses

2023-11-03 Thread Laszlo Ersek
On 11/3/23 15:46, Laszlo Ersek wrote: > Given that that is not the case, just apply my R-b. :) > I don't object to any of the v4 patches getting merged as posted. To clarify: - for patches 1 through 7: Acked-by: Laszlo Ersek - for patch 8: Reviewed-by: Laszlo Ersek Than

Re: [edk2-devel] Bitbucket mirror stopped updating in March 2022

2023-11-03 Thread Laszlo Ersek
On 11/3/23 15:49, Rebecca Cran wrote: > I just noticed the Bitbucket mirror that's listed in Maintainers.txt > hasn't had any new commits since March 2022. > > > EDK II > -- > W: http://www.tianocore.org/edk2/ > L: https://edk2.groups.io/g/devel/ > T: git - https://github.com/tianocore/edk2.g

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Remove Orphan status option

2023-11-05 Thread Laszlo Ersek
Hi Mike, On 11/5/23 02:11, Michael D Kinney wrote: > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Laszlo Ersek > Signed-off-by: Michael D Kinney > --- > Maintainers.txt | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Maintainers.txt b/Maintaine

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

2023-11-05 Thread Laszlo Ersek
SignedCapsulePkg: https://bugzilla.tianocore.org/show_bug.cgi?id=4589 > SourceLevelDebugPkg: https://bugzilla.tianocore.org/show_bug.cgi?id=4590 Thanks, I've taken <https://bugzilla.tianocore.org/show_bug.cgi?id=4588>. Laszlo > > Best regards, > > Mike > >> -Original Messa

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

2023-11-05 Thread Laszlo Ersek
8dbfb4887da034d8691bfca969e3 (1) Please drop the Change-Id line; it is not meaningful in the upstream repo. > Cc: Eric Dong > Cc: Ray Ni > Cc: Zeng Star > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Cc: Laszlo Ersek > Signed-off-by: Jiaxin Wu > --- > UefiCp

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

2023-11-05 Thread Laszlo Ersek
On 10/3/23 17:04, Jake Garver via groups.io wrote: > Ignore old style declaration warnings in oniguruma/src/st.c. This was > already ignored for MSFT, but newer versions of clang complain as well. > > Signed-off-by: Jake Garver > --- > .../Universal/RegularExpressionDxe/RegularExpressionDxe.inf

Re: [edk2-devel] [PATCH v1 1/7] UefiCpuPkg/PiSmmCpuDxeSmm: Optimize Semaphore Sync between BSP and AP

2023-11-07 Thread Laszlo Ersek
On 11/3/23 16:30, Wu, Jiaxin wrote: > This patch is to define 3 new functions (WaitForBsp & ReleaseBsp & > ReleaseOneAp) used for the semaphore sync between BSP & AP. With the > change, BSP and AP Sync flow will be easy understand as below: > BSP: ReleaseAllAPs or ReleaseOneAp --> AP: WaitForBsp >

Re: [edk2-devel] [PATCH v1 2/7] UefiCpuPkg/PiSmmCpuDxeSmm: Reduce times of BSP and AP Sync for SMM Exit

2023-11-07 Thread Laszlo Ersek
On 11/3/23 16:30, Wu, Jiaxin wrote: > After review, there are unnecessary steps for BSP and AP sync for SMM > exit. This patch is to reduce one round BSP and AP sync so as to improve > SMI performance: > BSP: WaitForAllAPs <-- AP: ReleaseBsp > BSP: ReleaseAllAPs --> AP: WaitForBsp > > Change-Id: I

Re: [edk2-devel] [PATCH v1 3/7] UefiCpuPkg: Adds SmmCpuSyncLib library class

2023-11-07 Thread Laszlo Ersek
On 11/3/23 16:30, Wu, Jiaxin wrote: > Intel is planning to provide different SMM CPU Sync implementation > along with some specific registers to improve the SMI performance, > hence need SmmCpuSyncLib Library for Intel. > > This patch is to: > 1.Adds SmmCpuSyncLib Library class in UefiCpuPkg.dec.

Re: [edk2-devel] [PATCH v1 1/7] UefiCpuPkg/PiSmmCpuDxeSmm: Optimize Semaphore Sync between BSP and AP

2023-11-07 Thread Laszlo Ersek
On 11/7/23 09:28, Laszlo Ersek wrote: > On 11/3/23 16:30, Wu, Jiaxin wrote: >> This patch is to define 3 new functions (WaitForBsp & ReleaseBsp & >> ReleaseOneAp) used for the semaphore sync between BSP & AP. With the >> change, BSP and AP Sync flow will be

Re: [edk2-devel] [PATCH v1 3/7] UefiCpuPkg: Adds SmmCpuSyncLib library class

2023-11-07 Thread Laszlo Ersek
On 11/7/23 11:26, Laszlo Ersek wrote: > Furthermore, counts of objects should be generally represented as UINTN > values, unless you have a good (explained!) reason for using a different > type. If the argument is that we need atomics for manipulating CPU counts, and that we don't

Re: [edk2-devel] [PATCH v1 4/7] UefiCpuPkg: Implements SmmCpuSyncLib library instance

2023-11-07 Thread Laszlo Ersek
On 11/3/23 16:30, Wu, Jiaxin wrote: > Implements SmmCpuSyncLib Library class. The instance follows the > existing SMM CPU driver (PiSmmCpuDxeSmm) sync implementation: > 1.Abstract Counter and Run semaphores into SmmCpuSyncCtx. > 2.Abstract CPU arrival count operation to > SmmCpuSyncGetArrivedCpuCou

Re: [edk2-devel] [PATCH v1 4/7] UefiCpuPkg: Implements SmmCpuSyncLib library instance

2023-11-07 Thread Laszlo Ersek
On 11/3/23 16:30, Wu, Jiaxin wrote: > diff --git a/UefiCpuPkg/UefiCpuLibs.dsc.inc b/UefiCpuPkg/UefiCpuLibs.dsc.inc > new file mode 100644 > index 00..6b9b362729 > --- /dev/null > +++ b/UefiCpuPkg/UefiCpuLibs.dsc.inc > @@ -0,0 +1,15 @@ > +## @file > +# UefiCpu DSC include file for [LibraryC

Re: [edk2-devel] [PATCH v1 5/7] OvmfPkg: Specifies SmmCpuSyncLib instance

2023-11-07 Thread Laszlo Ersek
On 11/3/23 16:30, Wu, Jiaxin wrote: > The SmmCpuSyncLib instance is included in UefiCpuLibs.dsc.inc. > This patch is to specify SmmCpuSyncLib instance in OvmfPkg by > using "!include UefiCpuPkg/UefiCpuLibs.dsc.inc". > > Change-Id: I2ab1737425e26a7bfc4f564b3b7f15ca5c2268fb > Cc: Ard Biesheuvel > C

Re: [edk2-devel] [PATCH v1 7/7] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SmmCpuSyncLib

2023-11-07 Thread Laszlo Ersek
On 11/3/23 16:30, Wu, Jiaxin wrote: > There is the SmmCpuSyncLib Library class define the SMM CPU sync > flow, which is aligned with existing SMM CPU driver sync behavior. > This patch is to consume SmmCpuSyncLib instance directly. > > With this change, SMM CPU Sync flow/logic can be customized >

Re: [edk2-devel] [Patch v2 1/1] Maintainers.txt: Remove Orphan status option

2023-11-07 Thread Laszlo Ersek
For critical > features, we must find community members that are willing to > own it. > > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Laszlo Ersek > Signed-off-by: Michael D Kinney > Reviewed-by: Laszlo Ersek > --- > Maintainers.txt | 2 -- > 1 file changed, 2 d

Re: 回复: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

2023-11-07 Thread Laszlo Ersek
On 11/6/23 01:59, gaoliming wrote: > Laszlo: > I agree your suggestion. We can submit a new request to update oniguruma to > the latest version. > > This patch avoids the warning on the current version. I think this change > is OK. I would like to merge this fix first. OK. Filed this BZ:

Re: [edk2-devel] Use dynamic pcd in smm mode

2023-11-07 Thread Laszlo Ersek
On 11/7/23 12:31, Yoshinoya wrote: > Hi, All: > Could dynamic PCD be used in smm driver code? > > It seems pcd has pei/dxe drivers, but not have smm related infrastructur > drivers. Dynamic PCDs (or more generally, DXE protocols) can be used in the entry point functions of DXE_SMM_DRIVER modules,

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

2023-11-07 Thread Laszlo Ersek
t: Tuesday, November 7, 2023 9:25 AM >> To: devel@edk2.groups.io >> Cc: Dong, Eric ; Ni, Ray ; Zeng, Star >> ; Gerd Hoffmann ; Kumar, Rahul R >> ; Laszlo Ersek >> Subject: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP >> Exception when CET ena

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix OVERRUN Coverity issues

2023-11-07 Thread Laszlo Ersek
Hi Ranbir, On 11/7/23 06:06, Ranbir Singh wrote: > From: Ranbir Singh > > The function NotifyPhase has a check > > ASSERT (Index < TypeMax); > > but this comes into play only in DEBUG mode. In Release mode, there is > no handling if the Index value is within array limits or not. If for > w

Re: [edk2-devel] [PATCH v2 2/2] MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix MISSING_BREAK Coverity issue

2023-11-07 Thread Laszlo Ersek
On 11/7/23 06:06, Ranbir Singh wrote: > From: Ranbir Singh > > The function SubmitResources has a switch-case code in which the > case ACPI_ADDRESS_SPACE_TYPE_MEM: which falls through to > case ACPI_ADDRESS_SPACE_TYPE_IO: if there is no scenario of > return EFI_INVALID_PARAMETER; > > While this

Re: [edk2-devel] [PATCH v3 1/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix REVERSE_INULL Coverity issue

2023-11-07 Thread Laszlo Ersek
-authored-by: Veeresh Sangolli > Signed-off-by: Ranbir Singh > Signed-off-by: Ranbir Singh > Reviewed-by: Laszlo Ersek > --- > MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Bu

Re: [edk2-devel] [PATCH v3 1/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix REVERSE_INULL Coverity issue

2023-11-07 Thread Laszlo Ersek
On 11/7/23 16:52, Laszlo Ersek wrote: > On 11/7/23 06:38, Ranbir Singh wrote: >> From: Ranbir Singh >> >> The function USBMouseDriverBindingStart do have >> >> ASSERT (UsbMouseDevice != NULL); >> >> after AllocateZeroPool, but it is applicable o

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg/Bus/Pci/XhciDxe: Fix FORWARD_NULL Coverity issues

2023-11-07 Thread Laszlo Ersek
On 11/7/23 06:57, Ranbir Singh wrote: > From: Ranbir Singh > > The functions UsbHcGetHostAddrForPciAddr, UsbHcGetPciAddrForHostAddr > and UsbHcFreeMem do have > > ASSERT ((Block != NULL)); > > statements after for loop, but these are applicable only in DEBUG mode. > In RELEASE mode, if for

Re: [edk2-devel] [PATCH v2 2/2] MdeModulePkg/Bus/Pci/XhciDxe: Fix MISSING_BREAK Coverity issues

2023-11-07 Thread Laszlo Ersek
On 11/7/23 06:58, Ranbir Singh wrote: > From: Ranbir Singh > > The functions > XhcInitializeEndpointContext and XhcInitializeEndpointContext64 has > a switch-case code in which the case USB_ENDPOINT_CONTROL: falls > through to default: > > While this may be intentional, it is not evident to any

Re: [edk2-devel] [PATCH v2 1/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix DEADCODE Coverity issue

2023-11-07 Thread Laszlo Ersek
On 11/7/23 07:19, Ranbir Singh wrote: > From: Ranbir Singh > > The function PciHotPlugRequestNotify has two if blocks towards the end > of function both containing return. Due to the parameter checks ensured > at the beginning of the function, one of the two if blocks is bound to > come in execut

Re: [edk2-devel] [PATCH v2 2/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix MISSING_BREAK Coverity issues

2023-11-07 Thread Laszlo Ersek
t; break; Agree, but the semicolon's placement is awkward. I propose No break here, as this is an intentional fall through. Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110863): ht

Re: [edk2-devel] [PATCH v2 3/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix ARRAY_VS_SINGLETON Coverity issues

2023-11-07 Thread Laszlo Ersek
On 11/7/23 07:19, Ranbir Singh wrote: > From: Ranbir Singh > > The function PciHostBridgeResourceAllocator is not making use of the > generic approach as is used in one of the other function namely - > DumpResourceMap. As a result, the following warnings can be seen as > reported by Coverity e.g.

Re: [edk2-devel] [PATCH v2 4/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue

2023-11-07 Thread Laszlo Ersek
On 11/7/23 07:19, Ranbir Singh wrote: > From: Ranbir Singh > > The function StartPciDevices has a check > > ASSERT (RootBridge != NULL); > > but this comes into play only in DEBUG mode. In Release mode, there > is no handling if the RootBridge value is NULL and the code proceeds > to uncond

Re: [edk2-devel] [PATCH v2 5/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix UNUSED_VALUE Coverity issues

2023-11-07 Thread Laszlo Ersek
On 11/7/23 07:19, Ranbir Singh wrote: > The return value after calls to functions > gBS->UninstallMultipleProtocolInterfaces, StartPciDevicesOnBridge, > PciPciDeviceInfoCollector, BarExisted, PciRootBridgeIo->Pci.Write, > gPciHotPlugInit->InitializeRootHpc and PciRootBridgeP2CProcess is > stored in

Re: [edk2-devel] [PATCH v2 1/2] FatPkg/EnhancedFatDxe: Fix SIGN_EXTENSION Coverity issues

2023-11-07 Thread Laszlo Ersek
On 11/7/23 07:28, Ranbir Singh wrote: > From: Ranbir Singh > > The functions FatGetDirEntInfo and FatOpenDirEnt contains the code > statements > > Cluster= (Entry->FileClusterHigh << 16) | > Entry->FileCluster; > and > OFile->FileCluster = ((DirEnt->Entry.FileClust

Re: [edk2-devel] [PATCH v2 2/2] FatPkg/EnhancedFatDxe: Fix OVERFLOW_BEFORE_WIDEN Coverity issue

2023-11-07 Thread Laszlo Ersek
On 11/7/23 07:28, Ranbir Singh wrote: > From: Ranbir Singh > > The function FatInitializeDiskCache evaluates an expression > > FAT_DATACACHE_GROUP_COUNT << DiskCache[CacheData].PageAlignment > > and assigns it to DataCacheSize which is of type UINTN. > > As per Coverity report, > FAT_DATAC

Re: [edk2-devel] [PATCH v8 0/5] Cache Management Operations Support For RISC-V

2023-11-07 Thread Laszlo Ersek
;> 5. Add platform level PCD to allow overriding of RISC-V features. >> >> Code Link: https://github.com/tianocore/edk2/pull/5002 >> >> Cc: Ard Biesheuvel >> Cc: Jiewen Yao >> Cc: Jordan Justen >> Cc: Gerd Hoffmann >> Cc: Sunil V L >> Cc:

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Use processor extended information

2023-11-07 Thread Laszlo Ersek
On 11/7/23 03:43, Wu, Jiaxin wrote: > Processor extended information is filled when > CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber > from GetProcessorInfo() (See commit: 1fadd18d). > > This filed value is retrieved from CPUID leaf 1FH, which is > a preferred superset to leaf 0BH. >

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Use processor extended information

2023-11-07 Thread Laszlo Ersek
On 11/7/23 19:40, Laszlo Ersek wrote: > On 11/7/23 03:43, Wu, Jiaxin wrote: >> Processor extended information is filled when >> CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber >> from GetProcessorInfo() (See commit: 1fadd18d). >> >> This filed value

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

2023-11-07 Thread Laszlo Ersek
shadow stack and normal SMI stack mismatch. > > Note: WRITE_UNPROTECT_RO_PAGES () must be called pair with > WRITE_PROTECT_RO_PAGES () in same function. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Zeng Star > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Cc: Laszlo Ersek

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridgeDxe: Add readback after final Cfg-Write

2023-11-08 Thread Laszlo Ersek
On 11/6/23 07:55, Joe L wrote: > (1) I'd like (a) the problem report, and the full reasoning by Ard and > Michael to be captured in the commit message, and (b) *minimally* a hint > at the possible reordering, and at the PCI spec-based workaround, to be > placed in the code comment a

Re: [edk2-devel] [PATCH v4 1/4] StandaloneMmPkg/Core: Limit FwVol encapsulation section recursion

2023-11-08 Thread Laszlo Ersek
against that PCD. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Wei6 Xu > --- > StandaloneMmPkg/Core/Dispatcher.c | 5 - > StandaloneMmPkg/Core/FwVol.c | 16 -- > Stan

Re: [edk2-devel] [PATCH v4 2/4] StandaloneMmPkg/Core: Fix potential memory leak issue

2023-11-08 Thread Laszlo Ersek
er: > - FreePages (DstBuffer, EFI_SIZE_TO_PAGES (DstBufferSize)); > + if (AllocatedDstBuffer != NULL) { > +FreePages (AllocatedDstBuffer, EFI_SIZE_TO_PAGES (DstBufferSize)); > + } > >return Status; > } Right, if AllocatedDstBuffer is needed, then we free it only u

Re: [edk2-devel] [PATCH v4 3/4] StandaloneMmPkg/Core: Fix issue that offset calculation might be wrong

2023-11-08 Thread Laszlo Ersek
er + 1' to avoid this issue. > MmCoreFfsFindMmDriver() also assumes section is EFI_COMMON_SECTION_HEADER. > If Section is EFI_COMMON_SECTION_HEADER2, 'Section + 1' will get a wrong > wrong InnerFvHeader adress. Add section head detection and calculate the > address accordin

Re: [edk2-devel] [PATCH v4 4/4] StandaloneMmPkg/Core: Fix the failure to find uncompressed inner FV

2023-11-08 Thread Laszlo Ersek
x this issue. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Wei6 Xu > --- > StandaloneMmPkg/Core/FwVol.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/StandaloneMmPkg/Core/F

Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR4.CET before restoring MSR IA32_S_CET

2023-11-08 Thread Laszlo Ersek
Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Wu Jiaxin > Cc: Tan Dun > --- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 53 --- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 69 > 2 files changed, 98 insertions(+),

Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/PiSmmCpuDxeSmm: Change CR4.CET bit only

2023-11-08 Thread Laszlo Ersek
On 11/6/23 10:07, Sheng Wei wrote: > Do not use fixed CR4 value 0x668, change CR4.CET bit only. > > Signed-off-by: Sheng Wei > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Wu Jiaxin > Cc: Tan Dun > --- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.na

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Set mSmmInterruptSspTables initial value

2023-11-08 Thread Laszlo Ersek
On 11/6/23 10:07, Sheng Wei wrote: > Initial the value of mSmmInterruptSspTables to 0. > > Signed-off-by: Sheng Wei > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Wu Jiaxin > Cc: Tan Dun > --- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 2 +- >

Re: [edk2-devel] [PATCH v4 11/14] UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if Nonzero

2023-11-08 Thread Laszlo Ersek
On 11/3/23 18:17, Taylor Beebe wrote: > The function EnforceMemoryMapAttribute() in the SMM MAT logic will > ensure that the CODE and DATA memory types have the desired attributes. EnforceMemoryMapAttribute() leaves those descriptors alone where Attribute is already nonzero ("PE image") [1]. For

Re: [edk2-devel] [PATCH v2 20/30] OvmfPkg/LoongArchVirt: Add serial port library

2023-11-08 Thread Laszlo Ersek
On 11/7/23 11:12, Chao Li wrote: > Hi Gerd, > > These two libraries is not only copy code, the way of obtain the serial > base address is different from ARM, and the early serial port output > also different from ARM, so these two libraries are LoongArch specific. I think we're going to have to g

Re: [edk2-devel] [PATCH v2 23/30] OvmfPkg/LoongArchVirt: Add PeiServiceTablePointerLib

2023-11-08 Thread Laszlo Ersek
On 11/6/23 04:30, Chao Li wrote: > Use a register to save PeiServiceTable pointer. This Library provides > PeiServiceTable pointer saveing and retrieval serivces. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd

Re: [edk2-devel] [PATCH v2 24/30] OvmfPkg/LoongArchVirt: Add platform boot manager library

2023-11-08 Thread Laszlo Ersek
On 11/6/23 04:30, Chao Li wrote: > This library is provides boot mananger interfaces, and it is referenced > from ArmVirtPkg. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Signed-off-by: Chao Li >

[edk2-devel] remove and , including references

2023-11-09 Thread Laszlo Ersek
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754 I'm sending this as a common anchor message for [edk2-platforms PATCH 0/2] remove and refs [PATCH 0/3] remove and , including refs Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messa

[edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

2023-11-09 Thread Laszlo Ersek
EBYTE2_5, which is also absent from edk2-platforms.) Cc: Sai Chaganty Cc: Nate DeSimone Cc: Chasel Chiu Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754 Signed-off-by: Laszlo Ersek --- Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoa

[edk2-devel] [edk2-platforms PATCH 0/2] remove and refs

2023-11-09 Thread Laszlo Ersek
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754 Remove references to two old headers that play no role in modern UEFI. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Sai Chaganty Laszlo Ersek (2): WhitleyOpenBoardPkg: remove references SimicsOpenBoardPkg: remove reference

[edk2-devel] [edk2-platforms PATCH 2/2] SimicsOpenBoardPkg: remove reference

2023-11-09 Thread Laszlo Ersek
.tianocore.org/show_bug.cgi?id=1754 Signed-off-by: Laszlo Ersek --- Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h b/Platform/Intel/SimicsO

[edk2-devel] [PATCH 0/3] remove and , including refs

2023-11-09 Thread Laszlo Ersek
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754 Remove two old headers that play no role in modern UEFI. Cc: Liming Gao Cc: Michael D Kinney Cc: Zhichao Gao Cc: Zhiguang Liu Laszlo Ersek (3): MdePkg: remove ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref

[edk2-devel] [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM

2023-11-09 Thread Laszlo Ersek
We're removing . First, remove the gEfiMpsTableGuid system config table reference from the UEFI Shell's DMEM debug command. Cc: Zhichao Gao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754 Signed-off-by: Laszlo Ersek --- ShellPkg/Library/UefiShellDebug1C

[edk2-devel] [PATCH 1/3] MdePkg: remove

2023-11-09 Thread Laszlo Ersek
754 Signed-off-by: Laszlo Ersek --- MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h | 288 1 file changed, 288 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h b/MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h deleted file mode 10

[edk2-devel] [PATCH 3/3] MdePkg: remove

2023-11-09 Thread Laszlo Ersek
edk2 or edk2-platforms. Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754 Signed-off-by: Laszlo Ersek --- MdePkg/MdePkg.dec | 3 -- MdePkg/Include/Guid/Mps.h | 29 2 files changed, 32 deletions(-) diff

[edk2-devel] [PATCH 00/37] OvmfPkg: remove the CSM (after edk2-stable202311)

2023-11-10 Thread Laszlo Ersek
Cc: Sunil V L Cc: Tom Lendacky Thanks Laszlo Laszlo Ersek (37): OvmfPkg: cripple CSM_ENABLE macro OvmfPkg: remove PcdCsmEnable OvmfPkg: unplug LegacyBootManagerLib from BdsDxe and UiApp OvmfPkg: remove LegacyBootManagerLib OvmfPkg: unplug LegacyBootMaintUiLib from UiApp

[edk2-devel] [PATCH 01/37] OvmfPkg: cripple CSM_ENABLE macro

2023-11-10 Thread Laszlo Ersek
: Jiewen Yao Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/Bhyve/BhyveX64.dsc | 1 + OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 + OvmfPkg/OvmfPkgIa32.dsc | 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 1 + OvmfPkg/OvmfPkgX6

[edk2-devel] [PATCH 02/37] OvmfPkg: remove PcdCsmEnable

2023-11-10 Thread Laszlo Ersek
nocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec | 5 --- OvmfPkg/IntelTdx/IntelTdxX64.dsc| 1 - OvmfPkg/OvmfPkgIa32.dsc | 1 - OvmfPkg/OvmfPkgIa32X64.dsc | 1 - OvmfPkg/OvmfPkgX64.dsc | 1

[edk2-devel] [PATCH 03/37] OvmfPkg: unplug LegacyBootManagerLib from BdsDxe and UiApp

2023-11-10 Thread Laszlo Ersek
Don't register the LegacyBmRefreshAllBootOption() and LegacyBmBoot() functions in BdsDxe and UiApp. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Corvin Köhne Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo

[edk2-devel] [PATCH 04/37] OvmfPkg: remove LegacyBootManagerLib

2023-11-10 Thread Laszlo Ersek
: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.uni | 20 - OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf | 57 - OvmfPkg/Csm/LegacyBootManagerLib/InternalLegacyBm.h | 60

[edk2-devel] [PATCH 05/37] OvmfPkg: unplug LegacyBootMaintUiLib from UiApp

2023-11-10 Thread Laszlo Ersek
://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/Bhyve/BhyveX64.dsc | 3 --- OvmfPkg/OvmfPkgIa32.dsc| 3 --- OvmfPkg/OvmfPkgIa32X64.dsc | 3 --- OvmfPkg/OvmfPkgX64.dsc | 3 --- OvmfPkg/OvmfXen.dsc| 3 --- 5 files changed, 15 deletions(-) diff --git a/OvmfPkg/Bhyve

[edk2-devel] [PATCH 06/37] OvmfPkg: remove LegacyBootMaintUiLib

2023-11-10 Thread Laszlo Ersek
: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 20 - OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiStrings.uni | 43 - OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf

[edk2-devel] [PATCH 07/37] OvmfPkg: remove gEfiLegacyDevOrderVariableGuid

2023-11-10 Thread Laszlo Ersek
: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec | 1 - OvmfPkg/Csm/Include/Guid/LegacyDevOrder.h | 39 2 files changed, 40 deletions(-) diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec index

[edk2-devel] [PATCH 08/37] OvmfPkg: exclude the CSM-based VideoDxe driver

2023-11-10 Thread Laszlo Ersek
n Köhne Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/Bhyve/BhyveX64.dsc| 6 -- OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 -- OvmfPkg/OvmfPkgIa32.dsc | 6 -- Ovm

[edk2-devel] [PATCH 10/37] OvmfPkg: remove gEfiVgaMiniPortProtocolGuid

2023-11-10 Thread Laszlo Ersek
- PCDs: - PcdBiosVideoCheckVbeEnable - PcdBiosVideoCheckVgaEnable - PcdBiosVideoSetTextVgaModeEnable Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec| 1

[edk2-devel] [PATCH 11/37] OvmfPkg: remove Bios Video PCDs

2023-11-10 Thread Laszlo Ersek
: - FrameworkDxe.h - Guid/LegacyBios.h - Protocol/LegacyBios.h Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec | 20 1 file changed, 20 deletions(-) diff --git

[edk2-devel] [PATCH 12/37] OvmfPkg: exclude LegacyBiosDxe

2023-11-10 Thread Laszlo Ersek
. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Corvin Köhne Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/Bhyve/BhyveX64.dsc | 1 - OvmfPkg/OvmfPkgIa32.dsc| 1 - OvmfPkg/OvmfPkgIa32X64.ds

[edk2-devel] [PATCH 13/37] OvmfPkg/IncompatiblePciDeviceSupportDxe: ignore CSM presence

2023-11-10 Thread Laszlo Ersek
finally shows that the iPXE option ROM for the device (1af41000.efi) was detected and is loaded. (Same PCIe root port, and PCIe root ports can only host a single device.) Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_

[edk2-devel] [PATCH 14/37] Revert "OvmfPkg: don't assign PCI BARs above 4GiB when CSM enabled"

2023-11-10 Thread Laszlo Ersek
://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32X64.dsc | 4 OvmfPkg/OvmfPkgX64.dsc | 4 2 files changed, 8 deletions(-) diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc index 3a83418bdd4e..1f144b07a650 100644 --- a/OvmfPkg

[edk2-devel] [PATCH 17/37] OvmfPkg: remove gEfiIsaIoProtocolGuid

2023-11-10 Thread Laszlo Ersek
- PcdLowPmmMemorySize - PcdOpromReservedMemoryBase - PcdOpromReservedMemorySize Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec | 1 - OvmfPkg/Csm/Include/Protocol

[edk2-devel] [PATCH 18/37] OvmfPkg: remove gEfiIsaAcpiProtocolGuid

2023-11-10 Thread Laszlo Ersek
- PcdLegacyBiosCacheLegacyRegion - PcdLowPmmMemorySize - PcdOpromReservedMemoryBase - PcdOpromReservedMemorySize Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec| 1

[edk2-devel] [PATCH 19/37] OvmfPkg: remove gEfiLegacyBiosGuid

2023-11-10 Thread Laszlo Ersek
- PcdOpromReservedMemoryBase - PcdOpromReservedMemorySize Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec | 1 - OvmfPkg/Csm/Include/Guid/LegacyBios.h | 29

[edk2-devel] [PATCH 16/37] OvmfPkg: exclude NullMemoryTestDxe driver

2023-11-10 Thread Laszlo Ersek
as Cc: Gerd Hoffmann Cc: Jianyong Wu Cc: Jiewen Yao Cc: Michael Roth Cc: Min Xu Cc: Rebecca Cran Cc: Sunil V L Cc: Tom Lendacky Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/AmdSev/AmdSevX64.dsc| 1 - OvmfPkg/Bhyve/BhyveX64.dsc

[edk2-devel] [PATCH 20/37] OvmfPkg: remove LegacyBiosDxe PCDs

2023-11-10 Thread Laszlo Ersek
/LegacyBiosPlatform.h - Protocol/LegacyInterrupt.h Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec | 38 1 file changed, 38 deletions(-) diff --git a/OvmfPkg/OvmfPkg.dec b

[edk2-devel] [PATCH 21/37] OvmfPkg: unplug CsmSupportLib from BdsDxe

2023-11-10 Thread Laszlo Ersek
s bogus, and has always been, since commit 656419f922c0 ("Add BhyvePkg, to support the bhyve hypervisor", 2020-07-31). Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Corvin Köhne Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588

[edk2-devel] [PATCH 22/37] OvmfPkg: remove CsmSupportLib

2023-11-10 Thread Laszlo Ersek
be scheduled for removal. Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf | 55 - OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.h | 48 - OvmfPkg/Csm/CsmSup

[edk2-devel] [PATCH 24/37] OvmfPkg: remove gEfiLegacyBiosPlatformProtocolGuid

2023-11-10 Thread Laszlo Ersek
- gEfiLegacyInterruptProtocolGuid - headers: - FrameworkDxe.h - Protocol/Legacy8259.h - Protocol/LegacyBios.h - Protocol/LegacyInterrupt.h Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek

[edk2-devel] [PATCH 23/37] OvmfPkg: remove gEfiFirmwareVolumeProtocolGuid

2023-11-10 Thread Laszlo Ersek
://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec | 1 - OvmfPkg/Csm/Include/Protocol/FirmwareVolume.h | 339 2 files changed, 340 deletions(-) diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec index 45a6105d39d6

[edk2-devel] [PATCH 25/37] OvmfPkg: remove gEfiLegacyBiosProtocolGuid

2023-11-10 Thread Laszlo Ersek
- headers: - FrameworkDxe.h - Protocol/Legacy8259.h - Protocol/LegacyInterrupt.h Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec |1 - OvmfPkg/Csm/Include

[edk2-devel] [PATCH 27/37] OvmfPkg: remove

2023-11-10 Thread Laszlo Ersek
F3-3E8A-4FEF-81C8-328ED647AB1A) - gEfiLegacy8259ProtocolGuid - headers: - Protocol/Legacy8259.h Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec

<    1   2   3   4   5   6   7   8   9   10   >