On 11/7/23 06:06, Ranbir Singh wrote: > From: Ranbir Singh <ranbir.sin...@dell.com> > > The function SubmitResources has a switch-case code in which the > case ACPI_ADDRESS_SPACE_TYPE_MEM: which falls through to > case ACPI_ADDRESS_SPACE_TYPE_IO: if there is no scenario of > return EFI_INVALID_PARAMETER; > > While this may be intentional, it is not evident to any general code > reader why there is no break; in between. Adding > > // No break; here as this is an intentional fallthrough. > > as comment in between makes it explicit. Incidentally, the comment > satisfies Coverity as well. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4212 > > Cc: Ray Ni <ray...@intel.com> > Co-authored-by: Veeresh Sangolli <veeresh.sango...@dellteam.com> > Signed-off-by: Ranbir Singh <ranbir.sin...@dell.com> > Signed-off-by: Ranbir Singh <rsi...@ventanamicro.com> > --- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > index 519e1369f85e..3bd91e2787fd 100644 > --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > @@ -1531,6 +1531,10 @@ SubmitResources ( > return EFI_INVALID_PARAMETER; > } > > + // > + // No break; here as this is an intentional fall through. > + // > + > case ACPI_ADDRESS_SPACE_TYPE_IO: > // > // Check aligment, it should be of the form 2^n-1
I agree with adding the comment (I agree it's a fallthrough), but the semicolon is weird. I think we should say: No break here, as this is an intentional fall through. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110857): https://edk2.groups.io/g/devel/message/110857 Mute This Topic: https://groups.io/mt/102437649/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
