[edk2-devel] [edk2-platforms PATCH 5/7] Silicon/Marvell/RealTimeClockLib: remove superfluous instance init steps

or step (3); it does not try to set "gRT" fields). (Note that the lib instance INF file already does not list gEfiRealTimeClockArchProtocolGuid.) Build-tested only (with "Armada70x0Db.dsc"). Cc: Leif Lindholm Cc: Marcin Wojtas Ref: https://bugzilla.tianocore.org/show_bug.cgi

[edk2-devel] [edk2-platforms PATCH 3/7] Hisilicon/M41T83RealTimeClockLib: remove superfluous instance init steps

nocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c b/Silicon/Hisilic

[edk2-devel] [edk2-platforms PATCH 2/7] LoongArchQemuPkg/LsRealTimeClockLib: remove superfluous instance init steps

file already does not list UefiRuntimeServicesTableLib.) Build-tested only (with "Loongson.dsc"). Cc: Bibo Mao Cc: Chao Li Cc: Xianglai li Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek --- Notes: context:-W Platform/Loongson/LoongArch

[edk2-devel] [edk2-platforms PATCH 7/7] Omap35xxPkg/RealTimeClockLib: remove superfluous instance init steps

ready does not list UefiRuntimeServicesTableLib and gEfiRealTimeClockArchProtocolGuid.) Build-tested only (with "BeagleBoardPkg.dsc"). Cc: Ard Biesheuvel Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek --- Silicon/TexasInstrume

[edk2-devel] [edk2-platforms PATCH 6/7] FT2000-4Pkg/RealTimeClockLib: remove superfluous instance init steps

ocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek --- Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c | 13 - 1 file changed, 13 deletions(-) diff --git a/Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c b/Silicon/Phytium/FT2000

[edk2-devel] [edk2-platforms PATCH 4/7] Hisilicon/RX8900RealTimeClockLib: remove superfluous instance init steps

8900 RTC, so upstream the RX8900RealTimeClockLib", so I guess there might be out-of-tree / proprietary consumers. Quite unfortunate. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek --- Silicon/Hisilicon/

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

szlo > > Regards, > John > > -Original Message- > From: Heinrich Schuchardt > Sent: Friday, October 20, 2023 6:44 PM > To: Laszlo Ersek > Cc: Sunil V L ; Li Yong ; Leif > Lindholm ; Ard Biesheuvel > ; Abner Chang ; Daniel > Schaefer ; devel@edk2.

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 10/20/23 14:25, Laszlo Ersek wrote: > On 10/20/23 13:30, John Chew wrote: >> Hi Heinrich, Laszlo, >> >> Thank you very much for your support! Really appreciate it =D >> >> My account just approved few days ago, so original patch (submit few weeks >> bac

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 10/20/23 14:25, Ard Biesheuvel wrote: > On Fri, 20 Oct 2023 at 11:49, Laszlo Ersek wrote: >> >> On 10/18/23 10:57, Ard Biesheuvel wrote: >>> On Wed, 18 Oct 2023 at 10:49, YuinYee Chew >>> wrote: >>>> >>>> Dear Maintainers, >>>

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg: Fix the failure to find uncompressed inner FV.

On 10/24/23 07:53, Xu, Wei6 wrote: > The MmCoreFfsFindMmDriver only checks for encapsulated compressed FVs. > When an inner FV is uncompressed, StandaloneMmCore will miss the FV and > all the MM drivers in the FV will not be dispatched. > Add checks for uncompressed inner FV to fix this issue. > >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

On 10/24/23 04:18, Gao, Zhichao wrote: > The patch looks good to me. > Reviewed-by: Zhichao Gao > > The comments of this patch and proposal would be taken care in another patch. > Better to have a Bugzilla record for the planned change. I've submitted

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/BaseXApicX2ApicLib: fix CPUID_V2_EXTENDED_TOPOLOGY detection

Eric, Ray, Rahul -- can you ACK this patch please? I intend to merge it in one or two days. Thanks Laszlo On 10/17/23 13:42, Laszlo Ersek wrote: > On 10/17/23 13:28, Gerd Hoffmann wrote: >> Checking the max cpuid leaf is not enough to figure whenever >> CPUID_V2_EXTENDED_TOPOLO

Re: [edk2-devel] [PATCH v6 1/5] MdePkg: Move RISC-V Cache Management Declarations Into BaseLib

t; #include > > -/** > - RISC-V invalidate instruction cache. > - > -**/ > -VOID > -EFIAPI > -RiscVInvalidateInstCacheAsm ( > - VOID > - ); > - > -/** > - RISC-V invalidate data cache. > - > -**/ > -VOID > -EFIAPI > -RiscVInvalidateDataCach

Re: [edk2-devel] [PATCH v6 2/5] MdePkg: Rename Cache Management Function To Clarify Fence Based Op

ed in future > patches. Current method is fence instruction based, rename the > function accordingly to add that clarity. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Sunil V L > Cc: Daniel Schaefer > Cc: Laszlo Ersek > > Signed-off-

Re: [edk2-devel] [PATCH v6 3/5] MdePkg: Implement RISC-V Cache Management Operations

. Not able to verify actual instruction in HW as Qemu ignores >any actual cache operations. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Sunil V L > Cc: Daniel Schaefer > Cc: Laszlo Ersek > > Signed-off-by: Dhaval Sharma > ---

Re: [edk2-devel] [PATCH v6 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features

usage should be avoided. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Sunil V L > Cc: Andrei Warkentin > Cc: Laszlo Ersek > > Signed-off-by: Dhaval Sharma > --- > > Notes: > v2: > - Modify

Re: [edk2-devel] [PATCH v6 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On 10/21/23 19:33, Dhaval Sharma wrote: > Use newly defined cache management operations for RISC-V where possible > It builds up on the support added for RISC-V cache management > instructions in BaseLib. > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Lasz

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

On 10/24/23 14:29, Laszlo Ersek wrote: > On 10/24/23 04:18, Gao, Zhichao wrote: >> The patch looks good to me. >> Reviewed-by: Zhichao Gao >> >> The comments of this patch and proposal would be taken care in another >> patch. Better to have a Bugzilla record

Re: [edk2-devel] [edk2-platforms PATCH 0/7] drop needless init steps in RealTimeClockLib instances

On 10/20/23 14:18, Laszlo Ersek wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=4565 > > RealTimeClockLib instances should neither set gRT fields nor install > EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL in LibRtcInitialize(); > EmbeddedPkg/RealTimeClockRuntimeDxe already perform

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL031RealTimeClockLib: remove superfluous instance init steps

On 10/20/23 14:27, Ard Biesheuvel wrote: > On Fri, 20 Oct 2023 at 14:17, Laszlo Ersek wrote: >> >> RealTimeClockLib instances are consumed by edk2's >> EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function >> InitializeRealTimeCloc

Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB

Yuanhao, On 10/19/23 05:20, Yuanhao Xie wrote: > With the fact that CSM is not supported, > the request is to remove the cache setting for memory under 1MB. > This can be treated as the missing part of legacy CSM deprecation. > > This patch only set the 0 to 9 and C to F as Write

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update maintainers list

mmCpuFeaturesLib/*Amd*.* > +M: Abdul Lateef Attar [abdattar] > +R: Abner Chang [changab] > + > UefiPayloadPkg > F: UefiPayloadPkg/ > W: https://github.com/tianocore/tianocore.github.io/wiki/UefiPayloadPkg For the UefiCpuPkg part: Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-

[edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove Isaac Oram's email address

Ray Ni Cc: Sai Chaganty Cc: Theo Jehl Signed-off-by: Laszlo Ersek --- Maintainers.txt | 11 --- 1 file changed, 11 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 3e72f53afa0d..affb2632e0db 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -148,7 +148,6 @@ R: Marvin Hä

Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB

can't rebase a public branch), and the code is alright per review, so a revert won't help much here. Laszlo > > Yuanhao > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 25, 2023 4:00 PM > To: devel@edk2.groups.io; Xie, Yuanhao > Cc:

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/BaseXApicX2ApicLib: fix CPUID_V2_EXTENDED_TOPOLOGY detection

On 10/17/23 13:28, Gerd Hoffmann wrote: > Checking the max cpuid leaf is not enough to figure whenever > CPUID_V2_EXTENDED_TOPOLOGY is supported. Intel SDM says: > >Software must detect the presence of CPUID leaf 1FH by verifying >(a) the highest leaf index supported by CPUID is >= 1FH, a

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/AcpiPlatformDxe: Fix Coverity report issues

On 10/23/23 11:05, sunceping wrote: > From: Ceping Sun > > v1 -> v2 Changed list: > 1:Since both commits are intended to fix coverity issues, they are merged > into one > 2: Changed the debug info level to debug error when "DsdtTable == NULL" > 3:Add the Cc member as below > Erdem Aktas erd

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update maintainers list

On 10/19/23 07:43, Chang, Abner via groups.io wrote: > From: Abner Chang > > - Add two entries of MdePkg and MdeModulePkg for > manageability modules and files. > - Add one entry of UefiCpuPkg AMD related files. > > Signed-off-by: Abner Chang > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Mich

Re: [edk2-devel] [PATCH] UefiCpuPkg: Remove ASSERT checking if FinishedCount equal to CpuCount-1

On 10/25/23 12:07, Yuanhao Xie wrote: > The purpose is to fix an assertion with applying the following patch > series: > > UefiCpuPkg: Refactor the logic for placing APs in HltLoop. > UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop. > UefiCpuPkg: Create MpHandOff. > UefiCpuPkg: ApW

Re: [edk2-devel] question about cxl device enumeration in pci bus driver

On 10/26/23 10:33, Gerd Hoffmann wrote: > On Thu, Oct 26, 2023 at 10:36:35AM +0800, Yoshinoya wrote: > >> CXL Host Bridge / Root Port / Switch / Device enumeration / HDM Config, >> maybe could be integrated into pci drivers stack. > > Point being? Can or should the firmware do anything useful w

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Uncrustify on C source files

, >"%a: RequestDataSize == 0, however RequestData is not NULL for PLDM > type: 0x%x, Command: 0x%x.\n", > @@ -85,7 +85,7 @@ PldmSubmitCommand ( > return EFI_INVALID_PARAMETER; >} > > - if (ResponseData == NULL && *ResponseDataSize != 0) { &

Re: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove Isaac Oram's email address

e: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove >> Isaac Oram's email address >> >> Caution: This message originated from an External Source. Use proper caution >> when opening attachments, clicking links, or responding. >> >> >> On Wed,

Re: [edk2-devel] [Patch V3] UefiCpuPkg/MpInitLib: Wait for all APs to finish initialization

ff); > - ASSERT (CpuMpData->FinishedCount == (CpuMpData->CpuCount - 1)); > + // > + // Wait for all APs finished initialization > + // > + while (CpuMpData->FinishedCount < (CpuMpData->CpuCount - 1)) { > +CpuPause (); > + } > >// &

Re: [edk2-devel] [Patch V3] UefiCpuPkg/MpInitLib: Wait for all APs to finish initialization

On 10/25/23 13:42, Yuanhao Xie wrote: > Aim: > - To solve the assertion that checks if CpuMpData->FinishedCount > equals (CpuMpData->CpuCount - 1). The assertion arises from a timing > discrepancy between the BSP's completion of startup signal checks and > the APs' incrementation of the FinishedCou

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

On 10/26/23 16:21, Peter Maydell wrote: > On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: >> On 10/10/23 09:43, Ard Biesheuvel wrote: >>> Thanks for looking into this - a cleanup was overdue here. >>> >>> I will take a look in more detail later, but on

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

On 10/26/23 16:46, Julien Grall wrote: > Hi, > > On 26/10/2023 15:21, Peter Maydell wrote: >> On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: >>> On 10/10/23 09:43, Ard Biesheuvel wrote: >>>> Thanks for looking into this - a cleanup was overdue here. >>

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

On 10/26/23 16:55, Ard Biesheuvel wrote: > On Thu, 26 Oct 2023 at 16:46, Julien Grall wrote: >> >> Hi, >> >> On 26/10/2023 15:21, Peter Maydell wrote: >>> On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: >>>> On 10/10/23 09:43, Ard Biesheuv

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard

dLib/realpath.c > @@ -34,7 +34,7 @@ > **/ > char * > realpath( > - char *file_name, > + const char *file_name, >char *resolved_name >) > { Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply On

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

On 10/26/23 15:53, Neal Gompa wrote: > From: Neal Gompa > > Currently, the ReadyToBoot event is only signaled when a formal Boot > Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). > > However, the introduction of Platform Recovery in UEFI 2.5 makes it > necessary to signal Read

Re: [edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

On 10/26/23 14:37, jacopo.r0...@gmail.com wrote: > Hi there, > > I was trying to HTTPs boot a virtual machine with the following scenario: > > 1) I have a self signed root CA /root.crt /and then I use it to sign > another self signed certificate /myip.crt /for the IP address X.X.X.X > 2) I have a

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

On 10/26/23 18:19, Laszlo Ersek wrote: > On 10/26/23 15:53, Neal Gompa wrote: >> From: Neal Gompa >> >> Currently, the ReadyToBoot event is only signaled when a formal Boot >> Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). >> >> Howe

Re: [edk2-devel] [Patch V3] UefiCpuPkg/MpInitLib: Wait for all APs to finish initialization

On 10/26/23 15:41, Laszlo Ersek wrote: > On 10/25/23 13:42, Yuanhao Xie wrote: >> Aim: >> - To solve the assertion that checks if CpuMpData->FinishedCount >> equals (CpuMpData->CpuCount - 1). The assertion arises from a timing >> discrepancy between the BSP'

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

On 10/26/23 17:21, Ard Biesheuvel wrote: > On Thu, 26 Oct 2023 at 17:19, Laszlo Ersek wrote: >> >> On 10/26/23 16:21, Peter Maydell wrote: >>> On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: >>>> On 10/10/23 09:43, Ard Biesheuvel wrote: >>>&g

[edk2-devel] EDK II Release Planning: update content for edk2-stable202311

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning#edk2-stable202311-tag-planning I've scanned the edk2 git commit range edk2-stable202308..f945b72331d7, and collected (and when necessary, closed/updated) TianoCore BZs. When TianoCore BZs were not available, I tried capt

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Sample python scripts for socket client capabilities on UEFI shell

On 10/27/23 18:27, Jayaprakash, N wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4580 > > This BZ has been created to provide the sample python scripts > to demonstrate the socket client capabilities using http library > on UEFI shell with the help of Python UEFI interpreter. > The h

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg: Fix the failure to find uncompressed inner FV.

same approach could be taken in the Standalone MM Core as well. Laszlo > > > BR, > Wei > > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, October 24, 2023 8:03 PM > To: devel@edk2.groups.io; Xu, Wei6 > Cc: Ard Biesheuvel ; Sami Mujawar >

Re: [edk2-devel] [PATCH v2 0/1] StandaloneMmCore finds drivers in uncompressed inner fv.

per individual issue fix (especially if you count the recursion limiting too). Thanks! Laszlo > > Thanks, > Ray > > *From:* Xu, Wei6 > *Sent:* Friday, October 27, 2023 8:59 AM > *To:* devel@edk2.g

Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

eserved for such guests that don't run in Confidential Virtual Machines ("CVM"s). In particular patches #6 and #7 would damage OVMF. Nacked-by: Laszlo Ersek Laszlo > > From a commit message standpoint, you have up to 74 characters per line > to use and I see most of your

Re: [edk2-devel] CodeQL and Apache Licensed Files

On 10/27/23 23:11, Michael Kubacki wrote: > I'd like to bring attention to Apache License 2.0 code in the CodeQL > series I sent to the mailing list for steward review. > > In particular, the files in the BaseTools/Plugin/CodeQL/analyze > directory of this patch: > > https://edk2.groups.io/g/deve

Re: [edk2-devel] [PATCH] Remove checking Smm Rev ID in AMD Save State lib when Reading Save State Register EFI_MM_SAVE_STATE_REGISTER_IO

On 10/27/23 07:36, Jacque Lin via groups.io wrote: > --- > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c | 13 - > 1 file changed, 13 deletions(-) Why? (The commit message is empty.) Laszlo > > diff --git a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > b/UefiCpuPkg/Li

Re: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove Isaac Oram's email address

On 10/25/23 10:35, Laszlo Ersek wrote: > Email to Isaac's address bounces ("5.1.0 Address > rejected"); remove that address. > > Cc: Abdul Lateef Attar > Cc: Abner Chang > Cc: Ashraf Ali S > Cc: Chasel Chiu > Cc: Eric Dong > Cc: Liming Gao &g

Re: [edk2-devel] [PATCH 0/2] Add Platform Hook Lib into StandaloneMmCore

On 10/27/23 18:08, Michael Kubacki wrote: > This allows ambiguous "platform" code in the critical path of the MM > core. Is this necessary? > > Do you need this for one feature that others might too and can be > abstracted? Or, do you plan to perform an unknown and arbitrary number > of changes be

Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest

On 10/27/23 19:41, Joey Vagedes via groups.io wrote: > Thank you for the reviews. Pending any reviews other maintainers of these > packages would like to do, this patch series is ready to merge. I've updated > the PR with the reviewed-by tags: > > https://github.com/tianocore/edk2/pull/4966 I f

Re: [edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

On 10/26/23 14:37, jacopo.r0...@gmail.com wrote: > Hi there, > > I was trying to HTTPs boot a virtual machine with the following > scenario: > > 1) I have a self signed root CA /root.crt /and then I use it to sign > another self signed certificate /myip.crt /for the IP address X.X.X.X > 2) I have a

Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest

On 10/28/23 16:20, Laszlo Ersek wrote: > On 10/27/23 19:41, Joey Vagedes via groups.io wrote: >> Thank you for the reviews. Pending any reviews other maintainers of these >> packages would like to do, this patch series is ready to merge. I've updated >> the PR

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 10/29/23 03:16, Pedro Falcato wrote: > On Sat, Oct 28, 2023 at 8:23 PM Michael D Kinney > wrote: >> >> Over the past few months, all the of the Maintainers and >> Reviewers listed in Maintainers.txt have been contacted to make >> sure Maintainers.txt accurately represents the TianoCore >> commu

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 10/29/23 09:05, Yao, Jiewen wrote: > Those are great questions. I also would like to understand: > > 1) What is definition of "actively participating in their roles"? Here are the definitions of Maintainer and Reviewer, from "Maintainers.txt": M: Package Maintainer: Cc address for patches an

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 10/29/23 14:48, Laszlo Ersek wrote: > I loathe disappointing people. English is a tricky language. The above landed as an (unintended) double-entendre. I meant: "I hate to disappoint people". I didn't mean: "I loathe people that are disappo

Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations

On 10/29/23 20:12, Pedro Falcato wrote: > On Sun, Oct 29, 2023 at 2:46 PM Dhaval Sharma wrote: >> >> Implement Cache Management Operations (CMO) defined by >> RISC-V spec https://github.com/riscv/riscv-CMOs. >> >> Notes: >> 1. CMO only supports block based Operations. Meaning cache >>flush/inv

Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

;> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Zhiguang Liu >> Cc: Laszlo Ersek >> >> Signed-off-by: Dhaval Sharma >> Acked-by: Laszlo Ersek >> --- >> >> Notes: >> V7: >> - Added PcdLib >> - Restructur

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 10/30/23 03:40, Yao, Jiewen wrote: > Thanks Mike. I am reading the WIKI page. > > >> and/or provides testing or regression testing for the Package (or some >> modules thereof), in certain platforms and environments. > > [Jiewen] Are we expecting Reviewer to provide testing or regression test

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 10/29/23 20:01, Pedro Falcato wrote: > On Sun, Oct 29, 2023 at 1:30 PM Laszlo Ersek wrote: >> >> On 10/29/23 03:16, Pedro Falcato wrote: >>>> diff --git a/Maintainers.txt b/Maintainers.txt >>>> index 3f40cdeb5554..2b03ccbe54aa 100644 >>>&g

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 10/30/23 06:31, Kinney, Michael D wrote: > There is a very good discussion here on the roles and responsibility > and potential suggestions for changes to the Wiki page that document > those roles and responsibilities. > > May I suggest that someone start a new thread that discusses > the propo

Re: [edk2-devel] [PATCH v3 1/4] StandaloneMmPkg/Core: Limit FwVol encapsulation section recursion

against that PCD. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Wei6 Xu > --- > StandaloneMmPkg/Core/FwVol.c | 16 ++-- > StandaloneMmPkg/Core/StandaloneMmCore.c | 5 +++-- > Stan

Re: [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Core: Fix potential memory leak issue

On 10/30/23 08:49, Wei6 Xu wrote: > In MmCoreFfsFindMmDriver(), ScratchBuffer is not freed in the error > return path that DstBuffer page allocation fails. Free ScratchBuffer > before return with error. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc:

Re: [edk2-devel] [PATCH v3 3/4] StandaloneMmPkg/Core: Fix issue that section address might be wrong

er + 1' to avoid this issue. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Wei6 Xu > --- > StandaloneMmPkg/Core/FwVol.c | 18 -- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --

Re: [edk2-devel] [PATCH v3 4/4] StandaloneMmPkg/Core: Fix the failure to find uncompressed inner FV

x this issue. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Wei6 Xu > --- > StandaloneMmPkg/Core/FwVol.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/StandaloneMmPkg/Core/FwVol.c b/Stan

Re: [edk2-devel] [PATCH] UefiCpuPkg/MmSaveStateLib: Remove checking Smm Rev ID in AMD MmSaveStateLib

+Gerd, +Paolo On 10/30/23 07:12, Jacque Lin via groups.io wrote: > Remove checking SMM Rev ID in AMD Save State lib when reading Save > State Register EFI_MM_SAVE_STATE_REGISTER_IO. > For AMD, it is not necessary to check SmmRevId when reading Save State > Register EFI_MM_SAVE_STATE_REGISTER_IO. >

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 10/30/23 23:18, Kinney, Michael D wrote: > Hi Laszlo, > > I do not support orphaned categories and that option should be > removed from Maintainer.txt. One of the motivations to get > Maintainers.txt updated is to work on the set of tasks related to > using GitHub PRs for code review. I see.

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

tefan Berger > Cc: Wenxing Hou > Cc: Xiaoyu Lu > Signed-off-by: Michael D Kinney > --- > Maintainers.txt | 53 ++--- > 1 file changed, 2 insertions(+), 51 deletions(-) FWIW: Reviewed-by: Laszlo Ersek Additionally, based on Mike's explanation down-thread, I'm pro

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows: Add Stale Check

label makes it easy to filter stale PRs in the PR list and >write automation around PRs that are stale. It's also an obvious >visual identifier that a PR needs attention in the PR list. > > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Michael D Kinney > Cc: Laszlo E

Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

t;> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Zhiguang Liu >> Cc: Laszlo Ersek >> >> Signed-off-by: Dhaval Sharma >> Acked-by: Laszlo Ersek >> --- >> >> Notes: >> V7: >> - Added PcdLib >> - Restructure DEBU

Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

port added for RISC-V cache management >>> instructions in BaseLib. >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Cc: Zhiguang Liu >>> Cc: Laszlo Ersek >>> >>> Signed-off-by: Dhaval Sharma >>> Acked-by: Laszlo Ersek >

Re: [edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

On 10/31/23 07:10, jacopo.r0...@gmail.com wrote: > Hi Laszlo, > > If I generate the certificate like > > /openssl req -new -nodes -x509 -days 365 -keyout server.key -out > server.crt -config config / > > it works perfectly fine (with the original configuration). > > The problem stands with the *cha

Re: [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Core: Fix potential memory leak issue

comment below On 10/31/23 09:37, Xu, Wei6 wrote: > Delete one my wrong comments. > > -Original Message- > From: Xu, Wei6 > Sent: Tuesday, October 31, 2023 2:40 PM > To: Laszlo Ersek ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Sami Mujawar > ; Ni, Ray >

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MmSaveStateLib: Remove checking Smm Rev ID in AMD MmSaveStateLib

Hi, On 10/31/23 10:15, Attar, AbdulLateef (Abdul Lateef) wrote: > [Public] > > +Laszlo, +Gerd, +Paolo > PR: https://github.com/tianocore/edk2/pull/4982 ... My opinion, stated elsewhere in this thread in detail, is that this patch is wrong, and should not be merged. Laszlo > > -Original M

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

On 10/31/23 02:41, Wu, Hao A wrote: > (Add MdePkg maintainers for their feedbacks) > > Sorry that I do not have strong opinion on this one. > > Some of my thoughts are: > * If you find the to-be-added APIs can be used in serveral places to reduce > repetative codes, then it will be worthwhile t

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

On 10/31/23 02:41, Wu, Hao A wrote: > (Add MdePkg maintainers for their feedbacks) > > Sorry that I do not have strong opinion on this one. > > Some of my thoughts are: > * If you find the to-be-added APIs can be used in serveral places to reduce > repetative codes, then it will be worthwhile t

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg/PlatformCI/ReadMe.md: Update contents

e supported > and are > -described below. > +This solution for building and running ArmVirtPkg has been validated with > Fedora > +37 Linux and the GCC5 toolchain. Two different firmware builds are supported > +and are described below. "Two different firmware builds" is now

Re: [edk2-devel] [PATCH 6/7] OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files

On 10/30/23 15:36, Ard Biesheuvel wrote: > On Fri, 27 Oct 2023 at 07:43, duntan wrote: >> >> Use BaseIoLibIntrinsic.inf in dsc files. The >> BaseIoLibIntrinsic supports Tdx and sev now. >> The BaseIoLibIntrinsicSev will be removed in >> the following patches. >> >> Signed-off-by: Dun Tan >> Cc: A

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Allow relocation of images with large address

On 10/30/23 18:27, Jeff Brasen via groups.io wrote: > Anything else needed to get this merged would as the November stable release > is coming up. Queued via . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. Vie

Re: [edk2-devel] [PATCH v2 2/5] MdePkg ACPI65: Add 0x0B/PRM to Generic Address Structure

On 10/31/23 10:19, Jinlong Xu wrote: > Hi, Liming > > Could you please help merge the patch? This is a portion of PRM ACPI 6.5 > support feature. Queued via . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. Vi

Re: [edk2-devel] [PATCH v1 1/1] .azurepipelines: Fix Python version (to 3.12)

On 10/30/23 20:07, Michael Kubacki wrote: > Reviewed-by: Michael Kubacki Queued via . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110414): https://edk2.groups.io/g/devel/message/110414 Mu

Re: [edk2-devel] [PATCH v3 4/4] ArmVirtPkg: Add varpolicy shell command

gt;> - `"varpolicy -b"` pages output as expected >> - `"varpolicy -s"` shows accurate variable statistic information >> - `"varpolicy -p"` shows accurate UEFI variable policy information >> - `"varpolicy-v -b"` dumps all information including vari

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg/PlatformCI/ReadMe.md: Update contents

On 10/31/23 13:23, Laszlo Ersek wrote: > On 10/31/23 00:09, Michael Kubacki wrote: >> From: Michael Kubacki >> >> Since the code is most regularly tested in CI, distro/versioning >> details are updated to match the latest CI configuration. >> >> CI has

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows: Add Stale Check

ilter stale PRs in the PR list and >write automation around PRs that are stale. It's also an obvious >visual identifier that a PR needs attention in the PR list. > > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Michael D Kinney > Cc: Laszlo Ersek > Signed-off-by

Re: [edk2-devel] [PATCH v2 2/5] MdePkg ACPI65: Add 0x0B/PRM to Generic Address Structure

On 10/31/23 14:42, Laszlo Ersek wrote: > On 10/31/23 10:19, Jinlong Xu wrote: >> Hi, Liming >> >> Could you please help merge the patch? This is a portion of PRM ACPI 6.5 >> support feature. > > Queued via <https://github.com/tianocor

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows: Add Stale Check

On 10/31/23 14:44, Laszlo Ersek wrote: > On 10/31/23 02:41, Michael Kubacki wrote: >> From: Michael Kubacki >> >> Adds a GitHub workflow that uses the actions/stale GitHub action to >> automatically leave notifications on and close PRs that have had no >> act

Re: [edk2-devel] [PATCH v1 1/1] .azurepipelines: Fix Python version (to 3.12)

On 10/31/23 14:43, Laszlo Ersek wrote: > On 10/30/23 20:07, Michael Kubacki wrote: >> Reviewed-by: Michael Kubacki > > Queued via <https://github.com/tianocore/edk2/pull/4984>. Commit 8e7462907050350f8a9ed54437a4441082180a9c. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] [PATCH v3 4/4] ArmVirtPkg: Add varpolicy shell command

On 10/31/23 14:43, Laszlo Ersek wrote: > On 10/30/23 23:36, Ard Biesheuvel wrote: >> On Mon, 30 Oct 2023 at 21:31, wrote: >>> >>> From: Michael Kubacki >>> >>> Adds the varpolicy EFI shell command to all DSC files that >>> curren

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg/PlatformCI/ReadMe.md: Update contents

On 10/31/23 14:43, Laszlo Ersek wrote: > On 10/31/23 13:23, Laszlo Ersek wrote: >> On 10/31/23 00:09, Michael Kubacki wrote: >>> From: Michael Kubacki >>> >>> Since the code is most regularly tested in CI, distro/versioning >>> details are updated to

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Allow relocation of images with large address

On 10/31/23 14:42, Laszlo Ersek wrote: > On 10/30/23 18:27, Jeff Brasen via groups.io wrote: >> Anything else needed to get this merged would as the November stable release >> is coming up. > > Queued via <https://github.com/tianocore/

Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations

On 10/31/23 10:55, Dhaval Sharma wrote: > I am posting an update on behalf of Jingyu as he had trouble with > posting. ... that should be rectified now -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110431): https://edk2.groups.io/g/dev

Re: [edk2-devel] [PATCH] UefiCpuPkg/MmSaveStateLib: Remove checking Smm Rev ID in AMD MmSaveStateLib

On 10/31/23 11:43, Attar, AbdulLateef (Abdul Lateef) via groups.io wrote: > [Public] > > Hi Laszlo and @Lin, Jacque > Please find my response inline. > Thanks > AbduL > -Original Message- > From: Laszlo Ersek > Sent: Monday, October 30, 2023 7:34 PM

Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

rom the REP variant to the non-REP variant. And now I have actually found it. I'm going to quote the commit message in full: > commit fb8b54694c53e73e1b6a098686e908f54f9bb7a9 > Author: Laszlo Ersek > Date: Thu Apr 7 22:28:38 2016 +0200 > > UefiCpuPkg: CpuIo2Dxe: optimize FIFO

Re: [edk2-devel] CodeQL and Apache Licensed Files

On 10/31/23 17:07, Michael Kubacki wrote: > On 10/28/2023 7:51 AM, Laszlo Ersek wrote: >> On 10/27/23 23:11, Michael Kubacki wrote: >>> I'd like to bring attention to Apache License 2.0 code in the CodeQL >>> series I sent to the mailing list for steward review. >

Re: [edk2-devel] [PATCH] UefiCpuPkg: Correct file description for MpHandOff header file

On 10/7/23 08:32, Yuanhao Xie wrote: > Cc: Eric Dong > Cc: Rahul Kumar > Cc: Tom Lendacky > Signed-off-by: Yuanhao Xie > --- > UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Queued in . -=-=-

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks

(*PreviousTick < CurrentTick) { > - Delta = (mPerformanceCounterStartValue - CurrentTick) + *PreviousTick; > + Delta = (mPerformanceCounterStartValue - CurrentTick) + (*PreviousTick > - mPerformanceCounterEndValue); > } else { >Delta = *PreviousTick - CurrentTick; &

Re: [edk2-devel] [PATCH] UefiCpuPkg: Correct file description for MpHandOff header file

On 10/31/23 21:33, Laszlo Ersek wrote: > On 10/7/23 08:32, Yuanhao Xie wrote: >> Cc: Eric Dong >> Cc: Rahul Kumar >> Cc: Tom Lendacky >> Signed-off-by: Yuanhao Xie >> --- >> UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 5 - >> 1 file changed,

Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

On 10/31/23 18:06, Laszlo Ersek wrote: > (3) During all this discussion here, I have been *distinctly* > recalling that I've experienced an *actual performance regression* > sometime, after we had unwittingly switched from the REP variant to > the non-REP variant. > >

Re: [edk2-devel] [PATCH v1 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list

ath > used by opensource.org. > - The submodule list in this file is stale and is very prone to > being forgotten. The list of submodules in the submodules setion > is replaced with a link to .gitmodules which has an active list > of submodules at any given time. > > Cc: A

<    1   2   3   4   5   6   7   8   9   10   >