On 10/21/23 19:33, Dhaval Sharma wrote: > The declarations for cache Management functions belong to BaseLib > instead of instance source file. This helps with further restructuring > of cache management code for RISC-V. > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang....@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > > Signed-off-by: Dhaval Sharma <dha...@rivosinc.com> > --- > > Notes: > V5: > - Move cache management function declaration in baselib where it belongs > > MdePkg/Include/Library/BaseLib.h | 20 ++++++++++++++++++++ > MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c | 20 -------------------- > 2 files changed, 20 insertions(+), 20 deletions(-) > > diff --git a/MdePkg/Include/Library/BaseLib.h > b/MdePkg/Include/Library/BaseLib.h > index 5d7067ee854e..7142bbfa42f2 100644 > --- a/MdePkg/Include/Library/BaseLib.h > +++ b/MdePkg/Include/Library/BaseLib.h > @@ -206,6 +206,26 @@ RiscVClearPendingTimerInterrupt ( > VOID > ); > > +/** > + RISC-V invalidate instruction cache. > + > +**/ > +VOID > +EFIAPI > +RiscVInvalidateInstCacheAsm ( > + VOID > + ); > + > +/** > + RISC-V invalidate data cache. > + > +**/ > +VOID > +EFIAPI > +RiscVInvalidateDataCacheAsm ( > + VOID > + ); > + > #endif // defined (MDE_CPU_RISCV64) > > #if defined (MDE_CPU_LOONGARCH64) > diff --git a/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c > b/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c > index d08fb9f193ca..d5efcf49a4bf 100644 > --- a/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c > +++ b/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c > @@ -10,26 +10,6 @@ > #include <Library/BaseLib.h> > #include <Library/DebugLib.h> > > -/** > - RISC-V invalidate instruction cache. > - > -**/ > -VOID > -EFIAPI > -RiscVInvalidateInstCacheAsm ( > - VOID > - ); > - > -/** > - RISC-V invalidate data cache. > - > -**/ > -VOID > -EFIAPI > -RiscVInvalidateDataCacheAsm ( > - VOID > - ); > - > /** > Invalidates the entire instruction cache in cache coherency domain of the > calling CPU.
Reviewed-by: Laszlo Ersek <ler...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110001): https://edk2.groups.io/g/devel/message/110001 Mute This Topic: https://groups.io/mt/102103776/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
