Re: [edk2-devel] [PATCH] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-26 Thread Li, Yi
Hi Zack, Please check V3 patch, thanks for review. Regards, Yi From: Clark-williams, Zachary Sent: Friday, June 23, 2023 6:26 AM To: devel@edk2.groups.io; Li, Yi1 ; Clark-williams, Zachary Subject: RE: [edk2-devel] [PATCH] NetworkPkg: Correct the length of EAP Identity when in ASCII format

[edk2-devel] [PATCH 0/3] ArmPkg: some memory attribute lib followup changes

2023-06-26 Thread Ard Biesheuvel
A couple of tweaks for the memory attribute handling code to go on top of the memory attribute PPI changes. Cc: Sami Mujawar Cc: Leif Lindholm Ard Biesheuvel (3): StandaloneMmPkg: Include correct MmuLib header ArmPkg: Drop individual memory permission helpers ArmPkg/OpteeLib: Map shared c

[edk2-devel] [PATCH 1/3] StandaloneMmPkg: Include correct MmuLib header

2023-06-26 Thread Ard Biesheuvel
StandaloneMm has its own version of the ArmMmuLib library class, but includes the ArmMmuLib header. This happens to work because the prototypes that are referenced are the same, but this will no longer be the case after a future patch. So correct the #includes. Signed-off-by: Ard Biesheuvel ---

[edk2-devel] [PATCH 3/3] ArmPkg/OpteeLib: Map shared communication buffer non-executable

2023-06-26 Thread Ard Biesheuvel
The OP-TEE secure OS exposes a non-secure memory region for communication between the secure OS itself and any clients in the non-secure firmware. This memory is writable by non-secure and is not used for code only data, and so it should be mapped non-executable. Signed-off-by: Ard Biesheuvel ---

[edk2-devel] [PATCH 2/3] ArmPkg: Drop individual memory permission helpers

2023-06-26 Thread Ard Biesheuvel
Now that we have a sane API to set and clear memory permissions that works the same on ARM and AArch64, we no longer have a need for the individual set/clear no-access/read-only/no-exec helpers so let's drop them. Signed-off-by: Ard Biesheuvel --- ArmPkg/Drivers/CpuDxe/CpuDxe.c

[edk2-devel] [PATCH v4 2/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm: Add USB Cdc ECM devices support

2023-06-26 Thread RichardHo [何明忠] via groups . io
This driver provides UEFI driver for USB CDC ECM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni Tested-by: Tinh Nguyen Acked-by: Hao A Wu Reviewed-by: Rebecca Cran Revie

[edk2-devel] [PATCH v4 3/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm: Add USB Cdc NCM devices support

2023-06-26 Thread RichardHo [何明忠] via groups . io
This driver provides UEFI driver for USB CDC NCM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni Tested-by: Tinh Nguyen Acked-by: Hao A Wu Reviewed-by: Rebecca Cran Revie

Re: [edk2-devel] [Patch V3 1/5] UefiCpuPkg: Refactor the logic for placing APs in HltLoop.

2023-06-26 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Xie, Yuanhao > Sent: Monday, June 26, 2023 1:57 PM > To: devel@edk2.groups.io > Cc: Gerd Hoffmann ; Dong, Eric ; Ni, > Ray ; Kumar, Rahul R ; Tom > Lendacky ; Xie, Yuanhao > > Subject: [Patch V3 1/5] UefiCpuPkg: Refactor the logic for pla

Re: [edk2-devel] [Patch V3 2/5] UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop.

2023-06-26 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Xie, Yuanhao > Sent: Monday, June 26, 2023 1:57 PM > To: devel@edk2.groups.io > Cc: Gerd Hoffmann ; Dong, Eric ; Ni, > Ray ; Kumar, Rahul R ; Tom > Lendacky ; Xie, Yuanhao > > Subject: [Patch V3 2/5] UefiCpuPkg: Refactor the logic for pla

Re: [edk2-devel] [PATCH v2 0/7] Add PPI to manage PEI phase memory attributes

2023-06-26 Thread Ard Biesheuvel
On Sun, 25 Jun 2023 at 04:59, gaoliming via groups.io wrote: > > For the changes in MdeModulePkg, Reviewed-by: Liming Gao > > Merged as #4573 Thanks all. > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Michael > > Kubacki > > 发送时间: 2023年6月7日 7:13 > > 收件人: Ard Biesheuvel ; devel@edk2.gro

Re: [edk2-devel] [Patch V3 3/5] UefiCpuPkg: Create MpHandOff.

2023-06-26 Thread Ni, Ray
Several comments below: > > The SaveCpuMpData() function was updated to construct the MP_HAND_OFF > Hob. Additionally, the function introduced the MP_HAND_OFF_SIGNAL, > which solely served the purpose of awakening the APs > and transitioning their context from PEI to DXE. The > WaitLoopExecutionM

Re: [edk2-devel] [Patch V3 4/5] UefiCpuPkg: ApWakeupFunction directly use CpuMpData.

2023-06-26 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Xie, Yuanhao > Sent: Monday, June 26, 2023 1:57 PM > To: devel@edk2.groups.io > Cc: Gerd Hoffmann ; Dong, Eric ; Ni, > Ray ; Kumar, Rahul R ; Tom > Lendacky ; Xie, Yuanhao > > Subject: [Patch V3 4/5] UefiCpuPkg: ApWakeupFunction directly

Re: [edk2-devel] uefi VM and IO window overlap issue

2023-06-26 Thread Ard Biesheuvel
On Tue, 20 Jun 2023 at 16:27, Gerd Hoffmann wrote: > > On Mon, Jun 12, 2023 at 07:27:37PM +, Kallol Biswas [C] wrote: > > Hi, > > We have been observing an issue that IO BARs can't be claimed due to > > resource > > conflict. > > > > [0.457693] pci :00:1d.0: can't claim BAR 4 [io

[edk2-devel] [PATCH v2 1/1] OvmfPkg/PciHotPlugInitDxe: fix io window size

2023-06-26 Thread Gerd Hoffmann
Smallest IO window size for PCI bridges is 0x1000. Fix default size accordingly. Avoids broken resource assignments like this: [ ... ] PciBus: Resource Map for Root Bridge PciRoot(0x0) Type = Io16; Base = 0x6000; Length = 0x7000;Alignment = 0xFFF [ ... ] Base =

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/PciHotPlugInitDxe: fix io window size

2023-06-26 Thread Ard Biesheuvel
On Mon, 26 Jun 2023 at 12:38, Gerd Hoffmann wrote: > > Smallest IO window size for PCI bridges is 0x1000. Fix default size > accordingly. Avoids broken resource assignments like this: > > [ ... ] > PciBus: Resource Map for Root Bridge PciRoot(0x0) > Type = Io16; Base = 0x6000; Le

Re: [edk2-devel] [Patch V2 3/6] UefiCpuPkg: Create MpHandOff.

2023-06-26 Thread Gerd Hoffmann
Hi, > The SaveCpuMpData() function was updated to construct the MP_HAND_OFF > Hob. The HOB still has the same scaleability problem (~2700 cpus max). take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106362): https://e

Re: [edk2-devel] [Patch V2 3/6] UefiCpuPkg: Create MpHandOff.

2023-06-26 Thread Yuanhao Xie
Hi Gerd, Please check [Patch V2 6/6] UefiCpuPkg: Enhance MpHandOff Handling. Best, Yuanhao -Original Message- From: Gerd Hoffmann Sent: Monday, June 26, 2023 7:22 PM To: Xie, Yuanhao Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray ; Kumar, Rahul R ; Tom Lendacky Subject: Re: [Patch

[edk2-devel] [PATCH 1/2] MdePkg: Move gTraceHubDebugInfoHobGuid to MdePkg

2023-06-26 Thread victorx . hsu
From: VictorX Hsu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 Move gTraceHubDebugInfoHobGuid to MdePkg. Cc: Liming Gao Reviewed-by: Guo Gua Cc: Chan Laura Cc: Prakashan Krishnadas Veliyathuparambil Cc: K N Karthik Signed-off-by: VictorX Hsu --- MdeModulePkg/MdeModulePkg.dec

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] Platform/AMD: Initial commit of AmdPlatformPkg

2023-06-26 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: Wednesday, June 21, 2023 10:36 AM To: devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) Subject: [edk2-platforms][PATCH 1/2] Platform/AMD: Initial commit of AmdPlatf

[edk2-devel] [PATCH 2/2] Maintainers.txt: Move TraceHubDebugInfoHob.h to MdePkg

2023-06-26 Thread victorx . hsu
From: VictorX Hsu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4486 Move TraceHubDebugInfoHob.h to MdePkg. Cc: Michael D Kinney Cc: Andrew Fish Cc: Liming Gao Cc: Guo Gua Cc: Chan Laura Cc: Prakashan Krishnadas Veliyathuparambil Cc: K N Karthik Signed-off-by: VictorX Hsu --- Ma

Re: [edk2-devel] [PATCH v1] StandaloneMmPkg: Add StandaloneMmIplPei driver.

2023-06-26 Thread Zhang, Hongbin1
Hi Ray, I have split to 5 patches with 5 commits in https://github.com/tianocore/edk2/pull/4375/ according to your suggestion. Please help to review it again. Thanks, Hongbin -Original Message- From: Zhang, Hongbin1 Sent: Wednesday, June 7, 2023 10:37 AM To: Yao, Jiewen ; Ni, Ray ;

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] AmdPlatformPkg/SimulatorSerialPortLibPort80: Simulator serial port lib

2023-06-26 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: Wednesday, June 21, 2023 7:08 AM To: devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) Subject: [edk2-platforms][PATCH 2/2] AmdPlatformPkg/SimulatorSerialPortLibPort

Re: [edk2-devel] [PATCH edk2-platforms v2 0/2] SbsaQemu: get GIC data from QEMU

2023-06-26 Thread Leif Lindholm
On Tue, Jun 06, 2023 at 11:21:23 +0200, Marcin Juszkiewicz wrote: > Those changes make use of recently added SMC calls to get GIC data from > QEMU instead of having them hardcoded. This is a beginning of changing > this platform to be more flexible. > > My blog post about our plans to QEMU SBSA Re

Re: [edk2-devel] [PATCH 3/3] ArmPkg/OpteeLib: Map shared communication buffer non-executable

2023-06-26 Thread Leif Lindholm
On Mon, Jun 26, 2023 at 10:36:44 +0200, Ard Biesheuvel wrote: > The OP-TEE secure OS exposes a non-secure memory region for > communication between the secure OS itself and any clients in the > non-secure firmware. This memory is writable by non-secure and is not > used for code only data, and so i

[edk2-devel] build Errore

2023-06-26 Thread skeleton artem
C:\edk2>build Build environment: Windows-10-10.0.19045-SP0 Build start time: 22:01:50, Jun.26 2023 WORKSPACE= c:\edk2 EDK_TOOLS_PATH = c:\edk2\basetools EDK_TOOLS_BIN= c:\edk2\basetools\bin\win32 CONF_PATH= c:\edk2\conf PYTHON_COMMAND = py -3 Processing meta-data . Archit

[edk2-devel] [PATCH v2 0/2] Support MM based variable services in PEI for ARM

2023-06-26 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 This patch series is a follow-up of previous submission: https://edk2.groups.io/g/devel/message/105954 The main changes between v1 and v2 patches are: - Adjusted input "CommSize" verification from MmCommunicationPei - Added more debug p

[edk2-devel] [PATCH v2 1/2] ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI

2023-06-26 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 This change introduced the MM communicate support in PEI phase for ARM based platforms. Similar to the DXE counterpart, `PcdMmBufferBase` is used as communicate buffer and SMC will be invoked to communicate to TrustZone when

[edk2-devel] [PATCH v2 2/2] MdeModulePkg: Variable: Introduce MM based variable read service in PEI

2023-06-26 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 This change introduced the Standalone MM based variable read capability in PEI phase for applicable platforms (such as ARM platforms). Similar to the x86 counterpart, MM communicate PPI is used to request variable informatio

Re: [edk2-devel] [PATCH v1 1/2] ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI

2023-06-26 Thread Kun Qin
Hi Sami, Thank you for your feedback. I have update the code as you suggested. Could you please re-review when you have a chance? https://edk2.groups.io/g/devel/message/106372 Thanks, Kun On 6/22/2023 12:17 PM, Sami Mujawar wrote: Hi Kun, Thank you for this patch. Please find my response

Re: 回复: [edk2-devel] [PATCH v1 2/2] MdeModulePkg: Variable: Introduce MM based variable read service in PEI

2023-06-26 Thread Kun Qin
Hi Liming, Thanks for catching that. I have removed the PCD usage and resend the patch here: https://edk2.groups.io/g/devel/message/106372 Could you please let me know if you have any other feedback? Per your functionality question, yes, the functionality was verified on both virtual and phy

[edk2-devel] IpmiCommandLib's IpmiGetSystemUuid clarification

2023-06-26 Thread Aaron Pop
I was hoping to get a clarification on the IpmiGetSystemUuid from MdeModulePkg... IPMI specification's Get Device Guid Command says that data is returned in "least signification byte first" and "this is the reverse of convention described in RFC4122". IpmiGetSystemUuid specifies that it is

[edk2-devel] [PATCH v1 00/24] Update Edk2-pytools to latest versions

2023-06-26 Thread Joey Vagedes
Updates Edk2-pytools to the latest versions, which introduces a new Policy for detecting which packages must be built given a set of changes. This policy is used when a library class instance INF is changed. When this occurs, it will review the PrEval:DscPath provided in the CI YAML file and determ

[edk2-devel] [PATCH v1 01/24] Edk2: edk2-pytools: Update to latest versions

2023-06-26 Thread Joey Vagedes
Update to the latest versions of edk2-pytool-extensions and edk2-pytool-library. This introduces a new policy to stuart_pr_eval which, when a change in an INF occurs, will mark any associated DSC that uses this INF to be built during CI. Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney

[edk2-devel] [PATCH v1 03/24] UefiPayloadPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 04/24] ArmPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 08/24] DynamicTablesPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 12/24] IntelFsp2Pkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 09/24] EmbeddedPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 05/24] UefiCpuPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 10/24] FatPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 11/24] FmpDevicePkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 02/24] UnitTestFrameworkPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 15/24] SignedCapsulePkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 14/24] SourceLevelDebugPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 06/24] ArmPlatformPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 16/24] ShellPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 17/24] SecurityPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 19/24] PrmPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 18/24] RedfishPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 21/24] NetworkPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 20/24] PcAtChipsetPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 22/24] MdePkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 23/24] MdeModulePkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

[edk2-devel] [PATCH v1 24/24] IntelFsp2WrapperPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to det

Re: [edk2-devel] [PATCH v1 0/2] Automatically set NXCOMPAT bit if requirements are met

2023-06-26 Thread Joey Vagedes
Hi Liming, This is being done as a part of the memory protections work which can be reviewed here: Task Table · Memory Protections (github.com) Overall, DxeCore will ingest the NX_COMPAT flag on image load. In the base case, when modules make alloca

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, June 26, 2023 #cal-reminder

2023-06-26 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, June 26, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f9

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, June 26, 2023 #cal-notice

2023-06-26 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, June 26, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-

Re: [edk2-devel] [PATCH] RedfishPkg: Fix SortLib library class name typo.

2023-06-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Mike, could you please create a PR for this change? Then I can merge it once the change passed CI. Thanks Abner > -Original Message- > From: Chang, Abner > Sent: Wednesday, June 21, 2023 8:26 AM > To: Mike Maslenkin ; devel@edk2.groups.io > Cc: nick.

Re: 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-06-26 Thread Michael Kubacki
On 6/24/2023 9:33 PM, gaoliming via groups.io wrote: Abhi: Sorry for the missing patch. I agree Michael comment. Can you help update the patch? If yes, you can add my Reviewed-by: Liming Gao Thanks Liming -邮件原件- 发件人: devel@edk2.groups.io 代表 Michael Kubacki 发送时间: 2023年6月9日 4:58 收件人

回复: [edk2-devel] Need help to add me to the edk-ii-maintainers and edk-ii-reviewers team

2023-06-26 Thread gaoliming via groups.io
Chinni: Mike is the maintainer of these two teams. Please wait for his response. Thanks Liming 发件人: devel@edk2.groups.io 代表 cbduggap 发送时间: 2023年6月26日 12:28 收件人: devel@edk2.groups.io 抄送: Chiu, Chasel 主题: Re: [edk2-devel] Need help to add me to the edk-ii-maintainers and edk-ii-reviewers t

回复: 回复: [edk2-devel] [PATCH v1 2/2] MdeModulePkg: Variable: Introduce MM based variable read service in PEI

2023-06-26 Thread gaoliming via groups.io
Kun: Thanks for your update. I have no other comments for this patch. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Kun Qin > 发送时间: 2023年6月27日 4:11 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: 'Hao A Wu' ; 'Jian J Wang' > ; 'Ronny Hansen'

[edk2-devel] 回复: [PATCH v1 00/24] Update Edk2-pytools to latest versions

2023-06-26 Thread gaoliming via groups.io
Joey: So, this change is required for all package YAML. If yes, can PrEval be auto set to the package dsc if only one DSC is in Package directory? Thanks Liming > -邮件原件- > 发件人: Joey Vagedes > 发送时间: 2023年6月27日 5:34 > 收件人: devel@edk2.groups.io > 抄送: Abner Chang ; Alexei Fedorov > ; Ard Bi

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, June 27, 2023 #cal-reminder

2023-06-26 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, June 27, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed

Re: [edk2-devel] [PATCH v2 0/1] CI: Use latest image for Linux jobs (Qemu 8, gcc 12)

2023-06-26 Thread Michael Kubacki
Merged in #4576 On 6/26/2023 2:44 AM, Oliver Steffen wrote: Quoting Michael Kubacki (2023-06-23 15:08:12) Hi Oliver, I see the PR you linked is marked as draft and test. I'm happy to help push this if you can confirm when you're done testing. Changed it, removed Draft and "Test". Thanks,

[edk2-devel] [Patch V3] [edk2-staging] BaseTools/FMMT: C FMMT match new version machine defines

2023-06-26 Thread Yuwei Chen
BaseTools have switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_*. Thus, match the FCE & FMMT tool in edk2-staging repo with the new version define. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Signed-off-by: Yuwei Chen --- V3 modify the patch with the correct define BaseTools/Source/C/F

[edk2-devel] [Patch V7 00/14] Use CpuPageTableLib to create and update smm page table

2023-06-26 Thread duntan
In the V7 patch set: In 'OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry', remove the code to apply AddressEncMask to PageMapLevel4Entry in InternalMemEncryptSevCreateIdentityMap1G() function. Only resend the patch in OvmfPkg for review. Other patches in the patch set have been

[edk2-devel] [Patch V7 01/14] OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry

2023-06-26 Thread duntan
Remove code that apply AddressEncMask to non-leaf entry when split smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it calls MemEncryptSevClearMmioPageEncMask to clear AddressEncMask bit in page table for a specific range. In AMD SEV feature, this AddressEncMask bit in page table is us

Re: [edk2-devel] [Patch V3 5/5] UefiCpuPkg: Eliminate the second INIT-SIPI-SIPI sequence.

2023-06-26 Thread Ni, Ray
> + OriginalValue = InterlockedCompareExchange32 ( > +(UINT32 *)ApStartupSignalBuffer, > +MP_HAND_OFF_SIGNAL, > +0 > +); > + if (OriginalValue == MP_HAND

[edk2-devel] 回复: [Patch V3] [edk2-staging] BaseTools/FMMT: C FMMT match new version machine defines

2023-06-26 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Yuwei Chen > 发送时间: 2023年6月27日 10:54 > 收件人: devel@edk2.groups.io > 抄送: Rebecca Cran ; Liming Gao > ; Bob Feng > 主题: [Patch V3] [edk2-staging] BaseTools/FMMT: C FMMT match new > version machine defines > > BaseTools have switch from EFI_IMAGE_MACHI