On Mon, 26 Jun 2023 at 12:38, Gerd Hoffmann <[email protected]> wrote:
>
> Smallest IO window size for PCI bridges is 0x1000. Fix default size
> accordingly. Avoids broken resource assignments like this:
>
> [ ... ]
> PciBus: Resource Map for Root Bridge PciRoot(0x0)
> Type = Io16; Base = 0x6000; Length = 0x7000; Alignment = 0xFFF
> [ ... ]
> Base = 0xC000; Length = 0x200; Alignment = 0xFFF; Owner =
> PPB [00|02|00:**]
> Base = 0xC200; Length = 0x40; Alignment = 0x3F; Owner =
> PCI [00|1F|03:20]
> Base = 0xC240; Length = 0x20; Alignment = 0x1F; Owner =
> PCI [00|1F|02:20]
> [ ... ]
>
> ... which the linux kernel fixes up later:
>
> [ 0.644657] pci 0000:00:1f.3: BAR 4: assigned [io 0x1000-0x103f]
> [ 0.646833] pci 0000:00:1f.2: BAR 4: assigned [io 0x1040-0x105f]
>
> With the patch applied:
>
> { ... ]
> PciBus: Resource Map for Root Bridge PciRoot(0x0)
> Type = Io16; Base = 0x6000; Length = 0x8000; Alignment = 0xFFF
> [ ... ]
> Base = 0xC000; Length = 0x1000; Alignment = 0xFFF;
> Owner = PPB [00|02|00:**]
> Base = 0xD000; Length = 0x40; Alignment = 0x3F; Owner =
> PCI [00|1F|03:20]
> Base = 0xD040; Length = 0x20; Alignment = 0x1F; Owner =
> PCI [00|1F|02:20]
> [ ... ]
>
> Signed-off-by: Gerd Hoffmann <[email protected]>
Thanks - I've queued this up now.
> ---
> OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c
> b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c
> index 69903a600981..bb2389d16c70 100644
> --- a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c
> +++ b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c
> @@ -741,7 +741,7 @@ GetResourcePadding (
> //
> // Request defaults.
> //
> - SetIoPadding (--FirstResource, (UINTN)HighBitSetRoundUp64 (512));
> + SetIoPadding (--FirstResource, (UINTN)HighBitSetRoundUp64 (0x1000));
> }
>
> if (DefaultMmio) {
> --
> 2.41.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106361): https://edk2.groups.io/g/devel/message/106361
Mute This Topic: https://groups.io/mt/99784806/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
