On Tue, Jun 06, 2023 at 11:21:23 +0200, Marcin Juszkiewicz wrote:
> Those changes make use of recently added SMC calls to get GIC data from
> QEMU instead of having them hardcoded. This is a beginning of changing
> this platform to be more flexible.
> 
> My blog post about our plans to QEMU SBSA Reference Platform:
> 
> https://marcin.juszkiewicz.com.pl/2023/05/23/versioning-of-sbsa-ref-machine/
> 
> Marcin Juszkiewicz (2):
>   Platform/SbsaQemu: read platform version
>   Platform/SbsaQemu: read GIC base from TF-A

There are a few style issues in the set:
- { for if statements placed on separate line
- Copyright stanza missing <BR>
- New header file missing include guard.

Since I've been tardy with review, I've addressed these, added
Reviewed-by: Leif Lindholm <quic_llind...@quicinc.com>
and pushed as be2af02a3fb2..1befeabcc86a.

Thanks!

/
    Leif

>  Silicon/Qemu/SbsaQemu/SbsaQemu.dec            |  3 ++
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc           |  3 ++
>  .../SbsaQemuPlatformDxe.inf                   |  9 +++++
>  .../Include/IndustryStandard/SbsaQemuSmc.h    | 12 ++++++
>  .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 37 +++++++++++++++++++
>  5 files changed, 64 insertions(+)
>  create mode 100644 
> Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuSmc.h
> 
> -- 
> 2.40.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106369): https://edk2.groups.io/g/devel/message/106369
Mute This Topic: https://groups.io/mt/99359662/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: 
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to