[edk2-devel] [Patch V4 00/21] Fix issues in CpuPageTableLib

In the V4 atch set 1. In the patch "UefiCpuPkg/MpInitLib: Add code to initialize MapMask", add code to set MapMask to MAX_UINT64 to fix the boot failure tested by Gred. 2. Add patches to enable PAE paing in CpuPageTable Lib and add random test for PAE paging 3. Add patch to reduce the number of r

[edk2-devel] [Patch V4 01/21] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition

Remove unneeded 'if' condition in CpuPageTableLib code. The deleted code is in the code branch for present non-leaf parent entry. So the 'if' check for (ParentPagingEntry->Pnle.Bits.Present == 0) is always FALSE. Signed-off-by: Dun Tan Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar Cc: Gerd

[edk2-devel] [Patch V4 02/21] UefiCpuPkg/CpuPageTableLib: Add check for input Length

Add check for input Length in PageTableMap (). Return RETURN_SUCCESS when input Length is 0. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Include/Library/CpuPageTableLib.h | 4 ++-- UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap

[edk2-devel] [Patch V4 03/21] UefiCpuPkg/CpuPageTableLib:Initialize some LocalVariable at beginning

Move some local variable initialization to the beginning of the function. Also delete duplicated calculation for RegionLength. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 21 -

[edk2-devel] [Patch V4 04/21] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

In previous code logic, when splitting a leaf parent entry to smaller granularity child page table, if the parent entry Attribute&Mask(without PageTableBaseAddress field) is equal to the input attribute&mask(without PageTableBaseAddress field), the split process won't happen. This may lead to failu

[edk2-devel] [Patch V4 05/21] UefiCpuPkg/CpuPageTableLib:Clear PageSize bit(Bit7) for non-leaf

Clear PageSize bit(Bit7) for non-leaf entry in PageTableLibSetPnle. This function is used to set non-leaf entry attributes so it should make sure that the PageSize bit of the entry should be 0. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/L

[edk2-devel] [Patch V4 06/21] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry

When splitting leaf parent entry to smaller granularity, create child page table before modifing parent entry. In previous code logic, when splitting a leaf parent entry, parent entry will point to a null 4k memory before child page table is created in this 4k memory. When the page table to be modi

[edk2-devel] [Patch V4 07/21] UefiCpuPkg/MpInitLib: Add code to initialize MapMask

In function CreatePageTable(), add code to initialize MapMask to MAX_UINT64. When creating new page table or map non-present range to present, all attributes should be provided. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/MpInitLib

[edk2-devel] [Patch V4 08/21] UefiCpuPkg/CpuPageTableLib:Add check for Mask and Attr

For different usage, check if the combination for Mask and Attr is valid when creating or updating page table. 1.For non-present range 1.1Mask.Present is 0 but some other attributes is provided. This case is invalid. 1.2Mask.Present is 1 and Attr.Present is 0. In this case,all other

[edk2-devel] [Patch V4 09/21] UefiCpuPkg/CpuPageTableLib: Add manual test to check Mask and Attr

Add manual test case to check input Mask and Attribute. The check steps are: 1.Create Page table to cover [0, 2G]. All fields of MapMask should be set. 2.Update Page table to set [2G - 8K,2G] from present to non-present. All fields of MapMask except present should not be set. 3.Still set [2G -

[edk2-devel] [Patch V4 10/21] UefiCpuPkg/CpuPageTableLib:Modify RandomBoolean() in RandomTest

Add an input parameter to control the probability of returning true. Change RandomBoolean() in RandomTest from 50% chance returning true to returning true with the percentage of input Probability. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPk

[edk2-devel] [Patch V4 11/21] UefiCpuPkg/CpuPageTableLib:Modify RandomTest to check Mask/Attr

Modify RandomTest to check invalid input. When creating new page table or updating exsiting page table: 1.If set [LinearAddress, LinearAddress+Length] to non-preset, all other attributes should not be provided. 2.If [LinearAddress, LinearAddress+Length] contain non-present range, the Returnstat

[edk2-devel] [Patch V4 12/21] UefiCpuPkg/CpuPageTableLib: Enable non-1:1 mapping in random test

Enable non-1:1 mapping in random test. In previous test, non-1:1 test will fail due to the non-1:1 mapping issue in CpuPageTableLib and invalid Input Mask when creating new page table or mapping not-present range. Now these issue have been fixed. Signed-off-by: Dun Tan Cc: Eric Dong Reviewed-by:

[edk2-devel] [Patch V4 13/21] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter.

Add OUTPUT IsModified parameter in PageTableMap() to indicate if page table has been modified. With this parameter, caller can know if need to call FlushTlb when the page table is in CR3. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Include

[edk2-devel] [Patch V4 14/21] UefiCpuPkg/CpuPageTableLib: Modify RandomTest to check IsModified

Modify RandomTest to check if parameter IsModified of PageTableMap() correctlly indicates whether input page table is modified or not. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Zhiguang Liu --- UefiCpuPkg/Library/CpuPageTableLib/UnitTest/RandomTes

[edk2-devel] [Patch V4 15/21] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf

From: Zhiguang Liu The definition of IA32_MAP_ATTRIBUTE has 64 bits, and one of the bit field PageTableBaseAddress is from bit 12 to bit 52. This means if the compiler treats the 64bits value as two UINT32 value, the field PageTableBaseAddress spans two UINT32 value. That's why when building in N

[edk2-devel] [Patch V4 16/21] UefiCpuPkg: Modify UnitTest code since tested API is changed

From: Zhiguang Liu Last commit changed the CpuPageTableLib API PageTableMap, unit test code should also be modified. Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar Signed-off-by: Zhiguang Liu --- UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c | 38

[edk2-devel] [Patch V4 17/21] UefiCpuPkg/CpuPageTableLib: Add check for page table creation

Add code to compare ParentPagingEntry Attribute&Mask and input Attribute&Mask to decide if new next level page table is needed in non-present ParentPagingEntry condition. This can help avoid unneccessary page table creation. For example, there is a page table in which [0, 1G] is mapped(Lv4[0] ,Lv3

[edk2-devel] [Patch V4 18/21] UefiCpuPkg: Combine branch for non-present and leaf ParentEntry

Combine 'if' condition branch for non-present and leaf Parent Entry in PageTableLibMapInLevel. Most steps of these two condition are the same. This commit doesn't change any functionality. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Librar

[edk2-devel] [Patch V4 19/21] UefiCpuPkg/CpuPageTableLib: Enable PAE paging

Modify CpuPageTableLib code to enable PAE paging. In PageTableMap() API: When creating new PAE page table, after creating page table, set all MustBeZero fields of 4 PDPTE to 0. The MustBeZero fields are treated as RW and other attributes by the common map logic. So they might be set to 1. When upda

[edk2-devel] [Patch V4 20/21] UefiCpuPkg/CpuPageTableLib: Add RandomTest for PAE paging

Add RandomTest for PAE paging. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c | 2 ++ UefiCpuPkg/Library/CpuPageTableLib/UnitTest/RandomTest.c | 3 +-- UefiCp

[edk2-devel] [Patch V4 21/21] UefiCpuPkg/CpuPageTableLib: Reduce the number of random tests

Reduce the number of random tests. In previous patch, non-1:1 mapping is enbaled and it may need more than an hour and a half for the CI test, which may lead to CI timeout. Reduce the number of random test count to pass the CI. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console.

On Wed, Mar 22, 2023 at 10:31:32AM -0600, Rebecca Cran wrote: > On 3/22/23 10:20 AM, Ard Biesheuvel wrote: > > On Fri, 17 Mar 2023 at 13:19, Gerd Hoffmann wrote: > > > Time to leave behind relics from the last century and arrive in the > > > modern world. Drop PC-ANSI Terminal Type for the serial

Re: [edk2-devel] [edk2-staging/OpenSSL11_EOL][PATCH 4/4] Readme: 0322 update

Hi, > +### Level 2: A bit like workaround, with possibility of upstream to openssl > +1. Enable the legacy path for X509 pubkey decode and pmeth initialization, > +The purpose is to avoid the use of EN/DECODE and Signature provider, will > reduce size about 90KB. > +(commit: x509: enable le

Re: [edk2-devel] [PATCH 3/9] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38

On Thu, 23 Mar 2023 at 02:30, Rebecca Cran wrote: > > On 3/22/23 5:49 AM, Ard Biesheuvel wrote: > > > > > The reason I added CLANG3x support for ARM in the past is to ensure > > compatibility with the ARM proprietary, Clang based toolchain. At the > > time, we went with GNU ld, but I would actuall

Re: [edk2-devel] [Patch V4 00/21] Fix issues in CpuPageTableLib

On Thu, Mar 23, 2023 at 03:40:36PM +0800, duntan wrote: > In the V4 atch set > 1. In the patch "UefiCpuPkg/MpInitLib: Add code to initialize MapMask", add > code to set MapMask to MAX_UINT64 to fix the boot failure tested by Gred. > 2. Add patches to enable PAE paing in CpuPageTable Lib and add ra

Re: [edk2-devel] [Patch V4 00/21] Fix issues in CpuPageTableLib

Thank you Gerd! Thanks, Dun -Original Message- From: Gerd Hoffmann Sent: Thursday, March 23, 2023 5:13 PM To: devel@edk2.groups.io; Tan, Dun Subject: Re: [edk2-devel] [Patch V4 00/21] Fix issues in CpuPageTableLib On Thu, Mar 23, 2023 at 03:40:36PM +0800, duntan wrote: > In the V4 atc

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console.

On Thu, 23 Mar 2023 at 09:20, Gerd Hoffmann wrote: > > On Wed, Mar 22, 2023 at 10:31:32AM -0600, Rebecca Cran wrote: > > On 3/22/23 10:20 AM, Ard Biesheuvel wrote: > > > On Fri, 17 Mar 2023 at 13:19, Gerd Hoffmann wrote: > > > > Time to leave behind relics from the last century and arrive in the

[edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt: Support multiple reserved memory ranges

M-mode firmware ranges should not be used by EDK2/OS. Currently, we search for mmode_resv0 node in FDT and mark it as the reserved memory in EFI memory map. However, if there are multiple M-mode firmware ranges, then this will miss those extra ranges allowing the OS to access the memory and hit a f

[edk2-devel] [PATCH 0/8] BaseTools: remove duplicate includes.

There is alot of code duplication between BaseTools and MdePkg (and also MdeModulePkg). This patch series starts reducing this by removing some header files. BaseTools are switched over to use the include files in MdePkg instead. It also cleans up some (apparently) obsolete code and adapts BaseT

[edk2-devel] [PATCH 1/8] BaseTools: remove WinNtInclude.h

Appears to be a relic for ancient windows / compiler versions, windows builds in CI work just fine without it. Signed-off-by: Gerd Hoffmann --- BaseTools/Source/C/Common/WinNtInclude.h| 66 - BaseTools/Source/C/GenFv/GenFvInternalLib.c | 1 - BaseTools/Source/C/GenFw/Elf

[edk2-devel] [PATCH 2/8] BaseTools: remove duplicate includes: /ProcessorBind.h

Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann --- .../Source/C/Include/AArch64/ProcessorBind.h | 148 -- .../Source/C/Include/Arm/ProcessorBind.h | 147 -- .../Source/C/Include/Ia32/ProcessorBind.h | 155

[edk2-devel] [PATCH 5/8] BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks

The #define for IMAGE_FILE_MACHINE_ARM is not present in MdePkg, this looks like a relic not used any more. Remove. Signed-off-by: Gerd Hoffmann --- BaseTools/Source/C/Common/BasePeCoff.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/BaseTools/Sour

[edk2-devel] [PATCH 3/8] BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h

Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann --- .../Source/C/Include/IndustryStandard/Acpi.h | 117 --- .../C/Include/IndustryStandard/Acpi1_0.h | 285 .../C/Include/IndustryStandard/Acpi2_0.h | 520 -- .../C/Inc

[edk2-devel] [PATCH 4/8] MdePkg/PeImage.h: add bits from BaseTools version

The BaseTools and MdePkg versions of PeImage.h diverged over time, add some missing bits to the MdePkg header file in preparation for removing the BaseTools version. Signed-off-by: Gerd Hoffmann --- MdePkg/Include/IndustryStandard/PeImage.h | 31 +++ 1 file changed, 31 insert

[edk2-devel] [PATCH 8/8] BaseTools: remove duplicate includes: IndustryStandard/*.h

Use the MdePkg versions instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann --- BaseTools/Source/C/EfiRom/EfiRom.h| 4 +- .../C/Include/IndustryStandard/Bluetooth.h| 56 -- .../C/Include/IndustryStandard/EfiPci.h | 51 -- ...emoryMappedConfiguration

[edk2-devel] [PATCH 6/8] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_*

Use the newer versions of the machine #defines. Signed-off-by: Gerd Hoffmann --- BaseTools/Source/C/EfiRom/EfiRom.h| 10 ++--- .../C/Include/IndustryStandard/PeImage.h | 1 + BaseTools/Source/C/Common/BasePeCoff.c| 28 ++--- BaseTools/Source/C/GenFv/GenFvInterna

[edk2-devel] [PATCH 7/8] BaseTools: remove duplicate includes: IndustryStandard/PeImage.h

Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann --- .../C/Include/IndustryStandard/PeImage.h | 779 -- 1 file changed, 779 deletions(-) delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/PeImage.h diff --git a/Bas

Re: [edk2-devel] [PATCH v3 1/3] Platform/AMD: Adds MinBoardPkg to support MinPlatformPkg

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Thursday, March 23, 2023 2:14 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard > Biesheuvel ; Leif Lindholm > ; Chang, Abner ; > Michael D Kinney

Re: [edk2-devel] [PATCH v3 3/3] Maintainers.txt: Adds AMD/MinBoardPkg maintainers

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Thursday, March 23, 2023 2:14 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Attar, > AbdulLateef (Abdul Lateef) ; Ard Biesheuvel > ; Leif Lindholm

Re: [edk2-devel] [Patch V4 02/21] UefiCpuPkg/CpuPageTableLib: Add check for input Length

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 02/21] UefiCpuPkg/CpuPageTableLib: Add check for input > Length > > Add check

Re: [edk2-devel] [PATCH v3 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library

[AMD Official Use Only - General] Hi Abdul, one comment below, > -Original Message- > From: Abdul Lateef Attar > Sent: Thursday, March 23, 2023 2:14 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard > Biesheuvel ; Leif Lindholm > ; Chang, Abner ; > Michael D Kin

Re: [edk2-devel] [Patch V4 03/21] UefiCpuPkg/CpuPageTableLib:Initialize some LocalVariable at beginning

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 03/21] UefiCpuPkg/CpuPageTableLib:Initialize some > LocalVariable at beginning

Re: [edk2-devel] [Patch V4 04/21] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

> + PhysicalAddrInEntry = > IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS (&PleBAttribute) + > PagingEntryIndex * RegionLength; Overall logic looks good to me. But above code might fail to build in IA32 build due to UINT32 * UINT64. > + PhysicalAddrInAttr = > (IA32_MAP_ATTRIBUTE_PAGE_TABL

Re: [edk2-devel] [Patch V4 05/21] UefiCpuPkg/CpuPageTableLib:Clear PageSize bit(Bit7) for non-leaf

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 05/21] UefiCpuPkg/CpuPageTableLib:Clear PageSize > bit(Bit7) for non-leaf > >

Re: [edk2-devel] [Patch V4 06/21] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry

> + ParentPagingEntry->Uint64 = ((UINTN)(VOID *)PagingEntry) | > (ParentPagingEntry->Uint64 & (~IA32_PE_BASE_ADDRESS_MASK_40)); In this branch, ParentPagingEntry is a leaf entry covering 2M or 1G physical address range. Then, why not use IA32_PE_BASE_ADDRESS_MASK_39? Because for the two type

Re: [edk2-devel] [Patch V4 07/21] UefiCpuPkg/MpInitLib: Add code to initialize MapMask

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 07/21] UefiCpuPkg/MpInitLib: Add code to initialize > MapMask > > In function

Re: [edk2-devel] [Patch V4 08/21] UefiCpuPkg/CpuPageTableLib:Add check for Mask and Attr

The commit message is very detailed. But the function header comments are not. Can you please update the function header comments to add 4 lines of @retval RETURN_INVALID_PARAMETER, each line describes one invalid case. It's ok to have multiple lines starting with @retval RETURN_INVALID_PARAMETER

Re: [edk2-devel] [Patch V4 09/21] UefiCpuPkg/CpuPageTableLib: Add manual test to check Mask and Attr

> + PageTableBufferSize = 0; > + PageTable = 0; > + Buffer= NULL; > + MapAttribute.Uint64 = 0; > + MapAttribute.Bits.Present = 1; > + MapMask.Uint64= 0; > + MapMask.Bits.Present = 1; > + // > + // Create Page table to cover [

Re: [edk2-devel] [Patch V4 10/21] UefiCpuPkg/CpuPageTableLib:Modify RandomBoolean() in RandomTest

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 10/21] UefiCpuPkg/CpuPageTableLib:Modify > RandomBoolean() in RandomTest > >

Re: [edk2-devel] [PATCH 3/9] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38

On Thu, 23 Mar 2023 at 10:04, Ard Biesheuvel wrote: > > On Thu, 23 Mar 2023 at 02:30, Rebecca Cran wrote: > > > > On 3/22/23 5:49 AM, Ard Biesheuvel wrote: > > > > > > > > The reason I added CLANG3x support for ARM in the past is to ensure > > > compatibility with the ARM proprietary, Clang based

Re: [edk2-devel] [Patch V4 11/21] UefiCpuPkg/CpuPageTableLib:Modify RandomTest to check Mask/Attr

> -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Liu, Zhiguang > Subject: [Patch V4 11/21] UefiCpuPkg/CpuPageTableLib:Modify RandomTest > to check Mask/Attr > > M

Re: [edk2-devel] [PATCH 2/8] BaseTools: remove duplicate includes: /ProcessorBind.h

Reviewed-by: Chao Li Thanks, Chao 在 2023/3/23 19:17, Gerd Hoffmann 写道: Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann --- .../Source/C/Include/AArch64/ProcessorBind.h | 148 -- .../Source/C/Include/Arm/ProcessorBind.h | 147

Re: [edk2-devel] [PATCH 6/8] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_*

Reviewed-by: Chao Li Thanks, Chao 在 2023/3/23 19:17, Gerd Hoffmann 写道: Use the newer versions of the machine #defines. Signed-off-by: Gerd Hoffmann --- BaseTools/Source/C/EfiRom/EfiRom.h| 10 ++--- .../C/Include/IndustryStandard/PeImage.h | 1 + BaseTools/Source/C/Common

Re: [edk2-devel] [Patch V4 13/21] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter.

> @@ -290,7 +291,8 @@ PageTableLibMapInLevel ( >IN UINT64 Length, >IN UINT64 Offset, >IN IA32_MAP_ATTRIBUTE *Attribute, > - IN IA32_MAP_ATTRIBUTE *Mask > + IN IA32_MAP_ATTRIBUTE *Mask, > + OUTBOOLEAN *IsModified >)

Re: [edk2-devel] [Patch V4 14/21] UefiCpuPkg/CpuPageTableLib: Modify RandomTest to check IsModified

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Liu, Zhiguang > Subject: [Patch V4 14/21] UefiCpuPkg/CpuPageTableLib: Modify RandomTest > to ch

Re: [edk2-devel] [Patch V4 15/21] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > > Subject: [Patch V4 15/21] UefiCpuPkg: Fix IA32 build failure in > CpuPageTableLib.inf > > From

Re: [edk2-devel] [PATCH 7/8] BaseTools: remove duplicate includes: IndustryStandard/PeImage.h

Reviewed-by: Chao Li Thanks, Chao 在 2023/3/23 19:17, Gerd Hoffmann 写道: Use the MdePkg version instead of maintaining a copy in BaseTools. Signed-off-by: Gerd Hoffmann --- .../C/Include/IndustryStandard/PeImage.h | 779 -- 1 file changed, 779 deletions(-) delete mode

[edk2-devel] [PATCH 1/1] OvmfPkg: replace SECURE_BOOT_FEATURE_ENABLED with PcdSecureBootSupported

Drop the '-D SECURE_BOOT_FEATURE_ENABLED' compile time option, use a new FeaturePcd instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfPkg.dec | 3 +++ OvmfPkg/CloudHv/CloudHvX64.dsc | 10 +- OvmfPkg/IntelTdx/IntelTdxX64.dsc

Re: [edk2-devel] [Patch V4 20/21] UefiCpuPkg/CpuPageTableLib: Add RandomTest for PAE paging

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 20/21] UefiCpuPkg/CpuPageTableLib: Add RandomTest > for PAE paging > > Add Ra

Re: [edk2-devel] [Patch V4 17/21] UefiCpuPkg/CpuPageTableLib: Add check for page table creation

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 17/21] UefiCpuPkg/CpuPageTableLib: Add check for page > table creation > > Ad

Re: [edk2-devel] [Patch V4 18/21] UefiCpuPkg: Combine branch for non-present and leaf ParentEntry

> -// > -// The parent entry is CR3 or PML5E/PML4E/PDPTE/PDE. > +// When ParentPagingEntry is non-present, parent entry is CR3 or > PML5E/PML4E/PDPTE/PDE. > // It does NOT point to an existing page directory. > +// When ParentPagingEntry is present, parent entry is leaf PDPTE_1

Re: [edk2-devel] [Patch V4 19/21] UefiCpuPkg/CpuPageTableLib: Enable PAE paging

Overall logics look good to me. 2 minor comments. > -#define IA32_PE_BASE_ADDRESS_MASK_40 0xFF000ull > -#define IA32_PE_BASE_ADDRESS_MASK_39 0xFE000ull > +#define IA32_PE_BASE_ADDRESS_MASK_40 0xFF000ull > +#define IA32_PE_BASE_ADDRESS_MASK_39 0xFE0

Re: [edk2-devel] [Patch V4 21/21] UefiCpuPkg/CpuPageTableLib: Reduce the number of random tests

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 21/21] UefiCpuPkg/CpuPageTableLib: Reduce the number > of random tests > > Re

[edk2-devel] [PATCH v3] MdePkg/Include: Add IPMI KCS definitions

From: Abner Chang BZ #4354 This change adds definitions for IPMI KCS. Spec ref: https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang C

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

The linker problems I was seeing were unrelated to those Patrick's patch fixed. I just applied Patrick's changes on top of my CLANGDWARF patches and OvmfPkgIa32.dsc builds fine. -- Rebecca Cran On 3/17/23 2:35 PM, Rebecca Cran wrote: Building with "build -p OvmfPkg/OvmfPkgX64.dsc -a X64 -

Re: [edk2-devel] [PATCH v4 9/9] edk2-platforms: Maintainers.txt

On Wed, Mar 22, 2023 at 10:48:40 +0800, abner.ch...@amd.com wrote: > From: Abner Chang > > Add maintainer and reviewer of ManageabilityPkg. > > Signed-off-by: Abner Chang > Cc: Abdul Lateef Attar > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Isaac Oram > Cc: Nickle Wang

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

Added the right reviewers @Gao, Liming @Feng, Bob C @yuwei.c...@intel.com -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101695): https://edk2.groups.io/g/devel/message/101695 Mute This Topic: https://groups.io/mt/97673648/21656 Group

[edk2-devel] [PATCH v3] MdePkg/Include: Add DMTF MCTP definitions

From: Abner Chang BZ #4355 This change adds definitions for DMTF MCTP base specification. Spec ref: https://www.dmtf.org/sites/default/files/standards/documents/DSP0236_1.3.1.pdf Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang Cc: Igor Kulchy

Re: [edk2-devel] [edk2-staging/OpenSSL11_EOL][PATCH 0/4] Openssl 3.0 POC update Mar 22

Hi Jiewen, What is your assessment of the progress on Openssl 3.0 from a size perspective. What is the goal and how close are we now? Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Li, Yi > Sent: Wednesday, March 22, 2023 7:45 PM > To: devel@edk2.groups.io

Re: [edk2-devel] [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

Seems like a code formatting issue. I will address it tomorrow. Regards, Mateusz -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101698): https://edk2.groups.io/g/devel/message/101698 Mute This Topic: https://groups.io/mt/97764094/21656 G

Re: [edk2-devel] [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

Hi, This patch seems to resolve the issue reported in 4011 - MdeModulePkg: Need configurable AHCI command retries (tianocore.org) and verified with 'AHCI_COMMAND_RETRIES' as 5. Able to unlock the drive with correct password on 2nd attempt aft

Re: [edk2-devel] [PATCH 2/3] BaseTools: Replace duplicate __PcdSet prototype with __PcdGet

Hi Liming, Could you review this patch please? I've dropped the 3rd patch which was running Uncrustify over the code, so this is the only one left before I can merge the series. Thanks. Rebecca Cran On 2/24/23 5:54 PM, Rebecca Cran wrote: Replace the duplicate __PcdSet prototype in PcdV

Re: [edk2-devel] [PATCH v3] MdePkg/Include: Add IPMI KCS definitions

Acked-by: Isaac Oram -Original Message- From: abner.ch...@amd.com Sent: Thursday, March 23, 2023 6:58 AM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Nickle Wang ; Igor Kulchytskyy ; Oram, Isaac W ; Abdul Lateef Attar Subject: [PATCH v3] MdePkg/Incl

Re: [edk2-devel] [PATCH v4 9/9] edk2-platforms: Maintainers.txt

Reviewed-by: Isaac Oram -Original Message- From: Leif Lindholm Sent: Thursday, March 23, 2023 7:46 AM To: abner.ch...@amd.com Cc: devel@edk2.groups.io; Abdul Lateef Attar ; Kinney, Michael D ; Gao, Liming ; Oram, Isaac W ; Nickle Wang Subject: Re: [PATCH v4 9/9] edk2-platforms: Maint

Re: [edk2-devel] [PATCH v3] MdePkg/Include: Add IPMI KCS definitions

Hi Abner, On 3/23/2023 8:57 PM, Chang, Abner via groups.io wrote: From: Abner Chang BZ #4354 This change adds definitions for IPMI KCS. Spec ref: https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html Signed-off-by: Abner Chang Cc: M

Re: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package

Reviewed-by: Isaac Oram edk2 convention has changed to naming DSC include files *.dsc.inc. I plan to update all the features sometime in the future. Manageability.dsc: I think that the "[LibraryClasses.ARM, LibraryClasses.AARCH64]" section contents should be moved to the ManageabilityPkg.dsc

Re: [edk2-devel] [PATCH v4 5/9] ManageabilityPkg: Add ManageabilityTransportHelperLib

Hi Abner, On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote: From: Abner Chang The helper functions library facilitates reducing duplicated code in the manageability transport library instances. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wan

Re: [edk2-devel] [Patch 0/2] Add and use FirmwareVolumeShadowPpi

Series Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Tuesday, March 21, 2023 7:06 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Gao, Liming ; Patel, Umang > > Subject: [edk2-devel] [Patch 0/

Re: [edk2-devel] [PATCH v4 7/9] ManageabilityPkg: Implement Ipmi Protocol/Ppi

Hi Abner, On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote: From: Abner Chang Add Ipmi Protocol/Ppi/SMM implementations. The underlying implementation of transport interface depends on the binded ManageabilityTransportLib. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc:

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

Hi Pawel, Any updates on this task? I would like to see this go in soon so it can get some flight time before next stable tag. Mike > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, March 7, 2023 2:25 PM > To: Paweł Poławski ; devel@edk2.groups.io > Cc: Gao, Liming ; Liu

Re: [edk2-devel] [PATCH v3] MdePkg/Include: Add IPMI KCS definitions

> -Original Message- > From: abner.ch...@amd.com > Sent: Thursday, March 23, 2023 6:58 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Nickle Wang ; Igor Kulchytskyy ; Oram, > Isaac W ; Abdul Lateef Attar > > Subject: [PATCH v3] MdePkg/Include

Re: [edk2-devel] [PATCH v3] MdePkg/Include: Add DMTF MCTP definitions

> -Original Message- > From: abner.ch...@amd.com > Sent: Thursday, March 23, 2023 8:05 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Nickle Wang ; Igor Kulchytskyy ; Oram, > Isaac W ; Abdul Lateef Attar > > Subject: [PATCH v3] MdePkg/Include

Re: [edk2-devel] [PATCH V5 4/8] OvmfPkg/PlatformPei: Update ReserveEmuVariableNvStore

Hi, joeyli Please see my comments in https://bugzilla.tianocore.org/show_bug.cgi?id=4379 I need your help to catch some logs in AMD SEV environment for this problem. Thanks Min > -Original Message- > From: joeyli > Sent: Tuesday, March 21, 2023 5:32 PM > To: devel@edk2.groups.io; Xu, Min

Re: [edk2-devel] [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

Thanks Baranee. We will proceed to merge the this patch after reviewing process. For the PCD (PcdAhciCommandRetryCount) previously introduced to address the password retry issue, what is your opinion on it? Do you think we can remove it or keep it for other reason? Thanks. Best Regards, Hao Wu

[edk2-devel] [PATCH] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAlignment.

Nothing to do here for virtio 1.0 devices Signed-off-by: Jeff Brasen --- .../Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c b/OvmfPkg/Library/VirtioM

Re: [edk2-devel] [edk2-staging/OpenSSL11_EOL][PATCH 4/4] Readme: 0322 update

Hi Gerd, Thanks for review, >> +### Level 2: A bit like workaround, with possibility of upstream to >> +openssl 1. Enable the legacy path for X509 pubkey decode and pmeth >> +initialization, The purpose is to avoid the use of EN/DECODE and Signature >> provider, will reduce size about 90KB. >>

Re: [edk2-devel] [Patch V4 08/21] UefiCpuPkg/CpuPageTableLib:Add check for Mask and Attr

Thanks for the comments Ray. I will update the patches in next version patch set. -Why break out of the loop when meeting a non-present entry? Because I think the parameter check is only needed once. Thanks, Dun -Original Message- From: Ni, Ray Sent: Thursday, March 23, 2023 8:53

Re: [edk2-devel] [Patch V4 06/21] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry

Non-leaf entry doesn't have PAT bit. So "& (~IA32_PE_BASE_ADDRESS_MASK_40)" is to make sure PAT bit in the original big-leaf entry is not assigned to the corresponding bit (bit 12) in non-leaf entry. Can you please add comments to explain why? With that, Reviewed-by: Ray Ni > -Original Mes

[edk2-devel] [PATCH v4] MdePkg/Include: Add DMTF MCTP definitions

From: Abner Chang BZ #4355 This change adds definitions for DMTF MCTP base specification. Spec ref: https://www.dmtf.org/sites/default/files/standards/documents/DSP0236_1.3.1.pdf Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang Cc: Igor Kulchy

Re: [edk2-devel] [PATCH v3] MdePkg/Include: Add DMTF MCTP definitions

[AMD Official Use Only - General] Hi Mike, MCTP v4 was just sent. Thanks Abner > -Original Message- > From: Kinney, Michael D > Sent: Friday, March 24, 2023 6:24 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Nickle Wang ; Igor > Kulchytskyy ; Oram, Is

[edk2-devel] [PATCH v4] MdePkg/Include: Add IPMI KCS definitions

From: Abner Chang BZ #4354 This change adds definitions for IPMI KCS. Spec ref: https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang C

Re: [edk2-devel] [PATCH v4] MdePkg/Include: Add IPMI KCS definitions

On 24/03/2023 10:15, Chang, Abner via groups.io wrote: From: Abner Chang BZ #4354 This change adds definitions for IPMI KCS. Spec ref: https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html Signed-off-by: Abner Chang Cc: Michael D K

[edk2-devel] reg: MAC address could not change on pre-boot environment and failed to PXE boot.

Hello : We are writing a application to program the MAC from UEFI shell and with the updated MAC address trying to do the PXE Boot which failed. The application uses the Simple Network Protocols StationAddress() to update the MAC. After update the Current Address in the Mode of SimpleNetwork I

[edk2-devel] 回复: [PATCH 2/3] BaseTools: Replace duplicate __PcdSet prototype with __PcdGet

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Rebecca Cran > 发送时间: 2023年2月25日 8:55 > 收件人: devel@edk2.groups.io; Bob Feng ; Liming > Gao ; Yuwei Chen > 抄送: Rebecca Cran > 主题: [PATCH 2/3] BaseTools: Replace duplicate __PcdSet prototype with > __PcdGet > > Replace the duplicate __PcdSet protot

回复: [edk2-devel] [PATCH 0/3] BaseTools: allow users to override CC and CXX on the make command line

Rebecca: I create PR https://github.com/tianocore/edk2/pull/4162 . But PR shows some failure. Can you help fix them? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming via > groups.io > 发送时间: 2023年3月23日 9:10 > 收件人: devel@edk2.groups.io; rebe...@bsdio.com; 'Andrew Fish' > ;

[edk2-devel] [Patch V5 00/22] Fix issues in CpuPageTableLib

In the V5 atch set: 1. In 'Fix the non-1:1 mapping issue' patch, add (UINT64) for PagingEntryIndex to avoid IA32 build failure 2. In 'Fix issue when splitting leaf entry', still use IA32_PE_BASE_ADDRESS_MASK_40 but add some comments to explain why. 3. In 'Add check for Mask and Attr', lines of @r

[edk2-devel] [Patch V5 01/22] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition

Remove unneeded 'if' condition in CpuPageTableLib code. The deleted code is in the code branch for present non-leaf parent entry. So the 'if' check for (ParentPagingEntry->Pnle.Bits.Present == 0) is always FALSE. Signed-off-by: Dun Tan Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar Tested-b

[edk2-devel] [Patch V5 03/22] UefiCpuPkg/CpuPageTableLib:Initialize some LocalVariable at beginning

Move some local variable initialization to the beginning of the function. Also delete duplicated calculation for RegionLength. Signed-off-by: Dun Tan Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar Tested-by: Gerd Hoffmann Acked-by: Gerd Hoffmann --- UefiCpuPkg/Library/CpuPageTableLib/Cpu

[edk2-devel] [Patch V5 04/22] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

In previous code logic, when splitting a leaf parent entry to smaller granularity child page table, if the parent entry Attribute&Mask(without PageTableBaseAddress field) is equal to the input attribute&mask(without PageTableBaseAddress field), the split process won't happen. This may lead to failu

  1   2   >