Thanks Baranee. We will proceed to merge the this patch after reviewing process.
For the PCD (PcdAhciCommandRetryCount) previously introduced to address the password retry issue, what is your opinion on it? Do you think we can remove it or keep it for other reason? Thanks. Best Regards, Hao Wu From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Anbazhagan, Baraneedharan via groups.io Sent: Friday, March 24, 2023 12:55 AM To: devel@edk2.groups.io; Wu, Hao A <hao.a...@intel.com>; Albecki, Mateusz <mateusz.albe...@intel.com> Cc: Ni, Ray <ray...@intel.com>; Chang, Hunter <hunter.ch...@intel.com> Subject: Re: [edk2-devel] [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors Hi, This patch seems to resolve the issue reported in 4011 - MdeModulePkg: Need configurable AHCI command retries (tianocore.org)<https://bugzilla.tianocore.org/show_bug.cgi?id=4011> and verified with 'AHCI_COMMAND_RETRIES' as 5. Able to unlock the drive with correct password on 2nd attempt after providing an incorrect password. Thanks, Baranee From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Wu, Hao A via groups.io Sent: Wednesday, March 22, 2023 1:59 AM To: Albecki, Mateusz <mateusz.albe...@intel.com<mailto:mateusz.albe...@intel.com>>; Anbazhagan, Baraneedharan <anbazha...@hp.com<mailto:anbazha...@hp.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Ni, Ray <ray...@intel.com<mailto:ray...@intel.com>>; Chang, Hunter <hunter.ch...@intel.com<mailto:hunter.ch...@intel.com>> Subject: Re: [edk2-devel] [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors CAUTION: External Email Thanks Mateusz, the patch looks good to me. I noticed that there are some check failures in https://github.com/tianocore/edk2/pull/4157, could you help to address them? Hello Baraneedharan Anbazhagan, Could you help to check if this patch can resolve the issue https://bugzilla.tianocore.org/show_bug.cgi?id=4011 when switching back to: "#define AHCI_COMMAND_RETRIES 5"? This change can be accessed for integration at: https://patch-diff.githubusercontent.com/raw/tianocore/edk2/pull/4157.patch Thanks in advance. Best Regards, Hao Wu > -----Original Message----- > From: Albecki, Mateusz > <mateusz.albe...@intel.com<mailto:mateusz.albe...@intel.com>> > Sent: Wednesday, March 22, 2023 4:20 AM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Albecki, Mateusz > <mateusz.albe...@intel.com<mailto:mateusz.albe...@intel.com>>; Wu, Hao A > <hao.a...@intel.com<mailto:hao.a...@intel.com>>; Ni, Ray > <ray...@intel.com<mailto:ray...@intel.com>>; Chang, Hunter > <hunter.ch...@intel.com<mailto:hunter.ch...@intel.com>> > Subject: [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors > > Fix for the recovery logic which causes hdd unlock to fail if user supplies > incorrect password. Every failed packet used to be recovered which is causing > the incorrect password to be tried multiple times. This patch series fixes the > logic to only retry commands that failed due to CRC error. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4011 > > Github pull: https://github.com/tianocore/edk2/pull/4157 > > Tests: > - tested basic linux boot from AHCI on qemu > - tested basic linux boot from AHCI on custom qemu which will fail 50% of the > DMA commands with CRC error. > Observed that all of the packets that failed were successfully retried. Custom > Qemu: https://github.com/matalbec/qemu/tree/sata_dma_50p_fail > - additionally Hunter Chang tested and confirmed that the password issue is no > longer observed. > > Cc: Hao A Wu <hao.a...@intel.com<mailto:hao.a...@intel.com>> > Cc: Ray Ni <ray...@intel.com<mailto:ray...@intel.com>> > Cc: Hunter Chang <hunter.ch...@intel.com<mailto:hunter.ch...@intel.com>> > > Mateusz Albecki (1): > MdeModulePkg/Ahci: Skip retry for non-transient errors > > .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 69 +++++++++++++++++-- > .../Bus/Ata/AtaAtapiPassThru/AhciMode.h | 3 +- > 2 files changed, 67 insertions(+), 5 deletions(-) > > -- > 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101713): https://edk2.groups.io/g/devel/message/101713 Mute This Topic: https://groups.io/mt/97764094/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
