Reviewed-by: Isaac Oram <isaac.w.o...@intel.com>
edk2 convention has changed to naming DSC include files *.dsc.inc. I plan to
update all the features sometime in the future.
Manageability.dsc:
I think that the "[LibraryClasses.ARM, LibraryClasses.AARCH64]" section
contents should be moved to the ManageabilityPkg.dsc for package specific build
settings. These seem like ARM libraries not directly related to manageability
features and we don't really want Manageability.dsc to override any board
porting choices already made by the board. And I think that we want these
includable feature DSC to be scoped to the feature only as much as we can.
Regards,
Isaac
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner via
groups.io
Sent: Tuesday, March 21, 2023 7:49 PM
To: devel@edk2.groups.io
Cc: Gao, Liming <gaolim...@byosoft.com.cn>; Oram, Isaac W
<isaac.w.o...@intel.com>; Desimone, Nathaniel L
<nathaniel.l.desim...@intel.com>; Abdul Lateef Attar <abdat...@amd.com>; Nickle
Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com>; Abdul Lateef Attar
<abdullateef.at...@amd.com>
Subject: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package
From: Abner Chang <abner.ch...@amd.com>
Initial commit of ManageabilityPkg
Signed-off-by: Abner Chang <abner.ch...@amd.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Isaac Oram <isaac.w.o...@intel.com>
Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
Cc: Abdul Lateef Attar <abdat...@amd.com>
Cc: Nickle Wang <nick...@nvidia.com>
Cc: Igor Kulchytskyy <ig...@ami.com>
Reviewed-by: Abdul Lateef Attar <abdullateef.at...@amd.com>
Reviewed-by: Nickle Wang <nick...@nvidia.com>
---
.../ManageabilityPkg/ManageabilityPkg.dec | 21 ++++++++++
.../Include/Dsc/Manageability.dsc | 16 ++++++++
.../ManageabilityPkg/ManageabilityPkg.dsc | 39 +++++++++++++++++++
3 files changed, 76 insertions(+)
create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dec
create mode 100644 Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dsc
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
b/Features/ManageabilityPkg/ManageabilityPkg.dec
new file mode 100644
index 0000000000..71bd8a0c80
--- /dev/null
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -0,0 +1,21 @@
+## @file
+# Manageabilty Package
+# This is the package provides the edk2 drivers and libraries # those
+are related to the platform management.
+#
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
+reserved.<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[Defines]
+ DEC_SPECIFICATION = 0x0001001d
+ PACKAGE_NAME = ManageabilityPkg
+ PACKAGE_GUID = 36310119-4FB2-4BA3-959D-74C16B849F9E
+ PACKAGE_VERSION = 1.0
+
+[Includes]
+ Include
+
+[Guids]
+ gManageabilityPkgTokenSpaceGuid = { 0xBDEFFF48, 0x1C31, 0x49CD, {
+0xA7, 0x6D, 0x92, 0x9E, 0x60, 0xDB, 0xB9, 0xF8 } }
diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
new file mode 100644
index 0000000000..2cb63c1ca6
--- /dev/null
+++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
@@ -0,0 +1,16 @@
+## @file
+# Common libraries for Manageabilty Package # # Copyright (C) 2023
+Advanced Micro Devices, Inc. All rights reserved.<BR> #
+SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[LibraryClasses.ARM, LibraryClasses.AARCH64]
+ #
+ # This library provides the instrinsic functions generated by a given
compiler.
+ #
+ NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
+ NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
+ ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
+
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc
b/Features/ManageabilityPkg/ManageabilityPkg.dsc
new file mode 100644
index 0000000000..b3586afa07
--- /dev/null
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc
@@ -0,0 +1,39 @@
+## @file
+# Manageabilty Package
+# This is the package provides edk2 drivers and libraries # those are
+related to the platform management.
+#
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
+reserved.<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent # ##
+
+[Defines]
+ PLATFORM_NAME = ManageabilityPkg
+ PLATFORM_GUID = 7A98123A-B194-40B6-A863-A52192F6D65D
+ PLATFORM_VERSION = 1.0
+ DSC_SPECIFICATION = 0x0001001e
+ OUTPUT_DIRECTORY = Build/ManageabilityPkg
+ SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
+ BUILD_TARGETS = DEBUG|RELEASE|NOOPT
+ SKUID_IDENTIFIER = DEFAULT
+
+[Packages]
+ MinPlatformPkg/MinPlatformPkg.dec
+
+[PcdsFeatureFlag]
+ #
+ # MinPlatform common include currently required PCD
+ #
+ gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable
|FALSE
+ gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable
|FALSE
+
+#
+# Include common libraries
+#
+!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
+!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
+
+!include Include/Dsc/Manageability.dsc
+
--
2.37.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101705): https://edk2.groups.io/g/devel/message/101705
Mute This Topic: https://groups.io/mt/97770708/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
