[edk2-devel] [edk2-platforms][PATCH V3 03/16] Platform/Loongson: Add PeiServicesTablePointerLib.

Use a register to save PeiServicesTable pointer, This lib Provides PeiServicesTable pointer saving and retrieval services. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../PeiServicesTablePointer.c | 78 +++ .../PeiServi

[edk2-devel] [edk2-platforms][PATCH V3 00/16] Platform: Add Loongson support.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 The uploaded code generates firmware to support Linux launching on the LoongArch platform under qemu, So it will run in a virtual machine. LoongArch is the general processor architecture of Loongson. You can get the latest LoongArch docume

[edk2-devel] [edk2-platforms][PATCH V3 02/16] Platform/Loongson: Support SEC And Add Readme.md

Add SEC Code And Readme.md for LoongArchQemu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li Signed-off-by: xianglai li --- Maintainers.txt | 4 + .../Include/LoongArchAsmMacro.h | 23 + .../Loongson/LoongArchQ

[edk2-devel] [edk2-platforms][PATCH V3 04/16] Platform/Loongson: Add QemuFwCfgLib.

QemuFwCfgLib for PEI phase. This library obtains the QemuFWCfg base address by directly parsing the fdt, and reads and writes the data in the QemuFWCfg by operating on the QemuFWCfg base address. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Include

[edk2-devel] [edk2-platforms][PATCH V3 06/16] Platform/Loongson: Add StableTimerLib.

This library provides a delay interface and a timing interface. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Include/Library/StableTimer.h | 43 .../Library/StableTimerLib/Count.S| 35 +++ .../Library/StableTimerLib/T

[edk2-devel] [edk2-platforms][PATCH V3 01/16] Platform/Loongson: Add Serial Port library

Serial Port library for LoongarchQemuPkg REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Include/Library/Cpu.h| 387 +++ .../Include/LoongArchQemuPlatform.h | 97 +++ .../Library/SerialPortLib/SerialPortLib.c

[edk2-devel] [edk2-platforms][PATCH V3 07/16] Platform/Loongson: Support PEI phase.

Platform PEI module for LoongArch platform initialization. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Loongson/LoongArchQemuPkg/Loongson.dec| 22 ++ .../Loongson/LoongArchQemuPkg/Loongson.dsc| 65 - .../Loongson/LoongArchQemuPkg/Loo

[edk2-devel] [edk2-platforms][PATCH V3 05/16] Platform/Loongson: Add MmuLib.

Read the memory map information through the QemuFwCfg interface, then build the page table through the memory map information, and finally enable Mmu. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Include/Library/MmuLib.h | 85 ++

[edk2-devel] [edk2-platforms][PATCH V3 09/16] Platform/Loongson: Add PciCpuIoDxe driver.

Add PCI CpuIo protocol.there is no fix translation offset between I/O port accesses and MMIO accesses. Add PciCpuIo2Dxe driver to implement EFI_CPU_IO2_PROTOCOL to add the translation for IO access. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Driv

[edk2-devel] [edk2-platforms][PATCH V3 08/16] Platform/Loongson: Add CPU DXE driver.

The driver produces EFI_CPU_ARCH_PROTOCOL, Initialize the exception entry address. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Drivers/CpuDxe/CpuDxe.c | 382 ++ .../LoongArchQemuPkg/Drivers/CpuDxe/CpuDxe.h | 151

[edk2-devel] [edk2-platforms][PATCH V3 10/16] Platform/Loongson: Add timer Dxe driver.

This driver produces Timer Architectural Protocol, Registers a timer interrupt and initializes the timer. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Drivers/StableTimerDxe/Timer.c| 405 ++ .../Drivers/StableTimerDxe/Ti

[edk2-devel] [edk2-platforms][PATCH V3 11/16] Platform/Loongson: Add RealTime Clock lib.

This library provides interfaces such as real-time clock initialization to get time and setting time. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../LsRealTimeClockLib/LsRealTimeClock.h | 41 +++ .../LsRealTimeClockLib/LsRealTimeClockLib.c |

[edk2-devel] [edk2-platforms][PATCH V3 12/16] Platform/Loongson: Add Platform Boot Manager Lib.

The Library provides Boot Manager interfaces. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../PlatformBootManagerLib/PlatformBm.c | 760 ++ .../PlatformBootManagerLib/PlatformBm.h | 112 +++ .../PlatformBootManagerLib.inf

[edk2-devel] [edk2-platforms][PATCH V3 13/16] Platform/Loongson: Add Reset System Lib.

This library provides interfaces related to restart and shutdown. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../BaseResetSystemAcpiGed.c | 155 ++ .../BaseResetSystemAcpiGedLib.inf | 42 +++ .../DxeResetSystemAc

[edk2-devel] [edk2-platforms][PATCH V3 16/16] Platform/Loongson: Support for saving variables to flash.

Added the function of saving non-volatile variables. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/Loongson.dec| 6 ++ Platform/Loongson/LoongArchQemuPkg/Loongson.dsc| 2 +- Platform/Loongson/LoongArchQem

[edk2-devel] [edk2-platforms][PATCH V3 14/16] Platform/Loongson: Support Dxe

Support Dxe for LoogArch. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Loongson/LoongArchQemuPkg/Loongson.dec| 14 +- .../Loongson/LoongArchQemuPkg/Loongson.dsc| 420 +- .../Loongson/LoongArchQemuPkg/Loongson.fdf| 243 +

[edk2-devel] [edk2-platforms][PATCH V3 15/16] Platform/Loongson: Add QemuFlashFvbServicesRuntimeDxe driver.

This library provides flash read and write functionality and supports writing variables to flash. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../QemuFlashFvbServicesRuntimeDxe/FvbInfo.c | 115 ++ .../FvbServicesRuntimeDxe.inf | 73

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

Abner, Comments in https://github.com/tianocore-docs/edk2-CCodingStandardsSpecification/pull/2#pullrequestreview-1124763311 We can discuss more in tomorrow's meeting. > -Original Message- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: Thursday, September 29, 2022 3:11 PM > To: Chang

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

Sunil, I don't have concern with your changes. Perhaps you can also move all existing source files to X86 folder. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunil V L > Sent: Wednesday, September 28, 2022 3:34 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: abner.ch...@a

Re: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Enable ADM when change TTM

Hi Ray, Could you help to review the merge the patch to the VTd driver in edkplatform branch ? This patch is used to enable Abort DMA Mode(ADM) when change the TTM . The comment from VTd spec is below. For implementations reporting Enhanced SRTP Support (ESRTPS) field as Clear in the Capability

[edk2-devel] [PATCH] MdeModulePkg: Handle InitialVFs=0 case for SR-IOV

From: Foster Nong Per SR-IOV spec,InitialVFs minimum is 0. Below code which use to calculate SR-IOV bus number, if InitialVFs =0, it maybe calculate the wrong bus number. LastVF = PFRid + FirstVFOffset + (PciIoDevice->InitialVFs - 1) * VFStride we can fix it with below code: if (PciIoDevice->I

Re: [edk2-devel] [PATCH] MdeModulePkg: Handle InitialVFs=0 case for SR-IOV

Foster, Can you please include the SRIOV spec content in comments? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bob > Feng > Sent: Thursday, September 29, 2022 4:50 PM > To: devel@edk2.groups.io > Cc: Nong, Foster > Subject: [edk2-devel] [PATCH] MdeModulePkg: Handle Ini

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization to allow bigger stack

Hi Abner, Thanks for the comments. I'll add comments on this code change to explain it in V2 patch. Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of Chang, Abner via groups.io Sent: Thursday, September 29, 2022 9:05 AM To: devel@edk2.groups.io; Tan, Dun Cc: Dong,

[edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization to allow bigger stack

This commit is a code optimization to allow bigger seperate stack size in ArchSetupExceptionStack. In previous code logic, CPU_STACK_ALIGNMENT bytes will be wasted if StackTop is already CPU_STACK_ALIGNMENT aligned. Signed-off-by: Dun Tan Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar ---

Re: [edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization to allow bigger stack

[AMD Official Use Only - General] Not the maintainer or reviewer, however Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan via > groups.io > Sent: Thursday, September 29, 2022 5:07 PM > To: devel@edk2.groups.io > Cc: Eric Dong ; Ray Ni ; Ra

[edk2-devel] [PATCH 3/4] OvmfPkg/PlatformInitLib: dynamic mmio window size

In case we have a reliable PhysMemAddressWidth use that to dynamically size the 64bit address window. Allocate 1/8 of the physical address space and place the window at the upper end of the address space. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformInitLib/MemDetect.c | 28

[edk2-devel] [PATCH 1/4] OvmfPkg/PlatformInitLib: qemu cpuid physbits detection

Add some qemu specific quirks to PlatformAddressWidthFromCpuid() to figure whenever the PhysBits value returned by CPUID is something real we can work with or not. See the source code comment for details on the logic. Also apply some limits to the address space we are going to use: * Place a har

[edk2-devel] [PATCH 2/4] OvmfPkg/PlatformInitLib: detect physical address space

Try detect physical address space, when successful use it. Otherwise go continue using the current guesswork code path. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformInitLib/MemDetect.c | 13 + 1 file changed, 13 insertions(+) diff --git a/OvmfPkg/Library/PlatformInitLib/

[edk2-devel] [PATCH 0/4] OvmfPkg: make better use of physical address space.

For historical reasons ovmf is quite conservative on address space usage, to play safe and avoid using more than 36 physical address bits (the guaranteed minimum) if possible. With devices (specifically GPUs) becoming larger and larger pci memory bars this becomes increasingly problematic. This p

[edk2-devel] [PATCH 4/4] OvmfPkg/PciHotPlugInitDxe: reserve more mmio space

In case the 64-bit pci mmio window is larger than the default size of 32G be generous and hand out larger chunks of address space for prefetchable mmio bridge windows. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf | 1 + OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

[AMD Official Use Only - General] Hi Sunil, One more thing other than the module reconstruction for archs before you sending patch to edk2: Not sure how would you do on migrating the RISC-V code from edk2-platforms to edk2. Did you make some other changes to the RISC-V CpuDxe on edk2-platform?

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

On Thu, Sep 29, 2022 at 02:54:05PM +, Chang, Abner wrote: > [AMD Official Use Only - General] > > Hi Sunil, > One more thing other than the module reconstruction for archs before you > sending patch to edk2: > Not sure how would you do on migrating the RISC-V code from edk2-platforms to > ed

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

MdeModulePkg maintainers, Any comments on this? > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, September 21, 2022 10:32 AM > To: devel@edk2.groups.io; Jeff Brasen > Cc: hao.a...@intel.com; ray...@intel.com; quic_llind...@quicinc.com; > ardb+tianoc...@kernel.org > Subject:

Re: [edk2-devel] [PATCH v5 09/21] MdePkg/BaseRngLib: Rename ArmReadIdIsar0() to ArmGetFeatRng()

On 9/28/22 19:10, Leif Lindholm wrote: On 2022-09-19 12:21, pierre.gond...@arm.com wrote: From: Pierre Gondois The MdePkg must be self contained and not have external dependencies. ArmReadIdIsar0() is defined in MdePkg/Library/BaseRngLib and is limited to the scope of this library. > Th

Re: [edk2-devel] [PATCH v5 09/21] MdePkg/BaseRngLib: Rename ArmReadIdIsar0() to ArmGetFeatRng()

On 2022-09-29 09:21, Pierre Gondois wrote: On 9/28/22 19:10, Leif Lindholm wrote: On 2022-09-19 12:21, pierre.gond...@arm.com wrote: From: Pierre Gondois The MdePkg must be self contained and not have external dependencies. ArmReadIdIsar0() is defined in MdePkg/Library/BaseRngLib and is lim

Re: [edk2-devel] [PATCH v4 4/6] MdeModulePkg: DxeMain accepts all memory at EBS if needed

> > Can you explain a bit more why this PCD is needed? > I'll expand the comment further, but essentially we need a bit in the firmware to persist from a call into a protocol to the eventual call to ExitBootServices. If we needed offline persistence, then we'd need to standardize a new bit in the

Re: [edk2-devel] [PATCH v4 2/6] MdeModulePkg: Add PcdEnableUnacceptedMemory

> The name PcdEnableUnacceptedMemory is a bit confusing imho. Could we > rename this to PcdAcceptAllUnacceptedMemory or something like that? > Will do. Is the protocol name EnableUnacceptedMemory still acceptable now that it's setting an AcceptAllUnacceptedMemory value to FALSE? -- -Dionna Glaze

Re: [edk2-devel] [PATCH 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls

Hi Rebecca, Thanks for sending this patch. I have a few questions inline "[KQ]". Could you please help me to understand the patch better? Thanks in advance. Regards, Kun On 8/29/2022 8:59 AM, Rebecca Cran wrote: Add support for EFI_MP_SERVICES_PROTOCOL during the DXE phase under AArch64. PS

Re: [edk2-devel] [PATCH v4 3/6] OvmfPkg: set PcdEnableUnacceptedMemory to FALSE

> Generally, we tend to rely on the DEC default for new PCDs if we're > not deviating from it. > If there is no specific reason to deviate from this here, I think we > can drop this patch. > > Or is this also needed to declare them as the right type? In that > case, I think you can drop the hunks t

[edk2-devel] [edk2-platforms PATCH 1/2] Platform/RaspberryPi: fix pci DT node address in SyncPcie()

To make sure the XHCI controller does not get reset by Linux in DT mode, we remove its pci parent node from the device tree. However, the pci node address has been updated in the Raspberry Pi 4 device tree [1] and no longer matches the one we are trying to remove in SyncPcie(). This results in the

[edk2-devel] [edk2-platforms PATCH 2/2] Platform/RaspberryPi: delete usb node instead of pci in SyncPcie()

In SyncPcie(), the pci node is removed from the device tree to make sure the XHCI controller is not reset by Linux in DT mode. However, we should only remove the usb child node and not the whole pci node. Removing the whole pci node prevents Linux to bypass XHCI handoff for the Raspberry Pi 4 [1].

[edk2-devel] [edk2-platforms PATCH 0/2] Platform/RaspberryPi: SyncPcie() fixes

This patch series does a few fixes in the SyncPcie() function, more specifically in the logic that deletes the pci node to prevent Linux from resetting the XHCI controller. Adrien Thierry (2): Platform/RaspberryPi: fix pci DT node address in SyncPcie() Platform/RaspberryPi: delete usb node ins

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

Hi Abner, Looks good to me. Reviewed-by: Abdul Lateef Attar Thanks AbduL -Original Message- From: Chang, Abner Sent: 28 September 2022 20:31 To: Sunil V L ; devel@edk2.groups.io; ray...@intel.com Cc: Kinney, Michael D ; lichao ; Kirkendall, Garrett ; Grimes, Paul ; He, Jiangang

[edk2-devel] [PATCH] ShellPkg: Changes to display Type 45 table in smbiosview and improved Type 3 table.

Add support in smbiosview command to display Type 45 table. There is a bug in Type 3 table which displays SystemEnclosureType as Undefined. As per Smbios spec, BIT7 in SMBIOS_TABLE_TYPE3.Type denotes whether chassis lock is present or not. But, currently BIT7 considered to display SystemEnclosur

[edk2-devel] [PATCH 1/1] MdeModulePkg: Handle InitialVFs=0 case for SR-IOV

Per the section 3.3.5 SR-IOV spec v1.1, InitialVFs (0ch). InitialVFs indicates to SR-PCIM the number of VFs that are initially associated with the PF. The minimum value of InitialVFs is 0. Below code is used to calculate SR-IOV reserved bus number, if InitialVFs =0, it maybe calculate the wrong b

[edk2-devel] [PATCH] DynamicTablesPkg:ACPI: SLIT Generator files

From: Swatisri Kantamsetti Added SLIT Generator and supporting files to generate SLIT ACPI Table Signed-off-by: Swatisri Kantamsetti --- DynamicTablesPkg/DynamicTables.dsc.inc| 2 + DynamicTablesPkg/Include/AcpiTableGenerator.h | 1 + .../Include/ArmNameSpaceObjects.h |

[edk2-devel] [PATCH v1 1/1] MiscBootServices: Stall_Func: Reduces the stall interval for Stall_Func

The Stall_Func test on the highest TPL causes issues with the disk IO by blocking interrupts. This blocking can cause disk corruption through IO timeouts. Since this doesn't seem to be the intent of the test this revision reduces the stall interval from 10 seconds to 4 and adjusts the delta toleran

[edk2-devel] [PATCH v1 0/1] Update Stall_Func interval to avoid IO timeouts

These changes contain an adjustment to the duration of the stall command to avoid disk corruption via IO timeouts. Robert Wood (1): MiscBootServices: Stall_Func: Reduces the stall interval for Stall_Func uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBoot

[edk2-devel] Updated Event: TianoCore Community Meeting EMEA/NAMO #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20220816T024022Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

[edk2-devel] Updated Event: TianoCore Community Meeting - APAC/NAMO #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20220816T024022Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2

If there's any further feedback on this RFC, please respond by Tuesday, October 4th. We plan to start implementing the changes later in the week. Thanks, Michael -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94542): https://edk2.groups

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

[AMD Official Use Only - General] > -Original Message- > From: Sunil V L > Sent: Thursday, September 29, 2022 11:22 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; ray...@intel.com; Kinney, Michael D > ; lichao ; Kirkendall, > Garrett ; Grimes, Paul > ; He, Jiangang ; Attar, > AbdulL

Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2

I just want to reiterate. If there are no concerns or objections raised by Oct 4, then the CodeQL static analysis will be phased into use in the edk2 repo and there will be code changes made to address the issues identified by COdeQL and all future code changes after a CodeQL check is enabled w

回复: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

Jeff: I have no comments for this change. Acked-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Jeff Brasen > via groups.io > 发送时间: 2022年9月30日 0:20 > 收件人: Ard Biesheuvel ; devel@edk2.groups.io > 抄送: hao.a...@intel.com; ray...@intel.com; quic_llind...@quicinc.com;

[edk2-devel] [PATCH 0/3] Add code coverage support for GCC

From: Gua Guo V1: Add coverage option for GCC V2: Add ReadMe.md for how to generate coverage report V3: Add VS2019 and GCC code coverage support V4: Add VS2019 and GCC Azure CI/CD support V5: Fix some typo and some flow issue Gua Guo (3): UnitTestFrameworkPkg: Add code coverage support for GCC

[edk2-devel] [PATCH 1/3] UnitTestFrameworkPkg: Add code coverage support for GCC

From: Gua Guo In order to collect code coverage after running executable file, generate *.gcda and *.gcno file that require by lcov tool to generate code coverage report. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael Kubacki Signed-off-by: Gua Guo --- UnitTestFramework

[edk2-devel] [PATCH 2/3] BaseTools/Plugin: Add coverage support for Unit Test

From: Gua Guo For GCC, use lcov to generate Unit Test code coverage report For VS2019, use OpenCppCoverage to generate code coverage report Cc: Bob Feng Cc: Bret Barkelew Cc: Liming Gao Cc: Michael D Kinney Cc: Sean Brogan Signed-off-by: Gua Guo --- .../HostBasedUnitTestRunner.py

[edk2-devel] [PATCH 3/3] .azurepipelines: Install code coverage tool

From: Gua Guo For Windows add below tool for code coverage 1. OpenCppCoverage: parsing pdb file to generate coverage data 2. pycobertura: show up html format data for coverage data For Linux add below tool for code coverage 1. lcov: parsing gcda gcno file to generate coverage data 2. lcov-cobert

[edk2-devel] [PATCH v5 0/3] Add code coverage support for GCC

From: Gua Guo V1: Add coverage option for GCC V2: Add ReadMe.md for how to generate coverage report V3: Add VS2019 and GCC code coverage support V4: Add VS2019 and GCC Azure CI/CD support V5: Fix some typo and some flow issue Gua Guo (3): UnitTestFrameworkPkg: Add code coverage support for GCC

[edk2-devel] [PATCH v5 1/3] UnitTestFrameworkPkg: Add code coverage support for GCC

From: Gua Guo In order to collect code coverage after running executable file, generate *.gcda and *.gcno file that require by lcov tool to generate code coverage report. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael Kubacki Signed-off-by: Gua Guo --- UnitTestFramework

[edk2-devel] [PATCH v5 2/3] BaseTools/Plugin: Add coverage support for Unit Test

From: Gua Guo For GCC, use lcov to generate Unit Test code coverage report For VS2019, use OpenCppCoverage to generate code coverage report Cc: Bob Feng Cc: Bret Barkelew Cc: Liming Gao Cc: Michael D Kinney Cc: Sean Brogan Signed-off-by: Gua Guo --- .../HostBasedUnitTestRunner.py

[edk2-devel] [PATCH v5 3/3] .azurepipelines: Install code coverage tool

From: Gua Guo For Windows add below tool for code coverage 1. OpenCppCoverage: parsing pdb file to generate coverage data 2. pycobertura: show up html format data for coverage data For Linux add below tool for code coverage 1. lcov: parsing gcda gcno file to generate coverage data 2. lcov-cobert

Re: [edk2-devel] [PATCH v5 0/3] Add code coverage support for GCC

@Kinney, Michael D and @Sean Brogan The PR is for the patch. https://github.com/tianocore/edk2/pull/3349 CI/CD support ready done. Coverage Data can get on Build/coverage.html. Have any concern, please also share for me.

回复: [edk2-devel] [PATCH] MdeModulePkg VariablePei: Add Variable state check when find variable in IndexTable.

Jiading: Hob Variable Store Info IndexTable is NULL. So, this logic doesn’t work for HOB variable store. NV Variable Store Info has IndexTable. When its IndexTable is initialized, its IndexTable will only record the variable with VAR_ADDED attribute. Because NV Variable Data is not changed in

Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2

Multiplication result converted to larger type · Code scanning alert #66 · tianocore/edk2 (github.com) Michael, I do not think above issue is a real issue. Will them be required to fix before enabling te CodeQL? From: devel@edk2.group

回复: [edk2-devel] [PATCH v5 3/3] .azurepipelines: Install code coverage tool

Gua: Should the change in HostBasedUnitTestRunner.py be combined into the patch 2? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Guo, Gua > 发送时间: 2022年9月30日 9:56 > 收件人: devel@edk2.groups.io > 抄送: Gua Guo ; Sean Brogan > ; Bret Barkelew > ; Michael D Kinney > ; Liming Gao > 主题:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Handle InitialVFs=0 case for SR-IOV

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Foster Nong > Sent: Thursday, September 29, 2022 5:20 PM > To: devel@edk2.groups.io > Cc: Nong, Foster > Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg: Handle InitialVFs=0 case for > SR-IOV > > Per the

Re: [edk2-devel] [PATCH 0/3] CryptoPkg: Extend Tls library

Hi All, Any comment about this patch set? Thanks very much. -Original Message- From: devel@edk2.groups.io On Behalf Of Li, Yi Sent: Monday, September 26, 2022 2:27 PM To: devel@edk2.groups.io Cc: Li, Yi1 ; Yao, Jiewen ; Wang, Jian J ; Lu, Xiaoyu1 ; Jiang, Guomin Subject: [edk2-devel] [

Re: [edk2-devel] [PATCH 3/3] CryptoPkg: Add new Tls APIs to DXE and protocol

I see one issue with adding new bits to the crypto services structured PCD. Comment below. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Li, Yi > Sent: Sunday, September 25, 2022 11:27 PM > To: devel@edk2.groups.io > Cc: Li, Yi1 ; Yao, Jiewen ; Wang, > Jian J ; Lu

Re: [edk2-devel] [PATCH 3/3] CryptoPkg: Add new Tls APIs to DXE and protocol

Thanks, next patch set will fix it. -Original Message- From: Kinney, Michael D Sent: Friday, September 30, 2022 1:09 PM To: devel@edk2.groups.io; Li, Yi1 ; Kinney, Michael D Cc: Yao, Jiewen ; Wang, Jian J ; Lu, Xiaoyu1 ; Jiang, Guomin Subject: RE: [edk2-devel] [PATCH 3/3] CryptoPkg:

回复: [edk2-devel] [RFC] Adoption of CodeQL in edk2

Michael: Could you estimate when CodeQL CI check can pass after CodeQL check is enabled? Thanks Liming 发件人: devel@edk2.groups.io 代表 Michael D Kinney 发送时间: 2022年9月30日 9:03 收件人: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael D 主题: Re: [edk2-devel] [RFC] Adoption of