On Thu, Sep 29, 2022 at 02:54:05PM +0000, Chang, Abner wrote: > [AMD Official Use Only - General] > > Hi Sunil, > One more thing other than the module reconstruction for archs before you > sending patch to edk2: > Not sure how would you do on migrating the RISC-V code from edk2-platforms to > edk2. Did you make some other changes to the RISC-V CpuDxe on edk2-platform? > Please keep the files history and send the patch for the migration first. > Then have the follow up patches for your changes if any and also add the > Ventana license. > > Below branches could be the reference for this migration, > https://github.com/changab/edk2/commits/RISC-V-MIGRATION-EDK2-PR > https://github.com/changab/edk2-platforms/commits/RISC-V-MIGRATION-EDK2-PLATFORM > > Thanks Sunil. > Abner > Thanks Abner. Let me take a look at your branch.
We have some changes and are not migrating everything from edk2-platforms. But I am not sure whether we can maintain the commit history when we migrate from a different repo. I think this should be like a new review and all old RB tags which were for edk2-platforms need to be removed. For ex: https://github.com/changab/edk2/commit/eca5ff6bea66be94fd58421ba98cb54d1f4181a6 IMO, RB tag should be removed and should be reviewed fresh when it is being added to edk2 repo. Thanks Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94523): https://edk2.groups.io/g/devel/message/94523 Mute This Topic: https://groups.io/mt/93872791/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
