[AMD Official Use Only - General]
> -----Original Message----- > From: Sunil V L <suni...@ventanamicro.com> > Sent: Thursday, September 29, 2022 11:22 PM > To: Chang, Abner <abner.ch...@amd.com> > Cc: devel@edk2.groups.io; ray...@intel.com; Kinney, Michael D > <michael.d.kin...@intel.com>; lichao <lic...@loongson.cn>; Kirkendall, > Garrett <garrett.kirkend...@amd.com>; Grimes, Paul > <paul.gri...@amd.com>; He, Jiangang <jiangang...@amd.com>; Attar, > AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com>; Leif Lindholm > <quic_llind...@quicinc.com>; Andrew Fish <af...@apple.com> > Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for > archs > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On Thu, Sep 29, 2022 at 02:54:05PM +0000, Chang, Abner wrote: > > [AMD Official Use Only - General] > > > > Hi Sunil, > > One more thing other than the module reconstruction for archs before you > sending patch to edk2: > > Not sure how would you do on migrating the RISC-V code from edk2- > platforms to edk2. Did you make some other changes to the RISC-V CpuDxe > on edk2-platform? > > Please keep the files history and send the patch for the migration first. > Then have the follow up patches for your changes if any and also add the > Ventana license. > > > > Below branches could be the reference for this migration, > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > > ub.com%2Fchangab%2Fedk2%2Fcommits%2FRISC-V-MIGRATION-EDK2- > PR&data= > > > 05%7C01%7CAbner.Chang%40amd.com%7Cb644f4b61bbd4e096c2308daa22e > 6703%7C3 > > > dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638000617445410044%7C > Unknown > > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > WwiLCJ > > > XVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wRnI%2Br4Dunydf77gSClb > 6ghHuY24Qs > > LrZTiPqc7pP1I%3D&reserved=0 > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > > ub.com%2Fchangab%2Fedk2-platforms%2Fcommits%2FRISC-V- > MIGRATION-EDK2-PL > > > ATFORM&data=05%7C01%7CAbner.Chang%40amd.com%7Cb644f4b61b > bd4e096c23 > > > 08daa22e6703%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63800 > 0617445 > > > 410044%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2 > luMzIiLCJ > > > BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5T2PHJOj > %2Bk6Mmu > > zNn0vsELm0raYiIDiI1X%2FekgZt6ls%3D&reserved=0 > > > > Thanks Sunil. > > Abner > > > Thanks Abner. Let me take a look at your branch. > > We have some changes and are not migrating everything from edk2- > platforms. But I am not sure whether we can maintain the commit history > when we migrate from a different repo. I think this should be like a new > review and all old RB tags which were for edk2-platforms need to be > removed. I was used tool to cherry pick from different repo to keep the history. Not sure if git command line can do this or not. To treat it as a new file that includes HPE and Ventana copyrights is confusing because HPE didn't have the collaboration with Ventana on those source files. I think you would have some files that are modified by Ventana regarding the functionality and some files without any change; the copyright should be applied to the contribution of functionality but not the migration or build error fix for the migration. I am fine with having a new review process, however, I would suggest below steps for the files from edk2-platform if to keep history is difficult. 1. Migrate the code from edk2-platform and fix the build error on edk2. In the source file keep HPE copyright only. Mention the origin of the file in the commit message. Please do not add Ventana copyright to the source file at this moment. 2. Afterward, add Ventana copyright for the further updates. This makes the contribution clear. 3. Do not delete the one on edk2-platforms. I think we can mention the implementation is obsoleted in the Readme.md under RISC-V PlatformPkg and ProcessorPkg. BTW, I can help on CpuDxe X86 migration. Thanks Abner > > For ex: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fchangab%2Fedk2%2Fcommit%2Feca5ff6bea66be94fd58421ba98c > b54d1f4181a6&data=05%7C01%7CAbner.Chang%40amd.com%7Cb644f4 > b61bbd4e096c2308daa22e6703%7C3dd8961fe4884e608e11a82d994e183d%7C > 0%7C0%7C638000617445566273%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000 > %7C%7C%7C&sdata=2TRD8pySU%2FIhz7ttFwdCHtPpl6JM0YSp%2BZjvo5 > %2FEEZ4%3D&reserved=0 > > IMO, RB tag should be removed and should be reviewed fresh when it is > being added to edk2 repo. > > Thanks > Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94543): https://edk2.groups.io/g/devel/message/94543 Mute This Topic: https://groups.io/mt/93872791/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
