Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-12 Thread Liming Gao
12, 2019 2:49 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Gao, Liming ; af...@apple.com; > Leif Lindholm > Cc: Justen, Jordan L ; Shi, Steven > > Subject: RE: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool > chain > > Mike, > I did a s

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Ni, Ray
@apple.com; Leif Lindholm > ; Kinney, Michael D > Cc: Justen, Jordan L ; Shi, Steven > > Subject: RE: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool > chain > > Ray, > > I agree that a name that represents the symbolic debug format makes more > sense. > &

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Michael D Kinney
: Monday, November 11, 2019 7:23 PM > To: devel@edk2.groups.io; Ni, Ray ; > Gao, Liming ; af...@apple.com; > Leif Lindholm > Cc: Justen, Jordan L ; Shi, > Steven > Subject: Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: > Enable CLANG9 tool chain > > And LLVM I believe

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Ni, Ray
2019 11:10 AM > To: devel@edk2.groups.io; Ni, Ray ; Gao, Liming > ; af...@apple.com; Leif Lindholm > > Cc: Justen, Jordan L ; Shi, Steven > > Subject: Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool > chain > > My point is if we choose CLANGPE, for

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Ni, Ray
9 9:46 AM > To: Gao, Liming ; devel@edk2.groups.io; > af...@apple.com; Leif Lindholm > Cc: Justen, Jordan L ; Shi, Steven > > Subject: Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool > chain > > Liming, > What name will be chosen when in future so

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Ni, Ray
: Ni, Ray ; Justen, Jordan L ; > Shi, Steven ; Gao, Liming > Subject: RE: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool > chain > > Thanks for your feedback. I will choose CLANGPE as the tool chain name. > > Thanks > Liming > >-Original Message-

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Liming Gao
;Cc: Ni, Ray ; Gao, Liming ; >devel@edk2.groups.io; Justen, Jordan L ; Shi, >Steven >Subject: Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool >chain > >Either works for me too. I like the PDE ending a little more, but agree it is a >little more obscure. >&g

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Andrew Fish via Groups.Io
Friday, November 8, 2019 9:50 AM >>> To: devel@edk2.groups.io; leif.lindh...@linaro.org; Andrew Fish >>> >>> Cc: Ni, Ray ; Justen, Jordan L >>> ; Gao, Liming ; Shi, >>> Steven >>> Subject: RE: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enabl

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Andrew Fish via Groups.Io
Friday, November 8, 2019 9:50 AM >>> To: devel@edk2.groups.io; leif.lindh...@linaro.org; Andrew Fish >>> >>> Cc: Ni, Ray ; Justen, Jordan L >>> ; Gao, Liming ; Shi, >>> Steven >>> Subject: RE: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enabl

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Leif Lindholm
> > From: Gao, Liming > > Sent: Friday, November 8, 2019 9:50 AM > > To: devel@edk2.groups.io; leif.lindh...@linaro.org; Andrew Fish > > > > Cc: Ni, Ray ; Justen, Jordan L > > ; Gao, Liming ; Shi, > > Steven > > Subject: RE: [edk2-

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-11 Thread Leif Lindholm
t;> > CLANG38. > >> > > >> >> CLANG38 may be used for Emulator in Linux or Mac. I don’t > >> >> try it before. > >> >> > >> >> CLANG9 goal is to align the same compiler in the different host > >> >> devel

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-07 Thread Ni, Ray
; leif.lindh...@linaro.org; Andrew Fish > > Cc: Ni, Ray ; Justen, Jordan L ; > Gao, Liming ; Shi, > Steven > Subject: RE: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool > chain > > Andrew and Leif: > Thanks for your comment. CLANG9 is different from CLANG3

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-07 Thread Liming Gao
>Cc: devel@edk2.groups.io; Gao, Liming ; Ni, Ray >; Justen, Jordan L >Subject: Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool >chain > >Hi Andrew, > >Yeah, I'm pretty easy with regards to what we change it to. >Although if we're bikeshedding,

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-07 Thread Andrew Fish via Groups.Io
lace VS or GCC compiler. On >>>> Windows Host, I verify VS debugger for the source level debug. On >>>> Linux host, I have not verified llvm debugger. I will investigate >>>> the debugger solution for OVMF in Linux host. >>> >>> We are not askin

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-07 Thread Leif Lindholm
stigate > >> the debugger solution for OVMF in Linux host. > > > > We are not asking you to throw out this toolchain profile. > > > > We are saying that since the functionality it provides is completely > > unrelated to that of CLANG38, it should not be named in

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-07 Thread Andrew Fish via Groups.Io
LANG38, it should not be named in a way that > suggests it is merely a revision update. > > / > Leif > >> Thanks >> Liming >> From: af...@apple.com >> Sent: Saturday, October 26, 2019 2:45 AM >> To: devel@edk2.groups.io; Gao, Liming >> Cc: Ni

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-07 Thread Leif Lindholm
2019 2:45 AM > To: devel@edk2.groups.io; Gao, Liming > Cc: Ni, Ray ; Justen, Jordan L > Subject: Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool > chain > > Liming, > > Sorry I missed this mail. Thanks for the info! I was doing some research into > this

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-11-07 Thread Leif Lindholm
Hi Liming, I don't feel we can release the stable tag with the toolchain profile still holding this name. Do you have any comments? Best Regards, Leif On Fri, Oct 25, 2019 at 11:45:10AM -0700, Andrew Fish via Groups.Io wrote: > Liming, > > Sorry I missed this mail. Thanks for the info! I was d

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-30 Thread Liming Gao
debugger solution for OVMF in Linux host. Thanks Liming From: af...@apple.com Sent: Saturday, October 26, 2019 2:45 AM To: devel@edk2.groups.io; Gao, Liming Cc: Ni, Ray ; Justen, Jordan L Subject: Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain Liming, Sorry I missed this

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-18 Thread Liming Gao
Andrew: Here is the cover letter on CLANG9 introduction. https://edk2.groups.io/g/devel/message/49157 1) Yes. CLANG9 tool chain is added to directly generate PE/COFF image (EFI image). This tool chain uses LLVM clang C compiler and lld linker, generates PE/COFF image and PDB compatible de

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-17 Thread Andrew Fish via Groups.Io
Ray, Sorry I'm coming a little late to this and I'm confused. I have some questions? 1) Does CLANG9 imply CLANGPE? 2) Does CLANGPE work on Linux and macOS? Can you pass the Windows style arguments to CLANGPE linker on Linux and macOS? 3) For the EmulatorPkg don't you have the extra requirement t

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-17 Thread Ni, Ray
Liming, Emulator is using a generic SEC module. The host specific module is called "Host". So I prefer to change the macro to "WIN_HOST_BUILD", with this change, Reviewed-by: Ray Ni > -Original Message- > From: Gao, Liming > Sent: Thursday, October 17, 2019 2:56 PM > To: devel@edk2.gro

[edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-16 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 1. Add WIN_SEC_BUILD macro check for CLANG9 tool chain build -p EmulatorPkg\EmulatorPkg.dsc -a IA32 -DWIN_SEC_BUILD=TRUE -t CLANG9 build -p EmulatorPkg\EmulatorPkg.dsc -a X64 -DWIN_SEC_BUILD=TRUE -t CLANG9 2. Append CLANG CC and LINK flags to