Pushed as 3037c13015016f7c398da37eabe33fb0961dc490
Note I fixed PatchCheck.py issues and committed in an order that doesn't break
git bisect.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107473): https://edk2.groups.io/g/devel/message
Pushed as 421e64019d4622b049f510ba8eef7c82fba7b32d
Note I fixed PatchCheck.py issues and committed in an order that doesn't break
git bisect.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107472): https://edk2.groups.io/g/devel/message
Pushed as e563c1c528f15d4224103f5c49559df620b5a655
Note I fixed PatchCheck.py issues and committed in an order that doesn't break
git bisect.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107471): https://edk2.groups.io/g/devel/message
Reviewed-by: Isaac Oram
-Original Message-
From: Arun K
Sent: Tuesday, July 25, 2023 8:36 AM
To: devel@edk2.groups.io; Arun K
Cc: Oram, Isaac W ; Desimone, Nathaniel L
; Ramkumar Krishnamoorthi ;
Gao, Liming
Subject: [edk2-devel][edk2-platforms][PATCH V5-1] IpmiFeaturePkg:Provided
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Arun K via
groups.io
Sent: Tuesday, July 25, 2023 8:37 AM
To: devel@edk2.groups.io; Arun K
Cc: Oram, Isaac W ; Desimone, Nathaniel L
; Ramkumar Krishnamoorthi ;
Gao, Liming
Subject: [edk2-devel][edk2
Pushed as 9131d63e08..41e8d638fa
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Wednesday, July 26, 2023 10:11 AM
To: Hsueh, DoraX ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Gao, Liming ; Dong,
Eric ; Chuang, Rosen ; Kuo, Ted
Reviewed-by: Isaac Oram
-Original Message-
From: Hsueh, DoraX
Sent: Monday, July 24, 2023 3:43 AM
To: devel@edk2.groups.io
Cc: Hsueh, DoraX ; Chiu, Chasel ;
Desimone, Nathaniel L ; Oram, Isaac W
; Gao, Liming ; Dong, Eric
; Chuang, Rosen ; Kuo, Ted
Subject: [PATCH] MinPlatformPkg
Reviewed-by: Isaac Oram
-Original Message-
From: Chang, Abner
Sent: Monday, July 10, 2023 6:36 PM
To: Chesley, Brit ; devel@edk2.groups.io
Cc: Oram, Isaac W ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang
Subject: RE: [edk2-platforms][PATCH v1 1/1] ManageabilityPkg: Ipmi Get/Set
I think the exception has something to do with gEfiPeiSmbus2PpiGuid.
Regards,
Isaac
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Tuesday, July 11, 2023 6:45 PM
To: Arun K ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Ramkumar
Krishnamoorthi ; Gao
d2Ex.
IpmiSubmitCommand2 - This API use the default interface
(PcdDefaultSystemInterface) to send IPMI command.
IpmiSubmitCommand2Ex - This API use the specific interface type to send IPMI
command which is passed as an argument.
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Aru
Pushed as 87c40ac89b97eccac690762536db5376af15bb65
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Wednesday, July 5, 2023 7:57 PM
To: devel@edk2.groups.io; mikub...@linux.microsoft.com
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Gao, Liming ; Dong,
Eric
Pushed as f4fbaf6022603957fefa77c9ceb77f4b2851b0dc
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Wednesday, July 5, 2023 7:55 PM
To: devel@edk2.groups.io; mikub...@linux.microsoft.com
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Gao, Liming ; Dong,
Eric
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael Kubacki
Sent: Wednesday, July 5, 2023 6:57 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Oram, Isaac W ; Gao,
Liming ; Dong, Eric ; Lautner,
Kenneth
Subject: [edk2
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael Kubacki
Sent: Wednesday, July 5, 2023 6:40 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Oram, Isaac W ; Gao,
Liming ; Dong, Eric
Subject: [edk2-devel] [edk2-platforms
Add macros that make it easier to determine if a status code
is an error, progress, or debug code.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Isaac Oram
---
.../Include/Guid/MemoryStatusCodeRecord.h | 2 +-
MdePkg/Include/Library/ReportStatusCodeLib.h | 61
Disambiguate SMM sourced asserts from other DXE asserts.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Isaac Oram
---
.../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/MdeModulePkg/Universal
Serial worker does not have this initialization function implemented.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Isaac Oram
---
.../RuntimeDxe/StatusCodeHandlerRuntimeDxe.h | 11 ---
.../StatusCodeHandler/Smm/StatusCodeHandlerMm.h | 11
This is some minor housekeeping on SMM status code handling.
https://github.com/tianocore/edk2/pull/4610
Cc: Dandan Bi
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Zhiguang Liu
Signed-off-by: Isaac Oram
Isaac Oram (3):
MdeModulePkg/StatusCodeHandlerSmm: Remove unused code
MdeModulePkg
Pushed as dd09609ec9..bc10b26189
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Friday, June 30, 2023 1:51 PM
To: Chang, Hunter ; devel@edk2.groups.io
Cc: Ni, Ray ; Chaganty, Rangasai V
; S, Ashraf Ali ; Chen,
Tina ; Chen, Arthur G
Subject: Re: [edk2-devel
Reviewed-by: Isaac Oram
-Original Message-
From: Chang, Hunter
Sent: Tuesday, June 13, 2023 5:40 AM
To: devel@edk2.groups.io
Cc: Chang, Hunter ; Ni, Ray ;
Chaganty, Rangasai V ; Oram, Isaac W
; S, Ashraf Ali ; Chen, Tina
; Chen, Arthur G
Subject: [PATCH v1] IntelSiliconPkg: Add
Pushed as 1befeabcc8..dd09609ec9
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Friday, June 30, 2023 1:22 PM
To: S, Ashraf Ali ; devel@edk2.groups.io;
mikub...@linux.microsoft.com
Cc: Ni, Ray ; Chaganty, Rangasai V
Subject: Re: [edk2-devel] [edk2
Reviewed-by: Isaac Oram
Mixing DEBUG_WARN | DEBUG_ERROR confuses me a bit. I would prefer simpler
definitions were errors are "something is wrong" and warnings are "something
might be wrong".
But it is a pretty minor nit and cleanup is good, so don't worry about chan
also has one
IPMI feature waiting for upstream to edk2-platform, work on both packages will
lead to divergency.
I suggest we just have AMI to revise their code to compliant with
ManageabilityPkg.
Regards,
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Isaac
d2 - This API use the default interface
(PcdDefaultSystemInterface) to send IPMI command.
IpmiSubmitCommand2Ex - This API use the specific interface type to send IPMI
command which is passed as an argument.
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Arun K
---
.../Generi
e default interface
(PcdDefaultSystemInterface) to send IPMI command.
IpmiSubmitCommand2Ex - This API use the specific interface type to send IPMI
command which is passed as an argument.
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Arun K
---
.../GenericIpmi/Common/IpmiBmc.h | 10
Nickle,
This looks reasonable to me. I can see an argument that suggests these align
more with the peripheral class errors, but your proposal looks better to me.
Regards,
Isaac
From: devel@edk2.groups.io On Behalf Of Nickle Wang via
groups.io
Sent: Wednesday, May 31, 2023 9:23 PM
To: r...@ed
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Saturday, May 13, 2023 5:33 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang
Subject: [edk2-devel] [edk2-platforms][PATCH 2/2
Reviewed-by: Isaac Oram
Typo in "wtchdog" and "Failt". Can be fixed prior to commit.
-Original Message-
From: abner.ch...@amd.com
Sent: Saturday, May 13, 2023 5:33 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang ; Tinh Ngu
Reviewed-by: Isaac Oram
-Original Message-
From: abner.ch...@amd.com
Sent: Saturday, May 13, 2023 8:49 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang
Subject: [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiBmcAcpi: Add to
ManageabilityPkg
From
Reviewed-by: Isaac Oram
You could consider changing "INTEL" and ('M', 'S', 'F', 'T') to more generic
placeholders. But that is also something that could be looked at separately
and more widely.
-Original Message-
From: devel@edk2.g
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Friday, May 12, 2023 2:58 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang
Subject: [edk2-devel] [edk2-platforms][PATCH 2/2
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Friday, May 12, 2023 2:58 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-devel] [edk2-platforms][PATCH 1
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Friday, May 12, 2023 12:29 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang
Subject: [edk2-devel] [edk2-platforms][PATCH 2/2
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Friday, May 12, 2023 12:29 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-devel] [edk2-platforms][PATCH
Reviewed-by: Isaac Oram
-Original Message-
From: abner.ch...@amd.com
Sent: Thursday, May 11, 2023 9:07 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang
Subject: [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiOsWdt: Add to
ManageabilityPkg
From
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Thursday, May 11, 2023 9:07 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-devel] [edk2-platforms][PATCH
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Thursday, May 11, 2023 8:27 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang
Subject: [edk2-devel] [edk2-platforms][PATCH 2/2
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Thursday, May 11, 2023 8:27 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul Lateef Attar
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-devel] [edk2-platforms][PATCH
Pushed as acf260597a..15f27d5c30
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Monday, May 15, 2023 2:22 PM
To: devel@edk2.groups.io; rebe...@bsdio.com; Dong, Eric ;
Gao, Liming ; Chaganty, Rangasai V
; Desimone, Nathaniel L
Subject: Re: [edk2-devel
Pushed as 3c8ea51b12..acf260597a
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Tuesday, May 16, 2023 12:43 PM
To: Rebecca Cran ; devel@edk2.groups.io; Chiu, Chasel
; Desimone, Nathaniel L
; Chaganty, Rangasai V
Subject: Re: [edk2-devel] [PATCH edk2
Series Reviewed-by: Isaac Oram
-Original Message-
From: Rebecca Cran
Sent: Monday, May 15, 2023 6:59 AM
To: devel@edk2.groups.io; Chiu, Chasel ; Desimone,
Nathaniel L ; Chaganty, Rangasai V
; Oram, Isaac W
Cc: Rebecca Cran
Subject: [PATCH edk2-platforms v2 0/2] Platform/Intel
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Isaac
> Oram
> Sent: Tuesday, May 16, 2023 10:39 AM
> To: devel@edk2.groups.io; Oram, Isaac W
> Cc: Wang, Jian J ; Gao, Liming
> ; Zimmer, Vincent
> ; Chiu, Chasel
> Subject: Re: [edk2-devel
Isaac
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Tuesday, May 16, 2023 10:35 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Wang, Jian J
; Gao, Liming
Subject: [edk2-devel][edk2-platforms][RFC PATCH V1 1/1]
MdeModulePkg/StatusCodeHandlerSmm: Add debug strings to m
Wang
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
.../Include/Guid/MemoryStatusCodeRecord.h | 7 +
.../Smm/MemoryStatusCodeWorker.c | 199 ++
2 files changed, 206 insertions(+)
diff --git a/MdeModulePkg/Include/Guid/MemoryStatusCodeRecord.h
b/MdeModulePkg
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran
Sent: Sunday, May 14, 2023 10:54 PM
To: devel@edk2.groups.io; Dong, Eric ; Oram, Isaac W
; Gao, Liming ; Chaganty,
Rangasai V ; Desimone, Nathaniel L
Cc: Rebecca Cran
Subject: [edk2
Reviewed-by: Isaac Oram
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Wednesday, May 10, 2023 8:02 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Oram, Isaac W ; Gao,
Liming ; Dong, Eric ; Gudla,
Raghava
Subject: [edk2-platforms][PATCH v4 1/1
Reviewed-by: Isaac Oram
Multiple instances of typo: AdditioalStatus
I think it is ok to fix before push since it is simple search and replace.
-Original Message-
From: abner.ch...@amd.com
Sent: Tuesday, May 9, 2023 12:56 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Abdul
Reviewed-by: Isaac Oram
I noted that the BaseManageabilityTransportIpmiHelper.c file header comment
indicates that this is a NULL library implementation which seems
incorrect/misleading. I think that this can be fixed before pushing.
-Original Message-
From: abner.ch...@amd.com
; Dong, Eric
> Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] MinPlatformPkg/Build:
> Add standalone MM build rules
>
> Adds MM_STANDALONE_CORE and MM_STANDALONE FFS file construction rules.
>
> Cc: Chasel Chiu
> Cc: Nate DeSimone
> Cc: Liming G
WhitleyOpenBoardPkg/DSC: Restore AdvancedFeatures
>
> Include for building Advanced Features was mistakenly removed in an
> earlier commit.
>
> Cc: Nate DeSimone
> Cc: Chasel Chiu
> Signed-off-by: Isaac Oram
> ---
> Platform/Intel/WhitleyOpenBoardPkg/Platfo
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Pedro Falcato
Sent: Tuesday, May 9, 2023 9:15 AM
To: devel@edk2.groups.io
Cc: Pedro Falcato ; Oram, Isaac W
; Theo Jehl
Subject: [edk2-devel] [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use
Raghava
>>> Sent: Friday, May 5, 2023 5:03 PM
>>> To: devel@edk2.groups.io
>>> Cc: Gudla, Raghava ; Chiu, Chasel
>>> ; Desimone, Nathaniel L
>>> ; Oram, Isaac W
>>
>>> Subject: [edk2-platforms:PATCH V1] MinPlatformPkg/SaveMemoryConfig:
>&g
Reviewed-by: Isaac Oram
A few superficial things that could be fixed now or later.
Typo: EFI_STASTUS
There is a mismatch between function names and parameter names that looks like
a cut/paste from prior function. Updating would probably match the spirit of
"no functional changes&quo
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Signed-off-by: Raghava Gudla
---
.../SaveMemoryConfig/SaveMemoryConfig.c | 34 +++
.../SaveMemoryConfig/SaveMemoryConfig.inf | 6 +++-
.../Include/Dsc/CoreCommonLib.dsc | 1 +
.../Intel/MinPlatformPkg/
Pushed as 64b06a4d19..d39c665fe3
Note I had trouble extracting the patch. I had to ignore whitespace and then
fixup line endings to pass
python \edk2\BaseTools\Scripts\PatchCheck.py -1
Regards,
Isaac
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Monday
Reviewed-by: Isaac Oram
-Original Message-
From: Attar, AbdulLateef (Abdul Lateef)
Sent: Friday, April 28, 2023 2:46 AM
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Chang, Abner ; Chaganty, Rangasai V
; Oram, Isaac W ;
Desimone, Nathaniel L ; Gao, Liming
Reviewed-by: Isaac Oram
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, April 12, 2023 9:41 AM
To: Chen, Aryeh ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Oram, Isaac W
; Gao, Liming ; Dong, Eric
Subject: RE: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and
Pushed as 857a342e50..07f5955bad
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Monday, April 3, 2023 8:56 AM
To: Ramkumar Krishnamoorthi ; devel@edk2.groups.io
Cc: Venkatesan, Selvaraj ; DOPPALAPUDI, HARIKRISHNA
; KARPAGAVINAYAGAM, MANICKAVASAKAM
Reviewed-by: Isaac Oram
I amended the author to match "Ramkumar K ". Please
correct. I am not sure if it is git config or groups.io that is mismatching.
You can do git log and see the delta between author and your signoff.
Thanks for fixing the enum.
Regards,
Isaac
-Origin
Reviewed-by: Isaac Oram
edk2 convention has changed to naming DSC include files *.dsc.inc. I plan to
update all the features sometime in the future.
Manageability.dsc:
I think that the "[LibraryClasses.ARM, LibraryClasses.AARCH64]" section
contents should be moved to the Manageabil
Reviewed-by: Isaac Oram
-Original Message-
From: Leif Lindholm
Sent: Thursday, March 23, 2023 7:46 AM
To: abner.ch...@amd.com
Cc: devel@edk2.groups.io; Abdul Lateef Attar ; Kinney,
Michael D ; Gao, Liming ;
Oram, Isaac W ; Nickle Wang
Subject: Re: [PATCH v4 9/9] edk2-platforms
Acked-by: Isaac Oram
-Original Message-
From: abner.ch...@amd.com
Sent: Thursday, March 23, 2023 6:58 AM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
; Liu, Zhiguang ; Nickle Wang
; Igor Kulchytskyy ; Oram, Isaac W
; Abdul Lateef Attar
Subject: [PATCH v3] MdePkg
Series pushed as d7466862b7..4811c37ae3
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Tuesday, March 21, 2023 1:44 PM
To: Mike Maslenkin
Cc: devel@edk2.groups.io; Arunk ; Desimone, Nathaniel L
; Gao, Liming
Subject: Re: [edk2-devel] [PATCH edk2-platforms
Series Reviewed-by: Isaac Oram
-Original Message-
From: Mike Maslenkin
Sent: Saturday, March 11, 2023 3:30 AM
Cc: devel@edk2.groups.io; Mike Maslenkin ; Arunk
; Oram, Isaac W ; Desimone, Nathaniel L
; Gao, Liming
Subject: [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes
Pushed as 8efa4f42b5..d7466862b7
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Tuesday, March 21, 2023 1:09 PM
To: devel@edk2.groups.io; Rudolph, Patrick
Cc: quic_llind...@quicinc.com; Kinney, Michael D ;
Chaganty, Rangasai V ; Desimone, Nathaniel L
; Gao
Pushed as 8efa4f42b5..d7466862b7
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Tuesday, March 21, 2023 12:33 PM
To: Rudolph, Patrick
Cc: devel@edk2.groups.io; quic_llind...@quicinc.com; Kinney, Michael D
; Chaganty, Rangasai V
; Desimone, Nathaniel L
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Patrick Rudolph
Sent: Monday, March 20, 2023 1:53 AM
Cc: devel@edk2.groups.io; quic_llind...@quicinc.com; Kinney, Michael D
; Chaganty, Rangasai V
; Oram, Isaac W ;
Desimone, Nathaniel L ; Gao, Liming
Reviewed-by: Isaac Oram
In the future, please CC maintainers from
https://github.com/iworam/edk2-platforms/blob/master/Maintainers.txt in the
commit messages.
-Original Message-
From: Patrick Rudolph
Sent: Monday, March 20, 2023 1:53 AM
Cc: devel@edk2.groups.io; quic_llind
Adds MM_STANDALONE_CORE and MM_STANDALONE FFS file
construction rules.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Isaac Oram
---
.../MinPlatformPkg/Include/Fdf/RuleInclude.fdf| 15 +++
1 file changed, 15 insertions(+)
diff --git a/Platform
We are doing some work to enable CI on edk2-platforms and would like to add
QemuOpenBoardPkg to the CI list. I do think that this will become more active
over time.
Is there a V2 coming? If so, I found a compiler issue with VS2019 and VS2015.
It doesn't like the local variable PlatformData hav
Pushed as 90ea518edf..95b58f71d9
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Wednesday, March 8, 2023 6:43 PM
To: Mike Maslenkin ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix
IPMI GetSelfTest command response
Series Reviewed-by
Series Reviewed-by: Isaac Oram
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100893): https://edk2.groups.io/g/devel/message/100893
Mute This Topic: https://groups.io/mt/97485240/21656
Group Owner: devel+ow...@edk2.groups.io
Pushed as 65e001a7f2..90ea518edf
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Tuesday, March 7, 2023 4:28 PM
To: Chiu, Chasel ; Chen, Aryeh ;
devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Gao, Liming
; Dong, Eric
Subject: Re: [edk2-devel] [PATCH v1
Reviewed-by: Isaac Oram
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, March 1, 2023 8:03 AM
To: Chen, Aryeh ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Oram, Isaac W
; Gao, Liming ; Dong, Eric
Subject: RE: [PATCH v1] MinPlatformPkg: Update MinDsdt device name from
Include for building Advanced Features was mistakenly removed
in an earlier commit.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 5 +
1 file changed, 5 insertions(+)
diff --git a/Platform/Intel/WhitleyOpenBoardPkg
Acked-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Thursday, March 2, 2023 7:17 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
; Liu, Zhiguang ; Nickle Wang
; Igor Kulchytskyy ; Oram, Isaac W
; Abdul
Acked-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chang, Abner via
groups.io
Sent: Thursday, March 2, 2023 7:25 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
; Liu, Zhiguang ; Nickle Wang
; Igor Kulchytskyy ; Oram, Isaac W
; Abdul
: Isaac Oram
---
.../IpmiFeaturePkg/Include/IpmiFeature.dsc| 24 +++
.../IpmiFeaturePkg/IpmiFeaturePkg.dsc | 1 +
2 files changed, 10 insertions(+), 15 deletions(-)
diff --git
a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
b/Features/Intel
Coding convention does not allow Hungarian notation,
https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/v/release-2.20/4_naming_conventions/43_identifiers#4.3.3-hungarian-prefixes
Please change pSelfTestResult to SelfTestResult.
Thanks,
Isaac
-Original Message-
From: de
ommit messages,
e.g.:
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Liming Gao
Regards,
Isaac
-Original Message-
From: Mike Maslenkin
Sent: Monday, February 27, 2023 3:28 PM
To: devel@edk2.groups.io
Cc: Mike Maslenkin ; Oram, Isaac W
; Desimone, Nathaniel L
; Gao, Liming
Subject: [PATCH
Reviewed-by: Isaac Oram
-Original Message-
From: Mike Maslenkin
Sent: Monday, February 27, 2023 3:28 PM
To: devel@edk2.groups.io
Cc: Mike Maslenkin ; Oram, Isaac W
; Desimone, Nathaniel L
; Gao, Liming
Subject: [PATCH edk2-platforms 1/3] IpmiFeaturePkg: fix IPMI GetSelfTest
command
f)
mailto:abdullateef.at...@amd.com>>; Leif Lindholm
mailto:quic_llind...@quicinc.com>>; Michael D Kinney
mailto:michael.d.kin...@intel.com>>; Liming Gao
mailto:gaolim...@byosoft.com.cn>>; Isaac Oram
mailto:isaac.w.o...@intel.com>>; Nate DeSimone
mailto:nathaniel.l.des
om: Abner Chang
Initial commit of ManageabilityPkg
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
.../ManageabilityPkg/ManageabilityPkg.dec | 18 +
.../Include/Com
H 5/7] ManageabilityPkg: Implement Ipmi
Protocol/Ppi
From: Abner Chang
Add Ipmi Protocol/Ppi implementation. The underlying implementation is provided
by IpmiBaseLib.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor Kulchy
Add Readme file of edk2 platform ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Abdul Lateef Attar
---
Features/ManageabilityPkg/Readme.md | 37 +
1 file changed, 37 insertion
on
From: Abner Chang
Rename IpmiSubmitCommand to IpmiSendCommand because the naming of this function
is confusing with IpmiSubmitCommand defined in IPMI Protocol.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Abdul Lateef A
nsport protocol.
You can skip reviewing on patch 2/7 as it is an image file.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Abdul Lateef Attar
Cc: Leif Lindholm
Cc: Michael D Kinney
Abner Chang (7):
IpmiFeaturePkg: Ren
Reviewed-by: Isaac Oram
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Thursday, February 9, 2023 4:52 PM
To: devel@edk2.groups.io
Cc: S, Ashraf Ali ; Oram, Isaac W
; Chaganty, Rangasai V ;
Ni, Ray ; Chiu, Chasel
Subject: [edk2-platforms][PATCH v1 1/1
Reviewed-by: Isaac Oram
-Original Message-
From: Chiu, Chasel
Sent: Thursday, February 9, 2023 10:27 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; S, Ashraf Ali
; Oram, Isaac W ; Chaganty,
Rangasai V ; Ni, Ray ;
Kubacki, Michael
Subject: [edk2-platforms: PATCH v4] IntelSiliconPkg
g the total NVS region size.
>
> One usage model is EventLog NVS region and there could be others.
>
> Cc: Ashraf Ali S
> Cc: Isaac Oram
> Cc: Rangasai V Chaganty
> Cc: Ray Ni
> Cc: Michael Kubacki
> Signed-off-by: Chasel Chiu
> ---
>
> Silicon
Pushed as bc0b6bf..bd07ad3
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Wednesday, February 8, 2023 5:59 PM
To: devel@edk2.groups.io; tommy_hu...@aspeedtech.com
Cc: a...@kernel.org; Desimone, Nathaniel L ;
quic_llind...@quicinc.com; Kinney, Michael D
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Tommy Huang
Sent: Wednesday, February 1, 2023 3:14 AM
To: devel@edk2.groups.io
Cc: a...@kernel.org; Desimone, Nathaniel L ;
Oram, Isaac W ; quic_llind...@quicinc.com; Kinney,
Michael D ; Chen, Ryan
-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg:
Improve sample build instructions
Reviewed-by: Rebecca Cran
On 1/18/23 18:20, Isaac Oram wrote:
> V1: Make the Windows build example current working directory based
> instead of arbitrary.
> V2: Fix case mismatch in edk2 repo l
Reviewed-by: Isaac Oram
At some point, we should work to comment the related flows better so that code
is clear on the different responsibilities for the different paths through
first boots, normal scenarios, reclaims, and error remediation. For now
though, this is fine.
Regards,
Isaac
Garrett,
Yeah, that was what I was trying to get at with "let's use what we have now and
then make an incompatible V1.0". I like the idea of alternates too. I dislike
punishing early adopters and I don't think alternatives hurt most of the
envisioned use cases.
Maybe we should start a branch
V1: Make the Windows build example current working directory based instead of
arbitrary.
V2: Fix case mismatch in edk2 repo local name.
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Rebecca Cran
Signed-off-by: Isaac Oram
---
Features/Intel/AdvancedFeaturePkg/Readme.md | 14
Series Pushed as 3b368b33e9..201514e6f5
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Wednesday, January 18, 2023 4:30 PM
To: devel@edk2.groups.io; abdat...@amd.com
Cc: Abdul Lateef Attar ; Dong, Eric
; Gao, Liming
Subject: Re: [edk2-devel] [PATCH v3 0/2
Series Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abdul Lateef
Attar via groups.io
Sent: Wednesday, January 18, 2023 5:04 AM
To: devel@edk2.groups.io
Cc: Abdul Lateef Attar ; Oram, Isaac W
; Dong, Eric ; Gao, Liming
Subject: [edk2-devel
latest validated FSP, 4.2.0.2A.
There are binary incompatible Dispatch mode interface changes necessary.
API mode interfaces are unchanged.
Cc: Nate DeSimone
Cc: Chasel Chiu
Isaac Oram (2):
WhitleySiliconPkg: Update to Whitley FSP 4.2.0.2A
WhitleyOpenBoardPkg: Update to Whitley FSP 4.2.0.2A
; Desimone, Nathaniel L
; Gao, Liming ; Dong,
Eric ; Bi, Dandan
Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Features/Intel: Prepare
for edk2-platforms CI
On 1/9/23 17:05, Isaac Oram wrote:
> --- /dev/null
> +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md
...
> +## Window
1 - 100 of 183 matches
Mail list logo
