Pushed as 615afc82db..ab4ddecb12 -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran Sent: Thursday, January 19, 2023 7:56 AM To: Oram, Isaac W <isaac.w.o...@intel.com>; devel@edk2.groups.io Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Rebecca Cran <quic_rc...@quicinc.com> Subject: Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions
Reviewed-by: Rebecca Cran <rebe...@quicinc.com> On 1/18/23 18:20, Isaac Oram wrote: > V1: Make the Windows build example current working directory based > instead of arbitrary. > V2: Fix case mismatch in edk2 repo local name. > > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Rebecca Cran <quic_rc...@quicinc.com> > Signed-off-by: Isaac Oram <isaac.w.o...@intel.com> > --- > Features/Intel/AdvancedFeaturePkg/Readme.md | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/Features/Intel/AdvancedFeaturePkg/Readme.md > b/Features/Intel/AdvancedFeaturePkg/Readme.md > index ba50560328..20f456bebe 100644 > --- a/Features/Intel/AdvancedFeaturePkg/Readme.md > +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md > @@ -19,19 +19,21 @@ Supported build targets > * GCC5 > > ## Windows Example: > -With current working directory at O:\ > - > git clone https://github.com/tianocore/edk2.git > > +git clone https://github.com/tianocore/edk2-non-osi.git > + > git clone https://github.com/tianocore/edk2-platforms.git > > -set workspace=O:\ > +set workspace=%cd% > > -set EDK_TOOLS_PATH=O:\Edk2\BaseTools > +set EDK_TOOLS_PATH=%workspace%\edk2\BaseTools > > -set > packages_path=O:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Intel > ;O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\ed > k2-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2-pla > tforms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\Netwo > rk;O:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-platfo > rms\Features\Intel\PowerManagement;O:\edk2-platforms\Features\Intel\Sy > stemInformation;O:\edk2-platforms\Features\Intel\UserInterface > +set > +packages_path=%workspace%\edk2;%workspace%\edk2-non-osi;%workspace%\e > +dk2-platforms\Platform\Intel;%workspace%\edk2-platforms\Silicon\Intel > +;%workspace%\edk2-platforms\Platform\Qemu;%workspace%\edk2-platforms\ > +Silicon\Qemu;%workspace%\edk2-platforms\Features\Intel;%workspace%\ed > +k2-platforms\Features\Intel\Debugging;%workspace%\edk2-platforms\Feat > +ures\Intel\Network;%workspace%\edk2-platforms\Features\Intel\OutOfBan > +dManagement;%workspace%\edk2-platforms\Features\Intel\PowerManagement > +;%workspace%\edk2-platforms\Features\Intel\SystemInformation;%workspa > +ce%\edk2-platforms\Features\Intel\UserInterface > > -cd \edk2 > +cd %workspace%\edk2 > + > +git submodule update --init > > edksetup.bat Rebuild > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99836): https://edk2.groups.io/g/devel/message/99836 Mute This Topic: https://groups.io/mt/96368993/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
