Pushed as f4fbaf6022603957fefa77c9ceb77f4b2851b0dc -----Original Message----- From: [email protected] <[email protected]> On Behalf Of Isaac Oram Sent: Wednesday, July 5, 2023 7:55 PM To: [email protected]; [email protected] Cc: Chiu, Chasel <[email protected]>; Desimone, Nathaniel L <[email protected]>; Gao, Liming <[email protected]>; Dong, Eric <[email protected]> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib
Reviewed-by: Isaac Oram <[email protected]> -----Original Message----- From: [email protected] <[email protected]> On Behalf Of Michael Kubacki Sent: Wednesday, July 5, 2023 6:40 PM To: [email protected] Cc: Chiu, Chasel <[email protected]>; Desimone, Nathaniel L <[email protected]>; Oram, Isaac W <[email protected]>; Gao, Liming <[email protected]>; Dong, Eric <[email protected]> Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib From: Michael Kubacki <[email protected]> Commit `b71f2bd` introduced a couple build errors in VariableWritelib. This change adds the SMM Services Table (`gSmst`) and MM Services Table (`gMmst`) calls needed to register the protocol notify in the Traditional and Standalone MM services constructors. Cc: Chasel Chiu <[email protected]> Cc: Nate DeSimone <[email protected]> Cc: Isaac Oram <[email protected]> Cc: Liming Gao <[email protected]> Cc: Eric Dong <[email protected]> Signed-off-by: Michael Kubacki <[email protected]> --- Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c | 6 +++++- Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c index 8c2b7d18f5f8..447d358a3104 100644 --- a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLibConstructor.c +++ b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Standalo +++ neMmVariableWriteLibConstructor.c @@ -74,7 +74,11 @@ StandaloneMmVariableWriteLibConstructor ( // // Register VarLibExitBootServicesCallback for gEdkiiSmmExitBootServicesProtocolGuid. // - Status = SmmRegisterProtocolNotify (&gEdkiiSmmExitBootServicesProtocolGuid, VarLibExitBootServicesCallback, &Registration); + Status = gMmst->MmRegisterProtocolNotify ( + &gEdkiiSmmExitBootServicesProtocolGuid, + VarLibExitBootServicesCallback, + &Registration + ); ASSERT_EFI_ERROR (Status); return Status; diff --git a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c index abc1e25cde6c..413930d465eb 100644 --- a/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLibConstructor.c +++ b/Platform/Intel/MinPlatformPkg/Library/SmmVariableWriteLib/Traditio +++ nalMmVariableWriteLibConstructor.c @@ -74,7 +74,11 @@ TraditionalMmVariableWriteLibConstructor ( // // Register VarLibExitBootServicesCallback for gEdkiiSmmExitBootServicesProtocolGuid. // - Status = SmmRegisterProtocolNotify (&gEdkiiSmmExitBootServicesProtocolGuid, VarLibExitBootServicesCallback, &Registration); + Status = gSmst->SmmRegisterProtocolNotify ( + &gEdkiiSmmExitBootServicesProtocolGuid, + VarLibExitBootServicesCallback, + &Registration + ); ASSERT_EFI_ERROR (Status); return Status; -- 2.41.0.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106669): https://edk2.groups.io/g/devel/message/106669 Mute This Topic: https://groups.io/mt/99977994/1492418 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106712): https://edk2.groups.io/g/devel/message/106712 Mute This Topic: https://groups.io/mt/99977994/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
