Hello Edhay,
There has been no response from Eric since June 22.
Do you have any concerns with this change?
It’s very straight forward as indicated in REF:
https://bugzilla.tianocore.org/show_bug.cgi?id=2145.
Thank you,
Irene
From: Irene Park
Sent: Monday, July 6, 2020 12:48 PM
To: Jin, Eric
Hello Eric,
Would you please kindly review this change?
Thank you,
Irene
From: G Edhaya Chandran
mailto:edhaya.chand...@arm.com>>
Sent: Monday, June 22, 2020 3:06 PM
To: Jin, Eric mailto:eric@intel.com>>
Cc: Irene Park mailto:ip...@nvidia.com>>
Subject: RE: [edk2-devel
Hello Ard,
Would you please kindly review this change?
Thank you,
Irene
-Original Message-
From: Samer El-Haj-Mahmoud
Sent: Monday, June 22, 2020 5:01 PM
To: devel@edk2.groups.io; Irene Park ; Ard Biesheuvel
Subject: RE: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2
Hello Ard,
Would you please kindly review this change?
Thank you,
Irene
-Original Message-
From: Samer El-Haj-Mahmoud
Sent: Monday, June 22, 2020 5:01 PM
To: devel@edk2.groups.io; Irene Park ; Ard Biesheuvel
Subject: RE: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2
: Irene Park
Sent: Tuesday, June 9, 2020 1:59 PM
To: devel@edk2.groups.io
Cc: Irene Park
Subject: [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero
From: Irene Park
PL011UartLib determines its FIFO depth based on the PID2 value but the register
PID2 is not mandatory as per the
Hi Edhaya,
Thank you for the review.
By the way, I don’t see it got mainlined yet.
Do you mind to share when you’re going to pick it up ?
Thank you,
Irene
From: devel@edk2.groups.io On Behalf Of G Edhaya Chandran
Sent: Friday, June 5, 2020 4:12 AM
To: Irene Park ; devel@edk2.groups.io
Subject
Hi Ard,
Would you please review this patch v2?
Thank you,
Irene
-Original Message-
From: Irene Park
Sent: Tuesday, June 9, 2020 1:59 PM
To: devel@edk2.groups.io
Cc: Irene Park
Subject: [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero
From: Irene Park
From: Irene Park
PL011UartLib determines its FIFO depth based on the PID2 value but
the register PID2 is not mandatory as per the SBSA spec.
This change won't check PID2 if PcdUartDefaultReceiveFifoDepth is set
to a value > 0.
Change-Id: I2dd7b3412f9306888078e0cb0488b902d4a8ace9
Signe
Hi Ard,
I feel bad that I confused you. I'll update the commit message later.
SBSA spec doesn't "mandate" that the optional registers such as PID2 are
present in a UART compliant to PL011.
Therefore this register access to PID2 will generate a fault onto SOC when its
UART doesn't provide such reg
Hello Ard Biesheuvel,
Would you please review this change?
Thank you,
Irene
-Original Message-
From: Irene Park
Sent: Friday, June 5, 2020 11:23 PM
To: devel@edk2.groups.io
Cc: Irene Park
Subject: [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth
From: Irene Park
Hello Ard Biesheuvel,
Would you please review this change?
Thank you,
Irene
-Original Message-
From: Irene Park
Sent: Friday, June 5, 2020 11:23 PM
To: devel@edk2.groups.io
Cc: Irene Park
Subject: [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth
From: Irene Park
From: Irene Park
PL011UartLib determines its FIFO depth based on the PID2 value but
the register PID2 is not mandatory in the SBSA spec.
This change adds a new 32bit PCD reference to define a FIFO depth and
make PL011UartLib available for the custom UART which is compliant
to the SBSA spec but
Hello Edhaya,
Would you please kindly review this change?
Thank you,
Irene
-Original Message-
From: G Edhaya Chandran
Sent: Wednesday, June 3, 2020 3:54 AM
To: Irene Park ; devel@edk2.groups.io; Samer El-Haj-Mahmoud
Cc: eric@intel.com
Subject: RE: [edk2-devel] [PATCH] uefi-sct
: devel@edk2.groups.io; Irene Park ; eric@intel.com
Cc: G Edhaya Chandran
Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove
gEfiFormBrowserExProtocolGuid
External email: Use caution opening links or attachments
+Edhaya
Irene, Edhaya is an SCT maintainer now, so please include him
-Original Message-
From: devel@edk2.groups.io On Behalf Of Irene Park
Sent: Tuesday, June 2, 2020 5:59 PM
To: devel@edk2.groups.io
Cc: Irene Park
Subject: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen
error occurred
External email: Use caution opening links or
From: Irene Park
AutoGen manager/workers halt the progress when an error occurs but
doesn't propagate the error code to main and allows main exit with 0
and gets the build system unable to catch the occurrence of an error.
This change informs main with an error when a progress is halte
Appreciated your proposal for the better subject. Will do it.
Thanks,
Irene
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Tuesday, June 2, 2020 5:18 AM
To: devel@edk2.groups.io; Irene Park
Subject: Re: [edk2-devel] [PATCH v2] BaseTools/Python: sys.exit(1
Hi Eric,
Would you please help review this change?
SCT build fails with the latest EDK2 due to lack of this change.
Thanks,
Irene
-Original Message-
From: devel@edk2.groups.io On Behalf Of Irene Park
Sent: Thursday, May 28, 2020 4:07 PM
To: devel@edk2.groups.io
Cc: eric@intel.com
Hi Bob,
Would you please review this patch again?
Thank you,
Irene
-Original Message-
From: devel@edk2.groups.io On Behalf Of Irene Park
Sent: Monday, June 1, 2020 4:28 PM
To: devel@edk2.groups.io
Cc: Irene Park
Subject: [edk2-devel] [PATCH v2] BaseTools/Python: sys.exit(1) when error
From: Irene Park
AutoGen manager/workers halt the progress when an error occurs but
doesn't propagate the error code to main and makes main sys.exit(0)
and gets the build system unable to catch the occurrence of an error.
This change informs main with an error when a progress is halted and
Hi Bob,
Thanks for the review.
Here is the original description of the issue.
There has been a build failure from SCT, related to
https://edk2.groups.io/g/devel/message/60407?p=,,,20,0,0,0::relevance,,gEfiFormBrowserExProtocolGuid,20,2,0,74529350.
(
https://edk2.groups.io/g/devel/message/60407?
-Original Message-
From: Irene Park
Sent: Thursday, May 28, 2020 3:19 PM
To: devel@edk2.groups.io
Cc: Irene Park
Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid
From: Irene Park
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
Replace the
A gentle reminder and adding Bob Feng and Liming Gao to CC.
Thank you,
Irene
-Original Message-
From: Irene Park
Sent: Wednesday, May 27, 2020 3:42 PM
To: devel@edk2.groups.io
Cc: Irene Park
Subject: [PATCH] BaseTools/Python: Add missing FatalError handling
From: Irene Park
23 matches
Mail list logo
