Hi Eric, Would you please help review this change? SCT build fails with the latest EDK2 due to lack of this change. Thanks, Irene
-----Original Message----- From: [email protected] <[email protected]> On Behalf Of Irene Park Sent: Thursday, May 28, 2020 4:07 PM To: [email protected] Cc: [email protected] Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments -----Original Message----- From: Irene Park <[email protected]> Sent: Thursday, May 28, 2020 3:19 PM To: [email protected] Cc: Irene Park <[email protected]> Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid From: Irene Park <[email protected]> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 Replace the gEfiFormBrowserExProtocolGuid with gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. Signed-off-by: Irene Park <[email protected]> --- .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c | 4 ++-- .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c index d495afd..fe973a3 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c @@ -1893,7 +1893,7 @@ DriverSampleInit ( EFI_STRING NameRequestHdr; MY_EFI_VARSTORE_DATA *VarStoreConfig; EFI_INPUT_KEY HotKey; - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; #if 1 EFI_STRING Progress; EFI_STRING Results; @@ -2190,7 +2190,7 @@ DriverSampleInit ( // // Example of how to use BrowserEx protocol to register HotKey. // - Status = gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, (VOID **) &FormBrowserEx); + Status = gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, NULL, + (VOID **) &FormBrowserEx); if (!EFI_ERROR (Status)) { // // First unregister the default hot key F9 and F10. diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf index cfa049e..75cb6fb 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf @@ -99,7 +99,7 @@ gEfiFormBrowser2ProtocolGuid ## CONSUMES gEfiHiiDatabaseProtocolGuid ## CONSUMES gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES - gEfiFormBrowserExProtocolGuid ## CONSUMES + gEdkiiFormBrowserExProtocolGuid ## CONSUMES gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES [Depex] -- 2.7.4 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60548): https://edk2.groups.io/g/devel/message/60548 Mute This Topic: https://groups.io/mt/74529350/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
