-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene Park
Sent: Tuesday, June 2, 2020 5:59 PM
To: devel@edk2.groups.io
Cc: Irene Park <ip...@nvidia.com>
Subject: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen
error occurred
External email: Use caution opening links or attachments
From: Irene Park <ip...@nvidia.com>
AutoGen manager/workers halt the progress when an error occurs but doesn't
propagate the error code to main and allows main exit with 0 and gets the build
system unable to catch the occurrence of an error.
This change informs main with an error when a progress is halted and helps main
exit with 1.
Signed-off-by: Irene Park <ip...@nvidia.com>
---
BaseTools/Source/Python/build/build.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/Python/build/build.py
b/BaseTools/Source/Python/build/build.py
index ed3a3b9..1ab1e60 100755
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -880,7 +880,10 @@ class Build():
self.AutoGenMgr.join()
rt = self.AutoGenMgr.Status
- return rt, 0
+ err = 0
+ if not rt:
+ err = UNKNOWN_ERROR
+ return rt, err
except FatalError as e:
return False, e.args[0]
except:
@@ -2724,4 +2727,3 @@ if __name__ == '__main__':
## 0-127 is a safe return range, and 1 is a standard default error
if r < 0 or r > 127: r = 1
sys.exit(r)
-
--
2.7.4
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#60611): https://edk2.groups.io/g/devel/message/60611
Mute This Topic: https://groups.io/mt/74638295/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
