From: Abdul Lateef Attar
Adds maintainers for AMD/MinBoardPkg
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Michael D Kinney
---
Maintainers.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 747
Adds SetCacheMtrrLib library for MinBoardPkg,
which sets MTRR values for PEI phase and also
modifies the MTRR value at the end of PEI phase.
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Michael D Kinney
---
Platform/AMD/MinBoardPkg/MinBoardPkg.ds
Adds initial DEC and DSC file for MinBoardPkg.
This package provides supporting modules for AMD boards to
leverage MinPlatformPkg framework.
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Michael D Kinney
---
Platform/AMD/MinBoardPkg/MinBoardPkg.de
V3 changes:
Dropped the PlatformPkg package.
Rename BoardPkg to MinBoardPkg
Addressed review comments from Leif and Abner.
Adds AMD/MinBoardPkg to support MinPlatformPkg framework.
PR: https://github.com/tianocore/edk2-platforms/pull/72
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chan
Hi Jiewen,
Bootloaders as SBL, coreboot supports multiple payloads and they would have TPM
acpi tables populated at bootloader phase.
These tables gets populated in bootloaders well before the payload gets loaded.
Its population cannot be avoided due to generic implementations.
Uninstallation f
Reviewed-by: James Lu
Thanks,
James
-Original Message-
From: Liu, KasimX
Sent: Thursday, March 16, 2023 3:01 PM
To: devel@edk2.groups.io
Cc: Liu, KasimX ; Dong, Guo ; Ni, Ray
; Lu, James ; Guo, Gua
Subject: [PATCH] UefiPayloadPkg:Add new build commands for Universalpayload
From: Ka
Reviewed-by: Ray Ni
> -Original Message-
> From: Xie, Yuanhao
> Sent: Tuesday, March 21, 2023 3:30 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo ; Ni, Ray ; Rhodes,
> Sean ; Lu, James ; Guo, Gua
> ; Kuo, Ted
> Subject: [PATCH] UefiCpuPkg: Solve that stack top address is not mapped in
>
[AMD Official Use Only - General]
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, March 23, 2023 10:19 AM
> To: devel@edk2.groups.io; Gao, Liming ; Chang,
> Abner
> Cc: Liu, Zhiguang ; 'Nickle Wang'
> ; 'Igor Kulchytskyy' ; Oram, Isaac W
> ; Attar, AbdulLateef (Abdul Lat
[AMD Official Use Only - General]
Yes, good suggestion. I will add it.
Thanks
Abner
> -Original Message-
> From: gaoliming
> Sent: Thursday, March 23, 2023 9:37 AM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: 'Michael D Kinney' ; 'Zhiguang Liu'
> ; 'Nickle Wang' ; 'Igor
> Kulchytskyy'
Mike and Liming,
Could you please help review this patch?
Thanks,
Dun
-Original Message-
From: devel@edk2.groups.io On Behalf Of duntan
Sent: Thursday, March 9, 2023 11:40 AM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
; Liu, Zhiguang ; Ni, Ray
Subject: [edk2-devel]
Mike and Liming,
Could you please help review this patch?
Thanks,
Dun
-Original Message-
From: devel@edk2.groups.io On Behalf Of duntan
Sent: Thursday, March 9, 2023 11:40 AM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
; Liu, Zhiguang
Subject: [edk2-devel] [Patch V3 1
Thanks for confirming that.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, March 21, 2023 7:54 PM
> To: Ni, Ray
> Cc: devel@edk2.groups.io; Pawel Polawski ; Kumar,
> Rahul R ; Oliver Steffen ;
> Dong, Eric
> Subject: Re: [edk2-devel] [PAT
Signed-off-by: Yi Li
---
CryptoPkg/Readme-OpenSSL3.0.md | 65 +-
1 file changed, 57 insertions(+), 8 deletions(-)
diff --git a/CryptoPkg/Readme-OpenSSL3.0.md b/CryptoPkg/Readme-OpenSSL3.0.md
index 85ed37b61d..fc5d24d074 100644
--- a/CryptoPkg/Readme-OpenSSL3.0.md
Signed-off-by: Yi Li
---
CryptoPkg/Library/OpensslLib/openssl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CryptoPkg/Library/OpensslLib/openssl
b/CryptoPkg/Library/OpensslLib/openssl
index 6048380660..2b0a888c36 16
--- a/CryptoPkg/Library/OpensslLib/openssl
+++ b/Crypt
Please check the patch series if interested.
PR: https://github.com/tianocore/edk2-staging/pull/363
Latest size data:
Binaries:
CryptoDxeFull 1.70% -> -1.6% -17KB
CryptoDxe 10.1% -> 8.3%68KB
CryptoSmm
Signed-off-by: Yi Li
---
CryptoPkg/Library/OpensslLib/HashNull.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/CryptoPkg/Library/OpensslLib/HashNull.c
b/CryptoPkg/Library/OpensslLib/HashNull.c
index ebd6369f98..e2a4da80a1 100644
--- a/CryptoPkg/Library/OpensslLib/HashNull.c
+++ b/Crypto
Signed-off-by: Yi Li
---
.../Library/OpensslLib/OpensslStub/uefiprov.c | 23 ---
1 file changed, 23 deletions(-)
diff --git a/CryptoPkg/Library/OpensslLib/OpensslStub/uefiprov.c
b/CryptoPkg/Library/OpensslLib/OpensslStub/uefiprov.c
index c21c475331..4473e3e706 100644
--- a/Crypt
Is that an I/O Port address or an MMIO address? Can it be either?
If it must be I/O Port address, then the PCD name should convey that.
If it can be either, then need another PCD to specify the type so the
Code can do the access with the correct IoLib APIs.
Mike
> -Original Message-
>
Sorry, I didn't realize there were people still using older builds of VS
2015.
--
Rebecca Cran
On 3/22/23 7:43 PM, Huang, Yanbo wrote:
Hi Rebecca,
The commit message “Visual Studio versions before VS 2015 don't support
__func__” may cause confuse since some of the older release of VS2015 a
Hi Rebecca,
The commit message “Visual Studio versions before VS 2015 don't support
__func__” may cause confuse since some of the older release of VS2015 also do
not support __func__.
Some of my fellows report the error since they use the VS 2015 version before
Update 3.
Best Regards,
Yanbo Hu
Abner:
This patch also adds one PCD PcdIpmiKcsBaseAddress. I see its default
value is 0xca2. Can you add comments for this default value?
Thanks
Liming
> -邮件原件-
> 发件人: abner.ch...@amd.com
> 发送时间: 2023年3月3日 10:32
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguan
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: abner.ch...@amd.com
> 发送时间: 2023年3月8日 22:47
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Nickle
> Wang ; Igor Kulchytskyy ; Isaac
> Oram ; Abdul Lateef Attar
>
> 主题: [PATCH V2] MdePkg/Include: Add IPMI KCS def
On 3/22/23 5:49 AM, Ard Biesheuvel wrote:
The reason I added CLANG3x support for ARM in the past is to ensure
compatibility with the ARM proprietary, Clang based toolchain. At the
time, we went with GNU ld, but I would actually prefer if we could
make this work with LLD as well.
Just to confi
Dun:
OK. Reviewed-by: Liming Gao
Can you create PR for this patch set? I will merge this PR.
Thanks
Liming
> -邮件原件-
> 发件人: Tan, Dun
> 发送时间: 2023年3月10日 14:17
> 收件人: Gao, Liming ; devel@edk2.groups.io
> 抄送: Kinney, Michael D ; Liu, Zhiguang
>
> 主题: RE: [Patch V3 1/2] MdePkg: modify
I've created https://bugzilla.tianocore.org/show_bug.cgi?id=4384 .
--
Rebecca Cran
On 3/22/23 7:05 PM, gaoliming wrote:
Rebecca:
Can you submit BZ for this change? This change belongs to the feature. I
would like to add it into stable tag feature planning.
Thanks
Liming
-邮件原件-
发
Rebecca:
This patch looks good to me. Reviewed-by: Liming Gao
I will help to merge this patch set.
Thanks
Liming
> -邮件原件-
> 发件人: Rebecca Cran
> 发送时间: 2023年3月15日 0:17
> 收件人: devel@edk2.groups.io; Andrew Fish ; Leif
> Lindholm ; Michael D Kinney
> ; Bob Feng ; Liming
> Gao ; Yuwei
Rebecca:
Can you submit BZ for this change? This change belongs to the feature. I
would like to add it into stable tag feature planning.
Thanks
Liming
> -邮件原件-
> 发件人: Oliver Smith-Denny
> 发送时间: 2023年3月23日 0:37
> 收件人: devel@edk2.groups.io; rebe...@bsdio.com; Michael D Kinney
> ; Liming
Hi Rebecca,
Using latest release would be my preference as well and what EDK II should
recommend.
We should document that the min supported version of VS2015 Update 3.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca Cran
> Sent: Wednesday, March 22, 2023 10
>From Uefi UPL side
Currently, SPI have silicon dependency so native is not support on
UniversalPayload, please use SECURITY_SUPPORT
+--+
| UefiUPL.elf |
+--+
| .upld_info |
+---
Also "where clang" please.
And could you provide more of the build output please? Perhaps on
https://pastebin.com/ ?
Thanks.
Rebecca Cran
On 3/22/23 4:07 PM, Guo, Gua wrote:
Mine are:
-Original Message-
From: Rebecca Cran
Sent: Wednesday, March 22, 2023 9:11 PM
To: Guo, Gua ; d
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, March 22, 2023 12:03 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Aktas, Erdem
> ; James Bottomley ;
> Gao, Liming ; Marvin Häuser ;
> Pawel Polawski ; Michael Roth
> ; Tom Lendacky ;
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann
> Sent: Wednesday, March 22, 2023 12:03 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Aktas, Erdem
> ; James Bottomley ;
> Gao, Liming ; Marvin Häuser ;
> Pawel Po
Can we not require that VS2015 Update 3 is installed?
Do people have reasons to be running older builds, or is it just that
they forget to install the updates?
--
Rebecca Cran
On 3/22/23 10:58 AM, Kinney, Michael D wrote:
Hi Rebecca,
It appears that some of the older release of VS2015 do
Hi Rebecca,
It appears that some of the older release of VS2015 do not support
__func__.
Can you please work on a patch that implements the workaround?
Thanks,
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, March 17, 2023 8:16 AM
> To: devel@edk2.groups.io; rebe..
Thanks for the cleanup!
Reviewed-by: Oliver Smith-Denny
On 3/21/2023 6:30 PM, Rebecca Cran wrote:
Update the toolchain definitions:
- Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with
CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64
and IA32.
- Remov
On 3/22/23 10:20 AM, Ard Biesheuvel wrote:
On Fri, 17 Mar 2023 at 13:19, Gerd Hoffmann wrote:
Time to leave behind relics from the last century and arrive in the
modern world. Drop PC-ANSI Terminal Type for the serial console, use
UTF-8 instead.
Signed-off-by: Gerd Hoffmann
No objections he
On Fri, 17 Mar 2023 at 13:19, Gerd Hoffmann wrote:
>
> Time to leave behind relics from the last century and arrive in the
> modern world. Drop PC-ANSI Terminal Type for the serial console, use
> UTF-8 instead.
>
> Signed-off-by: Gerd Hoffmann
No objections here but how will I be able to observ
For the patchset:
Reviewed-by: Oliver Smith-Denny
Thanks!
On 3/21/2023 7:06 PM, Michael D Kinney wrote:
Add FirmwareVolumeShadow PPI to shadow an FV to memory.
and use it to shadow FVs to memory.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Patel Umang
Umang Patel (2):
One comment below, thanks!
On 3/21/2023 7:06 PM, Michael D Kinney wrote:
From: Umang Patel
If FirmwareVolumeShadow PPI is available, then use it to
shadow FVs to memory. Otherwise fallback to CopyMem().
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: Patel Umang
---
SecurityPkg/FvReportPe
Question: Why not uninstall it in the universal payload package? or even not
populate it?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Subash
> Lakkimsetti
> Sent: Wednesday, March 22, 2023 1:59 PM
> To: devel@edk2.groups.io
> Cc: Lakkimsetti, Subash ; Zhang, Qi1
> ; K
From: Subash Lakkimsetti
This patch add the HOB fpr secure and measured boot
information. This is populated by bootloader phase
and uefipayload pkg uses this info to sync the TPM
info PCDs.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Subash Lakkimsetti
-
From: Subash Lakkimsetti
Define the build flags for secure boot and measure boot
for ci builds
Signed-off-by: Subash Lakkimsetti
---
UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 4
1 file changed, 4 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.ci.yaml
b/UefiPayloadPkg/UefiPayload
[Public]
Hi Abner,
That's right, Platform/AMD/MinBoardPkg will contains all
modules/library/drivers required for AMD boards which are based on
MinPlatformPkg framework.
Thanks
AbduL
-Original Message-
From: Chang, Abner
Sent: 22 March 2023 15:25
To: Attar, AbdulLateef (Abdul La
From: Subash Lakkimsetti
Bootloader supports multiple payload and TPM2 ACPI tables are updated
at bootloader phase. When UEFI is used payload these will be duplicates.
The tables are to be uninstalled before updating the TCG2ACPI tables
to avoid duplicates.
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-
From: Subash Lakkimsetti
Update the packages to support TPM and measured
boot in uefi payload.
Measured boot can be controoled using flag MEASURED_BOOT_ENABLE
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Patrick Rudolph
Signed-off-by: Subash Lakkimsetti
From: Subash Lakkimsetti
Support added in universal payload to enable secure boot and measured boot
Hob structure header for universal payload for secure boot and measure boot
information from bootloaders
as per the universal payload spec defined at
https://universalscalablefirmware.github.io/
From: Subash Lakkimsetti
Add the required modules for secure boot in
UefiPayloadPkg. SECURE_BOOT_ENABLE flag added to control
the secure boot feature. Requires SMM_SUPPORT and
flash to be SPI for the secure boot to function.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
S
From: Subash Lakkimsetti
Add the hob structure header for universal payload
for secure boot and measure boot information from
bootloaders. Universal payload spec definied at
https://universalscalablefirmware.github.io/documentation/2_universal_payload.html
Cc: Zhiguang Liu
Cc: Ray Ni
Cc: Gua G
I'm not seeing this failure. Could you tell me what the following
commands print, please:
where clang
where lld
Mine are:
C:\Users\bcran\Documents\src\uefi\edk2>where clang
C:\Program Files\LLVM\bin\clang.exe
C:\Program Files (x86)\Microsoft Visual
Studio\2019\Professional\VC\Tools\Llvm\b
On Wed, 22 Mar 2023 at 14:03, Gerd Hoffmann wrote:
>
> On Wed, Mar 22, 2023 at 01:32:01PM +0100, Ard Biesheuvel wrote:
> > On Wed, 22 Mar 2023 at 13:28, Rebecca Cran wrote:
> > >
> > > On 3/22/23 5:49 AM, Ard Biesheuvel wrote:
> > >
> > > > The reason I added CLANG3x support for ARM in the past i
On Wed, Mar 22, 2023 at 01:32:01PM +0100, Ard Biesheuvel wrote:
> On Wed, 22 Mar 2023 at 13:28, Rebecca Cran wrote:
> >
> > On 3/22/23 5:49 AM, Ard Biesheuvel wrote:
> >
> > > The reason I added CLANG3x support for ARM in the past is to ensure
> > > compatibility with the ARM proprietary, Clang ba
On Wed, 22 Mar 2023 at 13:28, Rebecca Cran wrote:
>
> On 3/22/23 5:49 AM, Ard Biesheuvel wrote:
>
> > The reason I added CLANG3x support for ARM in the past is to ensure
> > compatibility with the ARM proprietary, Clang based toolchain. At the
> > time, we went with GNU ld, but I would actually pr
On Wed, Mar 22, 2023 at 11:59:38 +, Attar, AbdulLateef (Abdul Lateef) wrote:
> [Public]
>
> Hi Abner,
> That's right, Platform/AMD/MinBoardPkg will contains all
> modules/library/drivers required for AMD boards which are
> based on MinPlatformPkg framework.
That works
On 3/22/23 5:49 AM, Ard Biesheuvel wrote:
The reason I added CLANG3x support for ARM in the past is to ensure
compatibility with the ARM proprietary, Clang based toolchain. At the
time, we went with GNU ld, but I would actually prefer if we could
make this work with LLD as well.
I can work arou
On Wed, 22 Mar 2023 at 02:30, Rebecca Cran wrote:
>
> Update the CLANGDWARF toolchain definition with the settings from
> CLANG38, and delete the CLANG35 and CLANG38 toolchains.
>
> The existing CLANGDWARF toolchain definition used ld.lld, but this
> causes the following linker errors when buildin
[AMD Official Use Only - General]
> -Original Message-
> From: Attar, AbdulLateef (Abdul Lateef)
> Sent: Tuesday, March 21, 2023 11:01 AM
> To: Leif Lindholm
> Cc: devel@edk2.groups.io; Chang, Abner ; Ard
> Biesheuvel ; Michael D Kinney
>
> Subject: RE: [edk2-devel] [PATCH v2 RESEND 4
Hello Rebecc,
Thanks for working on this - the toolchain definitions are not the
most fun part of the project.
On Wed, 22 Mar 2023 at 02:30, Rebecca Cran wrote:
>
> Update the toolchain definitions:
>
> - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with
> CLANGDWARF, updatin
Reviewed-by: Ray Ni
thanks,
ray
From: Gerd Hoffmann
Sent: Wednesday, March 22, 2023 3:02:43 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Aktas, Erdem
; James Bottomley ; Gao, Liming
; Marvin Häuser ; Pawel Polawski
; Michael Roth ; Tom Lendacky
; Gerd
Reviewed-by: Heng Luo
> -Original Message-
> From: Li, Yi1
> Sent: Wednesday, March 22, 2023 2:38 PM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 ; Gao, Zhichao ; Luo,
> Heng
> Subject: [edk2-staging/crypto-new-api][PATCH] CryptoPkg: Move ECC feature
> to OpensslLibFull
>
> The purpose is
This patch substitutes the macros that were renamed in the second
patch with the new, shared alignment macros.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Michael D Kinney
Reviewed-by: Jiewen Yao
Acked-by: Tom Lendacky
---
OvmfPkg/AmdSevDxe/AmdSevDxe.c | 6 ++
From: Marvin Häuser
This patch is a preparation for the patches that follow. The
subsequent patches will introduce and integrate new alignment-related
macros, which collide with existing definitions in MdeModulePkg.
Temporarily rename them to avoid build failure, till they can be
substituted with
From: Marvin Häuser
This patch substitutes the macros that were renamed in the first
patch with the new, shared alignment macros.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Vitaly Cheptsov
Signed-off-by: Marvin Häuser
Signed-off-by: Gerd Hoffmann
Reviewed-by: Hao A Wu
Reviewed-by: Michae
Drop MtrrLibIsPowerOfTwo function, use the new IS_POW2() macro instead.
The ASSERT() removed (inside MtrrLibIsPowerOfTwo) is superfluous,
another ASSERT() a few lines up in MtrrLibCalculateMtrrs() already
guarantees that Length can not be zero at this point.
Signed-off-by: Gerd Hoffmann
---
Uef
From: Marvin Häuser
ALIGNOF: Determining the alignment requirement of data types is
crucial to ensure safe memory accesses when parsing untrusted data.
IS_POW2: Determining whether a value is a power of two is important
to verify whether untrusted values are valid alignment values.
IS_ALIGNED:
This patch is a preparation for the patches that follow. The
subsequent patches will introduce and integrate new alignment-related
macros, which collide with existing definitions in OvmfPkg.
Temporarily rename them to avoid build failure, till they can be
substituted with the new, shared definition
v2 changes:
- rebase to latest master, adapt patches to changes.
- update macro documentation to use @retval TRUE/FALSE.
- added patch to use IS_POW2 in MtrrLib.
- add reviews and acks.
Gerd Hoffmann (3):
OvmfPkg: Rename IS_ALIGNED macros to avoid name collisions
OvmfPkg: Consume new align
66 matches
Mail list logo
