Thanks for confirming that. > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd > Hoffmann > Sent: Tuesday, March 21, 2023 7:54 PM > To: Ni, Ray <ray...@intel.com> > Cc: devel@edk2.groups.io; Pawel Polawski <ppola...@redhat.com>; Kumar, > Rahul R <rahul.r.ku...@intel.com>; Oliver Steffen <ostef...@redhat.com>; > Dong, Eric <eric.d...@intel.com> > Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode > for cpu hotplug > > On Tue, Mar 21, 2023 at 07:28:44AM +0000, Ni, Ray wrote: > > > + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) && > > > + (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255)) > > > + { > > > + X2Apic = TRUE; > > > > Gerd, > > I agree with your needs that want X2 APIC even the actual processor > number in BIOS phase <= 255. > > > > Question: Is it possible that BIOS stays at XAPIC, and later OS switches to > > X2 > APIC when the maximum CPU count > 255? > > Linux doesn't do that. In case x2apic mode is not active at boot the > number of CPUs will be limited to 255. > > > I am thinking about adding a new PCD to tell MP code switch to x2 apic > > in the first time AP wakes up. Possible timeline for the code change > > is about within 1 month. Do you think it can meet your needs? > > So the idea being that OVMF simply sets that PCD if needed (probably at > the same place where PcdCpuMaxLogicalProcessorNumber is set)? That > would work too. > > take care, > Gerd > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101615): https://edk2.groups.io/g/devel/message/101615 Mute This Topic: https://groups.io/mt/97447597/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-