Rebecca: This patch looks good to me. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
I will help to merge this patch set. Thanks Liming > -----邮件原件----- > 发件人: Rebecca Cran <rebe...@bsdio.com> > 发送时间: 2023年3月15日 0:17 > 收件人: devel@edk2.groups.io; Andrew Fish <af...@apple.com>; Leif > Lindholm <quic_llind...@quicinc.com>; Michael D Kinney > <michael.d.kin...@intel.com>; Bob Feng <bob.c.f...@intel.com>; Liming > Gao <gaolim...@byosoft.com.cn>; Yuwei Chen <yuwei.c...@intel.com> > 主题: Re: [edk2-devel] [PATCH 0/3] BaseTools: allow users to override CC and > CXX on the make command line > > This is a patch series that I'd really like to get committed. > > It'll allow us to drop the dependency on gcc for building edk2 on FreeBSD. > > > The Github branch is https://github.com/bcran/edk2/tree/mdepkg-c11 and > there's a PR at https://github.com/tianocore/edk2/pull/4142. > > > -- > > Rebecca Cran > > > On 3/9/23 8:47 AM, Rebecca Cran wrote: > > Could I get some reviews on this please? > > > > > > Thanks. > > > > Rebecca Cran > > > > > > On 2/16/23 8:50 PM, Rebecca Cran wrote: > >> Currently, the BaseTools Makefiles use BUILD_CC and BUILD_CXX, which > >> doesn't allow users to override the compiler to use in the expected way > >> by running e.g. "make CC=clang-17 CXX=clang++-17". clang/llvm support > >> was added in https://bugzilla.tianocore.org/show_bug.cgi?id=2842 in a > >> way that required users to run "make CXX=llvm" and have clang and > >> clang++ > >> executables under $(CLANG_BIN). As far as I know this isn't a standard > >> way of telling a build system to use clang, and so is likely difficult > >> to discover by users. > >> > >> This patch series fixes that, and as a side effect allows the clang > >> analyzer to run via "scan-build make". > >> > >> Since clang 17 defaults to C++17 or newer where the 'register' keyword > >> is deprecated and the warning turned into an error, override the > >> version used when building C++ code via "-std=c++14". > >> > >> Rebecca Cran (3): > >> BaseTools: Allow users to specify compiler to use with make CC= > CXX= > >> BaseTools: Improve detection of users wanting to build using clang > >> BaseTools: Build against C++14 when building with clang > >> > >> BaseTools/Source/C/DevicePath/GNUmakefile | 7 ++- > >> BaseTools/Source/C/LzmaCompress/GNUmakefile | 2 +- > >> BaseTools/Source/C/Makefiles/app.makefile | 2 +- > >> BaseTools/Source/C/Makefiles/footer.makefile | 6 +- > >> BaseTools/Source/C/Makefiles/header.makefile | 59 > >> ++++++++++---------- > >> BaseTools/Source/C/VfrCompile/GNUmakefile | 19 > ++++--- > >> BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 20 +++---- > >> BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile | 31 +++++----- > >> BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- > >> 9 files changed, 76 insertions(+), 72 deletions(-) > >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101601): https://edk2.groups.io/g/devel/message/101601 Mute This Topic: https://groups.io/mt/97792736/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
