śr., 15 gru 2021 o 01:03 Rebecca Cran napisał(a):
>
> MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
> ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
>
> Signed-off-by: Rebecca Cran
> ---
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
> 1 file changed, 1 insertion(+)
Hi,
> Ah, got it. I am just wondering since I did not see new CI opened for this.
Yes, it's an old branch and old pull request with
fresh updates pushed (which re-runs the CI).
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3776
Moving UFS HCS.DP (Device Attached) checking under UfsDeviceDetection() to fix
timing problem.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 51 +++
Hi
>
> Add pointer to the specs here?
>
Sure, spec links will be added. Thanks for reminder.
Min
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84963): https://edk2.groups.io/g/devel/message/84963
Mute This Topic: https://groups.io/mt/
Ah, got it. I am just wondering since I did not see new CI opened for this.
Anyway, good enough. Thank you very much to confirm that.
Thank you
Yao Jiewen
> -Original Message-
> From: kra...@redhat.com
> Sent: Thursday, December 16, 2021 1:58 PM
> To: Yao, Jiewen
> Cc: devel@edk2.group
On Wed, Dec 15, 2021 at 12:09:10PM +, Yao, Jiewen wrote:
> Acked-by: Jiewen Yao
>
> A quick question: Have you run run CI for this patch by yourself?
Yep, usually I open a draft pull request for the snake of running CI
(this one is #2099).
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3775
Refactoring UFS DME request sending function and retry up to 5 times.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 306 +++-
1 file cha
On December 14, 2021 10:01 PM, Ard Biesheuvel wrote:
> On Tue, 14 Dec 2021 at 14:42, Min Xu wrote:
> > --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c
> > +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c
> > @@ -335,7 +335,7 @@ FfsProcessSection (
> >
> > Status = UefiDecompressGetInfo (
> >
Currently, the serial and part number of a processor are filled with
fixed PCDs. However, they may be updated dynamically according to the
information being passed from a the pre-UEFI firmware during booting.
So, this patch is to support updating these string fields from
OemMiscLib if the PCDs are
Typically, the information of the SMBIOS type 1/2/3 is fetched from an
FRU device during UEFI booting intead of fixed PCDs. Therefore, this
patch is to add more HII string fields in the OemMiscLib and support
updating these SMBIOS types with the strings provided by the OemMiscLib
if the PCDs are em
This patch removes duplicate HII string definition in the
MiscSystemManufacturer.uni.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Rebecca Cran
Signed-off-by: Nhi Pham
Reviewed-by: Sami Mujawar
---
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 1 -
1 file changed, 1 d
This patchset leverages the OemUpdateSmbiosInfo API functions from
OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4
because they may be updated dynamically during UEFI booting with the
data being passed from the pre-UEFI firmware.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: R
Hi Sami,
On 16/12/2021 00:06, Sami Mujawar wrote:
Hi Nhi,
These patches do not cleanly apply. I guess you would need to run
uncrustify for these patches.
Can you check, please?
Sure, will fix all coding style issues found by uncrustify and change to
use FixedPcdGetPtr() instead of PcdGetP
Update Drivers/CpuDxe to initialize MpInitLib, which enables
EFI_MP_SERVICES_PROTOCOL support on AARCH64.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/CpuDxe/AArch64/Arch.c | 21 +
ArmPkg/Drivers/CpuDxe/Arm/Arch.c | 21 +
ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 +
ArmPkg/Drivers/CpuDx
Add support for EFI_MP_SERVICES_PROTOCOL during the DXE phase under
AArch64.
PSCI_CPU_ON is called to power on the core, the supplied procedure is
executed and PSCI_CPU_OFF is called to power off the core.
Minimal setup is done before calling the supplied procedure: for example
the MMU and caches
ArmPkg/Drivers/CpuDxe consumers now require an instance of MpInitLib.
Use ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
ArmVirtPkg/ArmVirt.dsc.inc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 5a
Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in
favor of a new Mpidr field. Update code in
ArmPlatformPkg/PrePeiCore/MainMPCore and ArmPlatformPkg/PrePi/MainMPCore.c
to use the new field and call new macros GET_MPIDR_AFF0 and GET_MPIDR_AFF1
instead.
Signed-off-by: Rebecca
Patch 1/4 is the start of addressing the issue that the Aff0 field of
the MPIDR is no longer guaranteed to be the core, and should be referred
to in a more generic way: for example it could be the thread, with Aff1
being the core and Aff2 the cluster. Clearly much more work is needed
to fully remo
On December 14, 2021 9:59 PM, Ard Biesheuvel wrote:
> On Tue, 14 Dec 2021 at 14:42, Min Xu wrote:
> >
> > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> >
> > This function is a null stub to make the build success.
> >
> > ---
> > .../MemoryAllocationLib.c | 28 +++
That’s great. Reviewed-by: Liming Gao
发件人: devel@edk2.groups.io 代表 Pedro Falcato
发送时间: 2021年12月15日 18:18
收件人: edk2-devel-groups-io ; Liming Gao
主题: Re: [edk2-devel] [PATCH v2 0/2] Update brotli to the latest commit
Liming,
Yes, yes it does. No need to turn off Werror now.
Thanks
I figured it out: it didn't like the generic wording "Component
description file".
--
Rebecca Cran
On 12/15/21 2:26 PM, Rebecca Cran via groups.io wrote:
On 12/15/21 10:46 AM, Rebecca Cran wrote:
diff --git a/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf
b/ArmPkg/Library/MpInitLib/DxeMpInitLib
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Oram, Isaac W
Sent: Wednesday, December 15, 2021 3:59 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Desimone, Nathaniel L
; Chaganty, Rangasai V
; Chiu, Chasel
Subject: [edk2-devel][edk2-platforms]
V1:
The list of WhiskeyLake and Whitley boards got confused at some
earlier merge
Untabified
V2:
Moved JunctionCity, MtOlympus, and TiogaPass into an OCP section
which fixed a table format issue
Fixed .md format issue where line wasn't made bold because of space
Cc: Nate DeSimone
Cc: Sai Chagant
Hi,
On 12/14/21 16:49, Adrien Thierry wrote:
The Raspberry Pi support in edk2-platforms, including ACPI, is a direct
ancestor of the original ms-iot tree (https://github.com/ms-iot/RPi-UEFI, by
way of https://github.com/andreiw/RaspberryPiPkg).
The way the miniUART is described in ACPI came fr
Pushed 514b20ed9319b66854fbcc43d21d079bf968042f
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, December 15, 2021 2:38 PM
> To: michael.kuba...@outlook.com; devel@edk2.groups.io; Kinney, Michael D
>
> Cc: Andrew Fish ; Leif Lindholm ; Gao,
> Liming
> Subject: R
Reviewed-by: Michael D Kinney
> -Original Message-
> From: michael.kuba...@outlook.com
> Sent: Tuesday, December 14, 2021 7:47 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Leif Lindholm ; Kinney,
> Michael D ; Gao,
> Liming
> Subject: [edk2-wiki][PATCH v1 1/1] Add code formatting
Actually... there are still a few things messed up.
1. There are two copies of PurleyOpenBoardPkg in the tree now
2. The table of platforms contains Markdown syntax errors now
3. There is no manufacturer listed for Junction City
For these reasons, I rescind my previous reviewed-by.
Thanks,
Nate
Hi Isaac,
Please correct the From: field. With that change...
Reviewed-by: Nate DeSimone
-Original Message-
From: Oram, Isaac W
Sent: Tuesday, December 14, 2021 1:57 PM
To: devel@edk2.groups.io
Cc: manickavasakam karpagavinayagam via groups.io
; Desimone, Nathaniel L
; Chaganty, Ran
On 12/15/21 10:46 AM, Rebecca Cran wrote:
diff --git a/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf
b/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf
new file mode 100644
index ..2275b6cca33a
--- /dev/null
+++ b/ArmPkg/Library/MpInitLib/DxeMpInitLib.inf
@@ -0,0 +1,53 @@
+#/** @file
+#
+# Comp
On 12/15/21 10:53 AM, Ard Biesheuvel wrote:
On Wed, 15 Dec 2021 at 18:46, Rebecca Cran wrote:
#define ARM_CORE_MASK ARM_CORE_AFF0
#define ARM_CLUSTER_MASK ARM_CORE_AFF1
-#define GET_CORE_ID(MpId)((MpId) & ARM_CORE_MASK)
-#define GET_CLUSTER_ID(MpId) (((MpId) & ARM_C
Hi Nhi,
I have a minor suggestion to use FixedPcdGetPtr(), other than that this
patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
Currently, the serial and part number of a processor are filled with
fixed PCDs. Ho
On 12/15/21 10:55 AM, Ard Biesheuvel wrote:
Perhaps I misunderstood your question about splitting up this patch,
as surely, adding a completely new library can be broken out into a
separate one?
Oh, of course it can! I just need to also split out the change to
CpuDxe.inf.
--
Rebecca Cran
Hi Rebecca,
On Wed, 15 Dec 2021 at 18:47, Rebecca Cran wrote:
>
> Add support for EFI_MP_SERVICES_PROTOCOL during the DXE phase under
> AArch64.
>
> PSCI_CPU_ON is called to power on the core, the supplied procedure is
> executed and PSCI_CPU_OFF is called to power off the core.
>
> Minimal setup
Hi Rebecca,
Some nits below.
On Wed, 15 Dec 2021 at 18:46, Rebecca Cran wrote:
>
> Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in
> favor of a new Mpidr field. Update code in
> ArmPlatformPkg/PrePeiCore/MainMPCore and ArmPlatformPkg/PrePi/MainMPCore.c
> to use the new f
Add support for EFI_MP_SERVICES_PROTOCOL during the DXE phase under
AArch64.
PSCI_CPU_ON is called to power on the core, the supplied procedure is
executed and PSCI_CPU_OFF is called to power off the core.
Minimal setup is done before calling the supplied procedure: for example
the MMU and caches
Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in
favor of a new Mpidr field. Update code in
ArmPlatformPkg/PrePeiCore/MainMPCore and ArmPlatformPkg/PrePi/MainMPCore.c
to use the new field and call new macros GET_MPIDR_AFF0 and GET_MPIDR_AFF1
instead.
Signed-off-by: Rebecca
ArmPkg: Add Library/MpInitLib to support EFI_MP_SERVICES_PROTOCOL
Changes from v1 to v2:
Mask off the non-affinity bits of the MPIDR, and since cluster 0/core 0
is 0x0 set the end of list value to MAX_UINT32.
Other changes based on Sami's feedback.
Rebecca Cran (2):
ArmPkg: Replace CoreId
Hi Khasim,
Thanks for the new version. I think there is only the 'Change-Id' that should
be removed in the commit message.
With that change, for this patch:
Reviewed-by: Pierre Gondois
Regards
On 12/14/21 8:43 PM, Khasim Mohammed via groups.io wrote:
> The patch removes PciExpressLib impleme
Hi Khassim,
Thanks for the new serie. I have some comments about the PCDs:
On 12/14/21 8:43 PM, Khasim Mohammed via groups.io wrote:
> This patch enables CCIX root complex support by updating
> the root complex node info in PciHostBridge library.
> The corresponding PCDs are updated.
>
> Change-
Hi Khassim,
Thanks for the new serie. I have some comments:
On 12/14/21 8:43 PM, Khasim Mohammed via groups.io wrote:
> The BasePCISegment Library in MdePkg doesn't allow configuring
> multiple segments required for PCIe and CCIX root port
> enumeration. Therefore, a custom PCI Segment library i
On Wed, 15 Dec 2021 at 18:18, Rebecca Cran wrote:
>
> Hi Sami,
>
>
> I've been looking at this again to make sure I've addressed all the issues
> before sending out a v2 patch series. I'm stuck on one point though: I'm not
> sure how it can be split into 2-3 patches without breaking bisecting. T
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Amend the help string to explain the use of the validator option.
Signed-off-by: Chris Jones
---
ShellPkg/Application/AcpiViewApp/AcpiViewApp.uni |
18 +-
ShellPkg/Library/UefiShell
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Rewrite SBBR validation into the validator framework. This decouples the
SBBR validations from the internal workings of the Acpiview application.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Add a new META_DATA_TYPE, "MetaDataInstalledTables" to store the
signatures from tables that have been successfully installed. This is
to allow validation of mandatory ACPI tables that are specified in the
Arm SBBR specification.
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Add processor ID cross table validation to the AcpiView global
validator. This validation retrieves MADT and PPTT processor data from
the ACPI data store and then compares the two to ensure that all PPTT
processor ID's are also f
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Store processor data from the MADT and PPTT ACPI tables so that it can
be used for processor ID validation.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 23
++
Hi Nhi,
Other than the code style issue (which I believe uncrustify will
complain about), this patch looks good to me.
With that fixed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
Typically, the information of the SMBIOS type 1/2
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Add a store for useful ACPI data that can be used in validation. This
data will be collected from the parsers, stored in the data store and
then can be accessed by validators once all parsing is complete.
The data is stored dyna
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Add the framework for running generic post parsing validations. Included
is an example ACPI validator that will run validations on ACPI tables
that are applicable to all platforms. Currently no validations are
implemented in this
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
To facilitate the change to using generic validators, replace old SBBR
mandatory table validation config options with a more generic validator
config option.
As generic validators have not been implemented yet, simply assert
if
Bugzilla: 3773 (https://bugzilla.tianocore.org/show_bug.cgi?id=3773)
Add readme to explain the function and use of the new AcpiView validator
framework.
Signed-off-by: Chris Jones
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Validators/Readme.md | 113
1 file changed,
Hi Sami,
I've been looking at this again to make sure I've addressed all the
issues before sending out a v2 patch series. I'm stuck on one point
though: I'm not sure how it can be split into 2-3 patches without
breaking bisecting. The CpuDxe and MpInitLib changes introduce a
dependency on Mp
Acked-by: Jiewen Yao
Thank you Ard, for the quick response.
I will reply on you to do the revert. Appreciate your help.
Thank you
Yao Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Thursday, December 16, 2021 12:50 AM
> To: edk2-devel-gr
Hi Nhi,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
This patch removes duplicate HII string definition in the
MiscSystemManufacturer.uni.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Hi Nhi,
These patches do not cleanly apply. I guess you would need to run
uncrustify for these patches.
Can you check, please?
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
This patchset leverages the OemUpdateSmbiosInfo API functions from
OemMiscLib for upda
On Wed, 15 Dec 2021 at 17:37, Boeuf, Sebastien
wrote:
>
> Hi Gerd,
>
> Your patch 41d8bb30386ceab55787fc9f5aac6434e2493e27 removing the CMOS
> support for getting high mem and low mem is breaking the OVMF support for
> Cloud Hypervisor as we are still providing this information through that
> mec
For the series:
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 11/30/21 9:10 PM, Nhi Pham via groups.io wrote:
This patchset leverages the OemUpdateSmbiosInfo API functions from
OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4
because they may be updated dynamically du
Hi Gerd,
Your patch 41d8bb30386ceab55787fc9f5aac6434e2493e27 removing the CMOS
support for getting high mem and low mem is breaking the OVMF support for
Cloud Hypervisor as we are still providing this information through that
mechanism.
Do you think it would be acceptable to revert it in order t
On Wed, 15 Dec 2021 at 17:04, Ard Biesheuvel wrote:
>
> On Wed, 15 Dec 2021 at 17:02, Philippe Mathieu-Daudé
> wrote:
> >
> > On 12/15/21 12:39, Gerd Hoffmann wrote:
> > > Signed-off-by: Gerd Hoffmann
> > > ---
> > > OvmfPkg/Microvm/MicrovmX64.dsc | 2 --
> > > 1 file changed, 2 deletions(-)
>
On Wed, 15 Dec 2021 at 17:02, Philippe Mathieu-Daudé wrote:
>
> On 12/15/21 12:39, Gerd Hoffmann wrote:
> > Signed-off-by: Gerd Hoffmann
> > ---
> > OvmfPkg/Microvm/MicrovmX64.dsc | 2 --
> > 1 file changed, 2 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daude
>
Thanks for the ack but I alre
On 12/9/21 1:46 AM, Omkar Anand Kulkarni wrote:
> Hi Ming,
>
> Thanks for this patch. This patch helps to resolve Standalone MM issue while
> exercising RAS use case.
> Few comments mentioned inline.
>
> - Omkar
>
>
> On 10/15/21 2:39 PM, Ming Huang via groups.io wrote:
>> There are two sc
Acked-by: Jiewen Yao
A quick question: Have you run run CI for this patch by yourself?
Thank you
Yao Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Wednesday, December 15, 2021 7:39 PM
> To: devel@edk2.groups.io
> Cc: Tom Lendacky ; James
Rename TPM_ENABLE to TPM2_ENABLE so naming is in line with the
ArmVirtPkg config option name.
Add separate TPM1_ENABLE option for TPM 1.2 support.
Signed-off-by: Gerd Hoffmann
Tested-by: Stefan Berger
---
OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 4 +++-
OvmfPkg/OvmfTpmComponents
Drop TPM_CONFIG_ENABLE config option. Including TPM support in the
build without also including the TPM configuration menu is not useful.
Suggested-by: Stefan Berger
Signed-off-by: Gerd Hoffmann
Tested-by: Stefan Berger
---
OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 2 --
OvmfPkg
Split Tcg2ConfigPei.inf into two variants: Tcg12ConfigPei.inf with
TPM 1.2 support included and Tcg2ConfigPei.inf supporting TPM 2.0 only.
This allows x86 builds to choose whenever TPM 1.2 support should be
included or not by picking the one or the other inf file.
Switch x86 builds to Tcg12ConfigP
With this in place the tpm configuration is not duplicated for each of
our four ovmf config variants (ia32, ia32x64, x64, amdsev) and it is
easier to keep them all in sync when updating the tpm configuration.
No functional change.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Stefan Berger
---
Ovm
Allows to enable/disable TPM 1.2 support in OVMF.
Allows to enable SHA-1 support for TPM hashing.
v4:
- rebase to latest master.
v3:
- drop config menu for tpm 1.2 (needs other fixes first)
- update some places missed.
- add microvm cleanup.
- add review/test tags.
v2:
- drop TPM_CONFIG_ENAB
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Microvm/MicrovmX64.dsc | 2 --
1 file changed, 2 deletions(-)
diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc
index bb256fd3c640..1c2e600febee 100644
--- a/OvmfPkg/Microvm/MicrovmX64.dsc
+++ b/OvmfPkg/Microvm/MicrovmX64.dsc
@@
Hi,
> Patch 2/3:
> This patch-set leverage the PrePiLib and MemoryAllocationLib in
> EmbeddedPkg. Some new funtions are added to meet the Tdvf Config-B
> requirement.
Care to explain why this is needed? How is tdvf different from other
pei-less platforms? Could we just place DXEFV directly in
On Tue, Dec 14, 2021 at 09:41:24PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> Tdvf Config-B skip PEI phase to reduce attack surface. So instead of
> jumping to SecStartupPhase2 (), TdxStartup () is called. This function
> brings up Tdx guest from SEC phase
Liming,
Yes, yes it does. No need to turn off Werror now.
Thanks,
Pedro
On Wed, 15 Dec 2021, 05:36 gaoliming, wrote:
> Pedro:
> Does Brotli fix GCC warning in the latest version?
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Pedro Falcato
> > 发送时间: 2021年12月8日 18:27
Hi,
> + PageTables = 0;
> + if (FeaturePcdGet (PcdDxeIplBuildPageTables)) {
Can this ever be false in a x64 build?
> +EFI_STATUS
> +FindDxeCore (
> + IN INTN FvInstance,
> + IN OUT EFI_PEI_FILE_HANDLE *FileHandle
> + )
> +{
> + if (FvInstance != -1) {
> +
Hi,
> +#define FW_CFG_NX_STACK_ITEM"opt/ovmf/PcdSetNxForStack"
Why this is needed?
> +//
> +// Values we program into the PM base address registers
> +//
> +#define PIIX4_PMBA_VALUE 0xB000
> +#define ICH9_PMBASE_VALUE 0x0600
They are in OvmfPkg/Include/OvmfPlatforms.h, no need to c
Hi,
> - Remove unnecessary drivers to reduce attack surface, such as
>network stack.
> + #
> + # Defines for default states. These can be changed on the command line.
> + # -D FLAG=VALUE
> + #
> + DEFINE SECURE_BOOT_ENABLE = FALSE
> + DEFINE SMM_REQUIRE = FALSE
> +
On Mon, Dec 13, 2021 at 08:57:02PM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
>
> OvmfPkg.dec is removed from [Packages] because it doesn't depend
> on OvmfPkg. LocalApicTimerDxe is moved to UefiCpuPkg.
>if (mTimerNotifyFunction != NULL) {
> -//
> -
On Mon, Dec 13, 2021 at 08:57:01PM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
>
> Discussion in https://bugzilla.tianocore.org/show_bug.cgi?id=1496 shows
> that 8254TimerDxe was not written for OVMF. It was moved over from
> PcAtChipsetPkg to OvmfPkg in 2019. P
On Mon, Dec 13, 2021 at 08:57:00PM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
>
> Per SDM, changing the mode of APIC timer (from one-shot to periodic or
> vice versa) by writing to the timer LVT entry does not start the timer.
> To start the timer, it is necessa
On Mon, Dec 13, 2021 at 08:56:59PM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
>
> XenTimerDxe is a local Apic timer driver and it has nothing to do
> with Xen. So rename it to LocalApicTimerDxe.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Brijesh Singh
On Mon, Dec 13, 2021 at 08:56:58PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> The IOMMU protocol driver provides capabilities to set a DMA access
> attribute and methods to allocate, free, map and unmap the DMA memory
> for the PCI Bus devices.
>
> The cur
On Mon, Dec 13, 2021 at 08:56:57PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> In the previous QemuFwCfgDxe only SEV is supported. This commit
> introduce TDX support in QemuFwCfgDxe.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Brijesh Singh
> Cc: E
> +++ b/OvmfPkg/Library/BaseMemEncryptTdxLib/BaseMemoryEncryptionNull.c
> @@ -0,0 +1,90 @@
> +/** @file
> +
> + Virtual Memory Management Services to set or clear the memory encryption
> +
> + Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2017, AMD Incorpor
On Mon, Dec 13, 2021 at 08:56:55PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> TdxDxe driver is dispatched early in DXE, due to being list in APRIORI.
> This module is responsible for below features:
> - Sets max logical cpus based on TDINFO
> - Sets PCI P
On Mon, Dec 13, 2021 at 08:56:54PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> In TDX the guest firmware is designed to publish a multiprocessor-wakeup
> structure to let the guest-bootstrap processor wake up guest-application
> processors with a mailbox. Th
> +/**
> + Check if it is Tdx guest
> +
> + @retvalTRUE It is Tdx guest
> + @retvalFALSE It is not Tdx guest
> +**/
> +BOOLEAN
> +PlatformPeiIsTdxGuest (
> + VOID
> + )
> +{
> + CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER *CcWorkAreaHeader;
> +
> + CcWorkAreaHeader = (CONFIDENTIAL_CO
On Tue, 30 Nov 2021 at 01:39, Kun Qin wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751
>
> Current MM communicate routine from ArmPkg would conduct few steps before
> proceeding with SMC calls. However, some inspection steps are different
> from PI specification.
>
> This patch
(+ Masahisa, Masami)
On Fri, 15 Oct 2021 at 11:07, Ming Huang wrote:
>
> TF-A: TrustedFirmware-A
> SPM: Secure Partition Manager(MM)
>
> In TF-A, the name of this field is sp_shared_buf_size. This field is
> the size of range for transmit data from TF-A to standaloneMM when
> SPM enable.
>
> SpP
On Wed, 1 Dec 2021 at 05:12, Nhi Pham via groups.io
wrote:
>
> This patchset leverages the OemUpdateSmbiosInfo API functions from
> OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4
> because they may be updated dynamically during UEFI booting with the
> data being passed fro
> @@ -357,6 +360,7 @@ GetPageTableEntry (
>
>// 4k
>L1PageTable = (UINT64 *)(UINTN)(L2PageTable[Index2] & ~AddressEncMask &
> PAGING_4K_ADDRESS_MASK_64);
> +
>if ((L1PageTable[Index1] == 0) && (Address != 0)) {
Hmm?
With that dropped:
Acked-by: Gerd Hoffmann
take care,
Gerd
On Mon, Dec 13, 2021 at 08:56:51PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> Guest Physical Address (GPA) space in Td guest is divided into private
> and shared sub-spaces, determined by the SHARED bit of GPA. This PCD
> holds the shared bit mask. Its defa
On Mon, Dec 13, 2021 at 08:56:49PM +0800, Min Xu wrote:
> RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> If TDX is enabled then we do not support DMA operation in PEI phase.
> This is mainly because DMA in TDX guest requires using bounce buffer
> (which need to allocate dynamic memor
> +EFI_STATUS
> +EFIAPI
> +BspAcceptMemoryResourceRange (
> + IN EFI_PHYSICAL_ADDRESS PhysicalAddress,
> + IN EFI_PHYSICAL_ADDRESS PhysicalEnd
> + )
> +{
> + EFI_STATUS Status;
> + UINT32 AcceptPageSize;
> + UINT64 StartAddress1;
> + UINT64 StartAddress2;
> + UINT64 S
On Wed, 15 Dec 2021 at 01:03, Rebecca Cran wrote:
>
> This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL support
> for AARCH64" series which is in the process of being reviewed (I'm
> sending a v2 soon).
>
> With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consumers
> of
Thank you liming.
Let’s move discussion to Bugzilla.
From: devel@edk2.groups.io On Behalf Of gaoliming
Sent: Wednesday, December 15, 2021 1:56 PM
To: devel@edk2.groups.io; Yao, Jiewen ; Reji, RencyX
Cc: Zhang, Qi1 ; Kumar, Rahul1 ;
Wang, Jian J ; H, Krishnaprasad
; Patil, Subhashini ;
Krish
93 matches
Mail list logo
