Hi,

> +  PageTables = 0;
> +  if (FeaturePcdGet (PcdDxeIplBuildPageTables)) {

Can this ever be false in a x64 build?

> +EFI_STATUS
> +FindDxeCore (
> +  IN INTN                         FvInstance,
> +  IN OUT     EFI_PEI_FILE_HANDLE  *FileHandle
> +  )
> +{

> +  if (FvInstance != -1) {
> +    //
> +    // Caller passed in a specific FV to try, so only try that one
> +    //
[ ... ]
> +  } else {
> +    // Assume the FV that contains the SEC (our code) also contains a 
> compressed FV.

This branch never runs, FvInstance is explicity set to 1 by the caller.

> +++ b/OvmfPkg/IntelTdx/TdxStartupLib/X64/PageTables.h

There is OvmfPkg/Include/IndustryStandard/PageTable.h

> +VOID
> +Split2MPageTo4K (

Yet another copy of this.  Please don't.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84890): https://edk2.groups.io/g/devel/message/84890
Mute This Topic: https://groups.io/mt/87720799/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to