Hi,

> +#define FW_CFG_NX_STACK_ITEM        "opt/ovmf/PcdSetNxForStack"

Why this is needed?

> +//
> +// Values we program into the PM base address registers
> +//
> +#define PIIX4_PMBA_VALUE   0xB000
> +#define ICH9_PMBASE_VALUE  0x0600

They are in OvmfPkg/Include/OvmfPlatforms.h, no need to copy them over.

> +VOID
> +PciExBarInitialization (

> +VOID
> +MiscInitialization (

Cut+Paste from PlatformPei

Please refactor the code (move the functions needed to a Library?) so we
don't have multiple copies of the setup code.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84889): https://edk2.groups.io/g/devel/message/84889
Mute This Topic: https://groups.io/mt/87720798/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to